Uh oh!
There was an error while loading. Please reload this page.
(Very) marginally expand test_monitor_update_fail_claim - #3126
Merged
G8XSU merged 1 commit intoJun 18, 2024
Merged
Conversation
codecov-commenter
commented
Jun 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@## main #3126 +/- ##
==========================================
- Coverage 89.90% 89.90% -0.01%
==========================================
Files 121 121 Lines 99170 99175 +5 Branches 99170 99175 +5 ==========================================
+ Hits 89159 89162 +3 + Misses 7408 7405 -3 - Partials 2603 2608 +5 ☔ View full report in Codecov by Sentry. |
G8XSU
reviewed
Jun 14, 2024
Uh oh!
There was an error while loading. Please reload this page.
G8XSU
previously approved these changes
Jun 18, 2024
TheBlueMattforce-pushed
the
2024-06-preimage-removal-blocked-by-claim-event
branch
from
June 18, 2024 13:58
130464e to
b1cf58eCompareFor some reason I wasn't sure this happened yet, so making the test for no-`PaymentClaimed`-event-before-preimage-on-disk explicit is nice.
TheBlueMattforce-pushed
the
2024-06-preimage-removal-blocked-by-claim-event
branch
from
June 18, 2024 17:59
b1cf58e to
68af6d0CompareG8XSU
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason I wasn't sure this happened yet, so making the test for no-
PaymentClaimed-event-before-preimage-on-disk explicit is nice.