Skip to content

Set max path length when paying BOLT 12 invoices. - #3156

Merged
valentinewallace merged 3 commits into
lightningdevkit:mainfrom
valentinewallace:2024-07-b12-max-path-len
Jul 8, 2024
Merged

Set max path length when paying BOLT 12 invoices.#3156
valentinewallace merged 3 commits into
lightningdevkit:mainfrom
valentinewallace:2024-07-b12-max-path-len

Conversation

@valentinewallace

Copy link
Copy Markdown
Contributor

This should've been done as part of #3026 but got overlooked.

@valentinewallacevalentinewallace changed the title 2024 07 b12 max path lenSet max path length when paying BOLT 12 invoices.Jul 3, 2024
@codecov-commenter

codecov-commenter commented Jul 3, 2024

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 96.87500% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.80%. Comparing base (669a459) to head (678aac0).
Report is 3 commits behind head on main.

FilesPatch %Lines
lightning/src/ln/outbound_payment.rs75.00%1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@ Coverage Diff @@## main #3156 +/- ##
==========================================
- Coverage 89.84% 89.80% -0.05% 
==========================================
Files 121 121 Lines 99454 99526 +72 Branches 99454 99526 +72 ==========================================
+ Hits 89357 89381 +24 - Misses 7498 7533 +35 - Partials 2599 2612 +13 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnulltnull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question

Comment threadlightning/src/ln/outbound_payment.rs
Comment threadlightning/src/ln/outbound_payment.rs Outdated
@valentinewallace
valentinewallaceforce-pushed the 2024-07-b12-max-path-len branch from 7b88b80 to 678aac0CompareJuly 8, 2024 14:36
@valentinewallace

Copy link
Copy Markdown
ContributorAuthor

Squashed in nit with this diff:

diff --git a/lightning/src/ln/outbound_payment.rs b/lightning/src/ln/outbound_payment.rs
index a9fba2c56..443a7b2c3 100644
--- a/lightning/src/ln/outbound_payment.rs+++ b/lightning/src/ln/outbound_payment.rs@@ -510,7 +510,7 @@ pub enum Bolt12PaymentError {
UnexpectedInvoice,
/// Payment for an invoice with the corresponding [`PaymentId`] was already initiated.
DuplicateInvoice,
- /// The [`BlindedPath`]s provided are too large and caused us to exceed the maximum onion packet+ /// The [`BlindedPath`]s provided are too large and caused us to exceed the maximum onion hop data
/// size of 1300 bytes.
///
/// [`BlindedPath`]: crate::blinded_path::BlindedPath

@valentinewallace

Copy link
Copy Markdown
ContributorAuthor

Trivial fix with a test so I'm gonna land with 1 ACK

@valentinewallace
valentinewallace merged commit bfc20f8 into lightningdevkit:mainJul 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@valentinewallace@codecov-commenter@tnull