Uh oh!
There was an error while loading. Please reload this page.
Disallow user-provided payer_signing_pubkey - #3264
Merged
TheBlueMatt merged 4 commits intoNov 12, 2024
Merged
Conversation
jkczyzforce-pushed
the
2024-08-remove-user-provided-payer-id
branch
from
August 22, 2024 20:44
ee91a75 to
0100dc4Comparejkczyzforce-pushed
the
2024-08-remove-user-provided-payer-id
branch
from
September 5, 2024 23:28
0100dc4 to
53ba3a9CompareCodecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #3264 +/- ##
========================================
Coverage 89.63% 89.64% ========================================
Files 128 128 Lines 104891 105163 +272 Branches 104891 105163 +272 ========================================
+ Hits 94024 94278 +254 - Misses 8156 8181 +25 + Partials 2711 2704 -7 ☔ View full report in Codecov by Sentry. |
jkczyzforce-pushed
the
2024-08-remove-user-provided-payer-id
branch
3 times, most recently
from
September 11, 2024 20:24
9838435 to
174a0f4Comparejkczyzforce-pushed
the
2024-08-remove-user-provided-payer-id
branch
from
September 16, 2024 21:49
174a0f4 to
4baba94Comparejkczyzforce-pushed
the
2024-08-remove-user-provided-payer-id
branch
from
October 2, 2024 16:50
4baba94 to
72aa0f8Compare2 tasks
jkczyzforce-pushed
the
2024-08-remove-user-provided-payer-id
branch
2 times, most recently
from
November 7, 2024 22:59
7334905 to
9cfc02fCompareWhen creating an InvoiceRequests, users may choose to either use a transient signing pubkey generated by LDK or provide a static one. Disallow the latter as it allows users to reuse the same pubkey, which results in poor sender privacy.
Now that InvoiceRequest::payer_signing_pubkey is always a derived pubkey, there is no longer a need for PayerSigningPubkeyStrategy.
Now that invoice requests are signed using transient keys only, remove the corresponding signing method from NodeSigner since it is never used.
jkczyzforce-pushed
the
2024-08-remove-user-provided-payer-id
branch
from
November 11, 2024 22:18
9cfc02f to
c331b67CompareTheBlueMatt
approved these changes
Nov 12, 2024
TheBlueMatt
left a comment
Collaborator
There was a problem hiding this comment.
There's a big pile of test changes, but its entirely mechanical. The actual diff is ~entirely remove-only except for some doc changes which seem straightforward. Just gonna land this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating an
InvoiceRequests, users may choose to either use a transient signing pubkey generated by LDK or provide a static one. Disallow the latter as it allows users to reuse the same pubkey, which results in poor sender privacy.Based on #3237.
Fixes#3198.