Skip to content

Allow Asynchronously responding to Invoice Request#3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shaavan wants to merge 11 commits into from
Closed

Allow Asynchronously responding to Invoice Request #3318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
93fdfdb
Rename manually_handle_bolt12_invoices
shaavan Sep 10, 2024
5774809
Introduce InvoiceRequestReceived Event
shaavan Aug 30, 2024
2a3c8c6
f: Make Responder Required
shaavan Sep 20, 2024
6342cdd
Introduce Bolt12ResponseError
shaavan Sep 16, 2024
e3b4c9d
Update InvoiceBuilder's amount_msats
shaavan Sep 10, 2024
af75a15
f: Update custom_amount_msats check
shaavan Sep 20, 2024
4431d52
Introduce get_response_for_invoice_request
shaavan Sep 16, 2024
f8b48dc
Introduce send_invoice_request_response
shaavan Sep 16, 2024
f00047b
Introduce reject_invoice_request
shaavan Sep 16, 2024
3a37880
f: Update InvoiceRequestReceived docs
shaavan Sep 20, 2024
9b4daa4
Introduce test for check asynchronous Invoice Request Response
shaavan Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 54 additions & 2 deletions lightning/src/events/mod.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ use crate::ln::features::ChannelTypeFeatures;
use crate::ln::msgs;
use crate::ln::types::{ChannelId, PaymentPreimage, PaymentHash, PaymentSecret};
use crate::offers::invoice::Bolt12Invoice;
use crate::offers::invoice_request::InvoiceRequest;
use crate::onion_message::messenger::Responder;
use crate::routing::gossip::NetworkUpdate;
use crate::routing::router::{BlindedTail, Path, RouteHop, RouteParameters};
Expand DownExpand Up@@ -821,10 +822,38 @@ pub enum Event {
/// Sockets for connecting to the node.
addresses: Vec<msgs::SocketAddress>,
},

/// Event triggered when manual handling is enabled and an invoice request is received.
///
/// Indicates that an [`InvoiceRequest`] for an [`Offer`] created by us has been received.
///
/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
/// Use [`ChannelManager::send_invoice_request_response`] to respond with an appropriate
/// response to the received invoice request. Use [`ChannelManager::reject_invoice_request`] to
/// reject the invoice request and respond with an [`InvoiceError`]. See the docs for further details.
///
/// [`Offer`]: crate::offers::offer::Offer
/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
/// [`ChannelManager::send_invoice_request_response`]: crate::ln::channelmanager::ChannelManager::send_invoice_request_response
/// [`ChannelManager::reject_invoice_request`]: crate::ln::channelmanager::ChannelManager::reject_invoice_request
/// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
InvoiceRequestReceived {
/// The received invoice request to respond to.
invoice_request: InvoiceRequest,
/// The context of the [`BlindedMessagePath`] used to send the invoice request.
///
/// [`BlindedMessagePath`]: crate::blinded_path::message::BlindedMessagePath
context: Option<OffersContext>,
/// A responder for replying with an [`InvoiceError`] if needed.
///
/// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
responder: Responder,
},

/// Indicates a [`Bolt12Invoice`] in response to an [`InvoiceRequest`] or a [`Refund`] was
/// received.
///
/// This event will only be generated if [`UserConfig::manually_handle_bolt12_invoices`] is set.
/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
/// Use [`ChannelManager::send_payment_for_bolt12_invoice`] to pay the invoice or
/// [`ChannelManager::abandon_payment`] to abandon the associated payment. See those docs for
/// further details.
Expand All@@ -835,7 +864,7 @@ pub enum Event {
///
/// [`InvoiceRequest`]: crate::offers::invoice_request::InvoiceRequest
/// [`Refund`]: crate::offers::refund::Refund
/// [`UserConfig::manually_handle_bolt12_invoices`]: crate::util::config::UserConfig::manually_handle_bolt12_invoices
/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
/// [`ChannelManager::send_payment_for_bolt12_invoice`]: crate::ln::channelmanager::ChannelManager::send_payment_for_bolt12_invoice
/// [`ChannelManager::abandon_payment`]: crate::ln::channelmanager::ChannelManager::abandon_payment
InvoiceReceived {
Expand DownExpand Up@@ -1741,6 +1770,14 @@ impl Writeable for Event {
(8, former_temporary_channel_id, required),
});
},
&Event::InvoiceRequestReceived { ref invoice_request, ref context, ref responder } => {
44u8.write(writer)?;
write_tlv_fields!(writer, {
(0, invoice_request, required),
(2, context, option),
(4, responder, required),
});
},
// Note that, going forward, all new events must only write data inside of
// `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
// data via `write_tlv_fields`.
Expand DownExpand Up@@ -2235,6 +2272,21 @@ impl MaybeReadable for Event {
former_temporary_channel_id: former_temporary_channel_id.0.unwrap(),
}))
},
44u8 => {
let mut f = || {
_init_and_read_len_prefixed_tlv_fields!(reader, {
(0, invoice_request, required),
(2, context, option),
(4, responder, required),
});
Ok(Some(Event::InvoiceRequestReceived {
invoice_request: invoice_request.0.unwrap(),
context,
responder: responder.0.unwrap(),
}))
};
f()
},
// Versions prior to 0.0.100 did not ignore odd types, instead returning InvalidValue.
// Version 0.0.100 failed to properly ignore odd types, possibly resulting in corrupt
// reads.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Allow Asynchronously responding to Invoice Request by shaavan · Pull Request #3318 · lightningdevkit/rust-lightning · GitHub
Skip to content
Allow Asynchronously responding to Invoice Request#3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

shaavan
wants to merge
11
commits into

from

 Closed


Allow Asynchronously responding to Invoice Request
#3318
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
93fdfdb

Rename manually_handle_bolt12_invoices


shaavan Sep 10, 2024
5774809

Introduce InvoiceRequestReceived Event


shaavan Aug 30, 2024
2a3c8c6

f: Make Responder Required


shaavan Sep 20, 2024
6342cdd

Introduce Bolt12ResponseError


shaavan Sep 16, 2024
e3b4c9d

Update InvoiceBuilder's amount_msats


shaavan Sep 10, 2024
af75a15

f: Update custom_amount_msats check


shaavan Sep 20, 2024
4431d52

Introduce get_response_for_invoice_request


shaavan Sep 16, 2024
f8b48dc

Introduce send_invoice_request_response


shaavan Sep 16, 2024
f00047b

Introduce reject_invoice_request


shaavan Sep 16, 2024
3a37880

f: Update InvoiceRequestReceived docs


shaavan Sep 20, 2024
9b4daa4

Introduce test for check asynchronous Invoice Request Response


shaavan Sep 16, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


56 changes: 54 additions & 2 deletions
lightning/src/events/mod.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ use crate::ln::features::ChannelTypeFeatures;
use crate::ln::msgs;
use crate::ln::types::{ChannelId, PaymentPreimage, PaymentHash, PaymentSecret};
use crate::offers::invoice::Bolt12Invoice;
use crate::offers::invoice_request::InvoiceRequest;
use crate::onion_message::messenger::Responder;
use crate::routing::gossip::NetworkUpdate;
use crate::routing::router::{BlindedTail, Path, RouteHop, RouteParameters};
Expand DownExpand Up@@ -821,10 +822,38 @@ pub enum Event {
 /// Sockets for connecting to the node.
 addresses: Vec<msgs::SocketAddress>,
	},

	/// Event triggered when manual handling is enabled and an invoice request is received.
	///
	/// Indicates that an [`InvoiceRequest`] for an [`Offer`] created by us has been received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_invoice_request_response`] to respond with an appropriate
	/// response to the received invoice request. Use [`ChannelManager::reject_invoice_request`] to
	/// reject the invoice request and respond with an [`InvoiceError`]. See the docs for further details.
	///
	/// [`Offer`]: crate::offers::offer::Offer
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_invoice_request_response`]: crate::ln::channelmanager::ChannelManager::send_invoice_request_response
	/// [`ChannelManager::reject_invoice_request`]: crate::ln::channelmanager::ChannelManager::reject_invoice_request
	/// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
	InvoiceRequestReceived {
 /// The received invoice request to respond to.
 invoice_request: InvoiceRequest,
 /// The context of the [`BlindedMessagePath`] used to send the invoice request.
 ///
 /// [`BlindedMessagePath`]: crate::blinded_path::message::BlindedMessagePath
 context: Option<OffersContext>,
 /// A responder for replying with an [`InvoiceError`] if needed.
 ///
 /// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
 responder: Responder,
	},

	/// Indicates a [`Bolt12Invoice`] in response to an [`InvoiceRequest`] or a [`Refund`] was
	/// received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_invoices`] is set.
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_payment_for_bolt12_invoice`] to pay the invoice or
	/// [`ChannelManager::abandon_payment`] to abandon the associated payment. See those docs for
	/// further details.
Expand All@@ -835,7 +864,7 @@ pub enum Event {
	///
	/// [`InvoiceRequest`]: crate::offers::invoice_request::InvoiceRequest
	/// [`Refund`]: crate::offers::refund::Refund
	/// [`UserConfig::manually_handle_bolt12_invoices`]: crate::util::config::UserConfig::manually_handle_bolt12_invoices
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_payment_for_bolt12_invoice`]: crate::ln::channelmanager::ChannelManager::send_payment_for_bolt12_invoice
	/// [`ChannelManager::abandon_payment`]: crate::ln::channelmanager::ChannelManager::abandon_payment
	InvoiceReceived {
Expand DownExpand Up@@ -1741,6 +1770,14 @@ impl Writeable for Event {
 (8, former_temporary_channel_id, required),
 });
 },
 &Event::InvoiceRequestReceived { ref invoice_request, ref context, ref responder } => {
 44u8.write(writer)?;
 write_tlv_fields!(writer, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 },
 // Note that, going forward, all new events must only write data inside of
 // `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
 // data via `write_tlv_fields`.
Expand DownExpand Up@@ -2235,6 +2272,21 @@ impl MaybeReadable for Event {
 former_temporary_channel_id: former_temporary_channel_id.0.unwrap(),
 }))
 },
 44u8 => {
 let mut f = || {
 _init_and_read_len_prefixed_tlv_fields!(reader, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 Ok(Some(Event::InvoiceRequestReceived {
 invoice_request: invoice_request.0.unwrap(),
 context,
 responder: responder.0.unwrap(),
 }))
 };
 f()
 },
 // Versions prior to 0.0.100 did not ignore odd types, instead returning InvalidValue.
 // Version 0.0.100 failed to properly ignore odd types, possibly resulting in corrupt
 // reads.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow Asynchronously responding to Invoice Request by shaavan · Pull Request #3318 · lightningdevkit/rust-lightning · GitHub
Skip to content
Allow Asynchronously responding to Invoice Request#3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

shaavan
wants to merge
11
commits into

from

 Closed


Allow Asynchronously responding to Invoice Request
#3318
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
93fdfdb

Rename manually_handle_bolt12_invoices


shaavan Sep 10, 2024
5774809

Introduce InvoiceRequestReceived Event


shaavan Aug 30, 2024
2a3c8c6

f: Make Responder Required


shaavan Sep 20, 2024
6342cdd

Introduce Bolt12ResponseError


shaavan Sep 16, 2024
e3b4c9d

Update InvoiceBuilder's amount_msats


shaavan Sep 10, 2024
af75a15

f: Update custom_amount_msats check


shaavan Sep 20, 2024
4431d52

Introduce get_response_for_invoice_request


shaavan Sep 16, 2024
f8b48dc

Introduce send_invoice_request_response


shaavan Sep 16, 2024
f00047b

Introduce reject_invoice_request


shaavan Sep 16, 2024
3a37880

f: Update InvoiceRequestReceived docs


shaavan Sep 20, 2024
9b4daa4

Introduce test for check asynchronous Invoice Request Response


shaavan Sep 16, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


56 changes: 54 additions & 2 deletions
lightning/src/events/mod.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ use crate::ln::features::ChannelTypeFeatures;
use crate::ln::msgs;
use crate::ln::types::{ChannelId, PaymentPreimage, PaymentHash, PaymentSecret};
use crate::offers::invoice::Bolt12Invoice;
use crate::offers::invoice_request::InvoiceRequest;
use crate::onion_message::messenger::Responder;
use crate::routing::gossip::NetworkUpdate;
use crate::routing::router::{BlindedTail, Path, RouteHop, RouteParameters};
Expand DownExpand Up@@ -821,10 +822,38 @@ pub enum Event {
 /// Sockets for connecting to the node.
 addresses: Vec<msgs::SocketAddress>,
	},

	/// Event triggered when manual handling is enabled and an invoice request is received.
	///
	/// Indicates that an [`InvoiceRequest`] for an [`Offer`] created by us has been received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_invoice_request_response`] to respond with an appropriate
	/// response to the received invoice request. Use [`ChannelManager::reject_invoice_request`] to
	/// reject the invoice request and respond with an [`InvoiceError`]. See the docs for further details.
	///
	/// [`Offer`]: crate::offers::offer::Offer
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_invoice_request_response`]: crate::ln::channelmanager::ChannelManager::send_invoice_request_response
	/// [`ChannelManager::reject_invoice_request`]: crate::ln::channelmanager::ChannelManager::reject_invoice_request
	/// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
	InvoiceRequestReceived {
 /// The received invoice request to respond to.
 invoice_request: InvoiceRequest,
 /// The context of the [`BlindedMessagePath`] used to send the invoice request.
 ///
 /// [`BlindedMessagePath`]: crate::blinded_path::message::BlindedMessagePath
 context: Option<OffersContext>,
 /// A responder for replying with an [`InvoiceError`] if needed.
 ///
 /// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
 responder: Responder,
	},

	/// Indicates a [`Bolt12Invoice`] in response to an [`InvoiceRequest`] or a [`Refund`] was
	/// received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_invoices`] is set.
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_payment_for_bolt12_invoice`] to pay the invoice or
	/// [`ChannelManager::abandon_payment`] to abandon the associated payment. See those docs for
	/// further details.
Expand All@@ -835,7 +864,7 @@ pub enum Event {
	///
	/// [`InvoiceRequest`]: crate::offers::invoice_request::InvoiceRequest
	/// [`Refund`]: crate::offers::refund::Refund
	/// [`UserConfig::manually_handle_bolt12_invoices`]: crate::util::config::UserConfig::manually_handle_bolt12_invoices
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_payment_for_bolt12_invoice`]: crate::ln::channelmanager::ChannelManager::send_payment_for_bolt12_invoice
	/// [`ChannelManager::abandon_payment`]: crate::ln::channelmanager::ChannelManager::abandon_payment
	InvoiceReceived {
Expand DownExpand Up@@ -1741,6 +1770,14 @@ impl Writeable for Event {
 (8, former_temporary_channel_id, required),
 });
 },
 &Event::InvoiceRequestReceived { ref invoice_request, ref context, ref responder } => {
 44u8.write(writer)?;
 write_tlv_fields!(writer, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 },
 // Note that, going forward, all new events must only write data inside of
 // `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
 // data via `write_tlv_fields`.
Expand DownExpand Up@@ -2235,6 +2272,21 @@ impl MaybeReadable for Event {
 former_temporary_channel_id: former_temporary_channel_id.0.unwrap(),
 }))
 },
 44u8 => {
 let mut f = || {
 _init_and_read_len_prefixed_tlv_fields!(reader, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 Ok(Some(Event::InvoiceRequestReceived {
 invoice_request: invoice_request.0.unwrap(),
 context,
 responder: responder.0.unwrap(),
 }))
 };
 f()
 },
 // Versions prior to 0.0.100 did not ignore odd types, instead returning InvalidValue.
 // Version 0.0.100 failed to properly ignore odd types, possibly resulting in corrupt
 // reads.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow Asynchronously responding to Invoice Request by shaavan · Pull Request #3318 · lightningdevkit/rust-lightning · GitHub
Skip to content
Allow Asynchronously responding to Invoice Request#3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

shaavan
wants to merge
11
commits into

from

 Closed


Allow Asynchronously responding to Invoice Request
#3318
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
93fdfdb

Rename manually_handle_bolt12_invoices


shaavan Sep 10, 2024
5774809

Introduce InvoiceRequestReceived Event


shaavan Aug 30, 2024
2a3c8c6

f: Make Responder Required


shaavan Sep 20, 2024
6342cdd

Introduce Bolt12ResponseError


shaavan Sep 16, 2024
e3b4c9d

Update InvoiceBuilder's amount_msats


shaavan Sep 10, 2024
af75a15

f: Update custom_amount_msats check


shaavan Sep 20, 2024
4431d52

Introduce get_response_for_invoice_request


shaavan Sep 16, 2024
f8b48dc

Introduce send_invoice_request_response


shaavan Sep 16, 2024
f00047b

Introduce reject_invoice_request


shaavan Sep 16, 2024
3a37880

f: Update InvoiceRequestReceived docs


shaavan Sep 20, 2024
9b4daa4

Introduce test for check asynchronous Invoice Request Response


shaavan Sep 16, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


56 changes: 54 additions & 2 deletions
lightning/src/events/mod.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ use crate::ln::features::ChannelTypeFeatures;
use crate::ln::msgs;
use crate::ln::types::{ChannelId, PaymentPreimage, PaymentHash, PaymentSecret};
use crate::offers::invoice::Bolt12Invoice;
use crate::offers::invoice_request::InvoiceRequest;
use crate::onion_message::messenger::Responder;
use crate::routing::gossip::NetworkUpdate;
use crate::routing::router::{BlindedTail, Path, RouteHop, RouteParameters};
Expand DownExpand Up@@ -821,10 +822,38 @@ pub enum Event {
 /// Sockets for connecting to the node.
 addresses: Vec<msgs::SocketAddress>,
	},

	/// Event triggered when manual handling is enabled and an invoice request is received.
	///
	/// Indicates that an [`InvoiceRequest`] for an [`Offer`] created by us has been received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_invoice_request_response`] to respond with an appropriate
	/// response to the received invoice request. Use [`ChannelManager::reject_invoice_request`] to
	/// reject the invoice request and respond with an [`InvoiceError`]. See the docs for further details.
	///
	/// [`Offer`]: crate::offers::offer::Offer
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_invoice_request_response`]: crate::ln::channelmanager::ChannelManager::send_invoice_request_response
	/// [`ChannelManager::reject_invoice_request`]: crate::ln::channelmanager::ChannelManager::reject_invoice_request
	/// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
	InvoiceRequestReceived {
 /// The received invoice request to respond to.
 invoice_request: InvoiceRequest,
 /// The context of the [`BlindedMessagePath`] used to send the invoice request.
 ///
 /// [`BlindedMessagePath`]: crate::blinded_path::message::BlindedMessagePath
 context: Option<OffersContext>,
 /// A responder for replying with an [`InvoiceError`] if needed.
 ///
 /// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
 responder: Responder,
	},

	/// Indicates a [`Bolt12Invoice`] in response to an [`InvoiceRequest`] or a [`Refund`] was
	/// received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_invoices`] is set.
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_payment_for_bolt12_invoice`] to pay the invoice or
	/// [`ChannelManager::abandon_payment`] to abandon the associated payment. See those docs for
	/// further details.
Expand All@@ -835,7 +864,7 @@ pub enum Event {
	///
	/// [`InvoiceRequest`]: crate::offers::invoice_request::InvoiceRequest
	/// [`Refund`]: crate::offers::refund::Refund
	/// [`UserConfig::manually_handle_bolt12_invoices`]: crate::util::config::UserConfig::manually_handle_bolt12_invoices
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_payment_for_bolt12_invoice`]: crate::ln::channelmanager::ChannelManager::send_payment_for_bolt12_invoice
	/// [`ChannelManager::abandon_payment`]: crate::ln::channelmanager::ChannelManager::abandon_payment
	InvoiceReceived {
Expand DownExpand Up@@ -1741,6 +1770,14 @@ impl Writeable for Event {
 (8, former_temporary_channel_id, required),
 });
 },
 &Event::InvoiceRequestReceived { ref invoice_request, ref context, ref responder } => {
 44u8.write(writer)?;
 write_tlv_fields!(writer, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 },
 // Note that, going forward, all new events must only write data inside of
 // `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
 // data via `write_tlv_fields`.
Expand DownExpand Up@@ -2235,6 +2272,21 @@ impl MaybeReadable for Event {
 former_temporary_channel_id: former_temporary_channel_id.0.unwrap(),
 }))
 },
 44u8 => {
 let mut f = || {
 _init_and_read_len_prefixed_tlv_fields!(reader, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 Ok(Some(Event::InvoiceRequestReceived {
 invoice_request: invoice_request.0.unwrap(),
 context,
 responder: responder.0.unwrap(),
 }))
 };
 f()
 },
 // Versions prior to 0.0.100 did not ignore odd types, instead returning InvalidValue.
 // Version 0.0.100 failed to properly ignore odd types, possibly resulting in corrupt
 // reads.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Allow Asynchronously responding to Invoice Request by shaavan · Pull Request #3318 · lightningdevkit/rust-lightning · GitHub
Skip to content
Allow Asynchronously responding to Invoice Request#3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

shaavan
wants to merge
11
commits into

from

 Closed


Allow Asynchronously responding to Invoice Request
#3318
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
93fdfdb

Rename manually_handle_bolt12_invoices


shaavan Sep 10, 2024
5774809

Introduce InvoiceRequestReceived Event


shaavan Aug 30, 2024
2a3c8c6

f: Make Responder Required


shaavan Sep 20, 2024
6342cdd

Introduce Bolt12ResponseError


shaavan Sep 16, 2024
e3b4c9d

Update InvoiceBuilder's amount_msats


shaavan Sep 10, 2024
af75a15

f: Update custom_amount_msats check


shaavan Sep 20, 2024
4431d52

Introduce get_response_for_invoice_request


shaavan Sep 16, 2024
f8b48dc

Introduce send_invoice_request_response


shaavan Sep 16, 2024
f00047b

Introduce reject_invoice_request


shaavan Sep 16, 2024
3a37880

f: Update InvoiceRequestReceived docs


shaavan Sep 20, 2024
9b4daa4

Introduce test for check asynchronous Invoice Request Response


shaavan Sep 16, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


56 changes: 54 additions & 2 deletions
lightning/src/events/mod.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ use crate::ln::features::ChannelTypeFeatures;
use crate::ln::msgs;
use crate::ln::types::{ChannelId, PaymentPreimage, PaymentHash, PaymentSecret};
use crate::offers::invoice::Bolt12Invoice;
use crate::offers::invoice_request::InvoiceRequest;
use crate::onion_message::messenger::Responder;
use crate::routing::gossip::NetworkUpdate;
use crate::routing::router::{BlindedTail, Path, RouteHop, RouteParameters};
Expand DownExpand Up@@ -821,10 +822,38 @@ pub enum Event {
 /// Sockets for connecting to the node.
 addresses: Vec<msgs::SocketAddress>,
	},

	/// Event triggered when manual handling is enabled and an invoice request is received.
	///
	/// Indicates that an [`InvoiceRequest`] for an [`Offer`] created by us has been received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_invoice_request_response`] to respond with an appropriate
	/// response to the received invoice request. Use [`ChannelManager::reject_invoice_request`] to
	/// reject the invoice request and respond with an [`InvoiceError`]. See the docs for further details.
	///
	/// [`Offer`]: crate::offers::offer::Offer
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_invoice_request_response`]: crate::ln::channelmanager::ChannelManager::send_invoice_request_response
	/// [`ChannelManager::reject_invoice_request`]: crate::ln::channelmanager::ChannelManager::reject_invoice_request
	/// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
	InvoiceRequestReceived {
 /// The received invoice request to respond to.
 invoice_request: InvoiceRequest,
 /// The context of the [`BlindedMessagePath`] used to send the invoice request.
 ///
 /// [`BlindedMessagePath`]: crate::blinded_path::message::BlindedMessagePath
 context: Option<OffersContext>,
 /// A responder for replying with an [`InvoiceError`] if needed.
 ///
 /// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
 responder: Responder,
	},

	/// Indicates a [`Bolt12Invoice`] in response to an [`InvoiceRequest`] or a [`Refund`] was
	/// received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_invoices`] is set.
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_payment_for_bolt12_invoice`] to pay the invoice or
	/// [`ChannelManager::abandon_payment`] to abandon the associated payment. See those docs for
	/// further details.
Expand All@@ -835,7 +864,7 @@ pub enum Event {
	///
	/// [`InvoiceRequest`]: crate::offers::invoice_request::InvoiceRequest
	/// [`Refund`]: crate::offers::refund::Refund
	/// [`UserConfig::manually_handle_bolt12_invoices`]: crate::util::config::UserConfig::manually_handle_bolt12_invoices
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_payment_for_bolt12_invoice`]: crate::ln::channelmanager::ChannelManager::send_payment_for_bolt12_invoice
	/// [`ChannelManager::abandon_payment`]: crate::ln::channelmanager::ChannelManager::abandon_payment
	InvoiceReceived {
Expand DownExpand Up@@ -1741,6 +1770,14 @@ impl Writeable for Event {
 (8, former_temporary_channel_id, required),
 });
 },
 &Event::InvoiceRequestReceived { ref invoice_request, ref context, ref responder } => {
 44u8.write(writer)?;
 write_tlv_fields!(writer, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 },
 // Note that, going forward, all new events must only write data inside of
 // `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
 // data via `write_tlv_fields`.
Expand DownExpand Up@@ -2235,6 +2272,21 @@ impl MaybeReadable for Event {
 former_temporary_channel_id: former_temporary_channel_id.0.unwrap(),
 }))
 },
 44u8 => {
 let mut f = || {
 _init_and_read_len_prefixed_tlv_fields!(reader, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 Ok(Some(Event::InvoiceRequestReceived {
 invoice_request: invoice_request.0.unwrap(),
 context,
 responder: responder.0.unwrap(),
 }))
 };
 f()
 },
 // Versions prior to 0.0.100 did not ignore odd types, instead returning InvalidValue.
 // Version 0.0.100 failed to properly ignore odd types, possibly resulting in corrupt
 // reads.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow Asynchronously responding to Invoice Request by shaavan · Pull Request #3318 · lightningdevkit/rust-lightning · GitHub
Skip to content
Allow Asynchronously responding to Invoice Request#3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

shaavan
wants to merge
11
commits into

from

 Closed


Allow Asynchronously responding to Invoice Request
#3318
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
93fdfdb

Rename manually_handle_bolt12_invoices


shaavan Sep 10, 2024
5774809

Introduce InvoiceRequestReceived Event


shaavan Aug 30, 2024
2a3c8c6

f: Make Responder Required


shaavan Sep 20, 2024
6342cdd

Introduce Bolt12ResponseError


shaavan Sep 16, 2024
e3b4c9d

Update InvoiceBuilder's amount_msats


shaavan Sep 10, 2024
af75a15

f: Update custom_amount_msats check


shaavan Sep 20, 2024
4431d52

Introduce get_response_for_invoice_request


shaavan Sep 16, 2024
f8b48dc

Introduce send_invoice_request_response


shaavan Sep 16, 2024
f00047b

Introduce reject_invoice_request


shaavan Sep 16, 2024
3a37880

f: Update InvoiceRequestReceived docs


shaavan Sep 20, 2024
9b4daa4

Introduce test for check asynchronous Invoice Request Response


shaavan Sep 16, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


56 changes: 54 additions & 2 deletions
lightning/src/events/mod.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ use crate::ln::features::ChannelTypeFeatures;
use crate::ln::msgs;
use crate::ln::types::{ChannelId, PaymentPreimage, PaymentHash, PaymentSecret};
use crate::offers::invoice::Bolt12Invoice;
use crate::offers::invoice_request::InvoiceRequest;
use crate::onion_message::messenger::Responder;
use crate::routing::gossip::NetworkUpdate;
use crate::routing::router::{BlindedTail, Path, RouteHop, RouteParameters};
Expand DownExpand Up@@ -821,10 +822,38 @@ pub enum Event {
 /// Sockets for connecting to the node.
 addresses: Vec<msgs::SocketAddress>,
	},

	/// Event triggered when manual handling is enabled and an invoice request is received.
	///
	/// Indicates that an [`InvoiceRequest`] for an [`Offer`] created by us has been received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_invoice_request_response`] to respond with an appropriate
	/// response to the received invoice request. Use [`ChannelManager::reject_invoice_request`] to
	/// reject the invoice request and respond with an [`InvoiceError`]. See the docs for further details.
	///
	/// [`Offer`]: crate::offers::offer::Offer
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_invoice_request_response`]: crate::ln::channelmanager::ChannelManager::send_invoice_request_response
	/// [`ChannelManager::reject_invoice_request`]: crate::ln::channelmanager::ChannelManager::reject_invoice_request
	/// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
	InvoiceRequestReceived {
 /// The received invoice request to respond to.
 invoice_request: InvoiceRequest,
 /// The context of the [`BlindedMessagePath`] used to send the invoice request.
 ///
 /// [`BlindedMessagePath`]: crate::blinded_path::message::BlindedMessagePath
 context: Option<OffersContext>,
 /// A responder for replying with an [`InvoiceError`] if needed.
 ///
 /// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
 responder: Responder,
	},

	/// Indicates a [`Bolt12Invoice`] in response to an [`InvoiceRequest`] or a [`Refund`] was
	/// received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_invoices`] is set.
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_payment_for_bolt12_invoice`] to pay the invoice or
	/// [`ChannelManager::abandon_payment`] to abandon the associated payment. See those docs for
	/// further details.
Expand All@@ -835,7 +864,7 @@ pub enum Event {
	///
	/// [`InvoiceRequest`]: crate::offers::invoice_request::InvoiceRequest
	/// [`Refund`]: crate::offers::refund::Refund
	/// [`UserConfig::manually_handle_bolt12_invoices`]: crate::util::config::UserConfig::manually_handle_bolt12_invoices
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_payment_for_bolt12_invoice`]: crate::ln::channelmanager::ChannelManager::send_payment_for_bolt12_invoice
	/// [`ChannelManager::abandon_payment`]: crate::ln::channelmanager::ChannelManager::abandon_payment
	InvoiceReceived {
Expand DownExpand Up@@ -1741,6 +1770,14 @@ impl Writeable for Event {
 (8, former_temporary_channel_id, required),
 });
 },
 &Event::InvoiceRequestReceived { ref invoice_request, ref context, ref responder } => {
 44u8.write(writer)?;
 write_tlv_fields!(writer, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 },
 // Note that, going forward, all new events must only write data inside of
 // `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
 // data via `write_tlv_fields`.
Expand DownExpand Up@@ -2235,6 +2272,21 @@ impl MaybeReadable for Event {
 former_temporary_channel_id: former_temporary_channel_id.0.unwrap(),
 }))
 },
 44u8 => {
 let mut f = || {
 _init_and_read_len_prefixed_tlv_fields!(reader, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 Ok(Some(Event::InvoiceRequestReceived {
 invoice_request: invoice_request.0.unwrap(),
 context,
 responder: responder.0.unwrap(),
 }))
 };
 f()
 },
 // Versions prior to 0.0.100 did not ignore odd types, instead returning InvalidValue.
 // Version 0.0.100 failed to properly ignore odd types, possibly resulting in corrupt
 // reads.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow Asynchronously responding to Invoice Request by shaavan · Pull Request #3318 · lightningdevkit/rust-lightning · GitHub
Skip to content
Allow Asynchronously responding to Invoice Request#3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

shaavan
wants to merge
11
commits into

from

 Closed


Allow Asynchronously responding to Invoice Request
#3318
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
93fdfdb

Rename manually_handle_bolt12_invoices


shaavan Sep 10, 2024
5774809

Introduce InvoiceRequestReceived Event


shaavan Aug 30, 2024
2a3c8c6

f: Make Responder Required


shaavan Sep 20, 2024
6342cdd

Introduce Bolt12ResponseError


shaavan Sep 16, 2024
e3b4c9d

Update InvoiceBuilder's amount_msats


shaavan Sep 10, 2024
af75a15

f: Update custom_amount_msats check


shaavan Sep 20, 2024
4431d52

Introduce get_response_for_invoice_request


shaavan Sep 16, 2024
f8b48dc

Introduce send_invoice_request_response


shaavan Sep 16, 2024
f00047b

Introduce reject_invoice_request


shaavan Sep 16, 2024
3a37880

f: Update InvoiceRequestReceived docs


shaavan Sep 20, 2024
9b4daa4

Introduce test for check asynchronous Invoice Request Response


shaavan Sep 16, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


56 changes: 54 additions & 2 deletions
lightning/src/events/mod.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ use crate::ln::features::ChannelTypeFeatures;
use crate::ln::msgs;
use crate::ln::types::{ChannelId, PaymentPreimage, PaymentHash, PaymentSecret};
use crate::offers::invoice::Bolt12Invoice;
use crate::offers::invoice_request::InvoiceRequest;
use crate::onion_message::messenger::Responder;
use crate::routing::gossip::NetworkUpdate;
use crate::routing::router::{BlindedTail, Path, RouteHop, RouteParameters};
Expand DownExpand Up@@ -821,10 +822,38 @@ pub enum Event {
 /// Sockets for connecting to the node.
 addresses: Vec<msgs::SocketAddress>,
	},

	/// Event triggered when manual handling is enabled and an invoice request is received.
	///
	/// Indicates that an [`InvoiceRequest`] for an [`Offer`] created by us has been received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_invoice_request_response`] to respond with an appropriate
	/// response to the received invoice request. Use [`ChannelManager::reject_invoice_request`] to
	/// reject the invoice request and respond with an [`InvoiceError`]. See the docs for further details.
	///
	/// [`Offer`]: crate::offers::offer::Offer
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_invoice_request_response`]: crate::ln::channelmanager::ChannelManager::send_invoice_request_response
	/// [`ChannelManager::reject_invoice_request`]: crate::ln::channelmanager::ChannelManager::reject_invoice_request
	/// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
	InvoiceRequestReceived {
 /// The received invoice request to respond to.
 invoice_request: InvoiceRequest,
 /// The context of the [`BlindedMessagePath`] used to send the invoice request.
 ///
 /// [`BlindedMessagePath`]: crate::blinded_path::message::BlindedMessagePath
 context: Option<OffersContext>,
 /// A responder for replying with an [`InvoiceError`] if needed.
 ///
 /// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
 responder: Responder,
	},

	/// Indicates a [`Bolt12Invoice`] in response to an [`InvoiceRequest`] or a [`Refund`] was
	/// received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_invoices`] is set.
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_payment_for_bolt12_invoice`] to pay the invoice or
	/// [`ChannelManager::abandon_payment`] to abandon the associated payment. See those docs for
	/// further details.
Expand All@@ -835,7 +864,7 @@ pub enum Event {
	///
	/// [`InvoiceRequest`]: crate::offers::invoice_request::InvoiceRequest
	/// [`Refund`]: crate::offers::refund::Refund
	/// [`UserConfig::manually_handle_bolt12_invoices`]: crate::util::config::UserConfig::manually_handle_bolt12_invoices
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_payment_for_bolt12_invoice`]: crate::ln::channelmanager::ChannelManager::send_payment_for_bolt12_invoice
	/// [`ChannelManager::abandon_payment`]: crate::ln::channelmanager::ChannelManager::abandon_payment
	InvoiceReceived {
Expand DownExpand Up@@ -1741,6 +1770,14 @@ impl Writeable for Event {
 (8, former_temporary_channel_id, required),
 });
 },
 &Event::InvoiceRequestReceived { ref invoice_request, ref context, ref responder } => {
 44u8.write(writer)?;
 write_tlv_fields!(writer, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 },
 // Note that, going forward, all new events must only write data inside of
 // `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
 // data via `write_tlv_fields`.
Expand DownExpand Up@@ -2235,6 +2272,21 @@ impl MaybeReadable for Event {
 former_temporary_channel_id: former_temporary_channel_id.0.unwrap(),
 }))
 },
 44u8 => {
 let mut f = || {
 _init_and_read_len_prefixed_tlv_fields!(reader, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 Ok(Some(Event::InvoiceRequestReceived {
 invoice_request: invoice_request.0.unwrap(),
 context,
 responder: responder.0.unwrap(),
 }))
 };
 f()
 },
 // Versions prior to 0.0.100 did not ignore odd types, instead returning InvalidValue.
 // Version 0.0.100 failed to properly ignore odd types, possibly resulting in corrupt
 // reads.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Allow Asynchronously responding to Invoice Request by shaavan · Pull Request #3318 · lightningdevkit/rust-lightning · GitHub
Skip to content
Allow Asynchronously responding to Invoice Request#3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

shaavan
wants to merge
11
commits into

from

 Closed


Allow Asynchronously responding to Invoice Request
#3318
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
93fdfdb

Rename manually_handle_bolt12_invoices


shaavan Sep 10, 2024
5774809

Introduce InvoiceRequestReceived Event


shaavan Aug 30, 2024
2a3c8c6

f: Make Responder Required


shaavan Sep 20, 2024
6342cdd

Introduce Bolt12ResponseError


shaavan Sep 16, 2024
e3b4c9d

Update InvoiceBuilder's amount_msats


shaavan Sep 10, 2024
af75a15

f: Update custom_amount_msats check


shaavan Sep 20, 2024
4431d52

Introduce get_response_for_invoice_request


shaavan Sep 16, 2024
f8b48dc

Introduce send_invoice_request_response


shaavan Sep 16, 2024
f00047b

Introduce reject_invoice_request


shaavan Sep 16, 2024
3a37880

f: Update InvoiceRequestReceived docs


shaavan Sep 20, 2024
9b4daa4

Introduce test for check asynchronous Invoice Request Response


shaavan Sep 16, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


56 changes: 54 additions & 2 deletions
lightning/src/events/mod.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ use crate::ln::features::ChannelTypeFeatures;
use crate::ln::msgs;
use crate::ln::types::{ChannelId, PaymentPreimage, PaymentHash, PaymentSecret};
use crate::offers::invoice::Bolt12Invoice;
use crate::offers::invoice_request::InvoiceRequest;
use crate::onion_message::messenger::Responder;
use crate::routing::gossip::NetworkUpdate;
use crate::routing::router::{BlindedTail, Path, RouteHop, RouteParameters};
Expand DownExpand Up@@ -821,10 +822,38 @@ pub enum Event {
 /// Sockets for connecting to the node.
 addresses: Vec<msgs::SocketAddress>,
	},

	/// Event triggered when manual handling is enabled and an invoice request is received.
	///
	/// Indicates that an [`InvoiceRequest`] for an [`Offer`] created by us has been received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_invoice_request_response`] to respond with an appropriate
	/// response to the received invoice request. Use [`ChannelManager::reject_invoice_request`] to
	/// reject the invoice request and respond with an [`InvoiceError`]. See the docs for further details.
	///
	/// [`Offer`]: crate::offers::offer::Offer
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_invoice_request_response`]: crate::ln::channelmanager::ChannelManager::send_invoice_request_response
	/// [`ChannelManager::reject_invoice_request`]: crate::ln::channelmanager::ChannelManager::reject_invoice_request
	/// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
	InvoiceRequestReceived {
 /// The received invoice request to respond to.
 invoice_request: InvoiceRequest,
 /// The context of the [`BlindedMessagePath`] used to send the invoice request.
 ///
 /// [`BlindedMessagePath`]: crate::blinded_path::message::BlindedMessagePath
 context: Option<OffersContext>,
 /// A responder for replying with an [`InvoiceError`] if needed.
 ///
 /// [`InvoiceError`]: crate::offers::invoice_error::InvoiceError
 responder: Responder,
	},

	/// Indicates a [`Bolt12Invoice`] in response to an [`InvoiceRequest`] or a [`Refund`] was
	/// received.
	///
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_invoices`] is set.
	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
	/// Use [`ChannelManager::send_payment_for_bolt12_invoice`] to pay the invoice or
	/// [`ChannelManager::abandon_payment`] to abandon the associated payment. See those docs for
	/// further details.
Expand All@@ -835,7 +864,7 @@ pub enum Event {
	///
	/// [`InvoiceRequest`]: crate::offers::invoice_request::InvoiceRequest
	/// [`Refund`]: crate::offers::refund::Refund
	/// [`UserConfig::manually_handle_bolt12_invoices`]: crate::util::config::UserConfig::manually_handle_bolt12_invoices
	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
	/// [`ChannelManager::send_payment_for_bolt12_invoice`]: crate::ln::channelmanager::ChannelManager::send_payment_for_bolt12_invoice
	/// [`ChannelManager::abandon_payment`]: crate::ln::channelmanager::ChannelManager::abandon_payment
	InvoiceReceived {
Expand DownExpand Up@@ -1741,6 +1770,14 @@ impl Writeable for Event {
 (8, former_temporary_channel_id, required),
 });
 },
 &Event::InvoiceRequestReceived { ref invoice_request, ref context, ref responder } => {
 44u8.write(writer)?;
 write_tlv_fields!(writer, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 },
 // Note that, going forward, all new events must only write data inside of
 // `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
 // data via `write_tlv_fields`.
Expand DownExpand Up@@ -2235,6 +2272,21 @@ impl MaybeReadable for Event {
 former_temporary_channel_id: former_temporary_channel_id.0.unwrap(),
 }))
 },
 44u8 => {
 let mut f = || {
 _init_and_read_len_prefixed_tlv_fields!(reader, {
 (0, invoice_request, required),
 (2, context, option),
 (4, responder, required),
 });
 Ok(Some(Event::InvoiceRequestReceived {
 invoice_request: invoice_request.0.unwrap(),
 context,
 responder: responder.0.unwrap(),
 }))
 };
 f()
 },
 // Versions prior to 0.0.100 did not ignore odd types, instead returning InvalidValue.
 // Version 0.0.100 failed to properly ignore odd types, possibly resulting in corrupt
 // reads.
Expand Down
Loading