Uh oh!
There was an error while loading. Please reload this page.
Revert "Add logging around event processing." - #3363
Merged
Conversation
This reverts commit 85eb814. Logging here can be overly verbose and moreover in case of event handling failure, we loop back without any added delay.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #3363 +/- ##
==========================================
+ Coverage 89.65% 91.05% +1.40%
==========================================
Files 126 127 +1 Lines 102546 116952 +14406 Branches 102546 116952 +14406 ==========================================
+ Hits 91935 106495 +14560 + Misses 7890 7861 -29 + Partials 2721 2596 -125 ☔ View full report in Codecov by Sentry. |
tnull
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 85eb814.
Logging here can be overly verbose and moreover in case of event handling failure,
we loop back without any added delay.
See more : #3314 (comment)
Reverting the change to keep main clean until we have viable fix via #3331