Skip to content

Remove next_funding_txid tlv from Channel read/write - #3417

Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
dunxen:2024-11-removenextfundingtxidpersist
Nov 26, 2024
Merged

Remove next_funding_txid tlv from Channel read/write#3417
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
dunxen:2024-11-removenextfundingtxidpersist

Conversation

@dunxen

@dunxendunxen commented Nov 21, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Want to remove this before release so that we can work on a way to not persist this but rather get it from other persisted data and just free up the TLV.

Note that the "added in 0.0.124" comment was incorrect as it was actually added in #3137 but the comment was stale. So it's safe to remove.

See #3137 (comment) for context.

optout21
optout21 reviewed Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs Outdated
optout21
optout21 reviewed Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs Outdated
optout21
optout21 requested changes Nov 21, 2024
View reviewed changes

@optout21optout21 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment regarding the commas

@dunxen
dunxenforce-pushed the 2024-11-removenextfundingtxidpersist branch from 5f02ff5 to b78ec80CompareNovember 21, 2024 10:55
@dunxen

dunxen commented Nov 21, 2024

Copy link
Copy Markdown
ContributorAuthor

LGTM, minor comment regarding the commas

Thanks. Done!

@codecov

codecovBot commented Nov 21, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.24%. Comparing base (0c31021) to head (7177acb).
Report is 10 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #3417 +/- ##
==========================================
+ Coverage 89.22% 89.24% +0.02% 
==========================================
Files 130 130 Lines 106965 106960 -5 Branches 106965 106960 -5 ==========================================
+ Hits 95438 95458 +20 + Misses 8734 8709 -25 
Partials 2793 2793

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkczyz
jkczyz self-requested a review November 21, 2024 14:46
@dunxendunxen mentioned this pull request Nov 22, 2024
Merged
jkczyz
jkczyz reviewed Nov 22, 2024
View reviewed changes

@jkczyzjkczyz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.

@dunxen
Remove next_funding_txid tlv from channel read/write
7177acb
We want to remove this before release so that we can work on a way to
not persist this but rather get it from other persisted data and just
free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was
actually added in lightningdevkit#3137 but the comment was stale so it's safe to remove.
@dunxen
dunxenforce-pushed the 2024-11-removenextfundingtxidpersist branch from b78ec80 to 7177acbCompareNovember 25, 2024 07:20
@dunxen

dunxen commented Nov 25, 2024

Copy link
Copy Markdown
ContributorAuthor

LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.

Yeah true, thanks! Done.

@TheBlueMatt

TheBlueMatt commented Nov 25, 2024

Copy link
Copy Markdown
Collaborator

Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?

@dunxen

dunxen commented Nov 26, 2024

Copy link
Copy Markdown
ContributorAuthor

Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?

Yeah that's likely what we'll do. I just wanted to remove the persistence here to keep this small. I can address removing the field entirely in #3423.

TheBlueMatt
TheBlueMatt approved these changes Nov 26, 2024
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, definitely need to figure it out before 0.1, though.

@TheBlueMatt
TheBlueMatt merged commit 12920d8 into lightningdevkit:mainNov 26, 2024
@dunxen

dunxen commented Nov 27, 2024

Copy link
Copy Markdown
ContributorAuthor

Alright, definitely need to figure it out before 0.1, though.

Yeah, I'm adding it to #3423 which needs to go in before 0.1.

@dunxendunxen mentioned this pull request Nov 27, 2024
Merged
@dunxen
dunxen deleted the 2024-11-removenextfundingtxidpersist branch January 20, 2025 08:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@optout21optout21optout21 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dunxen@TheBlueMatt@jkczyz@optout21
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Remove `next_funding_txid` tlv from `Channel` read/write by dunxen · Pull Request #3417 · lightningdevkit/rust-lightning · GitHub
Skip to content
Remove next_funding_txid tlv from Channel read/write - #3417
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
dunxen:2024-11-removenextfundingtxidpersist
Nov 26, 2024
Merged
Remove next_funding_txid tlv from Channel read/write#3417
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
dunxen:2024-11-removenextfundingtxidpersist
Conversation
@dunxen
@dunxendunxen
commented
Nov 21, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Want to remove this before release so that we can work on a way to not persist this but rather get it from other persisted data and just free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was actually added in #3137 but the comment was stale. So it's safe to remove.
See #3137 (comment) for context.
optout21
optout21
reviewed
Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

optout21
optout21
reviewed
Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

optout21
optout21
requested changes
Nov 21, 2024
View reviewed changes
@optout21optout21
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment regarding the commas
@dunxen
dunxenforce-pushed
the
2024-11-removenextfundingtxidpersist
branch
from
5f02ff5 to
b78ec80CompareNovember 21, 2024 10:55
@dunxen
dunxen
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
LGTM, minor comment regarding the commas
Thanks. Done!
@codecov
codecovBot
commented
Nov 21, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 89.24%. Comparing base (0c31021) to head (7177acb).

Report is 10 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #3417 +/- ##
==========================================
+ Coverage 89.22% 89.24% +0.02% 
==========================================
Files 130 130 Lines 106965 106960 -5 Branches 106965 106960 -5 ==========================================
+ Hits 95438 95458 +20 + Misses 8734 8709 -25 
Partials 2793 2793 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
@jkczyz
jkczyz
self-requested a review
November 21, 2024 14:46
@dunxendunxen
mentioned this pull request
Nov 22, 2024
 Merged

jkczyz
jkczyz
reviewed
Nov 22, 2024
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.
@dunxen
Remove next_funding_txid tlv from channel read/write
7177acb
We want to remove this before release so that we can work on a way to
not persist this but rather get it from other persisted data and just
free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was
actually added in lightningdevkit#3137 but the comment was stale so it's safe to remove.
@dunxen
dunxenforce-pushed
the
2024-11-removenextfundingtxidpersist
branch
from
b78ec80 to
7177acbCompareNovember 25, 2024 07:20
@dunxen
dunxen
commented
Nov 25, 2024

Copy link


Copy Markdown

ContributorAuthor
LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.
Yeah true, thanks! Done.
@TheBlueMatt
TheBlueMatt
commented
Nov 25, 2024

Copy link


Copy Markdown

Collaborator
Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?
@dunxen
dunxen
commented
Nov 26, 2024

Copy link


Copy Markdown

ContributorAuthor
Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?
Yeah that's likely what we'll do. I just wanted to remove the persistence here to keep this small. I can address removing the field entirely in #3423.
TheBlueMatt
TheBlueMatt
approved these changes
Nov 26, 2024
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, definitely need to figure it out before 0.1, though.
@TheBlueMatt
TheBlueMatt
merged commit 12920d8
into
lightningdevkit:mainNov 26, 2024
@dunxen
dunxen
commented
Nov 27, 2024

Copy link


Copy Markdown

ContributorAuthor
Alright, definitely need to figure it out before 0.1, though.
Yeah, I'm adding it to #3423 which needs to go in before 0.1.
@dunxendunxen
mentioned this pull request
Nov 27, 2024
 Merged

@dunxen
dunxen
deleted the

2024-11-removenextfundingtxidpersist

branch
January 20, 2025 08:32
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@optout21optout21optout21 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@dunxen@TheBlueMatt@jkczyz@optout21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove `next_funding_txid` tlv from `Channel` read/write by dunxen · Pull Request #3417 · lightningdevkit/rust-lightning · GitHub
Skip to content
Remove next_funding_txid tlv from Channel read/write - #3417
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
dunxen:2024-11-removenextfundingtxidpersist
Nov 26, 2024
Merged
Remove next_funding_txid tlv from Channel read/write#3417
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
dunxen:2024-11-removenextfundingtxidpersist
Conversation
@dunxen
@dunxendunxen
commented
Nov 21, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Want to remove this before release so that we can work on a way to not persist this but rather get it from other persisted data and just free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was actually added in #3137 but the comment was stale. So it's safe to remove.
See #3137 (comment) for context.
optout21
optout21
reviewed
Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

optout21
optout21
reviewed
Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

optout21
optout21
requested changes
Nov 21, 2024
View reviewed changes
@optout21optout21
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment regarding the commas
@dunxen
dunxenforce-pushed
the
2024-11-removenextfundingtxidpersist
branch
from
5f02ff5 to
b78ec80CompareNovember 21, 2024 10:55
@dunxen
dunxen
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
LGTM, minor comment regarding the commas
Thanks. Done!
@codecov
codecovBot
commented
Nov 21, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 89.24%. Comparing base (0c31021) to head (7177acb).

Report is 10 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #3417 +/- ##
==========================================
+ Coverage 89.22% 89.24% +0.02% 
==========================================
Files 130 130 Lines 106965 106960 -5 Branches 106965 106960 -5 ==========================================
+ Hits 95438 95458 +20 + Misses 8734 8709 -25 
Partials 2793 2793 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
@jkczyz
jkczyz
self-requested a review
November 21, 2024 14:46
@dunxendunxen
mentioned this pull request
Nov 22, 2024
 Merged

jkczyz
jkczyz
reviewed
Nov 22, 2024
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.
@dunxen
Remove next_funding_txid tlv from channel read/write
7177acb
We want to remove this before release so that we can work on a way to
not persist this but rather get it from other persisted data and just
free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was
actually added in lightningdevkit#3137 but the comment was stale so it's safe to remove.
@dunxen
dunxenforce-pushed
the
2024-11-removenextfundingtxidpersist
branch
from
b78ec80 to
7177acbCompareNovember 25, 2024 07:20
@dunxen
dunxen
commented
Nov 25, 2024

Copy link


Copy Markdown

ContributorAuthor
LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.
Yeah true, thanks! Done.
@TheBlueMatt
TheBlueMatt
commented
Nov 25, 2024

Copy link


Copy Markdown

Collaborator
Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?
@dunxen
dunxen
commented
Nov 26, 2024

Copy link


Copy Markdown

ContributorAuthor
Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?
Yeah that's likely what we'll do. I just wanted to remove the persistence here to keep this small. I can address removing the field entirely in #3423.
TheBlueMatt
TheBlueMatt
approved these changes
Nov 26, 2024
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, definitely need to figure it out before 0.1, though.
@TheBlueMatt
TheBlueMatt
merged commit 12920d8
into
lightningdevkit:mainNov 26, 2024
@dunxen
dunxen
commented
Nov 27, 2024

Copy link


Copy Markdown

ContributorAuthor
Alright, definitely need to figure it out before 0.1, though.
Yeah, I'm adding it to #3423 which needs to go in before 0.1.
@dunxendunxen
mentioned this pull request
Nov 27, 2024
 Merged

@dunxen
dunxen
deleted the

2024-11-removenextfundingtxidpersist

branch
January 20, 2025 08:32
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@optout21optout21optout21 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@dunxen@TheBlueMatt@jkczyz@optout21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove `next_funding_txid` tlv from `Channel` read/write by dunxen · Pull Request #3417 · lightningdevkit/rust-lightning · GitHub
Skip to content
Remove next_funding_txid tlv from Channel read/write - #3417
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
dunxen:2024-11-removenextfundingtxidpersist
Nov 26, 2024
Merged
Remove next_funding_txid tlv from Channel read/write#3417
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
dunxen:2024-11-removenextfundingtxidpersist
Conversation
@dunxen
@dunxendunxen
commented
Nov 21, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Want to remove this before release so that we can work on a way to not persist this but rather get it from other persisted data and just free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was actually added in #3137 but the comment was stale. So it's safe to remove.
See #3137 (comment) for context.
optout21
optout21
reviewed
Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

optout21
optout21
reviewed
Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

optout21
optout21
requested changes
Nov 21, 2024
View reviewed changes
@optout21optout21
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment regarding the commas
@dunxen
dunxenforce-pushed
the
2024-11-removenextfundingtxidpersist
branch
from
5f02ff5 to
b78ec80CompareNovember 21, 2024 10:55
@dunxen
dunxen
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
LGTM, minor comment regarding the commas
Thanks. Done!
@codecov
codecovBot
commented
Nov 21, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 89.24%. Comparing base (0c31021) to head (7177acb).

Report is 10 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #3417 +/- ##
==========================================
+ Coverage 89.22% 89.24% +0.02% 
==========================================
Files 130 130 Lines 106965 106960 -5 Branches 106965 106960 -5 ==========================================
+ Hits 95438 95458 +20 + Misses 8734 8709 -25 
Partials 2793 2793 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
@jkczyz
jkczyz
self-requested a review
November 21, 2024 14:46
@dunxendunxen
mentioned this pull request
Nov 22, 2024
 Merged

jkczyz
jkczyz
reviewed
Nov 22, 2024
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.
@dunxen
Remove next_funding_txid tlv from channel read/write
7177acb
We want to remove this before release so that we can work on a way to
not persist this but rather get it from other persisted data and just
free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was
actually added in lightningdevkit#3137 but the comment was stale so it's safe to remove.
@dunxen
dunxenforce-pushed
the
2024-11-removenextfundingtxidpersist
branch
from
b78ec80 to
7177acbCompareNovember 25, 2024 07:20
@dunxen
dunxen
commented
Nov 25, 2024

Copy link


Copy Markdown

ContributorAuthor
LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.
Yeah true, thanks! Done.
@TheBlueMatt
TheBlueMatt
commented
Nov 25, 2024

Copy link


Copy Markdown

Collaborator
Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?
@dunxen
dunxen
commented
Nov 26, 2024

Copy link


Copy Markdown

ContributorAuthor
Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?
Yeah that's likely what we'll do. I just wanted to remove the persistence here to keep this small. I can address removing the field entirely in #3423.
TheBlueMatt
TheBlueMatt
approved these changes
Nov 26, 2024
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, definitely need to figure it out before 0.1, though.
@TheBlueMatt
TheBlueMatt
merged commit 12920d8
into
lightningdevkit:mainNov 26, 2024
@dunxen
dunxen
commented
Nov 27, 2024

Copy link


Copy Markdown

ContributorAuthor
Alright, definitely need to figure it out before 0.1, though.
Yeah, I'm adding it to #3423 which needs to go in before 0.1.
@dunxendunxen
mentioned this pull request
Nov 27, 2024
 Merged

@dunxen
dunxen
deleted the

2024-11-removenextfundingtxidpersist

branch
January 20, 2025 08:32
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@optout21optout21optout21 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@dunxen@TheBlueMatt@jkczyz@optout21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Remove `next_funding_txid` tlv from `Channel` read/write by dunxen · Pull Request #3417 · lightningdevkit/rust-lightning · GitHub
Skip to content
Remove next_funding_txid tlv from Channel read/write - #3417
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
dunxen:2024-11-removenextfundingtxidpersist
Nov 26, 2024
Merged
Remove next_funding_txid tlv from Channel read/write#3417
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
dunxen:2024-11-removenextfundingtxidpersist
Conversation
@dunxen
@dunxendunxen
commented
Nov 21, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Want to remove this before release so that we can work on a way to not persist this but rather get it from other persisted data and just free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was actually added in #3137 but the comment was stale. So it's safe to remove.
See #3137 (comment) for context.
optout21
optout21
reviewed
Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

optout21
optout21
reviewed
Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

optout21
optout21
requested changes
Nov 21, 2024
View reviewed changes
@optout21optout21
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment regarding the commas
@dunxen
dunxenforce-pushed
the
2024-11-removenextfundingtxidpersist
branch
from
5f02ff5 to
b78ec80CompareNovember 21, 2024 10:55
@dunxen
dunxen
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
LGTM, minor comment regarding the commas
Thanks. Done!
@codecov
codecovBot
commented
Nov 21, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 89.24%. Comparing base (0c31021) to head (7177acb).

Report is 10 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #3417 +/- ##
==========================================
+ Coverage 89.22% 89.24% +0.02% 
==========================================
Files 130 130 Lines 106965 106960 -5 Branches 106965 106960 -5 ==========================================
+ Hits 95438 95458 +20 + Misses 8734 8709 -25 
Partials 2793 2793 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
@jkczyz
jkczyz
self-requested a review
November 21, 2024 14:46
@dunxendunxen
mentioned this pull request
Nov 22, 2024
 Merged

jkczyz
jkczyz
reviewed
Nov 22, 2024
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.
@dunxen
Remove next_funding_txid tlv from channel read/write
7177acb
We want to remove this before release so that we can work on a way to
not persist this but rather get it from other persisted data and just
free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was
actually added in lightningdevkit#3137 but the comment was stale so it's safe to remove.
@dunxen
dunxenforce-pushed
the
2024-11-removenextfundingtxidpersist
branch
from
b78ec80 to
7177acbCompareNovember 25, 2024 07:20
@dunxen
dunxen
commented
Nov 25, 2024

Copy link


Copy Markdown

ContributorAuthor
LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.
Yeah true, thanks! Done.
@TheBlueMatt
TheBlueMatt
commented
Nov 25, 2024

Copy link


Copy Markdown

Collaborator
Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?
@dunxen
dunxen
commented
Nov 26, 2024

Copy link


Copy Markdown

ContributorAuthor
Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?
Yeah that's likely what we'll do. I just wanted to remove the persistence here to keep this small. I can address removing the field entirely in #3423.
TheBlueMatt
TheBlueMatt
approved these changes
Nov 26, 2024
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, definitely need to figure it out before 0.1, though.
@TheBlueMatt
TheBlueMatt
merged commit 12920d8
into
lightningdevkit:mainNov 26, 2024
@dunxen
dunxen
commented
Nov 27, 2024

Copy link


Copy Markdown

ContributorAuthor
Alright, definitely need to figure it out before 0.1, though.
Yeah, I'm adding it to #3423 which needs to go in before 0.1.
@dunxendunxen
mentioned this pull request
Nov 27, 2024
 Merged

@dunxen
dunxen
deleted the

2024-11-removenextfundingtxidpersist

branch
January 20, 2025 08:32
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@optout21optout21optout21 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@dunxen@TheBlueMatt@jkczyz@optout21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove `next_funding_txid` tlv from `Channel` read/write by dunxen · Pull Request #3417 · lightningdevkit/rust-lightning · GitHub
Skip to content
Remove next_funding_txid tlv from Channel read/write - #3417
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
dunxen:2024-11-removenextfundingtxidpersist
Nov 26, 2024
Merged
Remove next_funding_txid tlv from Channel read/write#3417
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
dunxen:2024-11-removenextfundingtxidpersist
Conversation
@dunxen
@dunxendunxen
commented
Nov 21, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Want to remove this before release so that we can work on a way to not persist this but rather get it from other persisted data and just free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was actually added in #3137 but the comment was stale. So it's safe to remove.
See #3137 (comment) for context.
optout21
optout21
reviewed
Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

optout21
optout21
reviewed
Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

optout21
optout21
requested changes
Nov 21, 2024
View reviewed changes
@optout21optout21
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment regarding the commas
@dunxen
dunxenforce-pushed
the
2024-11-removenextfundingtxidpersist
branch
from
5f02ff5 to
b78ec80CompareNovember 21, 2024 10:55
@dunxen
dunxen
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
LGTM, minor comment regarding the commas
Thanks. Done!
@codecov
codecovBot
commented
Nov 21, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 89.24%. Comparing base (0c31021) to head (7177acb).

Report is 10 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #3417 +/- ##
==========================================
+ Coverage 89.22% 89.24% +0.02% 
==========================================
Files 130 130 Lines 106965 106960 -5 Branches 106965 106960 -5 ==========================================
+ Hits 95438 95458 +20 + Misses 8734 8709 -25 
Partials 2793 2793 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
@jkczyz
jkczyz
self-requested a review
November 21, 2024 14:46
@dunxendunxen
mentioned this pull request
Nov 22, 2024
 Merged

jkczyz
jkczyz
reviewed
Nov 22, 2024
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.
@dunxen
Remove next_funding_txid tlv from channel read/write
7177acb
We want to remove this before release so that we can work on a way to
not persist this but rather get it from other persisted data and just
free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was
actually added in lightningdevkit#3137 but the comment was stale so it's safe to remove.
@dunxen
dunxenforce-pushed
the
2024-11-removenextfundingtxidpersist
branch
from
b78ec80 to
7177acbCompareNovember 25, 2024 07:20
@dunxen
dunxen
commented
Nov 25, 2024

Copy link


Copy Markdown

ContributorAuthor
LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.
Yeah true, thanks! Done.
@TheBlueMatt
TheBlueMatt
commented
Nov 25, 2024

Copy link


Copy Markdown

Collaborator
Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?
@dunxen
dunxen
commented
Nov 26, 2024

Copy link


Copy Markdown

ContributorAuthor
Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?
Yeah that's likely what we'll do. I just wanted to remove the persistence here to keep this small. I can address removing the field entirely in #3423.
TheBlueMatt
TheBlueMatt
approved these changes
Nov 26, 2024
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, definitely need to figure it out before 0.1, though.
@TheBlueMatt
TheBlueMatt
merged commit 12920d8
into
lightningdevkit:mainNov 26, 2024
@dunxen
dunxen
commented
Nov 27, 2024

Copy link


Copy Markdown

ContributorAuthor
Alright, definitely need to figure it out before 0.1, though.
Yeah, I'm adding it to #3423 which needs to go in before 0.1.
@dunxendunxen
mentioned this pull request
Nov 27, 2024
 Merged

@dunxen
dunxen
deleted the

2024-11-removenextfundingtxidpersist

branch
January 20, 2025 08:32
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@optout21optout21optout21 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@dunxen@TheBlueMatt@jkczyz@optout21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Remove `next_funding_txid` tlv from `Channel` read/write by dunxen · Pull Request #3417 · lightningdevkit/rust-lightning · GitHub
Skip to content
Remove next_funding_txid tlv from Channel read/write - #3417
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
dunxen:2024-11-removenextfundingtxidpersist
Nov 26, 2024
Merged
Remove next_funding_txid tlv from Channel read/write#3417
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
dunxen:2024-11-removenextfundingtxidpersist
Conversation
@dunxen
@dunxendunxen
commented
Nov 21, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Want to remove this before release so that we can work on a way to not persist this but rather get it from other persisted data and just free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was actually added in #3137 but the comment was stale. So it's safe to remove.
See #3137 (comment) for context.
optout21
optout21
reviewed
Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

optout21
optout21
reviewed
Nov 21, 2024
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Outdated

optout21
optout21
requested changes
Nov 21, 2024
View reviewed changes
@optout21optout21
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment regarding the commas
@dunxen
dunxenforce-pushed
the
2024-11-removenextfundingtxidpersist
branch
from
5f02ff5 to
b78ec80CompareNovember 21, 2024 10:55
@dunxen
dunxen
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
LGTM, minor comment regarding the commas
Thanks. Done!
@codecov
codecovBot
commented
Nov 21, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 89.24%. Comparing base (0c31021) to head (7177acb).

Report is 10 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #3417 +/- ##
==========================================
+ Coverage 89.22% 89.24% +0.02% 
==========================================
Files 130 130 Lines 106965 106960 -5 Branches 106965 106960 -5 ==========================================
+ Hits 95438 95458 +20 + Misses 8734 8709 -25 
Partials 2793 2793 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
@jkczyz
jkczyz
self-requested a review
November 21, 2024 14:46
@dunxendunxen
mentioned this pull request
Nov 22, 2024
 Merged

jkczyz
jkczyz
reviewed
Nov 22, 2024
View reviewed changes
@jkczyzjkczyz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.
@dunxen
Remove next_funding_txid tlv from channel read/write
7177acb
We want to remove this before release so that we can work on a way to
not persist this but rather get it from other persisted data and just
free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was
actually added in lightningdevkit#3137 but the comment was stale so it's safe to remove.
@dunxen
dunxenforce-pushed
the
2024-11-removenextfundingtxidpersist
branch
from
b78ec80 to
7177acbCompareNovember 25, 2024 07:20
@dunxen
dunxen
commented
Nov 25, 2024

Copy link


Copy Markdown

ContributorAuthor
LGTM. Could you please include the rationale in the commit message? Better to not rely on github for this information.
Yeah true, thanks! Done.
@TheBlueMatt
TheBlueMatt
commented
Nov 25, 2024

Copy link


Copy Markdown

Collaborator
Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?
@dunxen
dunxen
commented
Nov 26, 2024

Copy link


Copy Markdown

ContributorAuthor
Can we actually just remove the field entirely and use funding_tx.compute_txid() and the current channel state instead?
Yeah that's likely what we'll do. I just wanted to remove the persistence here to keep this small. I can address removing the field entirely in #3423.
TheBlueMatt
TheBlueMatt
approved these changes
Nov 26, 2024
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, definitely need to figure it out before 0.1, though.
@TheBlueMatt
TheBlueMatt
merged commit 12920d8
into
lightningdevkit:mainNov 26, 2024
@dunxen
dunxen
commented
Nov 27, 2024

Copy link


Copy Markdown

ContributorAuthor
Alright, definitely need to figure it out before 0.1, though.
Yeah, I'm adding it to #3423 which needs to go in before 0.1.
@dunxendunxen
mentioned this pull request
Nov 27, 2024
 Merged

@dunxen
dunxen
deleted the

2024-11-removenextfundingtxidpersist

branch
January 20, 2025 08:32
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz left review comments
@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@optout21optout21optout21 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@dunxen@TheBlueMatt@jkczyz@optout21