Skip to content

[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding - #3444

Closed
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom
optout21:splice-dual-tx
Closed

[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding#3444
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom
optout21:splice-dual-tx

Conversation

@optout21

@optout21optout21 commented Dec 5, 2024•
edited by dunxen
Loading

Copy link
Copy Markdown
Contributor

This is a next step in the splicing partial implementation, including and depending on the following:

Also relevant: #3418

Next step in splicing (#1621): This PR adds the implementation of performing the interactive transaction negotiation for the new post-splice funding transaction, after the splice_init & splice_ack handshake. Only the initiator can currently contribute.
The initiator adds the current funding tx as input, plus additional inputs, and the new funding as output plus a change output (if applicable).
After tx_complete the flow stops, does not yet follow to the commitment/signature exchange.

This was referenced Dec 5, 2024
Closed
Merged
@jkczyz
jkczyz self-requested a review December 5, 2024 17:52
@optout21optout21 mentioned this pull request Dec 5, 2024
Closed
@optout21

optout21 commented Dec 11, 2024

Copy link
Copy Markdown
ContributorAuthor

Rebased to current main, and current state of #3443 .

@optout21optout21 mentioned this pull request Dec 14, 2024
Merged
@jkczyz
jkczyz requested a review from wpaulinoJanuary 6, 2025 18:37
@optout21

optout21 commented Jan 7, 2025

Copy link
Copy Markdown
ContributorAuthor

Rebased

@optout21
optout21force-pushed the splice-dual-tx branch 2 times, most recently from 6e8a1c1 to dc5a209CompareJanuary 15, 2025 23:22
@optout21

optout21 commented Jan 15, 2025

Copy link
Copy Markdown
ContributorAuthor

Rebased; after #3513 many changes disappeared :)

@optout21

optout21 commented Feb 11, 2025

Copy link
Copy Markdown
ContributorAuthor

Rebased, following channel phase #3418 . The channel manager part got much simpler!

@optout21optout21 mentioned this pull request Feb 28, 2025
Closed
@dunxen
dunxen self-requested a review March 4, 2025 11:37
@optout21
optout21force-pushed the splice-dual-tx branch 6 times, most recently from fc2e085 to f93b0deCompareMarch 5, 2025 22:57
@optout21

optout21 commented Mar 5, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Rebased up to 0216d7d#3629 from joostjager/log-attribution-failures Mar 4

Cannot rebase past that, df68774#3016 somehow breaks my rebaseing...

@optout21

optout21 commented Mar 5, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Squashed some commits

@optout21
optout21force-pushed the splice-dual-tx branch 4 times, most recently from 8b3e9b8 to 8526b4aCompareMarch 6, 2025 01:14
@optout21
optout21force-pushed the splice-dual-tx branch 11 times, most recently from ad7d810 to db27917CompareMarch 19, 2025 23:27
@codecov

codecovBot commented Mar 19, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 77.64706% with 114 lines in your changes missing coverage. Please review.

Project coverage is 89.67%. Comparing base (c355ea4) to head (db27917).
Report is 16 commits behind head on main.

Files with missing linesPatch %Lines
lightning/src/ln/channel.rs69.05%107 Missing and 1 partial ⚠️
lightning/src/ln/channelmanager.rs16.66%5 Missing ⚠️
lightning/src/events/mod.rs0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3444 +/- ##
==========================================
+ Coverage 89.20% 89.67% +0.46% 
==========================================
Files 155 155 Lines 119377 124547 +5170 Branches 119377 124547 +5170 ==========================================
+ Hits 106496 111687 +5191 + Misses 10266 10227 -39 - Partials 2615 2633 +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@optout21

optout21 commented Mar 27, 2025

Copy link
Copy Markdown
ContributorAuthor

Continued implementation: added funding_transaction_signed methods, tx_complete is handled on both sides.

@optout21optout21 mentioned this pull request Apr 8, 2025
Closed
@optout21optout21 mentioned this pull request Apr 15, 2025
Merged
@wpaulino
wpaulino removed their request for review April 28, 2025 16:41
@optout21

optout21 commented Dec 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Closing as this prototype is no longer valid/needed 😎

@optout21optout21 closed this Dec 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkczyzjkczyzAwaiting requested review from jkczyz
@dunxendunxenAwaiting requested review from dunxen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@optout21
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding by optout21 · Pull Request #3444 · lightningdevkit/rust-lightning · GitHub
Skip to content
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding - #3444
Closed
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom 
optout21:splice-dual-tx
Closed
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding#3444
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom 
optout21:splice-dual-tx
Conversation
@optout21
@optout21optout21
commented
Dec 5, 2024•

edited by dunxen

Loading

Copy link


Copy Markdown

Contributor
This is a next step in the splicing partial implementation, including and depending on the following:
Also relevant: #3418
Next step in splicing (#1621): This PR adds the implementation of performing the interactive transaction negotiation for the new post-splice funding transaction, after the splice_init & splice_ack handshake. Only the initiator can currently contribute.

The initiator adds the current funding tx as input, plus additional inputs, and the new funding as output plus a change output (if applicable).

After tx_complete the flow stops, does not yet follow to the commitment/signature exchange.

This was referenced Dec 5, 2024

Closed

 Merged

@jkczyz
jkczyz
self-requested a review
December 5, 2024 17:52
@optout21optout21
mentioned this pull request
Dec 5, 2024
 Closed

@optout21
optout21
commented
Dec 11, 2024

Copy link


Copy Markdown

ContributorAuthor
Rebased to current main, and current state of #3443 .
@optout21optout21
mentioned this pull request
Dec 14, 2024
 Merged

@jkczyz
jkczyz
requested a review
from wpaulinoJanuary 6, 2025 18:37
@optout21
optout21
commented
Jan 7, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased
@optout21
optout21force-pushed
the
splice-dual-tx
branch
2 times, most recently
from
6e8a1c1 to
dc5a209CompareJanuary 15, 2025 23:22
@optout21
optout21
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased; after #3513 many changes disappeared :)
@optout21
optout21
commented
Feb 11, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased, following channel phase #3418 . The channel manager part got much simpler!
@optout21optout21
mentioned this pull request
Feb 28, 2025
 Closed

@dunxen
dunxen
self-requested a review
March 4, 2025 11:37
@optout21
optout21force-pushed
the
splice-dual-tx
branch
6 times, most recently
from
fc2e085 to
f93b0deCompareMarch 5, 2025 22:57
@optout21
optout21
commented
Mar 5, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased up to 0216d7d#3629 from joostjager/log-attribution-failures Mar 4
Cannot rebase past that, df68774#3016 somehow breaks my rebaseing...
@optout21
optout21
commented
Mar 5, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Squashed some commits
@optout21
optout21force-pushed
the
splice-dual-tx
branch
4 times, most recently
from
8b3e9b8 to
8526b4aCompareMarch 6, 2025 01:14
@optout21
optout21force-pushed
the
splice-dual-tx
branch
11 times, most recently
from
ad7d810 to
db27917CompareMarch 19, 2025 23:27
@codecov
codecovBot
commented
Mar 19, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 77.64706% with 114 lines in your changes missing coverage. Please review.
Project coverage is 89.67%. Comparing base (c355ea4) to head (db27917).

Report is 16 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/ln/channel.rs69.05%107 Missing and 1 partial ⚠️
lightning/src/ln/channelmanager.rs16.66%5 Missing ⚠️
lightning/src/events/mod.rs0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3444 +/- ##
==========================================
+ Coverage 89.20% 89.67% +0.46% 
==========================================
Files 155 155 Lines 119377 124547 +5170 Branches 119377 124547 +5170 ==========================================
+ Hits 106496 111687 +5191 + Misses 10266 10227 -39 - Partials 2615 2633 +18 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow: 
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@optout21
optout21
commented
Mar 27, 2025

Copy link


Copy Markdown

ContributorAuthor
Continued implementation: added funding_transaction_signed methods, tx_complete is handled on both sides.
@optout21optout21
mentioned this pull request
Apr 8, 2025
 Closed

@optout21optout21
mentioned this pull request
Apr 15, 2025
 Merged

@wpaulino
wpaulino
removed their request for review
April 28, 2025 16:41
@optout21
optout21
commented
Dec 9, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing as this prototype is no longer valid/needed 😎
@optout21optout21
closed this
Dec 9, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzAwaiting requested review from jkczyz
@dunxendunxenAwaiting requested review from dunxen

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@optout21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding by optout21 · Pull Request #3444 · lightningdevkit/rust-lightning · GitHub
Skip to content
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding - #3444
Closed
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom 
optout21:splice-dual-tx
Closed
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding#3444
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom 
optout21:splice-dual-tx
Conversation
@optout21
@optout21optout21
commented
Dec 5, 2024•

edited by dunxen

Loading

Copy link


Copy Markdown

Contributor
This is a next step in the splicing partial implementation, including and depending on the following:
Also relevant: #3418
Next step in splicing (#1621): This PR adds the implementation of performing the interactive transaction negotiation for the new post-splice funding transaction, after the splice_init & splice_ack handshake. Only the initiator can currently contribute.

The initiator adds the current funding tx as input, plus additional inputs, and the new funding as output plus a change output (if applicable).

After tx_complete the flow stops, does not yet follow to the commitment/signature exchange.

This was referenced Dec 5, 2024

Closed

 Merged

@jkczyz
jkczyz
self-requested a review
December 5, 2024 17:52
@optout21optout21
mentioned this pull request
Dec 5, 2024
 Closed

@optout21
optout21
commented
Dec 11, 2024

Copy link


Copy Markdown

ContributorAuthor
Rebased to current main, and current state of #3443 .
@optout21optout21
mentioned this pull request
Dec 14, 2024
 Merged

@jkczyz
jkczyz
requested a review
from wpaulinoJanuary 6, 2025 18:37
@optout21
optout21
commented
Jan 7, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased
@optout21
optout21force-pushed
the
splice-dual-tx
branch
2 times, most recently
from
6e8a1c1 to
dc5a209CompareJanuary 15, 2025 23:22
@optout21
optout21
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased; after #3513 many changes disappeared :)
@optout21
optout21
commented
Feb 11, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased, following channel phase #3418 . The channel manager part got much simpler!
@optout21optout21
mentioned this pull request
Feb 28, 2025
 Closed

@dunxen
dunxen
self-requested a review
March 4, 2025 11:37
@optout21
optout21force-pushed
the
splice-dual-tx
branch
6 times, most recently
from
fc2e085 to
f93b0deCompareMarch 5, 2025 22:57
@optout21
optout21
commented
Mar 5, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased up to 0216d7d#3629 from joostjager/log-attribution-failures Mar 4
Cannot rebase past that, df68774#3016 somehow breaks my rebaseing...
@optout21
optout21
commented
Mar 5, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Squashed some commits
@optout21
optout21force-pushed
the
splice-dual-tx
branch
4 times, most recently
from
8b3e9b8 to
8526b4aCompareMarch 6, 2025 01:14
@optout21
optout21force-pushed
the
splice-dual-tx
branch
11 times, most recently
from
ad7d810 to
db27917CompareMarch 19, 2025 23:27
@codecov
codecovBot
commented
Mar 19, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 77.64706% with 114 lines in your changes missing coverage. Please review.
Project coverage is 89.67%. Comparing base (c355ea4) to head (db27917).

Report is 16 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/ln/channel.rs69.05%107 Missing and 1 partial ⚠️
lightning/src/ln/channelmanager.rs16.66%5 Missing ⚠️
lightning/src/events/mod.rs0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3444 +/- ##
==========================================
+ Coverage 89.20% 89.67% +0.46% 
==========================================
Files 155 155 Lines 119377 124547 +5170 Branches 119377 124547 +5170 ==========================================
+ Hits 106496 111687 +5191 + Misses 10266 10227 -39 - Partials 2615 2633 +18 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow: 
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@optout21
optout21
commented
Mar 27, 2025

Copy link


Copy Markdown

ContributorAuthor
Continued implementation: added funding_transaction_signed methods, tx_complete is handled on both sides.
@optout21optout21
mentioned this pull request
Apr 8, 2025
 Closed

@optout21optout21
mentioned this pull request
Apr 15, 2025
 Merged

@wpaulino
wpaulino
removed their request for review
April 28, 2025 16:41
@optout21
optout21
commented
Dec 9, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing as this prototype is no longer valid/needed 😎
@optout21optout21
closed this
Dec 9, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzAwaiting requested review from jkczyz
@dunxendunxenAwaiting requested review from dunxen

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@optout21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding by optout21 · Pull Request #3444 · lightningdevkit/rust-lightning · GitHub
Skip to content
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding - #3444
Closed
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom 
optout21:splice-dual-tx
Closed
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding#3444
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom 
optout21:splice-dual-tx
Conversation
@optout21
@optout21optout21
commented
Dec 5, 2024•

edited by dunxen

Loading

Copy link


Copy Markdown

Contributor
This is a next step in the splicing partial implementation, including and depending on the following:
Also relevant: #3418
Next step in splicing (#1621): This PR adds the implementation of performing the interactive transaction negotiation for the new post-splice funding transaction, after the splice_init & splice_ack handshake. Only the initiator can currently contribute.

The initiator adds the current funding tx as input, plus additional inputs, and the new funding as output plus a change output (if applicable).

After tx_complete the flow stops, does not yet follow to the commitment/signature exchange.

This was referenced Dec 5, 2024

Closed

 Merged

@jkczyz
jkczyz
self-requested a review
December 5, 2024 17:52
@optout21optout21
mentioned this pull request
Dec 5, 2024
 Closed

@optout21
optout21
commented
Dec 11, 2024

Copy link


Copy Markdown

ContributorAuthor
Rebased to current main, and current state of #3443 .
@optout21optout21
mentioned this pull request
Dec 14, 2024
 Merged

@jkczyz
jkczyz
requested a review
from wpaulinoJanuary 6, 2025 18:37
@optout21
optout21
commented
Jan 7, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased
@optout21
optout21force-pushed
the
splice-dual-tx
branch
2 times, most recently
from
6e8a1c1 to
dc5a209CompareJanuary 15, 2025 23:22
@optout21
optout21
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased; after #3513 many changes disappeared :)
@optout21
optout21
commented
Feb 11, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased, following channel phase #3418 . The channel manager part got much simpler!
@optout21optout21
mentioned this pull request
Feb 28, 2025
 Closed

@dunxen
dunxen
self-requested a review
March 4, 2025 11:37
@optout21
optout21force-pushed
the
splice-dual-tx
branch
6 times, most recently
from
fc2e085 to
f93b0deCompareMarch 5, 2025 22:57
@optout21
optout21
commented
Mar 5, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased up to 0216d7d#3629 from joostjager/log-attribution-failures Mar 4
Cannot rebase past that, df68774#3016 somehow breaks my rebaseing...
@optout21
optout21
commented
Mar 5, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Squashed some commits
@optout21
optout21force-pushed
the
splice-dual-tx
branch
4 times, most recently
from
8b3e9b8 to
8526b4aCompareMarch 6, 2025 01:14
@optout21
optout21force-pushed
the
splice-dual-tx
branch
11 times, most recently
from
ad7d810 to
db27917CompareMarch 19, 2025 23:27
@codecov
codecovBot
commented
Mar 19, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 77.64706% with 114 lines in your changes missing coverage. Please review.
Project coverage is 89.67%. Comparing base (c355ea4) to head (db27917).

Report is 16 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/ln/channel.rs69.05%107 Missing and 1 partial ⚠️
lightning/src/ln/channelmanager.rs16.66%5 Missing ⚠️
lightning/src/events/mod.rs0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3444 +/- ##
==========================================
+ Coverage 89.20% 89.67% +0.46% 
==========================================
Files 155 155 Lines 119377 124547 +5170 Branches 119377 124547 +5170 ==========================================
+ Hits 106496 111687 +5191 + Misses 10266 10227 -39 - Partials 2615 2633 +18 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow: 
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@optout21
optout21
commented
Mar 27, 2025

Copy link


Copy Markdown

ContributorAuthor
Continued implementation: added funding_transaction_signed methods, tx_complete is handled on both sides.
@optout21optout21
mentioned this pull request
Apr 8, 2025
 Closed

@optout21optout21
mentioned this pull request
Apr 15, 2025
 Merged

@wpaulino
wpaulino
removed their request for review
April 28, 2025 16:41
@optout21
optout21
commented
Dec 9, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing as this prototype is no longer valid/needed 😎
@optout21optout21
closed this
Dec 9, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzAwaiting requested review from jkczyz
@dunxendunxenAwaiting requested review from dunxen

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@optout21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding by optout21 · Pull Request #3444 · lightningdevkit/rust-lightning · GitHub
Skip to content
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding - #3444
Closed
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom 
optout21:splice-dual-tx
Closed
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding#3444
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom 
optout21:splice-dual-tx
Conversation
@optout21
@optout21optout21
commented
Dec 5, 2024•

edited by dunxen

Loading

Copy link


Copy Markdown

Contributor
This is a next step in the splicing partial implementation, including and depending on the following:
Also relevant: #3418
Next step in splicing (#1621): This PR adds the implementation of performing the interactive transaction negotiation for the new post-splice funding transaction, after the splice_init & splice_ack handshake. Only the initiator can currently contribute.

The initiator adds the current funding tx as input, plus additional inputs, and the new funding as output plus a change output (if applicable).

After tx_complete the flow stops, does not yet follow to the commitment/signature exchange.

This was referenced Dec 5, 2024

Closed

 Merged

@jkczyz
jkczyz
self-requested a review
December 5, 2024 17:52
@optout21optout21
mentioned this pull request
Dec 5, 2024
 Closed

@optout21
optout21
commented
Dec 11, 2024

Copy link


Copy Markdown

ContributorAuthor
Rebased to current main, and current state of #3443 .
@optout21optout21
mentioned this pull request
Dec 14, 2024
 Merged

@jkczyz
jkczyz
requested a review
from wpaulinoJanuary 6, 2025 18:37
@optout21
optout21
commented
Jan 7, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased
@optout21
optout21force-pushed
the
splice-dual-tx
branch
2 times, most recently
from
6e8a1c1 to
dc5a209CompareJanuary 15, 2025 23:22
@optout21
optout21
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased; after #3513 many changes disappeared :)
@optout21
optout21
commented
Feb 11, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased, following channel phase #3418 . The channel manager part got much simpler!
@optout21optout21
mentioned this pull request
Feb 28, 2025
 Closed

@dunxen
dunxen
self-requested a review
March 4, 2025 11:37
@optout21
optout21force-pushed
the
splice-dual-tx
branch
6 times, most recently
from
fc2e085 to
f93b0deCompareMarch 5, 2025 22:57
@optout21
optout21
commented
Mar 5, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased up to 0216d7d#3629 from joostjager/log-attribution-failures Mar 4
Cannot rebase past that, df68774#3016 somehow breaks my rebaseing...
@optout21
optout21
commented
Mar 5, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Squashed some commits
@optout21
optout21force-pushed
the
splice-dual-tx
branch
4 times, most recently
from
8b3e9b8 to
8526b4aCompareMarch 6, 2025 01:14
@optout21
optout21force-pushed
the
splice-dual-tx
branch
11 times, most recently
from
ad7d810 to
db27917CompareMarch 19, 2025 23:27
@codecov
codecovBot
commented
Mar 19, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 77.64706% with 114 lines in your changes missing coverage. Please review.
Project coverage is 89.67%. Comparing base (c355ea4) to head (db27917).

Report is 16 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/ln/channel.rs69.05%107 Missing and 1 partial ⚠️
lightning/src/ln/channelmanager.rs16.66%5 Missing ⚠️
lightning/src/events/mod.rs0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3444 +/- ##
==========================================
+ Coverage 89.20% 89.67% +0.46% 
==========================================
Files 155 155 Lines 119377 124547 +5170 Branches 119377 124547 +5170 ==========================================
+ Hits 106496 111687 +5191 + Misses 10266 10227 -39 - Partials 2615 2633 +18 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow: 
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@optout21
optout21
commented
Mar 27, 2025

Copy link


Copy Markdown

ContributorAuthor
Continued implementation: added funding_transaction_signed methods, tx_complete is handled on both sides.
@optout21optout21
mentioned this pull request
Apr 8, 2025
 Closed

@optout21optout21
mentioned this pull request
Apr 15, 2025
 Merged

@wpaulino
wpaulino
removed their request for review
April 28, 2025 16:41
@optout21
optout21
commented
Dec 9, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing as this prototype is no longer valid/needed 😎
@optout21optout21
closed this
Dec 9, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzAwaiting requested review from jkczyz
@dunxendunxenAwaiting requested review from dunxen

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@optout21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding by optout21 · Pull Request #3444 · lightningdevkit/rust-lightning · GitHub
Skip to content
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding - #3444
Closed
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom 
optout21:splice-dual-tx
Closed
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding#3444
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom 
optout21:splice-dual-tx
Conversation
@optout21
@optout21optout21
commented
Dec 5, 2024•

edited by dunxen

Loading

Copy link


Copy Markdown

Contributor
This is a next step in the splicing partial implementation, including and depending on the following:
Also relevant: #3418
Next step in splicing (#1621): This PR adds the implementation of performing the interactive transaction negotiation for the new post-splice funding transaction, after the splice_init & splice_ack handshake. Only the initiator can currently contribute.

The initiator adds the current funding tx as input, plus additional inputs, and the new funding as output plus a change output (if applicable).

After tx_complete the flow stops, does not yet follow to the commitment/signature exchange.

This was referenced Dec 5, 2024

Closed

 Merged

@jkczyz
jkczyz
self-requested a review
December 5, 2024 17:52
@optout21optout21
mentioned this pull request
Dec 5, 2024
 Closed

@optout21
optout21
commented
Dec 11, 2024

Copy link


Copy Markdown

ContributorAuthor
Rebased to current main, and current state of #3443 .
@optout21optout21
mentioned this pull request
Dec 14, 2024
 Merged

@jkczyz
jkczyz
requested a review
from wpaulinoJanuary 6, 2025 18:37
@optout21
optout21
commented
Jan 7, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased
@optout21
optout21force-pushed
the
splice-dual-tx
branch
2 times, most recently
from
6e8a1c1 to
dc5a209CompareJanuary 15, 2025 23:22
@optout21
optout21
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased; after #3513 many changes disappeared :)
@optout21
optout21
commented
Feb 11, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased, following channel phase #3418 . The channel manager part got much simpler!
@optout21optout21
mentioned this pull request
Feb 28, 2025
 Closed

@dunxen
dunxen
self-requested a review
March 4, 2025 11:37
@optout21
optout21force-pushed
the
splice-dual-tx
branch
6 times, most recently
from
fc2e085 to
f93b0deCompareMarch 5, 2025 22:57
@optout21
optout21
commented
Mar 5, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased up to 0216d7d#3629 from joostjager/log-attribution-failures Mar 4
Cannot rebase past that, df68774#3016 somehow breaks my rebaseing...
@optout21
optout21
commented
Mar 5, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Squashed some commits
@optout21
optout21force-pushed
the
splice-dual-tx
branch
4 times, most recently
from
8b3e9b8 to
8526b4aCompareMarch 6, 2025 01:14
@optout21
optout21force-pushed
the
splice-dual-tx
branch
11 times, most recently
from
ad7d810 to
db27917CompareMarch 19, 2025 23:27
@codecov
codecovBot
commented
Mar 19, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 77.64706% with 114 lines in your changes missing coverage. Please review.
Project coverage is 89.67%. Comparing base (c355ea4) to head (db27917).

Report is 16 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/ln/channel.rs69.05%107 Missing and 1 partial ⚠️
lightning/src/ln/channelmanager.rs16.66%5 Missing ⚠️
lightning/src/events/mod.rs0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3444 +/- ##
==========================================
+ Coverage 89.20% 89.67% +0.46% 
==========================================
Files 155 155 Lines 119377 124547 +5170 Branches 119377 124547 +5170 ==========================================
+ Hits 106496 111687 +5191 + Misses 10266 10227 -39 - Partials 2615 2633 +18 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow: 
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@optout21
optout21
commented
Mar 27, 2025

Copy link


Copy Markdown

ContributorAuthor
Continued implementation: added funding_transaction_signed methods, tx_complete is handled on both sides.
@optout21optout21
mentioned this pull request
Apr 8, 2025
 Closed

@optout21optout21
mentioned this pull request
Apr 15, 2025
 Merged

@wpaulino
wpaulino
removed their request for review
April 28, 2025 16:41
@optout21
optout21
commented
Dec 9, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing as this prototype is no longer valid/needed 😎
@optout21optout21
closed this
Dec 9, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzAwaiting requested review from jkczyz
@dunxendunxenAwaiting requested review from dunxen

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@optout21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding by optout21 · Pull Request #3444 · lightningdevkit/rust-lightning · GitHub
Skip to content
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding - #3444
Closed
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom 
optout21:splice-dual-tx
Closed
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding#3444
optout21 wants to merge 10 commits into
lightningdevkit:mainfrom 
optout21:splice-dual-tx
Conversation
@optout21
@optout21optout21
commented
Dec 5, 2024•

edited by dunxen

Loading

Copy link


Copy Markdown

Contributor
This is a next step in the splicing partial implementation, including and depending on the following:
Also relevant: #3418
Next step in splicing (#1621): This PR adds the implementation of performing the interactive transaction negotiation for the new post-splice funding transaction, after the splice_init & splice_ack handshake. Only the initiator can currently contribute.

The initiator adds the current funding tx as input, plus additional inputs, and the new funding as output plus a change output (if applicable).

After tx_complete the flow stops, does not yet follow to the commitment/signature exchange.

This was referenced Dec 5, 2024

Closed

 Merged

@jkczyz
jkczyz
self-requested a review
December 5, 2024 17:52
@optout21optout21
mentioned this pull request
Dec 5, 2024
 Closed

@optout21
optout21
commented
Dec 11, 2024

Copy link


Copy Markdown

ContributorAuthor
Rebased to current main, and current state of #3443 .
@optout21optout21
mentioned this pull request
Dec 14, 2024
 Merged

@jkczyz
jkczyz
requested a review
from wpaulinoJanuary 6, 2025 18:37
@optout21
optout21
commented
Jan 7, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased
@optout21
optout21force-pushed
the
splice-dual-tx
branch
2 times, most recently
from
6e8a1c1 to
dc5a209CompareJanuary 15, 2025 23:22
@optout21
optout21
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased; after #3513 many changes disappeared :)
@optout21
optout21
commented
Feb 11, 2025

Copy link


Copy Markdown

ContributorAuthor
Rebased, following channel phase #3418 . The channel manager part got much simpler!
@optout21optout21
mentioned this pull request
Feb 28, 2025
 Closed

@dunxen
dunxen
self-requested a review
March 4, 2025 11:37
@optout21
optout21force-pushed
the
splice-dual-tx
branch
6 times, most recently
from
fc2e085 to
f93b0deCompareMarch 5, 2025 22:57
@optout21
optout21
commented
Mar 5, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased up to 0216d7d#3629 from joostjager/log-attribution-failures Mar 4
Cannot rebase past that, df68774#3016 somehow breaks my rebaseing...
@optout21
optout21
commented
Mar 5, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Squashed some commits
@optout21
optout21force-pushed
the
splice-dual-tx
branch
4 times, most recently
from
8b3e9b8 to
8526b4aCompareMarch 6, 2025 01:14
@optout21
optout21force-pushed
the
splice-dual-tx
branch
11 times, most recently
from
ad7d810 to
db27917CompareMarch 19, 2025 23:27
@codecov
codecovBot
commented
Mar 19, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 77.64706% with 114 lines in your changes missing coverage. Please review.
Project coverage is 89.67%. Comparing base (c355ea4) to head (db27917).

Report is 16 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/ln/channel.rs69.05%107 Missing and 1 partial ⚠️
lightning/src/ln/channelmanager.rs16.66%5 Missing ⚠️
lightning/src/events/mod.rs0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3444 +/- ##
==========================================
+ Coverage 89.20% 89.67% +0.46% 
==========================================
Files 155 155 Lines 119377 124547 +5170 Branches 119377 124547 +5170 ==========================================
+ Hits 106496 111687 +5191 + Misses 10266 10227 -39 - Partials 2615 2633 +18 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow: 
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@optout21
optout21
commented
Mar 27, 2025

Copy link


Copy Markdown

ContributorAuthor
Continued implementation: added funding_transaction_signed methods, tx_complete is handled on both sides.
@optout21optout21
mentioned this pull request
Apr 8, 2025
 Closed

@optout21optout21
mentioned this pull request
Apr 15, 2025
 Merged

@wpaulino
wpaulino
removed their request for review
April 28, 2025 16:41
@optout21
optout21
commented
Dec 9, 2025

Copy link


Copy Markdown

ContributorAuthor
Closing as this prototype is no longer valid/needed 😎
@optout21optout21
closed this
Dec 9, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzAwaiting requested review from jkczyz
@dunxendunxenAwaiting requested review from dunxen

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@optout21