Add draft 0.1 release notes by TheBlueMatt · Pull Request #3530 · lightningdevkit/rust-lightning

TheBlueMatt · 2025-01-13T22:01:21Z

We'll have to add a few more things as backports land, but this should be basically it.

dunxen · 2025-01-14T15:19:55Z

Might have missed it while trying to grep, but should

rust-lightning/pending_changelog/3137-channel-negotiation-type.txt

# API Updates

not be there?

Also I think some of the pending_changelogs existed before the 0.1 branch off. Are some of them still from 0.0.125 but haven't been deleted?

TheBlueMatt · 2025-01-14T16:48:48Z

Errr, duh, sorry, forgot to go through that list fully.

codecov · 2025-01-14T16:57:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.48%. Comparing base (f92c4dc) to head (89b0d34).
Report is 26 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #3530 +/- ##
==========================================
+ Coverage 88.36% 89.48% +1.12% 
==========================================
Files 149 149 Lines 112875 118824 +5949 Branches 112875 118824 +5949 ==========================================
+ Hits 99742 106330 +6588 + Misses 10653 10129 -524 + Partials 2480 2365 -115

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jkczyz · 2025-01-14T19:14:54Z

+ * The `max_level_*` features were removed as the performance gain compared to
+ doing the limiting at runtime was negligible (#3431).
+ * `ChannelManager::create_bolt11_invoice` was added, deprecating the
+ `lightning::ln::invoice_utils` module (#3389).


Noted elsewhere that the module is still used for phantom invoice utils. Perhaps we just rename it next release?

We should probably make create_bolt11_invoice support phantom invoices instead?

IIUC, the utilities work without a ChannelManager as you would be accumulating PhantomRouteHints from multiple sources.

Mmm, right. We should at least rename the module, then :)

jkczyz · 2025-01-14T19:22:26Z

+ startup (#3305).
+
+## Node Compatibility
+ * LDK now handles fields in the experimental range of BOLT 12 messages (#3237).


consider: s/fields/TLVs

Fields feels more generally understandable vs the (kinda-)lightning-specific terminology?

jkczyz · 2025-01-14T19:26:42Z

+ * `ChannelMonitor`s no longer need to be re-persisted after deserializing the
+ `ChannelManager` before beginning normal operation. As such,


I feel like the note in backwards compatibility should be referenced here. IIUC, persistence is required at least once? And maybe the following sentence should come first to emphasize the API change here.

The second is pretty minor (the user's code will fail to compile, if it even matters at all), but I referenced the backwards compat section explicitly.

jkczyz

LGTM. Good to squash, IMO.

TheBlueMatt · 2025-01-15T18:29:06Z

Squashed.

TheBlueMatt · 2025-01-15T21:20:03Z

Note that I cancelled CI so other PRs can run, it doesn't really matter here, anyway, CI doesn't look at our release notes at all.

jkczyz · 2025-01-15T21:20:22Z

Looks like we need to account for the notes added in #3531.

TheBlueMatt · 2025-01-15T21:47:12Z

I was assuming that wouldn't make 0.1, I don't think we need to block 0.1 on it - its not a regression and it should only happen with a buggy Router.

TheBlueMatt · 2025-01-15T22:08:40Z

Backported in #3536.

…relnotes Add draft 0.1 release notes

TheBlueMatt added the backport 0.1 label Jan 13, 2025

TheBlueMatt added this to the 0.1 milestone Jan 14, 2025

tnull reviewed Jan 14, 2025
View reviewed changes

Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md

jkczyz reviewed Jan 14, 2025
View reviewed changes

TheBlueMatt mentioned this pull request Jan 14, 2025
Backports for 0.1.0 #3536
Merged

jkczyz reviewed Jan 15, 2025
View reviewed changes

TheBlueMatt force-pushed the 2025-01-0.1-relnotes branch from dbc37ac to 550944bCompare January 15, 2025 18:07

Add draft 0.1 release notes
5d1b6e0

TheBlueMatt force-pushed the 2025-01-0.1-relnotes branch from 550944b to 5d1b6e0Compare January 15, 2025 18:29

dunxen approved these changes Jan 15, 2025
View reviewed changes

jkczyz approved these changes Jan 15, 2025
View reviewed changes

TheBlueMatt merged commit 3fbf97d into lightningdevkit:mainJan 15, 2025

TheBlueMatt removed the backport 0.1 label Jan 15, 2025

tnull pushed a commit to tnull/rust-lightning that referenced this pull request Jan 16, 2025
Merge pull requestlightningdevkit#3530from TheBlueMatt/2025-01-0.1-…
889adb1
…relnotes Add draft 0.1 release notes

		* `ChannelMonitor`s no longer need to be re-persisted after deserializing the
		`ChannelManager` before beginning normal operation. As such,

Uh oh!

Conversation

TheBlueMatt commented Jan 13, 2025

Uh oh!

Uh oh!

Uh oh!

dunxen commented Jan 14, 2025

Uh oh!

TheBlueMatt commented Jan 14, 2025

Uh oh!

codecovBot commented Jan 14, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkczyz left a comment

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt commented Jan 15, 2025

Uh oh!

TheBlueMatt commented Jan 15, 2025

Uh oh!

jkczyz commented Jan 15, 2025

Uh oh!

TheBlueMatt commented Jan 15, 2025

Uh oh!

TheBlueMatt commented Jan 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecovBot commented Jan 14, 2025•
edited
Loading