Skip to content

[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext.#3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
optout21 wants to merge 4 commits into from
Closed

[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext. #3630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2145581
Minor preparation, post_value computation
optout21 Jan 5, 2025
b33fe68
Extend begin_interactive_funding_tx_construction() with splicing-spec…
optout21 Feb 24, 2025
93afe53
Implement splice tx negotiation
optout21 Mar 11, 2025
4c77cc5
Implement logic for handling last tx_complete, signature for shared i…
optout21 Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 60 additions & 1 deletion lightning/src/events/mod.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1463,6 +1463,58 @@ pub enum Event {
///
/// [`ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx`]: crate::util::config::ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx
BumpTransaction(BumpTransactionEvent),

/// Indicates that a transaction constructed via interactive transaction construction for a
/// dual-funded (V2) channel is ready to be signed by the client. This event will only be triggered
/// if at least one input was contributed by the holder.
///
/// The transaction contains all inputs provided by both parties when the channel was
/// created/accepted along with the channel's funding output and a change output if applicable.
///
/// No part of the transaction should be changed before signing as the content of the transaction
/// has already been negotiated with the counterparty.
///
/// Each signature MUST use the SIGHASH_ALL flag to avoid invalidation of initial commitment and
/// hence possible loss of funds.
///
/// After signing, call [`ChannelManager::funding_transaction_signed`] with the (partially) signed
/// funding transaction.
///
/// Generated in [`ChannelManager`] message handling.
///
/// [`ChannelManager`]: crate::ln::channelmanager::ChannelManager
/// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
FundingTransactionReadyForSigning {
/// The channel_id of the V2 channel which you'll need to pass back into
/// [`ChannelManager::funding_transaction_signed`].
///
/// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
channel_id: ChannelId,
/// The counterparty's node_id, which you'll need to pass back into
/// [`ChannelManager::funding_transaction_signed`].
///
/// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
counterparty_node_id: PublicKey,
/*
/// The `user_channel_id` value passed in to [`ChannelManager::create_dual_funded_channel`] for outbound
/// channels, or to [`ChannelManager::accept_inbound_channel`] or [`ChannelManager::accept_inbound_channel_with_contribution`]
/// for inbound channels if [`UserConfig::manually_accept_inbound_channels`] config flag is set to true.
/// Otherwise `user_channel_id` will be randomized for an inbound channel.
/// This may be zero for objects serialized with LDK versions prior to 0.0.113.
///
/// [`ChannelManager::create_dual_funded_channel`]: crate::ln::channelmanager::ChannelManager::create_dual_funded_channel
/// [`ChannelManager::accept_inbound_channel`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel
/// [`ChannelManager::accept_inbound_channel_with_contribution`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel_with_contribution
/// [`UserConfig::manually_accept_inbound_channels`]: crate::util::config::UserConfig::manually_accept_inbound_channels
user_channel_id: u128,
*/
/// The unsigned transaction to be signed and passed back to
/// [`ChannelManager::funding_transaction_signed`].
///
/// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
unsigned_transaction: Transaction,
},

/// We received an onion message that is intended to be forwarded to a peer
/// that is currently offline. This event will only be generated if the
/// `OnionMessenger` was initialized with
Expand DownExpand Up@@ -1768,7 +1820,7 @@ impl Writeable for Event {
BumpTransactionEvent::HTLCResolution { .. } => {}
}
write_tlv_fields!(writer, {}); // Write a length field for forwards compat
}
},
&Event::ChannelReady { ref channel_id, ref user_channel_id, ref counterparty_node_id, ref channel_type } => {
29u8.write(writer)?;
write_tlv_fields!(writer, {
Expand DownExpand Up@@ -1828,6 +1880,13 @@ impl Writeable for Event {
(8, former_temporary_channel_id, required),
});
},
&Event::FundingTransactionReadyForSigning { .. } => {
45u8.write(writer)?;
// We never write out FundingTransactionReadyForSigning events as, upon disconnection, peers
// drop any V2-established channels which have not yet exchanged the initial `commitment_signed`.
// We only exhange the initial `commitment_signed` after the client calls
// `ChannelManager::funding_transaction_signed` and ALWAYS before we send a `tx_signatures`
},
// Note that, going forward, all new events must only write data inside of
// `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
// data via `write_tlv_fields`.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext. by optout21 · Pull Request #3630 · lightningdevkit/rust-lightning · GitHub
Skip to content
[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext.#3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

optout21
wants to merge
4
commits into

from

 Closed


[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext.
#3630
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
2145581

Minor preparation, post_value computation


optout21 Jan 5, 2025
b33fe68

Extend begin_interactive_funding_tx_construction() with splicing-spec…


optout21 Feb 24, 2025
93afe53

Implement splice tx negotiation


optout21 Mar 11, 2025
4c77cc5

Implement logic for handling last tx_complete, signature for shared i…


optout21 Apr 3, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


61 changes: 60 additions & 1 deletion
lightning/src/events/mod.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1463,6 +1463,58 @@ pub enum Event {
	///
	/// [`ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx`]: crate::util::config::ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx
	BumpTransaction(BumpTransactionEvent),

	/// Indicates that a transaction constructed via interactive transaction construction for a
	/// dual-funded (V2) channel is ready to be signed by the client. This event will only be triggered
	/// if at least one input was contributed by the holder.
	///
	/// The transaction contains all inputs provided by both parties when the channel was
	/// created/accepted along with the channel's funding output and a change output if applicable.
	///
	/// No part of the transaction should be changed before signing as the content of the transaction
	/// has already been negotiated with the counterparty.
	///
	/// Each signature MUST use the SIGHASH_ALL flag to avoid invalidation of initial commitment and
	/// hence possible loss of funds.
	///
	/// After signing, call [`ChannelManager::funding_transaction_signed`] with the (partially) signed
	/// funding transaction.
	///
	/// Generated in [`ChannelManager`] message handling.
	///
	/// [`ChannelManager`]: crate::ln::channelmanager::ChannelManager
	/// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
	FundingTransactionReadyForSigning {
 /// The channel_id of the V2 channel which you'll need to pass back into
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 channel_id: ChannelId,
 /// The counterparty's node_id, which you'll need to pass back into
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 counterparty_node_id: PublicKey,
 /*
 /// The `user_channel_id` value passed in to [`ChannelManager::create_dual_funded_channel`] for outbound
 /// channels, or to [`ChannelManager::accept_inbound_channel`] or [`ChannelManager::accept_inbound_channel_with_contribution`]
 /// for inbound channels if [`UserConfig::manually_accept_inbound_channels`] config flag is set to true.
 /// Otherwise `user_channel_id` will be randomized for an inbound channel.
 /// This may be zero for objects serialized with LDK versions prior to 0.0.113.
 ///
 /// [`ChannelManager::create_dual_funded_channel`]: crate::ln::channelmanager::ChannelManager::create_dual_funded_channel
 /// [`ChannelManager::accept_inbound_channel`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel
 /// [`ChannelManager::accept_inbound_channel_with_contribution`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel_with_contribution
 /// [`UserConfig::manually_accept_inbound_channels`]: crate::util::config::UserConfig::manually_accept_inbound_channels
 user_channel_id: u128,
 */
 /// The unsigned transaction to be signed and passed back to
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 unsigned_transaction: Transaction,
	},

	/// We received an onion message that is intended to be forwarded to a peer
	/// that is currently offline. This event will only be generated if the
	/// `OnionMessenger` was initialized with
Expand DownExpand Up@@ -1768,7 +1820,7 @@ impl Writeable for Event {
 BumpTransactionEvent::HTLCResolution { .. } => {}
 }
 write_tlv_fields!(writer, {}); // Write a length field for forwards compat
 }
 },
 &Event::ChannelReady { ref channel_id, ref user_channel_id, ref counterparty_node_id, ref channel_type } => {
 29u8.write(writer)?;
 write_tlv_fields!(writer, {
Expand DownExpand Up@@ -1828,6 +1880,13 @@ impl Writeable for Event {
 (8, former_temporary_channel_id, required),
 });
 },
 &Event::FundingTransactionReadyForSigning { .. } => {
 45u8.write(writer)?;
 // We never write out FundingTransactionReadyForSigning events as, upon disconnection, peers
 // drop any V2-established channels which have not yet exchanged the initial `commitment_signed`.
 // We only exhange the initial `commitment_signed` after the client calls
 // `ChannelManager::funding_transaction_signed` and ALWAYS before we send a `tx_signatures`
 },
 // Note that, going forward, all new events must only write data inside of
 // `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
 // data via `write_tlv_fields`.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext. by optout21 · Pull Request #3630 · lightningdevkit/rust-lightning · GitHub
Skip to content
[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext.#3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

optout21
wants to merge
4
commits into

from

 Closed


[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext.
#3630
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
2145581

Minor preparation, post_value computation


optout21 Jan 5, 2025
b33fe68

Extend begin_interactive_funding_tx_construction() with splicing-spec…


optout21 Feb 24, 2025
93afe53

Implement splice tx negotiation


optout21 Mar 11, 2025
4c77cc5

Implement logic for handling last tx_complete, signature for shared i…


optout21 Apr 3, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


61 changes: 60 additions & 1 deletion
lightning/src/events/mod.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1463,6 +1463,58 @@ pub enum Event {
	///
	/// [`ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx`]: crate::util::config::ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx
	BumpTransaction(BumpTransactionEvent),

	/// Indicates that a transaction constructed via interactive transaction construction for a
	/// dual-funded (V2) channel is ready to be signed by the client. This event will only be triggered
	/// if at least one input was contributed by the holder.
	///
	/// The transaction contains all inputs provided by both parties when the channel was
	/// created/accepted along with the channel's funding output and a change output if applicable.
	///
	/// No part of the transaction should be changed before signing as the content of the transaction
	/// has already been negotiated with the counterparty.
	///
	/// Each signature MUST use the SIGHASH_ALL flag to avoid invalidation of initial commitment and
	/// hence possible loss of funds.
	///
	/// After signing, call [`ChannelManager::funding_transaction_signed`] with the (partially) signed
	/// funding transaction.
	///
	/// Generated in [`ChannelManager`] message handling.
	///
	/// [`ChannelManager`]: crate::ln::channelmanager::ChannelManager
	/// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
	FundingTransactionReadyForSigning {
 /// The channel_id of the V2 channel which you'll need to pass back into
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 channel_id: ChannelId,
 /// The counterparty's node_id, which you'll need to pass back into
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 counterparty_node_id: PublicKey,
 /*
 /// The `user_channel_id` value passed in to [`ChannelManager::create_dual_funded_channel`] for outbound
 /// channels, or to [`ChannelManager::accept_inbound_channel`] or [`ChannelManager::accept_inbound_channel_with_contribution`]
 /// for inbound channels if [`UserConfig::manually_accept_inbound_channels`] config flag is set to true.
 /// Otherwise `user_channel_id` will be randomized for an inbound channel.
 /// This may be zero for objects serialized with LDK versions prior to 0.0.113.
 ///
 /// [`ChannelManager::create_dual_funded_channel`]: crate::ln::channelmanager::ChannelManager::create_dual_funded_channel
 /// [`ChannelManager::accept_inbound_channel`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel
 /// [`ChannelManager::accept_inbound_channel_with_contribution`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel_with_contribution
 /// [`UserConfig::manually_accept_inbound_channels`]: crate::util::config::UserConfig::manually_accept_inbound_channels
 user_channel_id: u128,
 */
 /// The unsigned transaction to be signed and passed back to
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 unsigned_transaction: Transaction,
	},

	/// We received an onion message that is intended to be forwarded to a peer
	/// that is currently offline. This event will only be generated if the
	/// `OnionMessenger` was initialized with
Expand DownExpand Up@@ -1768,7 +1820,7 @@ impl Writeable for Event {
 BumpTransactionEvent::HTLCResolution { .. } => {}
 }
 write_tlv_fields!(writer, {}); // Write a length field for forwards compat
 }
 },
 &Event::ChannelReady { ref channel_id, ref user_channel_id, ref counterparty_node_id, ref channel_type } => {
 29u8.write(writer)?;
 write_tlv_fields!(writer, {
Expand DownExpand Up@@ -1828,6 +1880,13 @@ impl Writeable for Event {
 (8, former_temporary_channel_id, required),
 });
 },
 &Event::FundingTransactionReadyForSigning { .. } => {
 45u8.write(writer)?;
 // We never write out FundingTransactionReadyForSigning events as, upon disconnection, peers
 // drop any V2-established channels which have not yet exchanged the initial `commitment_signed`.
 // We only exhange the initial `commitment_signed` after the client calls
 // `ChannelManager::funding_transaction_signed` and ALWAYS before we send a `tx_signatures`
 },
 // Note that, going forward, all new events must only write data inside of
 // `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
 // data via `write_tlv_fields`.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext. by optout21 · Pull Request #3630 · lightningdevkit/rust-lightning · GitHub
Skip to content
[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext.#3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

optout21
wants to merge
4
commits into

from

 Closed


[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext.
#3630
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
2145581

Minor preparation, post_value computation


optout21 Jan 5, 2025
b33fe68

Extend begin_interactive_funding_tx_construction() with splicing-spec…


optout21 Feb 24, 2025
93afe53

Implement splice tx negotiation


optout21 Mar 11, 2025
4c77cc5

Implement logic for handling last tx_complete, signature for shared i…


optout21 Apr 3, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


61 changes: 60 additions & 1 deletion
lightning/src/events/mod.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1463,6 +1463,58 @@ pub enum Event {
	///
	/// [`ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx`]: crate::util::config::ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx
	BumpTransaction(BumpTransactionEvent),

	/// Indicates that a transaction constructed via interactive transaction construction for a
	/// dual-funded (V2) channel is ready to be signed by the client. This event will only be triggered
	/// if at least one input was contributed by the holder.
	///
	/// The transaction contains all inputs provided by both parties when the channel was
	/// created/accepted along with the channel's funding output and a change output if applicable.
	///
	/// No part of the transaction should be changed before signing as the content of the transaction
	/// has already been negotiated with the counterparty.
	///
	/// Each signature MUST use the SIGHASH_ALL flag to avoid invalidation of initial commitment and
	/// hence possible loss of funds.
	///
	/// After signing, call [`ChannelManager::funding_transaction_signed`] with the (partially) signed
	/// funding transaction.
	///
	/// Generated in [`ChannelManager`] message handling.
	///
	/// [`ChannelManager`]: crate::ln::channelmanager::ChannelManager
	/// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
	FundingTransactionReadyForSigning {
 /// The channel_id of the V2 channel which you'll need to pass back into
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 channel_id: ChannelId,
 /// The counterparty's node_id, which you'll need to pass back into
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 counterparty_node_id: PublicKey,
 /*
 /// The `user_channel_id` value passed in to [`ChannelManager::create_dual_funded_channel`] for outbound
 /// channels, or to [`ChannelManager::accept_inbound_channel`] or [`ChannelManager::accept_inbound_channel_with_contribution`]
 /// for inbound channels if [`UserConfig::manually_accept_inbound_channels`] config flag is set to true.
 /// Otherwise `user_channel_id` will be randomized for an inbound channel.
 /// This may be zero for objects serialized with LDK versions prior to 0.0.113.
 ///
 /// [`ChannelManager::create_dual_funded_channel`]: crate::ln::channelmanager::ChannelManager::create_dual_funded_channel
 /// [`ChannelManager::accept_inbound_channel`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel
 /// [`ChannelManager::accept_inbound_channel_with_contribution`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel_with_contribution
 /// [`UserConfig::manually_accept_inbound_channels`]: crate::util::config::UserConfig::manually_accept_inbound_channels
 user_channel_id: u128,
 */
 /// The unsigned transaction to be signed and passed back to
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 unsigned_transaction: Transaction,
	},

	/// We received an onion message that is intended to be forwarded to a peer
	/// that is currently offline. This event will only be generated if the
	/// `OnionMessenger` was initialized with
Expand DownExpand Up@@ -1768,7 +1820,7 @@ impl Writeable for Event {
 BumpTransactionEvent::HTLCResolution { .. } => {}
 }
 write_tlv_fields!(writer, {}); // Write a length field for forwards compat
 }
 },
 &Event::ChannelReady { ref channel_id, ref user_channel_id, ref counterparty_node_id, ref channel_type } => {
 29u8.write(writer)?;
 write_tlv_fields!(writer, {
Expand DownExpand Up@@ -1828,6 +1880,13 @@ impl Writeable for Event {
 (8, former_temporary_channel_id, required),
 });
 },
 &Event::FundingTransactionReadyForSigning { .. } => {
 45u8.write(writer)?;
 // We never write out FundingTransactionReadyForSigning events as, upon disconnection, peers
 // drop any V2-established channels which have not yet exchanged the initial `commitment_signed`.
 // We only exhange the initial `commitment_signed` after the client calls
 // `ChannelManager::funding_transaction_signed` and ALWAYS before we send a `tx_signatures`
 },
 // Note that, going forward, all new events must only write data inside of
 // `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
 // data via `write_tlv_fields`.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext. by optout21 · Pull Request #3630 · lightningdevkit/rust-lightning · GitHub
Skip to content
[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext.#3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

optout21
wants to merge
4
commits into

from

 Closed


[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext.
#3630
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
2145581

Minor preparation, post_value computation


optout21 Jan 5, 2025
b33fe68

Extend begin_interactive_funding_tx_construction() with splicing-spec…


optout21 Feb 24, 2025
93afe53

Implement splice tx negotiation


optout21 Mar 11, 2025
4c77cc5

Implement logic for handling last tx_complete, signature for shared i…


optout21 Apr 3, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


61 changes: 60 additions & 1 deletion
lightning/src/events/mod.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1463,6 +1463,58 @@ pub enum Event {
	///
	/// [`ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx`]: crate::util::config::ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx
	BumpTransaction(BumpTransactionEvent),

	/// Indicates that a transaction constructed via interactive transaction construction for a
	/// dual-funded (V2) channel is ready to be signed by the client. This event will only be triggered
	/// if at least one input was contributed by the holder.
	///
	/// The transaction contains all inputs provided by both parties when the channel was
	/// created/accepted along with the channel's funding output and a change output if applicable.
	///
	/// No part of the transaction should be changed before signing as the content of the transaction
	/// has already been negotiated with the counterparty.
	///
	/// Each signature MUST use the SIGHASH_ALL flag to avoid invalidation of initial commitment and
	/// hence possible loss of funds.
	///
	/// After signing, call [`ChannelManager::funding_transaction_signed`] with the (partially) signed
	/// funding transaction.
	///
	/// Generated in [`ChannelManager`] message handling.
	///
	/// [`ChannelManager`]: crate::ln::channelmanager::ChannelManager
	/// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
	FundingTransactionReadyForSigning {
 /// The channel_id of the V2 channel which you'll need to pass back into
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 channel_id: ChannelId,
 /// The counterparty's node_id, which you'll need to pass back into
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 counterparty_node_id: PublicKey,
 /*
 /// The `user_channel_id` value passed in to [`ChannelManager::create_dual_funded_channel`] for outbound
 /// channels, or to [`ChannelManager::accept_inbound_channel`] or [`ChannelManager::accept_inbound_channel_with_contribution`]
 /// for inbound channels if [`UserConfig::manually_accept_inbound_channels`] config flag is set to true.
 /// Otherwise `user_channel_id` will be randomized for an inbound channel.
 /// This may be zero for objects serialized with LDK versions prior to 0.0.113.
 ///
 /// [`ChannelManager::create_dual_funded_channel`]: crate::ln::channelmanager::ChannelManager::create_dual_funded_channel
 /// [`ChannelManager::accept_inbound_channel`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel
 /// [`ChannelManager::accept_inbound_channel_with_contribution`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel_with_contribution
 /// [`UserConfig::manually_accept_inbound_channels`]: crate::util::config::UserConfig::manually_accept_inbound_channels
 user_channel_id: u128,
 */
 /// The unsigned transaction to be signed and passed back to
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 unsigned_transaction: Transaction,
	},

	/// We received an onion message that is intended to be forwarded to a peer
	/// that is currently offline. This event will only be generated if the
	/// `OnionMessenger` was initialized with
Expand DownExpand Up@@ -1768,7 +1820,7 @@ impl Writeable for Event {
 BumpTransactionEvent::HTLCResolution { .. } => {}
 }
 write_tlv_fields!(writer, {}); // Write a length field for forwards compat
 }
 },
 &Event::ChannelReady { ref channel_id, ref user_channel_id, ref counterparty_node_id, ref channel_type } => {
 29u8.write(writer)?;
 write_tlv_fields!(writer, {
Expand DownExpand Up@@ -1828,6 +1880,13 @@ impl Writeable for Event {
 (8, former_temporary_channel_id, required),
 });
 },
 &Event::FundingTransactionReadyForSigning { .. } => {
 45u8.write(writer)?;
 // We never write out FundingTransactionReadyForSigning events as, upon disconnection, peers
 // drop any V2-established channels which have not yet exchanged the initial `commitment_signed`.
 // We only exhange the initial `commitment_signed` after the client calls
 // `ChannelManager::funding_transaction_signed` and ALWAYS before we send a `tx_signatures`
 },
 // Note that, going forward, all new events must only write data inside of
 // `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
 // data via `write_tlv_fields`.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext. by optout21 · Pull Request #3630 · lightningdevkit/rust-lightning · GitHub
Skip to content
[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext.#3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

optout21
wants to merge
4
commits into

from

 Closed


[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext.
#3630
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
2145581

Minor preparation, post_value computation


optout21 Jan 5, 2025
b33fe68

Extend begin_interactive_funding_tx_construction() with splicing-spec…


optout21 Feb 24, 2025
93afe53

Implement splice tx negotiation


optout21 Mar 11, 2025
4c77cc5

Implement logic for handling last tx_complete, signature for shared i…


optout21 Apr 3, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


61 changes: 60 additions & 1 deletion
lightning/src/events/mod.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1463,6 +1463,58 @@ pub enum Event {
	///
	/// [`ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx`]: crate::util::config::ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx
	BumpTransaction(BumpTransactionEvent),

	/// Indicates that a transaction constructed via interactive transaction construction for a
	/// dual-funded (V2) channel is ready to be signed by the client. This event will only be triggered
	/// if at least one input was contributed by the holder.
	///
	/// The transaction contains all inputs provided by both parties when the channel was
	/// created/accepted along with the channel's funding output and a change output if applicable.
	///
	/// No part of the transaction should be changed before signing as the content of the transaction
	/// has already been negotiated with the counterparty.
	///
	/// Each signature MUST use the SIGHASH_ALL flag to avoid invalidation of initial commitment and
	/// hence possible loss of funds.
	///
	/// After signing, call [`ChannelManager::funding_transaction_signed`] with the (partially) signed
	/// funding transaction.
	///
	/// Generated in [`ChannelManager`] message handling.
	///
	/// [`ChannelManager`]: crate::ln::channelmanager::ChannelManager
	/// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
	FundingTransactionReadyForSigning {
 /// The channel_id of the V2 channel which you'll need to pass back into
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 channel_id: ChannelId,
 /// The counterparty's node_id, which you'll need to pass back into
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 counterparty_node_id: PublicKey,
 /*
 /// The `user_channel_id` value passed in to [`ChannelManager::create_dual_funded_channel`] for outbound
 /// channels, or to [`ChannelManager::accept_inbound_channel`] or [`ChannelManager::accept_inbound_channel_with_contribution`]
 /// for inbound channels if [`UserConfig::manually_accept_inbound_channels`] config flag is set to true.
 /// Otherwise `user_channel_id` will be randomized for an inbound channel.
 /// This may be zero for objects serialized with LDK versions prior to 0.0.113.
 ///
 /// [`ChannelManager::create_dual_funded_channel`]: crate::ln::channelmanager::ChannelManager::create_dual_funded_channel
 /// [`ChannelManager::accept_inbound_channel`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel
 /// [`ChannelManager::accept_inbound_channel_with_contribution`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel_with_contribution
 /// [`UserConfig::manually_accept_inbound_channels`]: crate::util::config::UserConfig::manually_accept_inbound_channels
 user_channel_id: u128,
 */
 /// The unsigned transaction to be signed and passed back to
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 unsigned_transaction: Transaction,
	},

	/// We received an onion message that is intended to be forwarded to a peer
	/// that is currently offline. This event will only be generated if the
	/// `OnionMessenger` was initialized with
Expand DownExpand Up@@ -1768,7 +1820,7 @@ impl Writeable for Event {
 BumpTransactionEvent::HTLCResolution { .. } => {}
 }
 write_tlv_fields!(writer, {}); // Write a length field for forwards compat
 }
 },
 &Event::ChannelReady { ref channel_id, ref user_channel_id, ref counterparty_node_id, ref channel_type } => {
 29u8.write(writer)?;
 write_tlv_fields!(writer, {
Expand DownExpand Up@@ -1828,6 +1880,13 @@ impl Writeable for Event {
 (8, former_temporary_channel_id, required),
 });
 },
 &Event::FundingTransactionReadyForSigning { .. } => {
 45u8.write(writer)?;
 // We never write out FundingTransactionReadyForSigning events as, upon disconnection, peers
 // drop any V2-established channels which have not yet exchanged the initial `commitment_signed`.
 // We only exhange the initial `commitment_signed` after the client calls
 // `ChannelManager::funding_transaction_signed` and ALWAYS before we send a `tx_signatures`
 },
 // Note that, going forward, all new events must only write data inside of
 // `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
 // data via `write_tlv_fields`.
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext. by optout21 · Pull Request #3630 · lightningdevkit/rust-lightning · GitHub
Skip to content
[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext.#3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

optout21
wants to merge
4
commits into

from

 Closed


[Early Draft][Splicing] Interactive tx negotiation, with a single ChannelContext.
#3630
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
2145581

Minor preparation, post_value computation


optout21 Jan 5, 2025
b33fe68

Extend begin_interactive_funding_tx_construction() with splicing-spec…


optout21 Feb 24, 2025
93afe53

Implement splice tx negotiation


optout21 Mar 11, 2025
4c77cc5

Implement logic for handling last tx_complete, signature for shared i…


optout21 Apr 3, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


61 changes: 60 additions & 1 deletion
lightning/src/events/mod.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1463,6 +1463,58 @@ pub enum Event {
	///
	/// [`ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx`]: crate::util::config::ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx
	BumpTransaction(BumpTransactionEvent),

	/// Indicates that a transaction constructed via interactive transaction construction for a
	/// dual-funded (V2) channel is ready to be signed by the client. This event will only be triggered
	/// if at least one input was contributed by the holder.
	///
	/// The transaction contains all inputs provided by both parties when the channel was
	/// created/accepted along with the channel's funding output and a change output if applicable.
	///
	/// No part of the transaction should be changed before signing as the content of the transaction
	/// has already been negotiated with the counterparty.
	///
	/// Each signature MUST use the SIGHASH_ALL flag to avoid invalidation of initial commitment and
	/// hence possible loss of funds.
	///
	/// After signing, call [`ChannelManager::funding_transaction_signed`] with the (partially) signed
	/// funding transaction.
	///
	/// Generated in [`ChannelManager`] message handling.
	///
	/// [`ChannelManager`]: crate::ln::channelmanager::ChannelManager
	/// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
	FundingTransactionReadyForSigning {
 /// The channel_id of the V2 channel which you'll need to pass back into
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 channel_id: ChannelId,
 /// The counterparty's node_id, which you'll need to pass back into
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 counterparty_node_id: PublicKey,
 /*
 /// The `user_channel_id` value passed in to [`ChannelManager::create_dual_funded_channel`] for outbound
 /// channels, or to [`ChannelManager::accept_inbound_channel`] or [`ChannelManager::accept_inbound_channel_with_contribution`]
 /// for inbound channels if [`UserConfig::manually_accept_inbound_channels`] config flag is set to true.
 /// Otherwise `user_channel_id` will be randomized for an inbound channel.
 /// This may be zero for objects serialized with LDK versions prior to 0.0.113.
 ///
 /// [`ChannelManager::create_dual_funded_channel`]: crate::ln::channelmanager::ChannelManager::create_dual_funded_channel
 /// [`ChannelManager::accept_inbound_channel`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel
 /// [`ChannelManager::accept_inbound_channel_with_contribution`]: crate::ln::channelmanager::ChannelManager::accept_inbound_channel_with_contribution
 /// [`UserConfig::manually_accept_inbound_channels`]: crate::util::config::UserConfig::manually_accept_inbound_channels
 user_channel_id: u128,
 */
 /// The unsigned transaction to be signed and passed back to
 /// [`ChannelManager::funding_transaction_signed`].
 ///
 /// [`ChannelManager::funding_transaction_signed`]: crate::ln::channelmanager::ChannelManager::funding_transaction_signed
 unsigned_transaction: Transaction,
	},

	/// We received an onion message that is intended to be forwarded to a peer
	/// that is currently offline. This event will only be generated if the
	/// `OnionMessenger` was initialized with
Expand DownExpand Up@@ -1768,7 +1820,7 @@ impl Writeable for Event {
 BumpTransactionEvent::HTLCResolution { .. } => {}
 }
 write_tlv_fields!(writer, {}); // Write a length field for forwards compat
 }
 },
 &Event::ChannelReady { ref channel_id, ref user_channel_id, ref counterparty_node_id, ref channel_type } => {
 29u8.write(writer)?;
 write_tlv_fields!(writer, {
Expand DownExpand Up@@ -1828,6 +1880,13 @@ impl Writeable for Event {
 (8, former_temporary_channel_id, required),
 });
 },
 &Event::FundingTransactionReadyForSigning { .. } => {
 45u8.write(writer)?;
 // We never write out FundingTransactionReadyForSigning events as, upon disconnection, peers
 // drop any V2-established channels which have not yet exchanged the initial `commitment_signed`.
 // We only exhange the initial `commitment_signed` after the client calls
 // `ChannelManager::funding_transaction_signed` and ALWAYS before we send a `tx_signatures`
 },
 // Note that, going forward, all new events must only write data inside of
 // `write_tlv_fields`. Versions 0.0.101+ will ignore odd-numbered events that write
 // data via `write_tlv_fields`.
Expand Down
Loading