Add persistence test for htlc in the LocalRemoved state

[joostjager]

Increase coverage and prepare for attributable failures which are going to extend the update_fail_htlc message with an additional field that needs to be persisted as well (#3611)

[ldk-reviews-bot]

👋 Thanks for assigning @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (eaeed77) to head (96b172e).
Report is 48 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	98.64%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #3645 +/- ##
==========================================
+ Coverage 89.16% 90.25% +1.08% 
==========================================
Files 152 155 +3 Lines 118791 127106 +8315 Branches 118791 127106 +8315 ==========================================
+ Hits 105921 114715 +8794 + Misses 10312 9940 -372 + Partials 2558 2451 -107 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valentinewallace]

Looks good!

[ldk-reviews-bot]

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

[valentinewallace]

Will land after CI passes since this just adds a test

[carlaKC]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

[joostjager]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

Tests are indeed quite different in LDK compared to LND. There is a lot more manual message passing that needs to happen. But the upside is that the test suite runs incredibly fast.

Thanks for taking a look!

[joostjager]

Increase coverage and prepare for attributable failures which are going to extend the update_fail_htlc message with an additional field that needs to be persisted as well (#3611)

[ldk-reviews-bot]

👋 Thanks for assigning @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (eaeed77) to head (96b172e).
Report is 48 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	98.64%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #3645 +/- ##
==========================================
+ Coverage 89.16% 90.25% +1.08% 
==========================================
Files 152 155 +3 Lines 118791 127106 +8315 Branches 118791 127106 +8315 ==========================================
+ Hits 105921 114715 +8794 + Misses 10312 9940 -372 + Partials 2558 2451 -107 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valentinewallace]

Looks good!

[ldk-reviews-bot]

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

[valentinewallace]

Will land after CI passes since this just adds a test

[carlaKC]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

[joostjager]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

Tests are indeed quite different in LDK compared to LND. There is a lot more manual message passing that needs to happen. But the upside is that the test suite runs incredibly fast.

Thanks for taking a look!

[joostjager]

Increase coverage and prepare for attributable failures which are going to extend the update_fail_htlc message with an additional field that needs to be persisted as well (#3611)

[ldk-reviews-bot]

👋 Thanks for assigning @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (eaeed77) to head (96b172e).
Report is 48 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	98.64%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #3645 +/- ##
==========================================
+ Coverage 89.16% 90.25% +1.08% 
==========================================
Files 152 155 +3 Lines 118791 127106 +8315 Branches 118791 127106 +8315 ==========================================
+ Hits 105921 114715 +8794 + Misses 10312 9940 -372 + Partials 2558 2451 -107 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valentinewallace]

Looks good!

[ldk-reviews-bot]

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

[valentinewallace]

Will land after CI passes since this just adds a test

[carlaKC]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

[joostjager]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

Tests are indeed quite different in LDK compared to LND. There is a lot more manual message passing that needs to happen. But the upside is that the test suite runs incredibly fast.

Thanks for taking a look!

[joostjager]

Increase coverage and prepare for attributable failures which are going to extend the update_fail_htlc message with an additional field that needs to be persisted as well (#3611)

[ldk-reviews-bot]

👋 Thanks for assigning @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (eaeed77) to head (96b172e).
Report is 48 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	98.64%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #3645 +/- ##
==========================================
+ Coverage 89.16% 90.25% +1.08% 
==========================================
Files 152 155 +3 Lines 118791 127106 +8315 Branches 118791 127106 +8315 ==========================================
+ Hits 105921 114715 +8794 + Misses 10312 9940 -372 + Partials 2558 2451 -107 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valentinewallace]

Looks good!

[ldk-reviews-bot]

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

[valentinewallace]

Will land after CI passes since this just adds a test

[carlaKC]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

[joostjager]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

Tests are indeed quite different in LDK compared to LND. There is a lot more manual message passing that needs to happen. But the upside is that the test suite runs incredibly fast.

Thanks for taking a look!

[joostjager]

Increase coverage and prepare for attributable failures which are going to extend the update_fail_htlc message with an additional field that needs to be persisted as well (#3611)

[ldk-reviews-bot]

👋 Thanks for assigning @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (eaeed77) to head (96b172e).
Report is 48 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	98.64%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #3645 +/- ##
==========================================
+ Coverage 89.16% 90.25% +1.08% 
==========================================
Files 152 155 +3 Lines 118791 127106 +8315 Branches 118791 127106 +8315 ==========================================
+ Hits 105921 114715 +8794 + Misses 10312 9940 -372 + Partials 2558 2451 -107 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valentinewallace]

Looks good!

[ldk-reviews-bot]

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

[valentinewallace]

Will land after CI passes since this just adds a test

[carlaKC]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

[joostjager]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

Tests are indeed quite different in LDK compared to LND. There is a lot more manual message passing that needs to happen. But the upside is that the test suite runs incredibly fast.

Thanks for taking a look!

[joostjager]

Increase coverage and prepare for attributable failures which are going to extend the update_fail_htlc message with an additional field that needs to be persisted as well (#3611)

[ldk-reviews-bot]

👋 Thanks for assigning @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (eaeed77) to head (96b172e).
Report is 48 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	98.64%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #3645 +/- ##
==========================================
+ Coverage 89.16% 90.25% +1.08% 
==========================================
Files 152 155 +3 Lines 118791 127106 +8315 Branches 118791 127106 +8315 ==========================================
+ Hits 105921 114715 +8794 + Misses 10312 9940 -372 + Partials 2558 2451 -107 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valentinewallace]

Looks good!

[ldk-reviews-bot]

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

[valentinewallace]

Will land after CI passes since this just adds a test

[carlaKC]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

[joostjager]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

Tests are indeed quite different in LDK compared to LND. There is a lot more manual message passing that needs to happen. But the upside is that the test suite runs incredibly fast.

Thanks for taking a look!

[joostjager]

Increase coverage and prepare for attributable failures which are going to extend the update_fail_htlc message with an additional field that needs to be persisted as well (#3611)

[ldk-reviews-bot]

👋 Thanks for assigning @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (eaeed77) to head (96b172e).
Report is 48 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	98.64%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #3645 +/- ##
==========================================
+ Coverage 89.16% 90.25% +1.08% 
==========================================
Files 152 155 +3 Lines 118791 127106 +8315 Branches 118791 127106 +8315 ==========================================
+ Hits 105921 114715 +8794 + Misses 10312 9940 -372 + Partials 2558 2451 -107 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valentinewallace]

Looks good!

[ldk-reviews-bot]

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

[valentinewallace]

Will land after CI passes since this just adds a test

[carlaKC]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

[joostjager]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

Tests are indeed quite different in LDK compared to LND. There is a lot more manual message passing that needs to happen. But the upside is that the test suite runs incredibly fast.

Thanks for taking a look!

[joostjager]

Increase coverage and prepare for attributable failures which are going to extend the update_fail_htlc message with an additional field that needs to be persisted as well (#3611)

[ldk-reviews-bot]

👋 Thanks for assigning @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (eaeed77) to head (96b172e).
Report is 48 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	98.64%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #3645 +/- ##
==========================================
+ Coverage 89.16% 90.25% +1.08% 
==========================================
Files 152 155 +3 Lines 118791 127106 +8315 Branches 118791 127106 +8315 ==========================================
+ Hits 105921 114715 +8794 + Misses 10312 9940 -372 + Partials 2558 2451 -107 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valentinewallace]

Looks good!

[ldk-reviews-bot]

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

[valentinewallace]

Will land after CI passes since this just adds a test

[carlaKC]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

[joostjager]

Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌

Tests are indeed quite different in LDK compared to LND. There is a lot more manual message passing that needs to happen. But the upside is that the test suite runs incredibly fast.

Thanks for taking a look!