Allow `ElectrumSyncClient` to reuse a preexisting client by tnull · Pull Request #3646 · lightningdevkit/rust-lightning

tnull · 2025-03-05T11:30:11Z

Previously, our API would only allow users to have ElectrumSyncClient a) construct an entirely newelectrum_client::Client or b) take an owened client via from_client.

Here, we change ElectrumSyncClient::from_client to accept an Arc<ElectrumClient>, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

Previously, our API would only allow users to have `ElectrumSyncClient` a) construct an entirely `new` `electrum_client::Client` or b) take an owened client via `from_client`. Here, we change `ElectrumSyncClient::from_client` to accept an `Arc<ElectrumClient>`, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

ldk-reviews-bot · 2025-03-05T11:30:14Z

I've assigned @arik-so as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

arik-so

post-merge ACK

tnull · 2025-03-05T11:30:11Z

Previously, our API would only allow users to have ElectrumSyncClient a) construct an entirely newelectrum_client::Client or b) take an owened client via from_client.

Here, we change ElectrumSyncClient::from_client to accept an Arc<ElectrumClient>, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

Previously, our API would only allow users to have `ElectrumSyncClient` a) construct an entirely `new` `electrum_client::Client` or b) take an owened client via `from_client`. Here, we change `ElectrumSyncClient::from_client` to accept an `Arc<ElectrumClient>`, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

ldk-reviews-bot · 2025-03-05T11:30:14Z

I've assigned @arik-so as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

arik-so

post-merge ACK

tnull · 2025-03-05T11:30:11Z

Previously, our API would only allow users to have ElectrumSyncClient a) construct an entirely newelectrum_client::Client or b) take an owened client via from_client.

Here, we change ElectrumSyncClient::from_client to accept an Arc<ElectrumClient>, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

Previously, our API would only allow users to have `ElectrumSyncClient` a) construct an entirely `new` `electrum_client::Client` or b) take an owened client via `from_client`. Here, we change `ElectrumSyncClient::from_client` to accept an `Arc<ElectrumClient>`, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

ldk-reviews-bot · 2025-03-05T11:30:14Z

I've assigned @arik-so as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

arik-so

post-merge ACK

tnull · 2025-03-05T11:30:11Z

Previously, our API would only allow users to have ElectrumSyncClient a) construct an entirely newelectrum_client::Client or b) take an owened client via from_client.

Here, we change ElectrumSyncClient::from_client to accept an Arc<ElectrumClient>, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

Previously, our API would only allow users to have `ElectrumSyncClient` a) construct an entirely `new` `electrum_client::Client` or b) take an owened client via `from_client`. Here, we change `ElectrumSyncClient::from_client` to accept an `Arc<ElectrumClient>`, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

ldk-reviews-bot · 2025-03-05T11:30:14Z

I've assigned @arik-so as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

arik-so

post-merge ACK

tnull · 2025-03-05T11:30:11Z

Previously, our API would only allow users to have ElectrumSyncClient a) construct an entirely newelectrum_client::Client or b) take an owened client via from_client.

Here, we change ElectrumSyncClient::from_client to accept an Arc<ElectrumClient>, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

Previously, our API would only allow users to have `ElectrumSyncClient` a) construct an entirely `new` `electrum_client::Client` or b) take an owened client via `from_client`. Here, we change `ElectrumSyncClient::from_client` to accept an `Arc<ElectrumClient>`, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

ldk-reviews-bot · 2025-03-05T11:30:14Z

I've assigned @arik-so as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

arik-so

post-merge ACK

tnull · 2025-03-05T11:30:11Z

Previously, our API would only allow users to have ElectrumSyncClient a) construct an entirely newelectrum_client::Client or b) take an owened client via from_client.

Here, we change ElectrumSyncClient::from_client to accept an Arc<ElectrumClient>, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

Previously, our API would only allow users to have `ElectrumSyncClient` a) construct an entirely `new` `electrum_client::Client` or b) take an owened client via `from_client`. Here, we change `ElectrumSyncClient::from_client` to accept an `Arc<ElectrumClient>`, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

ldk-reviews-bot · 2025-03-05T11:30:14Z

I've assigned @arik-so as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

arik-so

post-merge ACK

tnull · 2025-03-05T11:30:11Z

Previously, our API would only allow users to have ElectrumSyncClient a) construct an entirely newelectrum_client::Client or b) take an owened client via from_client.

Here, we change ElectrumSyncClient::from_client to accept an Arc<ElectrumClient>, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

Previously, our API would only allow users to have `ElectrumSyncClient` a) construct an entirely `new` `electrum_client::Client` or b) take an owened client via `from_client`. Here, we change `ElectrumSyncClient::from_client` to accept an `Arc<ElectrumClient>`, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

ldk-reviews-bot · 2025-03-05T11:30:14Z

I've assigned @arik-so as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

arik-so

post-merge ACK

tnull · 2025-03-05T11:30:11Z

Previously, our API would only allow users to have ElectrumSyncClient a) construct an entirely newelectrum_client::Client or b) take an owened client via from_client.

Here, we change ElectrumSyncClient::from_client to accept an Arc<ElectrumClient>, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

Previously, our API would only allow users to have `ElectrumSyncClient` a) construct an entirely `new` `electrum_client::Client` or b) take an owened client via `from_client`. Here, we change `ElectrumSyncClient::from_client` to accept an `Arc<ElectrumClient>`, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.

ldk-reviews-bot · 2025-03-05T11:30:14Z

I've assigned @arik-so as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

arik-so

post-merge ACK