Skip to content

Add option to generate outbound scid alias using intercept namespace - #3839

Closed
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom
aylagreystone:intercept-alias
Closed

Add option to generate outbound scid alias using intercept namespace#3839
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom
aylagreystone:intercept-alias

Conversation

@aylagreystone

@aylagreystoneaylagreystone commented Jun 9, 2025

Copy link
Copy Markdown

Introduces a flag on ChannelHandshakeConfig that can be set to enable outbound scid alias generation to use the intercept namespace. This would allow users to selectively enable interception on channels and get HtlcIntercepted events for every payment forwarded on those channels.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 9, 2025•
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov

codecovBot commented Jun 9, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.84%. Comparing base (0848e7a) to head (363cf07).
Report is 57 commits behind head on main.

Files with missing linesPatch %Lines
lightning/src/util/config.rs25.00%1 Missing and 2 partials ⚠️
lightning/src/ln/channelmanager.rs94.44%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3839 +/- ##
==========================================
- Coverage 89.88% 89.84% -0.04% 
==========================================
Files 160 160 Lines 129654 129670 +16 Branches 129654 129670 +16 ==========================================
- Hits 116534 116507 -27 - Misses 10425 10458 +33 - Partials 2695 2705 +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aylagreystone
aylagreystoneforce-pushed the intercept-alias branch 3 times, most recently from c2cf0b5 to 5b1d52fCompareJune 9, 2025 21:45
@tnull
tnull requested review from tnull and removed request for valentinewallaceJune 10, 2025 07:59
tnull
tnull reviewed Jun 10, 2025
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on Discord, I don't think we should extend the intercept SCID concept much further. If we want to do generalized HTLC interception (#2855), we should finally do it 'properly', i.e., create an interface (e.g., a trait) that would allow users to intercept all HLTCs and then return an action to be taken. This could for example be similar to what CLN does with its hooks.

@tnull

tnull commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Going ahead and closing this as it has been superseded by the draft at #3843.

@tnulltnull closed this Jun 12, 2025
@aylagreystoneaylagreystone mentioned this pull request Jun 12, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aylagreystone@ldk-reviews-bot@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add option to generate outbound scid alias using intercept namespace by aylagreystone · Pull Request #3839 · lightningdevkit/rust-lightning · GitHub
Skip to content
Add option to generate outbound scid alias using intercept namespace - #3839
Closed
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom 
aylagreystone:intercept-alias
Closed
Add option to generate outbound scid alias using intercept namespace#3839
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom 
aylagreystone:intercept-alias
Conversation
@aylagreystone
@aylagreystoneaylagreystone
commented
Jun 9, 2025

Copy link


Copy Markdown

Introduces a flag on ChannelHandshakeConfig that can be set to enable outbound scid alias generation to use the intercept namespace. This would allow users to selectively enable interception on channels and get HtlcIntercepted events for every payment forwarded on those channels.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 9, 2025•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Jun 9, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
Project coverage is 89.84%. Comparing base (0848e7a) to head (363cf07).

Report is 57 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/util/config.rs25.00%1 Missing and 2 partials ⚠️
lightning/src/ln/channelmanager.rs94.44%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3839 +/- ##
==========================================
- Coverage 89.88% 89.84% -0.04% 
==========================================
Files 160 160 Lines 129654 129670 +16 Branches 129654 129670 +16 ==========================================
- Hits 116534 116507 -27 - Misses 10425 10458 +33 - Partials 2695 2705 +10 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@aylagreystone
aylagreystoneforce-pushed
the
intercept-alias
branch
3 times, most recently
from
c2cf0b5 to
5b1d52fCompareJune 9, 2025 21:45
@tnull
tnull
requested review from
tnull
and removed request for
valentinewallaceJune 10, 2025 07:59
tnull
tnull
reviewed
Jun 10, 2025
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on Discord, I don't think we should extend the intercept SCID concept much further. If we want to do generalized HTLC interception (#2855), we should finally do it 'properly', i.e., create an interface (e.g., a trait) that would allow users to intercept all HLTCs and then return an action to be taken. This could for example be similar to what CLN does with its hooks.
@tnull
tnull
commented
Jun 12, 2025

Copy link


Copy Markdown

Contributor
Going ahead and closing this as it has been superseded by the draft at #3843.
@tnulltnull
closed this
Jun 12, 2025
@aylagreystoneaylagreystone
mentioned this pull request
Jun 12, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aylagreystone@ldk-reviews-bot@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add option to generate outbound scid alias using intercept namespace by aylagreystone · Pull Request #3839 · lightningdevkit/rust-lightning · GitHub
Skip to content
Add option to generate outbound scid alias using intercept namespace - #3839
Closed
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom 
aylagreystone:intercept-alias
Closed
Add option to generate outbound scid alias using intercept namespace#3839
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom 
aylagreystone:intercept-alias
Conversation
@aylagreystone
@aylagreystoneaylagreystone
commented
Jun 9, 2025

Copy link


Copy Markdown

Introduces a flag on ChannelHandshakeConfig that can be set to enable outbound scid alias generation to use the intercept namespace. This would allow users to selectively enable interception on channels and get HtlcIntercepted events for every payment forwarded on those channels.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 9, 2025•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Jun 9, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
Project coverage is 89.84%. Comparing base (0848e7a) to head (363cf07).

Report is 57 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/util/config.rs25.00%1 Missing and 2 partials ⚠️
lightning/src/ln/channelmanager.rs94.44%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3839 +/- ##
==========================================
- Coverage 89.88% 89.84% -0.04% 
==========================================
Files 160 160 Lines 129654 129670 +16 Branches 129654 129670 +16 ==========================================
- Hits 116534 116507 -27 - Misses 10425 10458 +33 - Partials 2695 2705 +10 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@aylagreystone
aylagreystoneforce-pushed
the
intercept-alias
branch
3 times, most recently
from
c2cf0b5 to
5b1d52fCompareJune 9, 2025 21:45
@tnull
tnull
requested review from
tnull
and removed request for
valentinewallaceJune 10, 2025 07:59
tnull
tnull
reviewed
Jun 10, 2025
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on Discord, I don't think we should extend the intercept SCID concept much further. If we want to do generalized HTLC interception (#2855), we should finally do it 'properly', i.e., create an interface (e.g., a trait) that would allow users to intercept all HLTCs and then return an action to be taken. This could for example be similar to what CLN does with its hooks.
@tnull
tnull
commented
Jun 12, 2025

Copy link


Copy Markdown

Contributor
Going ahead and closing this as it has been superseded by the draft at #3843.
@tnulltnull
closed this
Jun 12, 2025
@aylagreystoneaylagreystone
mentioned this pull request
Jun 12, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aylagreystone@ldk-reviews-bot@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add option to generate outbound scid alias using intercept namespace by aylagreystone · Pull Request #3839 · lightningdevkit/rust-lightning · GitHub
Skip to content
Add option to generate outbound scid alias using intercept namespace - #3839
Closed
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom 
aylagreystone:intercept-alias
Closed
Add option to generate outbound scid alias using intercept namespace#3839
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom 
aylagreystone:intercept-alias
Conversation
@aylagreystone
@aylagreystoneaylagreystone
commented
Jun 9, 2025

Copy link


Copy Markdown

Introduces a flag on ChannelHandshakeConfig that can be set to enable outbound scid alias generation to use the intercept namespace. This would allow users to selectively enable interception on channels and get HtlcIntercepted events for every payment forwarded on those channels.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 9, 2025•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Jun 9, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
Project coverage is 89.84%. Comparing base (0848e7a) to head (363cf07).

Report is 57 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/util/config.rs25.00%1 Missing and 2 partials ⚠️
lightning/src/ln/channelmanager.rs94.44%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3839 +/- ##
==========================================
- Coverage 89.88% 89.84% -0.04% 
==========================================
Files 160 160 Lines 129654 129670 +16 Branches 129654 129670 +16 ==========================================
- Hits 116534 116507 -27 - Misses 10425 10458 +33 - Partials 2695 2705 +10 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@aylagreystone
aylagreystoneforce-pushed
the
intercept-alias
branch
3 times, most recently
from
c2cf0b5 to
5b1d52fCompareJune 9, 2025 21:45
@tnull
tnull
requested review from
tnull
and removed request for
valentinewallaceJune 10, 2025 07:59
tnull
tnull
reviewed
Jun 10, 2025
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on Discord, I don't think we should extend the intercept SCID concept much further. If we want to do generalized HTLC interception (#2855), we should finally do it 'properly', i.e., create an interface (e.g., a trait) that would allow users to intercept all HLTCs and then return an action to be taken. This could for example be similar to what CLN does with its hooks.
@tnull
tnull
commented
Jun 12, 2025

Copy link


Copy Markdown

Contributor
Going ahead and closing this as it has been superseded by the draft at #3843.
@tnulltnull
closed this
Jun 12, 2025
@aylagreystoneaylagreystone
mentioned this pull request
Jun 12, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aylagreystone@ldk-reviews-bot@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add option to generate outbound scid alias using intercept namespace by aylagreystone · Pull Request #3839 · lightningdevkit/rust-lightning · GitHub
Skip to content
Add option to generate outbound scid alias using intercept namespace - #3839
Closed
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom 
aylagreystone:intercept-alias
Closed
Add option to generate outbound scid alias using intercept namespace#3839
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom 
aylagreystone:intercept-alias
Conversation
@aylagreystone
@aylagreystoneaylagreystone
commented
Jun 9, 2025

Copy link


Copy Markdown

Introduces a flag on ChannelHandshakeConfig that can be set to enable outbound scid alias generation to use the intercept namespace. This would allow users to selectively enable interception on channels and get HtlcIntercepted events for every payment forwarded on those channels.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 9, 2025•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Jun 9, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
Project coverage is 89.84%. Comparing base (0848e7a) to head (363cf07).

Report is 57 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/util/config.rs25.00%1 Missing and 2 partials ⚠️
lightning/src/ln/channelmanager.rs94.44%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3839 +/- ##
==========================================
- Coverage 89.88% 89.84% -0.04% 
==========================================
Files 160 160 Lines 129654 129670 +16 Branches 129654 129670 +16 ==========================================
- Hits 116534 116507 -27 - Misses 10425 10458 +33 - Partials 2695 2705 +10 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@aylagreystone
aylagreystoneforce-pushed
the
intercept-alias
branch
3 times, most recently
from
c2cf0b5 to
5b1d52fCompareJune 9, 2025 21:45
@tnull
tnull
requested review from
tnull
and removed request for
valentinewallaceJune 10, 2025 07:59
tnull
tnull
reviewed
Jun 10, 2025
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on Discord, I don't think we should extend the intercept SCID concept much further. If we want to do generalized HTLC interception (#2855), we should finally do it 'properly', i.e., create an interface (e.g., a trait) that would allow users to intercept all HLTCs and then return an action to be taken. This could for example be similar to what CLN does with its hooks.
@tnull
tnull
commented
Jun 12, 2025

Copy link


Copy Markdown

Contributor
Going ahead and closing this as it has been superseded by the draft at #3843.
@tnulltnull
closed this
Jun 12, 2025
@aylagreystoneaylagreystone
mentioned this pull request
Jun 12, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aylagreystone@ldk-reviews-bot@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add option to generate outbound scid alias using intercept namespace by aylagreystone · Pull Request #3839 · lightningdevkit/rust-lightning · GitHub
Skip to content
Add option to generate outbound scid alias using intercept namespace - #3839
Closed
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom 
aylagreystone:intercept-alias
Closed
Add option to generate outbound scid alias using intercept namespace#3839
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom 
aylagreystone:intercept-alias
Conversation
@aylagreystone
@aylagreystoneaylagreystone
commented
Jun 9, 2025

Copy link


Copy Markdown

Introduces a flag on ChannelHandshakeConfig that can be set to enable outbound scid alias generation to use the intercept namespace. This would allow users to selectively enable interception on channels and get HtlcIntercepted events for every payment forwarded on those channels.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 9, 2025•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Jun 9, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
Project coverage is 89.84%. Comparing base (0848e7a) to head (363cf07).

Report is 57 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/util/config.rs25.00%1 Missing and 2 partials ⚠️
lightning/src/ln/channelmanager.rs94.44%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3839 +/- ##
==========================================
- Coverage 89.88% 89.84% -0.04% 
==========================================
Files 160 160 Lines 129654 129670 +16 Branches 129654 129670 +16 ==========================================
- Hits 116534 116507 -27 - Misses 10425 10458 +33 - Partials 2695 2705 +10 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@aylagreystone
aylagreystoneforce-pushed
the
intercept-alias
branch
3 times, most recently
from
c2cf0b5 to
5b1d52fCompareJune 9, 2025 21:45
@tnull
tnull
requested review from
tnull
and removed request for
valentinewallaceJune 10, 2025 07:59
tnull
tnull
reviewed
Jun 10, 2025
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on Discord, I don't think we should extend the intercept SCID concept much further. If we want to do generalized HTLC interception (#2855), we should finally do it 'properly', i.e., create an interface (e.g., a trait) that would allow users to intercept all HLTCs and then return an action to be taken. This could for example be similar to what CLN does with its hooks.
@tnull
tnull
commented
Jun 12, 2025

Copy link


Copy Markdown

Contributor
Going ahead and closing this as it has been superseded by the draft at #3843.
@tnulltnull
closed this
Jun 12, 2025
@aylagreystoneaylagreystone
mentioned this pull request
Jun 12, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aylagreystone@ldk-reviews-bot@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Add option to generate outbound scid alias using intercept namespace by aylagreystone · Pull Request #3839 · lightningdevkit/rust-lightning · GitHub
Skip to content
Add option to generate outbound scid alias using intercept namespace - #3839
Closed
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom 
aylagreystone:intercept-alias
Closed
Add option to generate outbound scid alias using intercept namespace#3839
aylagreystone wants to merge 1 commit into
lightningdevkit:mainfrom 
aylagreystone:intercept-alias
Conversation
@aylagreystone
@aylagreystoneaylagreystone
commented
Jun 9, 2025

Copy link


Copy Markdown

Introduces a flag on ChannelHandshakeConfig that can be set to enable outbound scid alias generation to use the intercept namespace. This would allow users to selectively enable interception on channels and get HtlcIntercepted events for every payment forwarded on those channels.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 9, 2025•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Jun 9, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
Project coverage is 89.84%. Comparing base (0848e7a) to head (363cf07).

Report is 57 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/util/config.rs25.00%1 Missing and 2 partials ⚠️
lightning/src/ln/channelmanager.rs94.44%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3839 +/- ##
==========================================
- Coverage 89.88% 89.84% -0.04% 
==========================================
Files 160 160 Lines 129654 129670 +16 Branches 129654 129670 +16 ==========================================
- Hits 116534 116507 -27 - Misses 10425 10458 +33 - Partials 2695 2705 +10 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@aylagreystone
aylagreystoneforce-pushed
the
intercept-alias
branch
3 times, most recently
from
c2cf0b5 to
5b1d52fCompareJune 9, 2025 21:45
@tnull
tnull
requested review from
tnull
and removed request for
valentinewallaceJune 10, 2025 07:59
tnull
tnull
reviewed
Jun 10, 2025
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on Discord, I don't think we should extend the intercept SCID concept much further. If we want to do generalized HTLC interception (#2855), we should finally do it 'properly', i.e., create an interface (e.g., a trait) that would allow users to intercept all HLTCs and then return an action to be taken. This could for example be similar to what CLN does with its hooks.
@tnull
tnull
commented
Jun 12, 2025

Copy link


Copy Markdown

Contributor
Going ahead and closing this as it has been superseded by the draft at #3843.
@tnulltnull
closed this
Jun 12, 2025
@aylagreystoneaylagreystone
mentioned this pull request
Jun 12, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aylagreystone@ldk-reviews-bot@tnull