Remove (and deny) useless test vec!s#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 2 commits into from
Jun 26, 2025
Merged

Remove (and deny) useless test vec!s #3883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c23810
Remove uneccessary `vec!`s across tests
TheBlueMatt Jun 12, 2025
6091c4a
clippy-Deny useless `vec`s in test code
TheBlueMatt Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/check-lint.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,4 +110,4 @@ CLIPPY() {

CLIPPY
# We allow some additional warnings in tests which we should fix, but which aren't currently a priority
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap -A clippy::useless_vec"
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap"
26 changes: 13 additions & 13 deletions lightning-rapid-gossip-sync/src/processing.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -503,7 +503,7 @@ mod tests {
let logger = TestLogger::new();
let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

let example_input = vec![
let example_input = [
76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -534,7 +534,7 @@ mod tests {
let logger = TestLogger::new();
let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

let example_input = vec![
let example_input = [
76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 97, 206, 240,
0, 0, 0, 0, 2, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186, 5,
Expand DownExpand Up@@ -597,7 +597,7 @@ mod tests {
let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

let example_input = vec![
let example_input = [
76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 105, 183,
240, 0, 0, 0, 0, 1, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186,
Expand DownExpand Up@@ -625,7 +625,7 @@ mod tests {
let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

let example_input = vec![
let example_input = [
76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 106, 12, 80,
1, 0, 2, 23, 48, 0, 0, 0, 3, 143, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213,
Expand DownExpand Up@@ -700,7 +700,7 @@ mod tests {
#[test]
#[cfg(feature = "std")]
fn incremental_only_update_ignores_missing_channel() {
let incremental_update_input = vec![
let incremental_update_input = [
76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -721,7 +721,7 @@ mod tests {
#[test]
#[cfg(feature = "std")]
fn incremental_only_update_fails_without_prior_updates() {
let announced_update_input = vec![
let announced_update_input = [
76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -749,7 +749,7 @@ mod tests {
#[test]
#[cfg(feature = "std")]
fn incremental_only_update_fails_without_prior_same_direction_updates() {
let initialization_input = vec![
let initialization_input = [
76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -789,7 +789,7 @@ mod tests {
assert!(initialized.contains("619737530008010752"));
assert!(initialized.contains("783241506229452801"));

let opposite_direction_incremental_update_input = vec![
let opposite_direction_incremental_update_input = [
76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -802,7 +802,7 @@ mod tests {
#[test]
#[cfg(feature = "std")]
fn incremental_update_succeeds_with_prior_announcements_and_full_updates() {
let initialization_input = vec![
let initialization_input = [
76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -829,7 +829,7 @@ mod tests {
let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
assert!(initialization_result.is_ok());

let single_direction_incremental_update_input = vec![
let single_direction_incremental_update_input = [
76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -863,7 +863,7 @@ mod tests {
#[test]
#[cfg(feature = "std")]
fn update_succeeds_when_duplicate_gossip_is_applied() {
let initialization_input = vec![
let initialization_input = [
76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -890,7 +890,7 @@ mod tests {
let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
assert!(initialization_result.is_ok());

let single_direction_incremental_update_input = vec![
let single_direction_incremental_update_input = [
76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -1023,7 +1023,7 @@ mod tests {
#[test]
#[cfg(feature = "std")]
pub fn update_fails_with_unknown_version() {
let unknown_version_input = vec![
let unknown_version_input = [
76, 68, 75, 3, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand Down
6 changes: 3 additions & 3 deletions lightning/src/chain/channelmonitor.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6260,7 +6260,7 @@ mod tests {
value: Amount::ZERO,
});
let base_weight = claim_tx.weight().to_wu();
let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
let inputs_weight = [WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
let mut inputs_total_weight = 2; // count segwit flags
{
let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6292,7 +6292,7 @@ mod tests {
value: Amount::ZERO,
});
let base_weight = claim_tx.weight().to_wu();
let inputs_weight = vec![weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
let inputs_weight = [weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
let mut inputs_total_weight = 2; // count segwit flags
{
let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6322,7 +6322,7 @@ mod tests {
value: Amount::ZERO,
});
let base_weight = claim_tx.weight().to_wu();
let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT];
let inputs_weight = [WEIGHT_REVOKED_OUTPUT];
let mut inputs_total_weight = 2; // count segwit flags
{
let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand Down
4 changes: 2 additions & 2 deletions lightning/src/ln/blinded_payment_tests.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -747,7 +747,7 @@ fn do_blinded_intercept_payment(intercept_node_fails: bool) {

if intercept_node_fails {
nodes[1].node.fail_intercepted_htlc(intercept_id).unwrap();
expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], vec![HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], [HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
nodes[1].node.process_pending_htlc_forwards();
check_added_monitors!(&nodes[1], 1);
fail_blinded_htlc_backwards(payment_hash, 1, &[&nodes[0], &nodes[1]], false);
Expand DownExpand Up@@ -1046,7 +1046,7 @@ fn do_multi_hop_receiver_fail(check: ReceiveCheckFail) {
do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
expect_pending_htlcs_forwardable!(nodes[2]);
expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[2],
vec![HTLCHandlingFailureType::Receive { payment_hash }]);
[HTLCHandlingFailureType::Receive { payment_hash }]);
check_added_monitors!(nodes[2], 1);
},
ReceiveCheckFail::PaymentConstraints => {
Expand Down
8 changes: 4 additions & 4 deletions lightning/src/ln/channelmanager.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15935,7 +15935,7 @@ mod tests {
check_added_monitors!(nodes[1], 0);
commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
expect_pending_htlcs_forwardable!(nodes[1]);
expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
check_added_monitors!(nodes[1], 1);
let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16155,7 +16155,7 @@ mod tests {
// We have to forward pending HTLCs twice - once tries to forward the payment forward (and
// fails), the second will process the resulting failure and fail the HTLC backward
expect_pending_htlcs_forwardable!(nodes[1]);
expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
check_added_monitors!(nodes[1], 1);
let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16200,7 +16200,7 @@ mod tests {
check_added_monitors!(nodes[1], 0);
commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
expect_pending_htlcs_forwardable!(nodes[1]);
expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
check_added_monitors!(nodes[1], 1);
let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16247,7 +16247,7 @@ mod tests {
check_added_monitors!(nodes[1], 0);
commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
expect_pending_htlcs_forwardable!(nodes[1]);
expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
check_added_monitors!(nodes[1], 1);
let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
assert!(updates.update_add_htlcs.is_empty());
Expand Down
4 changes: 2 additions & 2 deletions lightning/src/ln/functional_test_utils.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2168,7 +2168,7 @@ pub fn do_commitment_signed_dance(node_a: &Node<'_, '_, '_>, node_b: &Node<'_, '

if fail_backwards {
expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node_a,
vec![crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
[crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
check_added_monitors!(node_a, 1);

let node_a_per_peer_state = node_a.node.per_peer_state.read().unwrap();
Expand DownExpand Up@@ -3243,7 +3243,7 @@ pub fn pass_failed_payment_back<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expe
node.node.handle_update_fail_htlc(prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
commitment_signed_dance!(node, prev_node, next_msgs.as_ref().unwrap().1, update_next_node);
if !update_next_node {
expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, vec![HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, [HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
}
}
let events = node.node.get_and_clear_pending_msg_events();
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Remove (and deny) useless test vec!s#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Jun 26, 2025
 Merged


Remove (and deny) useless test vec!s
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
4c23810

Remove uneccessary `vec!`s across tests


TheBlueMatt Jun 12, 2025
6091c4a

clippy-Deny useless `vec`s in test code


TheBlueMatt Jun 12, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ci/check-lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,4 +110,4 @@ CLIPPY() {

CLIPPY
# We allow some additional warnings in tests which we should fix, but which aren't currently a priority
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap -A clippy::useless_vec"
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap"

26 changes: 13 additions & 13 deletions
lightning-rapid-gossip-sync/src/processing.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -503,7 +503,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -534,7 +534,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 97, 206, 240,
 0, 0, 0, 0, 2, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186, 5,
Expand DownExpand Up@@ -597,7 +597,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 105, 183,
 240, 0, 0, 0, 0, 1, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186,
Expand DownExpand Up@@ -625,7 +625,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 106, 12, 80,
 1, 0, 2, 23, 48, 0, 0, 0, 3, 143, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213,
Expand DownExpand Up@@ -700,7 +700,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_ignores_missing_channel() {
 let incremental_update_input = vec![
 let incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -721,7 +721,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_updates() {
 let announced_update_input = vec![
 let announced_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -749,7 +749,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_same_direction_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -789,7 +789,7 @@ mod tests {
 assert!(initialized.contains("619737530008010752"));
 assert!(initialized.contains("783241506229452801"));

 let opposite_direction_incremental_update_input = vec![
 let opposite_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -802,7 +802,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_update_succeeds_with_prior_announcements_and_full_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -829,7 +829,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -863,7 +863,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn update_succeeds_when_duplicate_gossip_is_applied() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -890,7 +890,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -1023,7 +1023,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	pub fn update_fails_with_unknown_version() {
 let unknown_version_input = vec![
 let unknown_version_input = [
 76, 68, 75, 3, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand Down

6 changes: 3 additions & 3 deletions
lightning/src/chain/channelmonitor.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6260,7 +6260,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6292,7 +6292,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let inputs_weight = [weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6322,7 +6322,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/blinded_payment_tests.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,7 +747,7 @@ fn do_blinded_intercept_payment(intercept_node_fails: bool) {

	if intercept_node_fails {
 nodes[1].node.fail_intercepted_htlc(intercept_id).unwrap();
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], vec![HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], [HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 nodes[1].node.process_pending_htlc_forwards();
 check_added_monitors!(&nodes[1], 1);
 fail_blinded_htlc_backwards(payment_hash, 1, &[&nodes[0], &nodes[1]], false);
Expand DownExpand Up@@ -1046,7 +1046,7 @@ fn do_multi_hop_receiver_fail(check: ReceiveCheckFail) {
 do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
 expect_pending_htlcs_forwardable!(nodes[2]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[2],
vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[2], 1);
 },
 ReceiveCheckFail::PaymentConstraints => {
Expand Down

8 changes: 4 additions & 4 deletions
lightning/src/ln/channelmanager.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15935,7 +15935,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16155,7 +16155,7 @@ mod tests {
 // We have to forward pending HTLCs twice - once tries to forward the payment forward (and
 // fails), the second will process the resulting failure and fail the HTLC backward
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16200,7 +16200,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16247,7 +16247,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/functional_test_utils.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2168,7 +2168,7 @@ pub fn do_commitment_signed_dance(node_a: &Node<'_, '_, '_>, node_b: &Node<'_, '

	if fail_backwards {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node_a,
vec![crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 [crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 check_added_monitors!(node_a, 1);

 let node_a_per_peer_state = node_a.node.per_peer_state.read().unwrap();
Expand DownExpand Up@@ -3243,7 +3243,7 @@ pub fn pass_failed_payment_back<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expe
 node.node.handle_update_fail_htlc(prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
 commitment_signed_dance!(node, prev_node, next_msgs.as_ref().unwrap().1, update_next_node);
 if !update_next_node {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, vec![HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, [HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 }
 }
 let events = node.node.get_and_clear_pending_msg_events();
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove (and deny) useless test vec!s#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Jun 26, 2025
 Merged


Remove (and deny) useless test vec!s
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
4c23810

Remove uneccessary `vec!`s across tests


TheBlueMatt Jun 12, 2025
6091c4a

clippy-Deny useless `vec`s in test code


TheBlueMatt Jun 12, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ci/check-lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,4 +110,4 @@ CLIPPY() {

CLIPPY
# We allow some additional warnings in tests which we should fix, but which aren't currently a priority
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap -A clippy::useless_vec"
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap"

26 changes: 13 additions & 13 deletions
lightning-rapid-gossip-sync/src/processing.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -503,7 +503,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -534,7 +534,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 97, 206, 240,
 0, 0, 0, 0, 2, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186, 5,
Expand DownExpand Up@@ -597,7 +597,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 105, 183,
 240, 0, 0, 0, 0, 1, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186,
Expand DownExpand Up@@ -625,7 +625,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 106, 12, 80,
 1, 0, 2, 23, 48, 0, 0, 0, 3, 143, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213,
Expand DownExpand Up@@ -700,7 +700,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_ignores_missing_channel() {
 let incremental_update_input = vec![
 let incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -721,7 +721,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_updates() {
 let announced_update_input = vec![
 let announced_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -749,7 +749,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_same_direction_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -789,7 +789,7 @@ mod tests {
 assert!(initialized.contains("619737530008010752"));
 assert!(initialized.contains("783241506229452801"));

 let opposite_direction_incremental_update_input = vec![
 let opposite_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -802,7 +802,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_update_succeeds_with_prior_announcements_and_full_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -829,7 +829,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -863,7 +863,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn update_succeeds_when_duplicate_gossip_is_applied() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -890,7 +890,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -1023,7 +1023,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	pub fn update_fails_with_unknown_version() {
 let unknown_version_input = vec![
 let unknown_version_input = [
 76, 68, 75, 3, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand Down

6 changes: 3 additions & 3 deletions
lightning/src/chain/channelmonitor.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6260,7 +6260,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6292,7 +6292,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let inputs_weight = [weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6322,7 +6322,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/blinded_payment_tests.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,7 +747,7 @@ fn do_blinded_intercept_payment(intercept_node_fails: bool) {

	if intercept_node_fails {
 nodes[1].node.fail_intercepted_htlc(intercept_id).unwrap();
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], vec![HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], [HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 nodes[1].node.process_pending_htlc_forwards();
 check_added_monitors!(&nodes[1], 1);
 fail_blinded_htlc_backwards(payment_hash, 1, &[&nodes[0], &nodes[1]], false);
Expand DownExpand Up@@ -1046,7 +1046,7 @@ fn do_multi_hop_receiver_fail(check: ReceiveCheckFail) {
 do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
 expect_pending_htlcs_forwardable!(nodes[2]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[2],
vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[2], 1);
 },
 ReceiveCheckFail::PaymentConstraints => {
Expand Down

8 changes: 4 additions & 4 deletions
lightning/src/ln/channelmanager.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15935,7 +15935,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16155,7 +16155,7 @@ mod tests {
 // We have to forward pending HTLCs twice - once tries to forward the payment forward (and
 // fails), the second will process the resulting failure and fail the HTLC backward
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16200,7 +16200,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16247,7 +16247,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/functional_test_utils.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2168,7 +2168,7 @@ pub fn do_commitment_signed_dance(node_a: &Node<'_, '_, '_>, node_b: &Node<'_, '

	if fail_backwards {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node_a,
vec![crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 [crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 check_added_monitors!(node_a, 1);

 let node_a_per_peer_state = node_a.node.per_peer_state.read().unwrap();
Expand DownExpand Up@@ -3243,7 +3243,7 @@ pub fn pass_failed_payment_back<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expe
 node.node.handle_update_fail_htlc(prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
 commitment_signed_dance!(node, prev_node, next_msgs.as_ref().unwrap().1, update_next_node);
 if !update_next_node {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, vec![HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, [HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 }
 }
 let events = node.node.get_and_clear_pending_msg_events();
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove (and deny) useless test vec!s#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Jun 26, 2025
 Merged


Remove (and deny) useless test vec!s
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
4c23810

Remove uneccessary `vec!`s across tests


TheBlueMatt Jun 12, 2025
6091c4a

clippy-Deny useless `vec`s in test code


TheBlueMatt Jun 12, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ci/check-lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,4 +110,4 @@ CLIPPY() {

CLIPPY
# We allow some additional warnings in tests which we should fix, but which aren't currently a priority
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap -A clippy::useless_vec"
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap"

26 changes: 13 additions & 13 deletions
lightning-rapid-gossip-sync/src/processing.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -503,7 +503,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -534,7 +534,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 97, 206, 240,
 0, 0, 0, 0, 2, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186, 5,
Expand DownExpand Up@@ -597,7 +597,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 105, 183,
 240, 0, 0, 0, 0, 1, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186,
Expand DownExpand Up@@ -625,7 +625,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 106, 12, 80,
 1, 0, 2, 23, 48, 0, 0, 0, 3, 143, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213,
Expand DownExpand Up@@ -700,7 +700,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_ignores_missing_channel() {
 let incremental_update_input = vec![
 let incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -721,7 +721,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_updates() {
 let announced_update_input = vec![
 let announced_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -749,7 +749,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_same_direction_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -789,7 +789,7 @@ mod tests {
 assert!(initialized.contains("619737530008010752"));
 assert!(initialized.contains("783241506229452801"));

 let opposite_direction_incremental_update_input = vec![
 let opposite_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -802,7 +802,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_update_succeeds_with_prior_announcements_and_full_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -829,7 +829,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -863,7 +863,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn update_succeeds_when_duplicate_gossip_is_applied() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -890,7 +890,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -1023,7 +1023,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	pub fn update_fails_with_unknown_version() {
 let unknown_version_input = vec![
 let unknown_version_input = [
 76, 68, 75, 3, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand Down

6 changes: 3 additions & 3 deletions
lightning/src/chain/channelmonitor.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6260,7 +6260,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6292,7 +6292,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let inputs_weight = [weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6322,7 +6322,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/blinded_payment_tests.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,7 +747,7 @@ fn do_blinded_intercept_payment(intercept_node_fails: bool) {

	if intercept_node_fails {
 nodes[1].node.fail_intercepted_htlc(intercept_id).unwrap();
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], vec![HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], [HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 nodes[1].node.process_pending_htlc_forwards();
 check_added_monitors!(&nodes[1], 1);
 fail_blinded_htlc_backwards(payment_hash, 1, &[&nodes[0], &nodes[1]], false);
Expand DownExpand Up@@ -1046,7 +1046,7 @@ fn do_multi_hop_receiver_fail(check: ReceiveCheckFail) {
 do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
 expect_pending_htlcs_forwardable!(nodes[2]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[2],
vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[2], 1);
 },
 ReceiveCheckFail::PaymentConstraints => {
Expand Down

8 changes: 4 additions & 4 deletions
lightning/src/ln/channelmanager.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15935,7 +15935,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16155,7 +16155,7 @@ mod tests {
 // We have to forward pending HTLCs twice - once tries to forward the payment forward (and
 // fails), the second will process the resulting failure and fail the HTLC backward
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16200,7 +16200,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16247,7 +16247,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/functional_test_utils.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2168,7 +2168,7 @@ pub fn do_commitment_signed_dance(node_a: &Node<'_, '_, '_>, node_b: &Node<'_, '

	if fail_backwards {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node_a,
vec![crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 [crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 check_added_monitors!(node_a, 1);

 let node_a_per_peer_state = node_a.node.per_peer_state.read().unwrap();
Expand DownExpand Up@@ -3243,7 +3243,7 @@ pub fn pass_failed_payment_back<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expe
 node.node.handle_update_fail_htlc(prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
 commitment_signed_dance!(node, prev_node, next_msgs.as_ref().unwrap().1, update_next_node);
 if !update_next_node {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, vec![HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, [HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 }
 }
 let events = node.node.get_and_clear_pending_msg_events();
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Remove (and deny) useless test vec!s#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Jun 26, 2025
 Merged


Remove (and deny) useless test vec!s
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
4c23810

Remove uneccessary `vec!`s across tests


TheBlueMatt Jun 12, 2025
6091c4a

clippy-Deny useless `vec`s in test code


TheBlueMatt Jun 12, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ci/check-lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,4 +110,4 @@ CLIPPY() {

CLIPPY
# We allow some additional warnings in tests which we should fix, but which aren't currently a priority
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap -A clippy::useless_vec"
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap"

26 changes: 13 additions & 13 deletions
lightning-rapid-gossip-sync/src/processing.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -503,7 +503,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -534,7 +534,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 97, 206, 240,
 0, 0, 0, 0, 2, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186, 5,
Expand DownExpand Up@@ -597,7 +597,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 105, 183,
 240, 0, 0, 0, 0, 1, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186,
Expand DownExpand Up@@ -625,7 +625,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 106, 12, 80,
 1, 0, 2, 23, 48, 0, 0, 0, 3, 143, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213,
Expand DownExpand Up@@ -700,7 +700,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_ignores_missing_channel() {
 let incremental_update_input = vec![
 let incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -721,7 +721,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_updates() {
 let announced_update_input = vec![
 let announced_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -749,7 +749,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_same_direction_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -789,7 +789,7 @@ mod tests {
 assert!(initialized.contains("619737530008010752"));
 assert!(initialized.contains("783241506229452801"));

 let opposite_direction_incremental_update_input = vec![
 let opposite_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -802,7 +802,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_update_succeeds_with_prior_announcements_and_full_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -829,7 +829,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -863,7 +863,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn update_succeeds_when_duplicate_gossip_is_applied() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -890,7 +890,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -1023,7 +1023,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	pub fn update_fails_with_unknown_version() {
 let unknown_version_input = vec![
 let unknown_version_input = [
 76, 68, 75, 3, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand Down

6 changes: 3 additions & 3 deletions
lightning/src/chain/channelmonitor.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6260,7 +6260,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6292,7 +6292,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let inputs_weight = [weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6322,7 +6322,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/blinded_payment_tests.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,7 +747,7 @@ fn do_blinded_intercept_payment(intercept_node_fails: bool) {

	if intercept_node_fails {
 nodes[1].node.fail_intercepted_htlc(intercept_id).unwrap();
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], vec![HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], [HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 nodes[1].node.process_pending_htlc_forwards();
 check_added_monitors!(&nodes[1], 1);
 fail_blinded_htlc_backwards(payment_hash, 1, &[&nodes[0], &nodes[1]], false);
Expand DownExpand Up@@ -1046,7 +1046,7 @@ fn do_multi_hop_receiver_fail(check: ReceiveCheckFail) {
 do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
 expect_pending_htlcs_forwardable!(nodes[2]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[2],
vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[2], 1);
 },
 ReceiveCheckFail::PaymentConstraints => {
Expand Down

8 changes: 4 additions & 4 deletions
lightning/src/ln/channelmanager.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15935,7 +15935,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16155,7 +16155,7 @@ mod tests {
 // We have to forward pending HTLCs twice - once tries to forward the payment forward (and
 // fails), the second will process the resulting failure and fail the HTLC backward
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16200,7 +16200,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16247,7 +16247,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/functional_test_utils.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2168,7 +2168,7 @@ pub fn do_commitment_signed_dance(node_a: &Node<'_, '_, '_>, node_b: &Node<'_, '

	if fail_backwards {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node_a,
vec![crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 [crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 check_added_monitors!(node_a, 1);

 let node_a_per_peer_state = node_a.node.per_peer_state.read().unwrap();
Expand DownExpand Up@@ -3243,7 +3243,7 @@ pub fn pass_failed_payment_back<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expe
 node.node.handle_update_fail_htlc(prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
 commitment_signed_dance!(node, prev_node, next_msgs.as_ref().unwrap().1, update_next_node);
 if !update_next_node {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, vec![HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, [HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 }
 }
 let events = node.node.get_and_clear_pending_msg_events();
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove (and deny) useless test vec!s#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Jun 26, 2025
 Merged


Remove (and deny) useless test vec!s
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
4c23810

Remove uneccessary `vec!`s across tests


TheBlueMatt Jun 12, 2025
6091c4a

clippy-Deny useless `vec`s in test code


TheBlueMatt Jun 12, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ci/check-lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,4 +110,4 @@ CLIPPY() {

CLIPPY
# We allow some additional warnings in tests which we should fix, but which aren't currently a priority
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap -A clippy::useless_vec"
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap"

26 changes: 13 additions & 13 deletions
lightning-rapid-gossip-sync/src/processing.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -503,7 +503,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -534,7 +534,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 97, 206, 240,
 0, 0, 0, 0, 2, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186, 5,
Expand DownExpand Up@@ -597,7 +597,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 105, 183,
 240, 0, 0, 0, 0, 1, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186,
Expand DownExpand Up@@ -625,7 +625,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 106, 12, 80,
 1, 0, 2, 23, 48, 0, 0, 0, 3, 143, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213,
Expand DownExpand Up@@ -700,7 +700,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_ignores_missing_channel() {
 let incremental_update_input = vec![
 let incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -721,7 +721,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_updates() {
 let announced_update_input = vec![
 let announced_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -749,7 +749,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_same_direction_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -789,7 +789,7 @@ mod tests {
 assert!(initialized.contains("619737530008010752"));
 assert!(initialized.contains("783241506229452801"));

 let opposite_direction_incremental_update_input = vec![
 let opposite_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -802,7 +802,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_update_succeeds_with_prior_announcements_and_full_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -829,7 +829,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -863,7 +863,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn update_succeeds_when_duplicate_gossip_is_applied() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -890,7 +890,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -1023,7 +1023,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	pub fn update_fails_with_unknown_version() {
 let unknown_version_input = vec![
 let unknown_version_input = [
 76, 68, 75, 3, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand Down

6 changes: 3 additions & 3 deletions
lightning/src/chain/channelmonitor.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6260,7 +6260,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6292,7 +6292,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let inputs_weight = [weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6322,7 +6322,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/blinded_payment_tests.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,7 +747,7 @@ fn do_blinded_intercept_payment(intercept_node_fails: bool) {

	if intercept_node_fails {
 nodes[1].node.fail_intercepted_htlc(intercept_id).unwrap();
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], vec![HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], [HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 nodes[1].node.process_pending_htlc_forwards();
 check_added_monitors!(&nodes[1], 1);
 fail_blinded_htlc_backwards(payment_hash, 1, &[&nodes[0], &nodes[1]], false);
Expand DownExpand Up@@ -1046,7 +1046,7 @@ fn do_multi_hop_receiver_fail(check: ReceiveCheckFail) {
 do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
 expect_pending_htlcs_forwardable!(nodes[2]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[2],
vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[2], 1);
 },
 ReceiveCheckFail::PaymentConstraints => {
Expand Down

8 changes: 4 additions & 4 deletions
lightning/src/ln/channelmanager.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15935,7 +15935,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16155,7 +16155,7 @@ mod tests {
 // We have to forward pending HTLCs twice - once tries to forward the payment forward (and
 // fails), the second will process the resulting failure and fail the HTLC backward
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16200,7 +16200,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16247,7 +16247,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/functional_test_utils.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2168,7 +2168,7 @@ pub fn do_commitment_signed_dance(node_a: &Node<'_, '_, '_>, node_b: &Node<'_, '

	if fail_backwards {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node_a,
vec![crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 [crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 check_added_monitors!(node_a, 1);

 let node_a_per_peer_state = node_a.node.per_peer_state.read().unwrap();
Expand DownExpand Up@@ -3243,7 +3243,7 @@ pub fn pass_failed_payment_back<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expe
 node.node.handle_update_fail_htlc(prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
 commitment_signed_dance!(node, prev_node, next_msgs.as_ref().unwrap().1, update_next_node);
 if !update_next_node {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, vec![HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, [HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 }
 }
 let events = node.node.get_and_clear_pending_msg_events();
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove (and deny) useless test vec!s#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Jun 26, 2025
 Merged


Remove (and deny) useless test vec!s
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
4c23810

Remove uneccessary `vec!`s across tests


TheBlueMatt Jun 12, 2025
6091c4a

clippy-Deny useless `vec`s in test code


TheBlueMatt Jun 12, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ci/check-lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,4 +110,4 @@ CLIPPY() {

CLIPPY
# We allow some additional warnings in tests which we should fix, but which aren't currently a priority
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap -A clippy::useless_vec"
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap"

26 changes: 13 additions & 13 deletions
lightning-rapid-gossip-sync/src/processing.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -503,7 +503,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -534,7 +534,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 97, 206, 240,
 0, 0, 0, 0, 2, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186, 5,
Expand DownExpand Up@@ -597,7 +597,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 105, 183,
 240, 0, 0, 0, 0, 1, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186,
Expand DownExpand Up@@ -625,7 +625,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 106, 12, 80,
 1, 0, 2, 23, 48, 0, 0, 0, 3, 143, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213,
Expand DownExpand Up@@ -700,7 +700,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_ignores_missing_channel() {
 let incremental_update_input = vec![
 let incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -721,7 +721,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_updates() {
 let announced_update_input = vec![
 let announced_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -749,7 +749,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_same_direction_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -789,7 +789,7 @@ mod tests {
 assert!(initialized.contains("619737530008010752"));
 assert!(initialized.contains("783241506229452801"));

 let opposite_direction_incremental_update_input = vec![
 let opposite_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -802,7 +802,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_update_succeeds_with_prior_announcements_and_full_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -829,7 +829,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -863,7 +863,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn update_succeeds_when_duplicate_gossip_is_applied() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -890,7 +890,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -1023,7 +1023,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	pub fn update_fails_with_unknown_version() {
 let unknown_version_input = vec![
 let unknown_version_input = [
 76, 68, 75, 3, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand Down

6 changes: 3 additions & 3 deletions
lightning/src/chain/channelmonitor.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6260,7 +6260,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6292,7 +6292,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let inputs_weight = [weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6322,7 +6322,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/blinded_payment_tests.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,7 +747,7 @@ fn do_blinded_intercept_payment(intercept_node_fails: bool) {

	if intercept_node_fails {
 nodes[1].node.fail_intercepted_htlc(intercept_id).unwrap();
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], vec![HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], [HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 nodes[1].node.process_pending_htlc_forwards();
 check_added_monitors!(&nodes[1], 1);
 fail_blinded_htlc_backwards(payment_hash, 1, &[&nodes[0], &nodes[1]], false);
Expand DownExpand Up@@ -1046,7 +1046,7 @@ fn do_multi_hop_receiver_fail(check: ReceiveCheckFail) {
 do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
 expect_pending_htlcs_forwardable!(nodes[2]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[2],
vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[2], 1);
 },
 ReceiveCheckFail::PaymentConstraints => {
Expand Down

8 changes: 4 additions & 4 deletions
lightning/src/ln/channelmanager.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15935,7 +15935,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16155,7 +16155,7 @@ mod tests {
 // We have to forward pending HTLCs twice - once tries to forward the payment forward (and
 // fails), the second will process the resulting failure and fail the HTLC backward
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16200,7 +16200,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16247,7 +16247,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/functional_test_utils.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2168,7 +2168,7 @@ pub fn do_commitment_signed_dance(node_a: &Node<'_, '_, '_>, node_b: &Node<'_, '

	if fail_backwards {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node_a,
vec![crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 [crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 check_added_monitors!(node_a, 1);

 let node_a_per_peer_state = node_a.node.per_peer_state.read().unwrap();
Expand DownExpand Up@@ -3243,7 +3243,7 @@ pub fn pass_failed_payment_back<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expe
 node.node.handle_update_fail_htlc(prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
 commitment_signed_dance!(node, prev_node, next_msgs.as_ref().unwrap().1, update_next_node);
 if !update_next_node {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, vec![HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, [HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 }
 }
 let events = node.node.get_and_clear_pending_msg_events();
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Remove (and deny) useless test vec!s#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 2 commits into

from

Jun 26, 2025
 Merged


Remove (and deny) useless test vec!s
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
4c23810

Remove uneccessary `vec!`s across tests


TheBlueMatt Jun 12, 2025
6091c4a

clippy-Deny useless `vec`s in test code


TheBlueMatt Jun 12, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ci/check-lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,4 +110,4 @@ CLIPPY() {

CLIPPY
# We allow some additional warnings in tests which we should fix, but which aren't currently a priority
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap -A clippy::useless_vec"
CLIPPY --tests "-A clippy::bool_assert_comparison -A clippy::assertions_on_constants -A clippy::needless-late-init -A clippy::field_reassign_with_default -A clippy::unnecessary_literal_unwrap"

26 changes: 13 additions & 13 deletions
lightning-rapid-gossip-sync/src/processing.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -503,7 +503,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -534,7 +534,7 @@ mod tests {
 let logger = TestLogger::new();
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 97, 206, 240,
 0, 0, 0, 0, 2, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186, 5,
Expand DownExpand Up@@ -597,7 +597,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 105, 183,
 240, 0, 0, 0, 0, 1, 63, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213, 170, 186,
Expand DownExpand Up@@ -625,7 +625,7 @@ mod tests {
 let network_graph = NetworkGraph::new(Network::Bitcoin, &logger);
 let rapid_sync = RapidGossipSync::new(&network_graph, &logger);

 let example_input = vec![
 let example_input = [
 76, 68, 75, 2, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 102, 106, 12, 80,
 1, 0, 2, 23, 48, 0, 0, 0, 3, 143, 27, 132, 197, 86, 123, 18, 100, 64, 153, 93, 62, 213,
Expand DownExpand Up@@ -700,7 +700,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_ignores_missing_channel() {
 let incremental_update_input = vec![
 let incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -721,7 +721,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_updates() {
 let announced_update_input = vec![
 let announced_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -749,7 +749,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_only_update_fails_without_prior_same_direction_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand DownExpand Up@@ -789,7 +789,7 @@ mod tests {
 assert!(initialized.contains("619737530008010752"));
 assert!(initialized.contains("783241506229452801"));

 let opposite_direction_incremental_update_input = vec![
 let opposite_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand All@@ -802,7 +802,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn incremental_update_succeeds_with_prior_announcements_and_full_updates() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -829,7 +829,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -863,7 +863,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	fn update_succeeds_when_duplicate_gossip_is_applied() {
 let initialization_input = vec![
 let initialization_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand All@@ -890,7 +890,7 @@ mod tests {
 let initialization_result = rapid_sync.update_network_graph(&initialization_input[..]);
 assert!(initialization_result.is_ok());

 let single_direction_incremental_update_input = vec![
 let single_direction_incremental_update_input = [
 76, 68, 75, 1, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 229, 183, 167,
 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Expand DownExpand Up@@ -1023,7 +1023,7 @@ mod tests {
	#[test]
	#[cfg(feature = "std")]
	pub fn update_fails_with_unknown_version() {
 let unknown_version_input = vec![
 let unknown_version_input = [
 76, 68, 75, 3, 111, 226, 140, 10, 182, 241, 179, 114, 193, 166, 162, 70, 174, 99, 247,
 79, 147, 30, 131, 101, 225, 90, 8, 156, 104, 214, 25, 0, 0, 0, 0, 0, 97, 227, 98, 218,
 0, 0, 0, 4, 2, 22, 7, 207, 206, 25, 164, 197, 231, 230, 231, 56, 102, 61, 250, 251,
Expand Down

6 changes: 3 additions & 3 deletions
lightning/src/chain/channelmonitor.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6260,7 +6260,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT, weight_revoked_offered_htlc(channel_type_features), weight_revoked_offered_htlc(channel_type_features), weight_revoked_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6292,7 +6292,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let inputs_weight = [weight_offered_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features), weight_received_htlc(channel_type_features)];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand DownExpand Up@@ -6322,7 +6322,7 @@ mod tests {
 value: Amount::ZERO,
 });
 let base_weight = claim_tx.weight().to_wu();
 let inputs_weight = vec![WEIGHT_REVOKED_OUTPUT];
 let inputs_weight = [WEIGHT_REVOKED_OUTPUT];
 let mut inputs_total_weight = 2; // count segwit flags
 {
 let mut sighash_parts = sighash::SighashCache::new(&mut claim_tx);
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/blinded_payment_tests.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -747,7 +747,7 @@ fn do_blinded_intercept_payment(intercept_node_fails: bool) {

	if intercept_node_fails {
 nodes[1].node.fail_intercepted_htlc(intercept_id).unwrap();
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], vec![HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[1], [HTLCHandlingFailureType::InvalidForward { requested_forward_scid: intercept_scid }]);
 nodes[1].node.process_pending_htlc_forwards();
 check_added_monitors!(&nodes[1], 1);
 fail_blinded_htlc_backwards(payment_hash, 1, &[&nodes[0], &nodes[1]], false);
Expand DownExpand Up@@ -1046,7 +1046,7 @@ fn do_multi_hop_receiver_fail(check: ReceiveCheckFail) {
 do_commitment_signed_dance(&nodes[2], &nodes[1], &payment_event_1_2.commitment_msg, true, true);
 expect_pending_htlcs_forwardable!(nodes[2]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed_ignore!(nodes[2],
vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[2], 1);
 },
 ReceiveCheckFail::PaymentConstraints => {
Expand Down

8 changes: 4 additions & 4 deletions
lightning/src/ln/channelmanager.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15935,7 +15935,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash: our_payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16155,7 +16155,7 @@ mod tests {
 // We have to forward pending HTLCs twice - once tries to forward the payment forward (and
 // fails), the second will process the resulting failure and fail the HTLC backward
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16200,7 +16200,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand DownExpand Up@@ -16247,7 +16247,7 @@ mod tests {
 check_added_monitors!(nodes[1], 0);
 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 expect_pending_htlcs_forwardable!(nodes[1]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCHandlingFailureType::Receive { payment_hash }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], [HTLCHandlingFailureType::Receive { payment_hash }]);
 check_added_monitors!(nodes[1], 1);
 let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 assert!(updates.update_add_htlcs.is_empty());
Expand Down

4 changes: 2 additions & 2 deletions
lightning/src/ln/functional_test_utils.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2168,7 +2168,7 @@ pub fn do_commitment_signed_dance(node_a: &Node<'_, '_, '_>, node_b: &Node<'_, '

	if fail_backwards {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node_a,
vec![crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 [crate::events::HTLCHandlingFailureType::Forward{ node_id: Some(node_b.node.get_our_node_id()), channel_id }]);
 check_added_monitors!(node_a, 1);

 let node_a_per_peer_state = node_a.node.per_peer_state.read().unwrap();
Expand DownExpand Up@@ -3243,7 +3243,7 @@ pub fn pass_failed_payment_back<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expe
 node.node.handle_update_fail_htlc(prev_node.node.get_our_node_id(), &next_msgs.as_ref().unwrap().0);
 commitment_signed_dance!(node, prev_node, next_msgs.as_ref().unwrap().1, update_next_node);
 if !update_next_node {
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, vec![HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(node, [HTLCHandlingFailureType::Forward { node_id: Some(prev_node.node.get_our_node_id()), channel_id: next_msgs.as_ref().unwrap().0.channel_id }]);
 }
 }
 let events = node.node.get_and_clear_pending_msg_events();
Expand Down
Loading