Skip to content

Rustfmt parts of channelmanager.rs - #3960

Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
joostjager:simple-hold-fmt
Jul 25, 2025
Merged

Rustfmt parts of channelmanager.rs#3960
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
joostjager:simple-hold-fmt

Conversation

@joostjager

Copy link
Copy Markdown
Contributor

Prepare for #3957

@ldk-reviews-bot

ldk-reviews-bot commented Jul 25, 2025

Copy link
Copy Markdown

I've assigned @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov

codecovBot commented Jul 25, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.41176% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.93%. Comparing base (55baa15) to head (0d56fb7).
⚠️ Report is 6 commits behind head on main.

Files with missing linesPatch %Lines
lightning/src/ln/channelmanager.rs79.41%27 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3960 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.02% 
==========================================
Files 173 173 Lines 123794 123876 +82 Branches 123794 123876 +82 ==========================================
+ Hits 110114 110165 +51 - Misses 11227 11255 +28 - Partials 2453 2456 +3 
FlagCoverage Δ
fuzzing22.17% <0.00%> (-0.04%)⬇️
tests88.75% <79.41%> (-0.02%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joostjager
joostjager marked this pull request as ready for review July 25, 2025 13:29

@tankyleotankyleo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced both commits on my machine.

@ldk-reviews-bot

Copy link
Copy Markdown

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@TheBlueMatt
TheBlueMatt merged commit ed42300 into lightningdevkit:mainJul 25, 2025
50 of 51 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@joostjager@ldk-reviews-bot@tankyleo@TheBlueMatt