Skip to content

LSPS5 follow up: Move TimeProvider to utils::time module for better organization - #3962

Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
martinsaposnic:move-time-provider-to-utils
Jul 26, 2025
Merged

LSPS5 follow up: Move TimeProvider to utils::time module for better organization#3962
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
martinsaposnic:move-time-provider-to-utils

Conversation

@martinsaposnic

@martinsaposnicmartinsaposnic commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

This is a follow up for the LSPS5 merged PR. Comment by @tnull#3662 (comment)

Might be worth moving this to some crate::utils::time or similar path, if we'll end up keeping it at all. (in a follow-up)

@ldk-reviews-bot

ldk-reviews-bot commented Jul 25, 2025

Copy link
Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@martinsaposnicmartinsaposnic mentioned this pull request Jul 25, 2025
18 tasks
@codecov

codecovBot commented Jul 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.92%. Comparing base (ff279d6) to head (81313cd).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #3962 +/- ##
========================================
Coverage 88.91% 88.92% ========================================
Files 173 174 +1 Lines 123393 123794 +401 Branches 123393 123794 +401 ========================================
+ Hits 109717 110083 +366 - Misses 11216 11252 +36 + Partials 2460 2459 -1 
FlagCoverage Δ
fuzzing22.21% <0.00%> (-0.11%)⬇️
tests88.75% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martinsaposnic
martinsaposnicforce-pushed the move-time-provider-to-utils branch from 735dc48 to 81313cdCompareJuly 25, 2025 17:30
@TheBlueMatt
TheBlueMatt requested review from TheBlueMatt and removed request for valentinewallaceJuly 26, 2025 18:51
@ldk-reviews-bot

Copy link
Copy Markdown

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@TheBlueMatt
TheBlueMatt merged commit d56f71f into lightningdevkit:mainJul 26, 2025
27 of 28 checks passed

@tnulltnull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-merge ACK

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@martinsaposnic@ldk-reviews-bot@tnull@TheBlueMatt