Skip to content

LSPS5 - small follow ups - #3963

Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom
martinsaposnic:lsps5-small-followups
Jul 26, 2025
Merged

LSPS5 - small follow ups#3963
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom
martinsaposnic:lsps5-small-followups

Conversation

@martinsaposnic

Copy link
Copy Markdown
Contributor

@ldk-reviews-bot

ldk-reviews-bot commented Jul 25, 2025

Copy link
Copy Markdown

👋 I see @valentinewallace was un-assigned.
If you'd like another reviewer assignment, please click here.

@martinsaposnicmartinsaposnic mentioned this pull request Jul 25, 2025
18 tasks
@codecov

codecovBot commented Jul 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.95%. Comparing base (ff279d6) to head (79f1da5).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #3963 +/- ##
==========================================
+ Coverage 88.91% 88.95% +0.03% 
==========================================
Files 173 173 Lines 123393 123794 +401 Branches 123393 123794 +401 ==========================================
+ Hits 109717 110120 +403 - Misses 11216 11224 +8 + Partials 2460 2450 -10 
FlagCoverage Δ
fuzzing22.21% <0.00%> (-0.11%)⬇️
tests88.78% <100.00%> (+0.03%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheBlueMatt
TheBlueMatt removed the request for review from valentinewallaceJuly 26, 2025 18:25
@TheBlueMatt
TheBlueMatt merged commit bc5a18b into lightningdevkit:mainJul 26, 2025
43 of 51 checks passed

@tnulltnull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge ACK

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@martinsaposnic@ldk-reviews-bot@tnull@TheBlueMatt