Uh oh!
There was an error while loading. Please reload this page.
Trampoline forwarding - #3976
Closed
a-mpch wants to merge 4 commits into
Closed
Conversation
👋 Hi! This PR is now in draft status. |
a-mpch
commented
Jul 30, 2025
| #[cfg(not(any(test, feature = "_test_utils")))] | ||
| let retry_strategy = Retry::Attempts(3); | ||
| #[cfg(any(test, feature = "_test_utils"))] |
ContributorAuthor
There was a problem hiding this comment.
Not really a fan on this one, I'd accept any idea
a-mpch
commented
Jul 30, 2025
ContributorAuthor
drafting while rebasing again and fixing minor issues of CI |
a-mpch
marked this pull request as draft
July 30, 2025 23:16
Ensure that the Trampolin onion's amount and CLTV values does not exceed the limitations imposed by the outer onion. Co-authored-by: Arik Sosman <git@arik.io>
To process errors returned from downstream nodes when forwarding between Trampoline nodes, we need to store information beyond what's available in `HTLCPreviousHopData`, suc as the used hops as the newly generated outer onion's session_priv. To that end, we add a new variant to `HTLCSource` in this commit, which futre-proofs mapping an outbound forward to an incoming MPP. Co-authored-by: Arik Sosman <git@arik.io>
The previously existing `HTLCDestination` do not map nicely to the failure vent of a Trampoline forward, so we introduce a new variant to fill the gap. Co-authored-by: Arik Sosman <git@arik.io>
a-mpch
commented
Jul 31, 2025
| { | ||
| // We use Unkonwn Failure code instead of TemporaryTrampolineFailure because errors uses u16 bolt04 codes. | ||
| let payment_failed_conditions = PaymentFailedConditions::new() | ||
| .expected_htlc_error_data(LocalHTLCFailureReason::UnknownFailureCode { code: 16409 }, &[0; 0]); |
ContributorAuthor
There was a problem hiding this comment.
Not really sure on testing like this or just add the TemporaryTrampolineFailure
a-mpchforce-pushed
the
2025-07-trampoline-forwarding
branch
2 times, most recently
from
August 1, 2025 14:44
4a72640 to
ef09262CompareCodecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@## main #3976 +/- ##
=========================================
Coverage 88.91% 88.91% =========================================
Files 174 174 Lines 124232 125526 +1294 Branches 124232 125526 +1294 =========================================
+ Hits 110455 111610 +1155 - Misses 11301 11419 +118 - Partials 2476 2497 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In this commit, we expand our forwarding logic to do ad-hoc pathfinding to subsequent Trampoline nodes, covering both blinded and unblinded scenarios. We set a constant for retrying payments in Trampoline nodes up to 3 failures. We further modify our error propagation logic to handle Trampoline forward HTLC failures. Co-authored-by: Arik Sosman <git@arik.io>
a-mpchforce-pushed
the
2025-07-trampoline-forwarding
branch
from
August 1, 2025 15:31
ef09262 to
3d2fe8dComparecarlaKC
commented
Feb 12, 2026
Contributor
Replaced with #4414. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3711
Rebase and fixes to a sooner
mainbranch.Some changes from the previous branch:
What's missing: