Skip to content

Correct post-update action comment on claims from closed chans - #3985

Merged
valentinewallace merged 1 commit into
lightningdevkit:mainfrom
TheBlueMatt:2025-08-fix-comment
Aug 5, 2025
Merged

Correct post-update action comment on claims from closed chans#3985
valentinewallace merged 1 commit into
lightningdevkit:mainfrom
TheBlueMatt:2025-08-fix-comment

Conversation

@TheBlueMatt

@TheBlueMattTheBlueMatt commented Aug 2, 2025

Copy link
Copy Markdown
Collaborator

Before e938ed7 and 41f703c, when we had a payment preimage for a claim which needed to go to a closed channel, we'd always run the post-ChannelMonitorUpdate completion action immediately as we didn't actually track async
ChannelMonitorUpdates to closed channels. Since those commits we do, but the comment noting the completion action processing was not updated.

Thus, here we update the comment, for the easiest close on a major feature issue ever.

Fixes#2355.

@TheBlueMatt
Correct post-update action comment on claims from closed chans
a18b2c9
Before e938ed7 and
41f703c, when we had a payment
preimage for a claim which needed to go to a closed channel, we'd
always run the post-`ChannelMonitorUpdate` completion action
immediately as we didn't actually track async
`ChannelMonitorUpdate`s to closed channels. Since those commits we
do, but the comment noting the completion action processing was not
updated.
Thus, here we update the comment, for the easiest close on a major
feature issue ever.
Fixeslightningdevkit#2355.
@ldk-reviews-bot

ldk-reviews-bot commented Aug 2, 2025•
edited
Loading

Copy link
Copy Markdown

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov

codecovBot commented Aug 2, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.93%. Comparing base (61e5819) to head (a18b2c9).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #3985 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.02% 
==========================================
Files 174 174 Lines 124201 124201 Branches 124201 124201 ==========================================
- Hits 110472 110459 -13 - Misses 11251 11261 +10 - Partials 2478 2481 +3
FlagCoverage Δ
fuzzing22.63% <ø> (ø)
tests88.76% <ø> (-0.02%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldk-reviews-bot

ldk-reviews-bot commented Aug 4, 2025

Copy link
Copy Markdown

🔔 1st Reminder

Hey @valentinewallace! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Aug 5, 2025

Copy link
Copy Markdown

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@valentinewallace
valentinewallace merged commit dc335e9 into lightningdevkit:mainAug 5, 2025
24 of 25 checks passed
@TheBlueMattTheBlueMatt self-assigned this Aug 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt

Labels

None yet

Projects

Weekly Goals
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stop completing monitor udpate completion actions when claiming on a closed channel

3 participants

@TheBlueMatt@ldk-reviews-bot@valentinewallace
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Correct post-update action comment on claims from closed chans by TheBlueMatt · Pull Request #3985 · lightningdevkit/rust-lightning · GitHub
Skip to content
Correct post-update action comment on claims from closed chans - #3985
Merged
valentinewallace merged 1 commit into
lightningdevkit:mainfrom 
TheBlueMatt:2025-08-fix-comment
Aug 5, 2025
Merged
Correct post-update action comment on claims from closed chans#3985
valentinewallace merged 1 commit into
lightningdevkit:mainfrom 
TheBlueMatt:2025-08-fix-comment
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Aug 2, 2025

Copy link


Copy Markdown

Collaborator
Before e938ed7 and 41f703c, when we had a payment preimage for a claim which needed to go to a closed channel, we'd always run the post-ChannelMonitorUpdate completion action immediately as we didn't actually track async
ChannelMonitorUpdates to closed channels. Since those commits we do, but the comment noting the completion action processing was not updated.
Thus, here we update the comment, for the easiest close on a major feature issue ever.
Fixes#2355.
@TheBlueMatt
Correct post-update action comment on claims from closed chans
a18b2c9
Before e938ed7 and
41f703c, when we had a payment
preimage for a claim which needed to go to a closed channel, we'd
always run the post-`ChannelMonitorUpdate` completion action
immediately as we didn't actually track async
`ChannelMonitorUpdate`s to closed channels. Since those commits we
do, but the comment noting the completion action processing was not
updated.
Thus, here we update the comment, for the easiest close on a major
feature issue ever.
Fixeslightningdevkit#2355.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 2, 2025•

edited

Loading

Copy link


Copy Markdown

I've assigned @valentinewallace as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Aug 2, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 88.93%. Comparing base (61e5819) to head (a18b2c9).
⚠️ Report is 12 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #3985 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.02% 
==========================================
Files 174 174 Lines 124201 124201 Branches 124201 124201 ==========================================
- Hits 110472 110459 -13 - Misses 11251 11261 +10 - Partials 2478 2481 +3 
FlagCoverage Δ
fuzzing22.63% <ø> (ø)
tests88.76% <ø> (-0.02%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 4, 2025

Copy link


Copy Markdown

🔔 1st Reminder
Hey @valentinewallace! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 5, 2025

Copy link


Copy Markdown

👋 The first review has been submitted!
Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.
@valentinewallace
valentinewallace
merged commit dc335e9
into
lightningdevkit:mainAug 5, 2025

24 of 25 checks passed

@TheBlueMattTheBlueMatt
self-assigned this
Aug 7, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt

Labels


None yet


Projects

Weekly Goals

Status: No status


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Stop completing monitor udpate completion actions when claiming on a closed channel


3 participants

@TheBlueMatt@ldk-reviews-bot@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Correct post-update action comment on claims from closed chans by TheBlueMatt · Pull Request #3985 · lightningdevkit/rust-lightning · GitHub
Skip to content
Correct post-update action comment on claims from closed chans - #3985
Merged
valentinewallace merged 1 commit into
lightningdevkit:mainfrom 
TheBlueMatt:2025-08-fix-comment
Aug 5, 2025
Merged
Correct post-update action comment on claims from closed chans#3985
valentinewallace merged 1 commit into
lightningdevkit:mainfrom 
TheBlueMatt:2025-08-fix-comment
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Aug 2, 2025

Copy link


Copy Markdown

Collaborator
Before e938ed7 and 41f703c, when we had a payment preimage for a claim which needed to go to a closed channel, we'd always run the post-ChannelMonitorUpdate completion action immediately as we didn't actually track async
ChannelMonitorUpdates to closed channels. Since those commits we do, but the comment noting the completion action processing was not updated.
Thus, here we update the comment, for the easiest close on a major feature issue ever.
Fixes#2355.
@TheBlueMatt
Correct post-update action comment on claims from closed chans
a18b2c9
Before e938ed7 and
41f703c, when we had a payment
preimage for a claim which needed to go to a closed channel, we'd
always run the post-`ChannelMonitorUpdate` completion action
immediately as we didn't actually track async
`ChannelMonitorUpdate`s to closed channels. Since those commits we
do, but the comment noting the completion action processing was not
updated.
Thus, here we update the comment, for the easiest close on a major
feature issue ever.
Fixeslightningdevkit#2355.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 2, 2025•

edited

Loading

Copy link


Copy Markdown

I've assigned @valentinewallace as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Aug 2, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 88.93%. Comparing base (61e5819) to head (a18b2c9).
⚠️ Report is 12 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #3985 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.02% 
==========================================
Files 174 174 Lines 124201 124201 Branches 124201 124201 ==========================================
- Hits 110472 110459 -13 - Misses 11251 11261 +10 - Partials 2478 2481 +3 
FlagCoverage Δ
fuzzing22.63% <ø> (ø)
tests88.76% <ø> (-0.02%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 4, 2025

Copy link


Copy Markdown

🔔 1st Reminder
Hey @valentinewallace! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 5, 2025

Copy link


Copy Markdown

👋 The first review has been submitted!
Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.
@valentinewallace
valentinewallace
merged commit dc335e9
into
lightningdevkit:mainAug 5, 2025

24 of 25 checks passed

@TheBlueMattTheBlueMatt
self-assigned this
Aug 7, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt

Labels


None yet


Projects

Weekly Goals

Status: No status


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Stop completing monitor udpate completion actions when claiming on a closed channel


3 participants

@TheBlueMatt@ldk-reviews-bot@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Correct post-update action comment on claims from closed chans by TheBlueMatt · Pull Request #3985 · lightningdevkit/rust-lightning · GitHub
Skip to content
Correct post-update action comment on claims from closed chans - #3985
Merged
valentinewallace merged 1 commit into
lightningdevkit:mainfrom 
TheBlueMatt:2025-08-fix-comment
Aug 5, 2025
Merged
Correct post-update action comment on claims from closed chans#3985
valentinewallace merged 1 commit into
lightningdevkit:mainfrom 
TheBlueMatt:2025-08-fix-comment
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Aug 2, 2025

Copy link


Copy Markdown

Collaborator
Before e938ed7 and 41f703c, when we had a payment preimage for a claim which needed to go to a closed channel, we'd always run the post-ChannelMonitorUpdate completion action immediately as we didn't actually track async
ChannelMonitorUpdates to closed channels. Since those commits we do, but the comment noting the completion action processing was not updated.
Thus, here we update the comment, for the easiest close on a major feature issue ever.
Fixes#2355.
@TheBlueMatt
Correct post-update action comment on claims from closed chans
a18b2c9
Before e938ed7 and
41f703c, when we had a payment
preimage for a claim which needed to go to a closed channel, we'd
always run the post-`ChannelMonitorUpdate` completion action
immediately as we didn't actually track async
`ChannelMonitorUpdate`s to closed channels. Since those commits we
do, but the comment noting the completion action processing was not
updated.
Thus, here we update the comment, for the easiest close on a major
feature issue ever.
Fixeslightningdevkit#2355.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 2, 2025•

edited

Loading

Copy link


Copy Markdown

I've assigned @valentinewallace as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Aug 2, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 88.93%. Comparing base (61e5819) to head (a18b2c9).
⚠️ Report is 12 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #3985 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.02% 
==========================================
Files 174 174 Lines 124201 124201 Branches 124201 124201 ==========================================
- Hits 110472 110459 -13 - Misses 11251 11261 +10 - Partials 2478 2481 +3 
FlagCoverage Δ
fuzzing22.63% <ø> (ø)
tests88.76% <ø> (-0.02%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 4, 2025

Copy link


Copy Markdown

🔔 1st Reminder
Hey @valentinewallace! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 5, 2025

Copy link


Copy Markdown

👋 The first review has been submitted!
Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.
@valentinewallace
valentinewallace
merged commit dc335e9
into
lightningdevkit:mainAug 5, 2025

24 of 25 checks passed

@TheBlueMattTheBlueMatt
self-assigned this
Aug 7, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt

Labels


None yet


Projects

Weekly Goals

Status: No status


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Stop completing monitor udpate completion actions when claiming on a closed channel


3 participants

@TheBlueMatt@ldk-reviews-bot@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Correct post-update action comment on claims from closed chans by TheBlueMatt · Pull Request #3985 · lightningdevkit/rust-lightning · GitHub
Skip to content
Correct post-update action comment on claims from closed chans - #3985
Merged
valentinewallace merged 1 commit into
lightningdevkit:mainfrom 
TheBlueMatt:2025-08-fix-comment
Aug 5, 2025
Merged
Correct post-update action comment on claims from closed chans#3985
valentinewallace merged 1 commit into
lightningdevkit:mainfrom 
TheBlueMatt:2025-08-fix-comment
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Aug 2, 2025

Copy link


Copy Markdown

Collaborator
Before e938ed7 and 41f703c, when we had a payment preimage for a claim which needed to go to a closed channel, we'd always run the post-ChannelMonitorUpdate completion action immediately as we didn't actually track async
ChannelMonitorUpdates to closed channels. Since those commits we do, but the comment noting the completion action processing was not updated.
Thus, here we update the comment, for the easiest close on a major feature issue ever.
Fixes#2355.
@TheBlueMatt
Correct post-update action comment on claims from closed chans
a18b2c9
Before e938ed7 and
41f703c, when we had a payment
preimage for a claim which needed to go to a closed channel, we'd
always run the post-`ChannelMonitorUpdate` completion action
immediately as we didn't actually track async
`ChannelMonitorUpdate`s to closed channels. Since those commits we
do, but the comment noting the completion action processing was not
updated.
Thus, here we update the comment, for the easiest close on a major
feature issue ever.
Fixeslightningdevkit#2355.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 2, 2025•

edited

Loading

Copy link


Copy Markdown

I've assigned @valentinewallace as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Aug 2, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 88.93%. Comparing base (61e5819) to head (a18b2c9).
⚠️ Report is 12 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #3985 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.02% 
==========================================
Files 174 174 Lines 124201 124201 Branches 124201 124201 ==========================================
- Hits 110472 110459 -13 - Misses 11251 11261 +10 - Partials 2478 2481 +3 
FlagCoverage Δ
fuzzing22.63% <ø> (ø)
tests88.76% <ø> (-0.02%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 4, 2025

Copy link


Copy Markdown

🔔 1st Reminder
Hey @valentinewallace! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 5, 2025

Copy link


Copy Markdown

👋 The first review has been submitted!
Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.
@valentinewallace
valentinewallace
merged commit dc335e9
into
lightningdevkit:mainAug 5, 2025

24 of 25 checks passed

@TheBlueMattTheBlueMatt
self-assigned this
Aug 7, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt

Labels


None yet


Projects

Weekly Goals

Status: No status


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Stop completing monitor udpate completion actions when claiming on a closed channel


3 participants

@TheBlueMatt@ldk-reviews-bot@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Correct post-update action comment on claims from closed chans by TheBlueMatt · Pull Request #3985 · lightningdevkit/rust-lightning · GitHub
Skip to content
Correct post-update action comment on claims from closed chans - #3985
Merged
valentinewallace merged 1 commit into
lightningdevkit:mainfrom 
TheBlueMatt:2025-08-fix-comment
Aug 5, 2025
Merged
Correct post-update action comment on claims from closed chans#3985
valentinewallace merged 1 commit into
lightningdevkit:mainfrom 
TheBlueMatt:2025-08-fix-comment
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Aug 2, 2025

Copy link


Copy Markdown

Collaborator
Before e938ed7 and 41f703c, when we had a payment preimage for a claim which needed to go to a closed channel, we'd always run the post-ChannelMonitorUpdate completion action immediately as we didn't actually track async
ChannelMonitorUpdates to closed channels. Since those commits we do, but the comment noting the completion action processing was not updated.
Thus, here we update the comment, for the easiest close on a major feature issue ever.
Fixes#2355.
@TheBlueMatt
Correct post-update action comment on claims from closed chans
a18b2c9
Before e938ed7 and
41f703c, when we had a payment
preimage for a claim which needed to go to a closed channel, we'd
always run the post-`ChannelMonitorUpdate` completion action
immediately as we didn't actually track async
`ChannelMonitorUpdate`s to closed channels. Since those commits we
do, but the comment noting the completion action processing was not
updated.
Thus, here we update the comment, for the easiest close on a major
feature issue ever.
Fixeslightningdevkit#2355.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 2, 2025•

edited

Loading

Copy link


Copy Markdown

I've assigned @valentinewallace as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Aug 2, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 88.93%. Comparing base (61e5819) to head (a18b2c9).
⚠️ Report is 12 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #3985 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.02% 
==========================================
Files 174 174 Lines 124201 124201 Branches 124201 124201 ==========================================
- Hits 110472 110459 -13 - Misses 11251 11261 +10 - Partials 2478 2481 +3 
FlagCoverage Δ
fuzzing22.63% <ø> (ø)
tests88.76% <ø> (-0.02%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 4, 2025

Copy link


Copy Markdown

🔔 1st Reminder
Hey @valentinewallace! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 5, 2025

Copy link


Copy Markdown

👋 The first review has been submitted!
Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.
@valentinewallace
valentinewallace
merged commit dc335e9
into
lightningdevkit:mainAug 5, 2025

24 of 25 checks passed

@TheBlueMattTheBlueMatt
self-assigned this
Aug 7, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt

Labels


None yet


Projects

Weekly Goals

Status: No status


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Stop completing monitor udpate completion actions when claiming on a closed channel


3 participants

@TheBlueMatt@ldk-reviews-bot@valentinewallace

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Correct post-update action comment on claims from closed chans by TheBlueMatt · Pull Request #3985 · lightningdevkit/rust-lightning · GitHub
Skip to content
Correct post-update action comment on claims from closed chans - #3985
Merged
valentinewallace merged 1 commit into
lightningdevkit:mainfrom 
TheBlueMatt:2025-08-fix-comment
Aug 5, 2025
Merged
Correct post-update action comment on claims from closed chans#3985
valentinewallace merged 1 commit into
lightningdevkit:mainfrom 
TheBlueMatt:2025-08-fix-comment
Conversation
@TheBlueMatt
@TheBlueMattTheBlueMatt
commented
Aug 2, 2025

Copy link


Copy Markdown

Collaborator
Before e938ed7 and 41f703c, when we had a payment preimage for a claim which needed to go to a closed channel, we'd always run the post-ChannelMonitorUpdate completion action immediately as we didn't actually track async
ChannelMonitorUpdates to closed channels. Since those commits we do, but the comment noting the completion action processing was not updated.
Thus, here we update the comment, for the easiest close on a major feature issue ever.
Fixes#2355.
@TheBlueMatt
Correct post-update action comment on claims from closed chans
a18b2c9
Before e938ed7 and
41f703c, when we had a payment
preimage for a claim which needed to go to a closed channel, we'd
always run the post-`ChannelMonitorUpdate` completion action
immediately as we didn't actually track async
`ChannelMonitorUpdate`s to closed channels. Since those commits we
do, but the comment noting the completion action processing was not
updated.
Thus, here we update the comment, for the easiest close on a major
feature issue ever.
Fixeslightningdevkit#2355.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 2, 2025•

edited

Loading

Copy link


Copy Markdown

I've assigned @valentinewallace as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Aug 2, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 88.93%. Comparing base (61e5819) to head (a18b2c9).
⚠️ Report is 12 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #3985 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.02% 
==========================================
Files 174 174 Lines 124201 124201 Branches 124201 124201 ==========================================
- Hits 110472 110459 -13 - Misses 11251 11261 +10 - Partials 2478 2481 +3 
FlagCoverage Δ
fuzzing22.63% <ø> (ø)
tests88.76% <ø> (-0.02%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 4, 2025

Copy link


Copy Markdown

🔔 1st Reminder
Hey @valentinewallace! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 5, 2025

Copy link


Copy Markdown

👋 The first review has been submitted!
Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.
@valentinewallace
valentinewallace
merged commit dc335e9
into
lightningdevkit:mainAug 5, 2025

24 of 25 checks passed

@TheBlueMattTheBlueMatt
self-assigned this
Aug 7, 2025
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@valentinewallacevalentinewallacevalentinewallace approved these changes

Assignees

@TheBlueMattTheBlueMatt

Labels


None yet


Projects

Weekly Goals

Status: No status


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Stop completing monitor udpate completion actions when claiming on a closed channel


3 participants

@TheBlueMatt@ldk-reviews-bot@valentinewallace