LSPS5 -> More follow ups

[martinsaposnic]

Addressing LSPS5 follow ups, specifically these comments #3662 and #3662

This is finished but will mark this as draft because it depends on #3969. Once that's merged I will rebase this PR and undraft it.
Commits to review here are 27e5350 and 9d975ae Done ✅

[ldk-reviews-bot]

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.93%. Comparing base (7c5491d) to head (552d8e4).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #3987 +/- ##
==========================================
- Coverage 88.98% 88.93% -0.06% 
==========================================
Files 174 174 Lines 124222 124538 +316 Branches 124222 124538 +316 ==========================================
+ Hits 110543 110760 +217 - Misses 11201 11283 +82 - Partials 2478 2495 +17 

Flag	Coverage Δ
fuzzing	22.18% <0.00%> (-0.05%)	⬇️
tests	88.76% <100.00%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tnull]

This needs a rebase.

[tankyleo]

Looks like we can remove these clones here too for consistency ?

diff --git a/lightning-liquidity/src/lsps2/msgs.rs b/lightning-liquidity/src/lsps2/msgs.rs
index 84875d4ab..22a0d8116 100644
--- a/lightning-liquidity/src/lsps2/msgs.rs+++ b/lightning-liquidity/src/lsps2/msgs.rs@@ -72,7 +72,7 @@ impl LSPS2RawOpeningFeeParams {
LSPS2OpeningFeeParams {
min_fee_msat: self.min_fee_msat,
proportional: self.proportional,
- valid_until: self.valid_until.clone(),+ valid_until: self.valid_until,
min_lifetime: self.min_lifetime,
max_client_to_self_delay: self.max_client_to_self_delay,
min_payment_size_msat: self.min_payment_size_msat,
@@ -235,7 +235,7 @@ mod tests {
let raw = LSPS2RawOpeningFeeParams {
min_fee_msat,
proportional,
- valid_until: valid_until.clone().into(),+ valid_until,
min_lifetime,
max_client_to_self_delay,
min_payment_size_msat,

[tnull]

LGTM, mod the pending comments.

[martinsaposnic]

thanks for the review @tankyleo !

I just force pushed this change:

diff --git a/lightning-liquidity/src/lsps2/msgs.rs b/lightning-liquidity/src/lsps2/msgs.rs
index 84875d4ab..8fb9536b6 100644
--- a/lightning-liquidity/src/lsps2/msgs.rs+++ b/lightning-liquidity/src/lsps2/msgs.rs@@ -72,7 +72,7 @@ impl LSPS2RawOpeningFeeParams {
LSPS2OpeningFeeParams {
min_fee_msat: self.min_fee_msat,
proportional: self.proportional,
- valid_until: self.valid_until.clone(),+ valid_until: self.valid_until,
min_lifetime: self.min_lifetime,
max_client_to_self_delay: self.max_client_to_self_delay,
min_payment_size_msat: self.min_payment_size_msat,
@@ -235,7 +235,7 @@ mod tests {
let raw = LSPS2RawOpeningFeeParams {
min_fee_msat,
proportional,
- valid_until: valid_until.clone().into(),+ valid_until: valid_until.into(),
min_lifetime,
max_client_to_self_delay,
min_payment_size_msat,

[tnull]

LGTM

Simple enough, landing this.