Skip to content

Fix windows CI - #3995

Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
martinsaposnic:fix-3990
Aug 7, 2025
Merged

Fix windows CI#3995
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
martinsaposnic:fix-3990

Conversation

@martinsaposnic

@martinsaposnicmartinsaposnic commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Fixes#3990

Use rust-lld linker for windows to fix link.exe error

@ldk-reviews-bot

ldk-reviews-bot commented Aug 7, 2025

Copy link
Copy Markdown

I've assigned @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@martinsaposnic

Copy link
Copy Markdown
ContributorAuthor

seems to be working, didn't fail at the 12min mark

@martinsaposnicmartinsaposnic changed the title Use rust-lld linker for windows to fix link.exe errorFix windows CIAug 7, 2025
@codecov

codecovBot commented Aug 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.92%. Comparing base (de2005a) to head (e1edbde).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #3995 +/- ##
==========================================
- Coverage 88.93% 88.92% -0.01% 
==========================================
Files 174 174 Lines 124539 124539 Branches 124539 124539 ==========================================
- Hits 110758 110751 -7 - Misses 11287 11289 +2 - Partials 2494 2499 +5 
FlagCoverage Δ
fuzzing22.18% <ø> (ø)
tests88.75% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@TheBlueMatt
TheBlueMatt merged commit 381416a into lightningdevkit:mainAug 7, 2025
23 of 24 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows CI failing

3 participants

@martinsaposnic@ldk-reviews-bot@TheBlueMatt