Skip to content

Signal splice prototype feature bit instead - #4156

Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
wpaulino:splice-prototype-feature-bit
Oct 10, 2025
Merged

Signal splice prototype feature bit instead#4156
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
wpaulino:splice-prototype-feature-bit

Conversation

@wpaulino

@wpaulinowpaulino commented Oct 10, 2025

Copy link
Copy Markdown
Contributor

As our splice implementation is not yet complete (missing RBF support) and we still need to do cross-compatibility testing with eclair/CLN, we signal the agreed upon prototype feature bit instead.

Fixes#4062.

@wpaulino
Signal splice prototype feature bit instead
7a53d67
As our splice implementation is not yet complete (missing RBF support)
and we still need to do cross-compatibility testing with eclair/CLN, we
signal the agreed upon prototype feature bit instead.
@wpaulinowpaulino added this to the 0.2 milestone Oct 10, 2025
@wpaulinowpaulino self-assigned this Oct 10, 2025
@ldk-reviews-bot

ldk-reviews-bot commented Oct 10, 2025•
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

TheBlueMatt
TheBlueMatt previously approved these changes Oct 10, 2025
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial enough, landing.

@ldk-reviews-bot

ldk-reviews-bot commented Oct 10, 2025

Copy link
Copy Markdown

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@TheBlueMatt

TheBlueMatt commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

Oops, ln::msgs::tests::encoding_commitment_signed needs updating for the new tlv

@wpaulino
Use proper TLV type for CommitmentSigned::funding_txid
bddd5c7
Now that we are sure we will be moving forward with the `funding_txid`
TLV, we use the TLV type as mandated per the spec.
@wpaulino
wpaulinoforce-pushed the splice-prototype-feature-bit branch from 88368df to bddd5c7CompareOctober 10, 2025 21:08
@TheBlueMatt
TheBlueMatt merged commit 21e9a9c into lightningdevkit:mainOct 10, 2025
22 checks passed
@wpaulino
wpaulino deleted the splice-prototype-feature-bit branch October 10, 2025 21:23
@codecov

codecovBot commented Oct 10, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.75%. Comparing base (fcb1164) to head (bddd5c7).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #4156 +/- ##
=======================================
Coverage 88.74% 88.75% =======================================
Files 180 180 Lines 135809 135821 +12 Branches 135809 135821 +12 =======================================
+ Hits 120523 120546 +23 + Misses 12519 12506 -13 - Partials 2767 2769 +2
FlagCoverage Δ
fuzzing21.71% <ø> (+0.01%)⬆️
tests88.59% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes

Assignees

@wpaulinowpaulino

Labels

None yet

Projects

None yet

Milestone

0.2

Development

Successfully merging this pull request may close these issues.

Use temp feature bits for splicing and 0FC

3 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt