Skip to content

Doc and comment fixes from #4167 - #4178

Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
TheBlueMatt:2025-10-upgrade-scid-timeout
Oct 28, 2025
Merged

Doc and comment fixes from #4167#4178
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
TheBlueMatt:2025-10-upgrade-scid-timeout

Conversation

@TheBlueMatt

@TheBlueMattTheBlueMatt commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

This fixes incorrect docs and comments introduced by e95ebf8 and
491b694

@TheBlueMattTheBlueMatt added this to the 0.2 milestone Oct 27, 2025
@ldk-reviews-bot

ldk-reviews-bot commented Oct 27, 2025•
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov

codecovBot commented Oct 27, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.82%. Comparing base (e457a48) to head (ab21871).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #4178 +/- ##
==========================================
+ Coverage 88.80% 88.82% +0.01% 
==========================================
Files 180 180 Lines 137262 137262 Branches 137262 137262 ==========================================
+ Hits 121901 121928 +27 + Misses 12553 12529 -24 + Partials 2808 2805 -3
FlagCoverage Δ
fuzzing21.50% <0.00%> (ø)
tests88.67% <100.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tankyleo
tankyleo reviewed Oct 27, 2025
View reviewed changes
Comment threadlightning/src/ln/chan_utils.rs Outdated
@TheBlueMatt
TheBlueMattforce-pushed the 2025-10-upgrade-scid-timeout branch from 33273b2 to a745439CompareOctober 27, 2025 19:58
@TheBlueMatt
TheBlueMatt requested review from tankyleo and removed request for wpaulinoOctober 27, 2025 19:59
tankyleo
tankyleo reviewed Oct 27, 2025
View reviewed changes
Comment threadlightning/src/util/test_channel_signer.rs Outdated
@ldk-reviews-bot

ldk-reviews-bot commented Oct 27, 2025

Copy link
Copy Markdown

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@TheBlueMatt
Doc and comment fixes fromlightningdevkit#4167
ab21871
This fixes incorrect docs and comments introduced by
e95ebf8 and
491b694
@TheBlueMatt
TheBlueMattforce-pushed the 2025-10-upgrade-scid-timeout branch from a745439 to ab21871CompareOctober 27, 2025 21:06
@TheBlueMatt

TheBlueMatt commented Oct 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

This is trivial.

@TheBlueMatt
TheBlueMatt merged commit add8241 into lightningdevkit:mainOct 28, 2025
22 of 25 checks passed
@TheBlueMattTheBlueMatt mentioned this pull request Oct 29, 2025
Merged
@TheBlueMatt

TheBlueMatt commented Oct 29, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Backported to 0.2 in #4185.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tankyleotankyleotankyleo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBlueMatt@ldk-reviews-bot@tankyleo