Skip to content

Add LDK Node integration test - #4206

Merged
tnull merged 1 commit into
lightningdevkit:mainfrom
tnull:2025-11-ldk-node-integration-test
Nov 5, 2025
Merged

Add LDK Node integration test#4206
tnull merged 1 commit into
lightningdevkit:mainfrom
tnull:2025-11-ldk-node-integration-test

Conversation

@tnull

@tnulltnull commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

We add a simple workflow to our CI that runs cargo check on LDK Node to ensure LDK didn't introduce breaking API changes.

The idea here is to catch breaking changes early, and encourage to fix them in LDK or LDK Node main ASAP.

In the future we might want to extend this to run the full test suite, once we whack-a-moled a few more of LDK Node's flaky tests.

@ldk-reviews-bot

ldk-reviews-bot commented Nov 5, 2025

Copy link
Copy Markdown

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull
tnullforce-pushed the 2025-11-ldk-node-integration-test branch 3 times, most recently from 9425d6b to 816b70eCompareNovember 5, 2025 10:49
We add a simple workflow to our CI that runs `cargo check` on LDK Node to ensure
LDK didn't introduce breaking API changes.
The idea here is to catch breaking changes early, and encourage to fix
them in LDK or LDK Node `main` ASAP.
In the future we might want to extend this to run the full test suite,
once we whack-a-moled a few more of LDK Node's flaky tests.
@tnull
tnullforce-pushed the 2025-11-ldk-node-integration-test branch from 816b70e to f50ea31CompareNovember 5, 2025 10:50

@joostjagerjoostjager left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and cool

@@ -0,0 +1,44 @@
name: LDK Node Integration Tests

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use something like "LDK Node build compatibility check" for now? Can update the name once the integration tests are actually ran.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I intentionally left it more general for now.

@codecov

codecovBot commented Nov 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.30%. Comparing base (2d6e017) to head (f50ea31).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #4206 +/- ##
=======================================
Coverage 89.29% 89.30% =======================================
Files 180 180 Lines 137913 137913 Branches 137913 137913 =======================================
+ Hits 123144 123157 +13 + Misses 12154 12147 -7 + Partials 2615 2609 -6 
FlagCoverage Δ
fuzzing33.58% <ø> (+0.90%)⬆️
tests88.69% <ø> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tnull

tnull commented Nov 5, 2025

Copy link
Copy Markdown
ContributorAuthor

Will just land this, as it's simple enough and we can make further changes.

@tnull
tnull merged commit 08c2236 into lightningdevkit:mainNov 5, 2025
24 of 26 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tnull@ldk-reviews-bot@joostjager