Skip to content

Fix build warnings under rustc 1.75.0 - #4212

Merged
tnull merged 2 commits into
lightningdevkit:mainfrom
jkczyz:2025-11-fix-warnings
Nov 7, 2025
Merged

Fix build warnings under rustc 1.75.0#4212
tnull merged 2 commits into
lightningdevkit:mainfrom
jkczyz:2025-11-fix-warnings

Conversation

@jkczyz

Copy link
Copy Markdown
Contributor

No description provided.

@ldk-reviews-bot

ldk-reviews-bot commented Nov 6, 2025

Copy link
Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@jkczyz
jkczyz requested a review from tnullNovember 6, 2025 22:44
@jkczyz

Copy link
Copy Markdown
ContributorAuthor

Locally, I see a doc test failing to compile under c_bindings, but I'm not sure how to resolve it. Using conditional code compilation doesn't seem to work.

@codecov

codecovBot commented Nov 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.31%. Comparing base (08c2236) to head (2338805).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #4212 +/- ##
==========================================
+ Coverage 89.30% 89.31% +0.01% 
==========================================
Files 180 180 Lines 137913 137913 Branches 137913 137913 ==========================================
+ Hits 123159 123174 +15 + Misses 12142 12133 -9 + Partials 2612 2606 -6 
FlagCoverage Δ
fuzzing33.60% <0.00%> (+0.09%)⬆️
tests88.71% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tnulltnull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. This was also fixed in #4175, but no reason not to already land this.

@ldk-reviews-bot

Copy link
Copy Markdown

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@tnull
tnull merged commit 95c4eaf into lightningdevkit:mainNov 7, 2025
26 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jkczyz@ldk-reviews-bot@tnull