Skip to content

Bump lightning-block-sync version number to fix SemVer CI - #4271

Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
tnull:2025-12-bump-lightning-block-sync-version
Dec 9, 2025
Merged

Bump lightning-block-sync version number to fix SemVer CI#4271
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
tnull:2025-12-bump-lightning-block-sync-version

Conversation

@tnull

@tnulltnull commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

PR #4175 made the first breaking API change in lightning-block-sync since v0.2 without bumping the version number. Here we bump the version number, allowing our SemVer CI check to be happy again.

PR lightningdevkit#4175 made the first breaking API change in `lightning-block-sync`
since v0.2 without bumping the version number. Here we bump the version
number, allowing our SemVer CI check to be happy again.
@ldk-reviews-bot

ldk-reviews-bot commented Dec 9, 2025

Copy link
Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot

Copy link
Copy Markdown

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@TheBlueMatt
TheBlueMatt merged commit e663517 into lightningdevkit:mainDec 9, 2025
18 checks passed
@codecov

codecovBot commented Dec 9, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.33%. Comparing base (75a6c5b) to head (926523d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #4271 +/- ##
=======================================
Coverage 89.33% 89.33% =======================================
Files 180 180 Lines 139302 139302 Branches 139302 139302 =======================================
+ Hits 124439 124444 +5 + Misses 12241 12231 -10 - Partials 2622 2627 +5 
FlagCoverage Δ
fuzzing35.05% <ø> (+0.01%)⬆️
tests88.67% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tnull@ldk-reviews-bot@TheBlueMatt