Skip to content

Upstream VssStoreBuilder and VssStore to lightning-persister#4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tnull wants to merge 13 commits into from
Closed

Upstream VssStoreBuilder and VssStore to lightning-persister#4323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2f2b6bd
Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`
tnull Jan 19, 2026
2827b96
f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`
tnull Mar 23, 2026
34db635
f s/ldk-node/ldk/g
tnull Mar 23, 2026
7414d20
f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`
tnull Mar 23, 2026
d861d3d
f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`
tnull Mar 23, 2026
f9a9a81
f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`
tnull Mar 23, 2026
ad76745
f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`
tnull Mar 23, 2026
ba5aea6
f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`
tnull Mar 23, 2026
6667ac1
f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`
tnull Mar 23, 2026
67b24f9
Add CI job running basic VSS tests
tnull Jan 19, 2026
9bafd93
f Add CI job running basic VSS tests
tnull Mar 23, 2026
43a38c9
f Add CI job running basic VSS tests
tnull Mar 23, 2026
9686cb9
Fix: Handle V0 empty-namespace keys consistently
tnull Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions .github/workflows/vss-tests.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
name: VSS Tests

on: [push, pull_request]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
build-and-test:
runs-on: ubuntu-latest

services:
postgres:
image: postgres:latest
ports:
- 5432:5432
env:
POSTGRES_DB: postgres
POSTGRES_USER: postgres
POSTGRES_PASSWORD: postgres
options: >-
--health-cmd pg_isready
--health-interval 10s
--health-timeout 5s
--health-retries 5

steps:
- name: Checkout code
uses: actions/checkout@v4
with:
path: rust-lightning
- name: Checkout VSS
uses: actions/checkout@v4
with:
repository: lightningdevkit/vss-server
path: vss-server

- name: Build and Deploy VSS Server
run: |
cd vss-server/rust
cargo run server/vss-server-config.toml > /tmp/vss-server.log 2>&1 &
until curl -sf http://localhost:8080/vss > /dev/null; do sleep 1; done
- name: Run VSS tests
run: |
cd rust-lightning/lightning-persister
export TEST_VSS_BASE_URL="http://localhost:8080/vss"
RUSTFLAGS="--cfg vss_test" cargo test --features vss vss_store
Comment thread
tnull marked this conversation as resolved.
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -67,4 +67,5 @@ check-cfg = [
"cfg(simple_close)",
"cfg(peer_storage)",
"cfg(tor)",
"cfg(vss_test)",
]
5 changes: 5 additions & 0 deletions lightning-persister/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,11 +17,15 @@ rustdoc-args = ["--cfg", "docsrs"]

[features]
tokio = ["dep:tokio"]
vss = ["dep:vss-client", "dep:tokio", "dep:getrandom", "dep:lightning-macros"]
Comment thread
tnull marked this conversation as resolved.

[dependencies]
bitcoin = "0.32.2"
lightning = { version = "0.3.0", path = "../lightning" }
lightning-macros = { version = "0.2.0", path = "../lightning-macros", optional = true }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }

@ldk-claude-review-botldk-claude-review-botMar 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The code uses tokio::sync::Mutex extensively (7+ call sites in vss_store.rs), but the tokio dependency only declares features = ["rt-multi-thread"]. The sync feature is required for tokio::sync::Mutex to be available.

This likely compiles today only because vss-client-ng transitively enables tokio/sync. If that crate ever changes its tokio feature requirements, this will break.

Suggested change
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread", "sync"] }

vss-client = { package = "vss-client-ng", version = "0.5", optional = true }
getrandom = { version = "0.3", optional = true }

[target.'cfg(windows)'.dependencies]
windows-sys = { version = "0.48.0", default-features = false, features = ["Win32_Storage_FileSystem", "Win32_Foundation"] }
Expand All@@ -32,6 +36,7 @@ criterion = { version = "0.4", optional = true, default-features = false }
[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
bitcoin = { version = "0.32.2", default-features = false }
rand = { version = "0.9.2", default-features = false, features = ["thread_rng"] }
tokio = { version = "1.35", default-features = false, features = ["macros"] }

[lints]
Expand Down
6 changes: 6 additions & 0 deletions lightning-persister/src/lib.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,12 @@ extern crate criterion;

pub mod fs_store;

#[cfg(feature = "vss")]
pub mod vss_store;

#[cfg(feature = "vss")]
pub use vss_client;

mod utils;

#[cfg(test)]
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister` by tnull · Pull Request #4323 · lightningdevkit/rust-lightning · GitHub
Skip to content
Upstream VssStoreBuilder and VssStore to lightning-persister#4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

tnull
wants to merge
13
commits into

from

 Closed


Upstream VssStoreBuilder and VssStore to lightning-persister#4323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
2f2b6bd

Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Jan 19, 2026
2827b96

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
34db635

f s/ldk-node/ldk/g


tnull Mar 23, 2026
7414d20

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
d861d3d

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
f9a9a81

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ad76745

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ba5aea6

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
6667ac1

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
67b24f9

Add CI job running basic VSS tests


tnull Jan 19, 2026
9bafd93

f Add CI job running basic VSS tests


tnull Mar 23, 2026
43a38c9

f Add CI job running basic VSS tests


tnull Mar 23, 2026
9686cb9

Fix: Handle V0 empty-namespace keys consistently


tnull Mar 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


48 changes: 48 additions & 0 deletions
.github/workflows/vss-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
name: VSS Tests

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.ref }}
 cancel-in-progress: true

jobs:
 build-and-test:
 runs-on: ubuntu-latest

 services:
 postgres:
 image: postgres:latest
 ports:
 - 5432:5432
 env:
 POSTGRES_DB: postgres
 POSTGRES_USER: postgres
 POSTGRES_PASSWORD: postgres
 options: >-
 --health-cmd pg_isready
 --health-interval 10s
 --health-timeout 5s
 --health-retries 5

 steps:
 - name: Checkout code
 uses: actions/checkout@v4
 with:
 path: rust-lightning
 - name: Checkout VSS
 uses: actions/checkout@v4
 with:
 repository: lightningdevkit/vss-server
 path: vss-server

 - name: Build and Deploy VSS Server
 run: |
 cd vss-server/rust
 cargo run server/vss-server-config.toml > /tmp/vss-server.log 2>&1 &
 until curl -sf http://localhost:8080/vss > /dev/null; do sleep 1; done
 - name: Run VSS tests
 run: |
 cd rust-lightning/lightning-persister
 export TEST_VSS_BASE_URL="http://localhost:8080/vss"
 RUSTFLAGS="--cfg vss_test" cargo test --features vss vss_store
Comment thread
tnull marked this conversation as resolved.


1 change: 1 addition & 0 deletions
Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,4 +67,5 @@ check-cfg = [
 "cfg(simple_close)",
 "cfg(peer_storage)",
 "cfg(tor)",
 "cfg(vss_test)",
]

5 changes: 5 additions & 0 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,11 +17,15 @@ rustdoc-args = ["--cfg", "docsrs"]

[features]
tokio = ["dep:tokio"]
vss = ["dep:vss-client", "dep:tokio", "dep:getrandom", "dep:lightning-macros"]
Comment thread
tnull marked this conversation as resolved.


[dependencies]
bitcoin = "0.32.2"
lightning = { version = "0.3.0", path = "../lightning" }
lightning-macros = { version = "0.2.0", path = "../lightning-macros", optional = true }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
@ldk-claude-review-botldk-claude-review-botMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The code uses tokio::sync::Mutex extensively (7+ call sites in vss_store.rs), but the tokio dependency only declares features = ["rt-multi-thread"]. The sync feature is required for tokio::sync::Mutex to be available.
This likely compiles today only because vss-client-ng transitively enables tokio/sync. If that crate ever changes its tokio feature requirements, this will break.

Suggested change

tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread", "sync"] }
vss-client = { package = "vss-client-ng", version = "0.5", optional = true }
getrandom = { version = "0.3", optional = true }

[target.'cfg(windows)'.dependencies]
windows-sys = { version = "0.48.0", default-features = false, features = ["Win32_Storage_FileSystem", "Win32_Foundation"] }
Expand All@@ -32,6 +36,7 @@ criterion = { version = "0.4", optional = true, default-features = false }
[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
bitcoin = { version = "0.32.2", default-features = false }
rand = { version = "0.9.2", default-features = false, features = ["thread_rng"] }
tokio = { version = "1.35", default-features = false, features = ["macros"] }

[lints]
Expand Down

6 changes: 6 additions & 0 deletions
lightning-persister/src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,12 @@ extern crate criterion;

pub mod fs_store;

#[cfg(feature = "vss")]
pub mod vss_store;

#[cfg(feature = "vss")]
pub use vss_client;

mod utils;

#[cfg(test)]
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister` by tnull · Pull Request #4323 · lightningdevkit/rust-lightning · GitHub
Skip to content
Upstream VssStoreBuilder and VssStore to lightning-persister#4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

tnull
wants to merge
13
commits into

from

 Closed


Upstream VssStoreBuilder and VssStore to lightning-persister#4323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
2f2b6bd

Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Jan 19, 2026
2827b96

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
34db635

f s/ldk-node/ldk/g


tnull Mar 23, 2026
7414d20

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
d861d3d

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
f9a9a81

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ad76745

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ba5aea6

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
6667ac1

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
67b24f9

Add CI job running basic VSS tests


tnull Jan 19, 2026
9bafd93

f Add CI job running basic VSS tests


tnull Mar 23, 2026
43a38c9

f Add CI job running basic VSS tests


tnull Mar 23, 2026
9686cb9

Fix: Handle V0 empty-namespace keys consistently


tnull Mar 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


48 changes: 48 additions & 0 deletions
.github/workflows/vss-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
name: VSS Tests

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.ref }}
 cancel-in-progress: true

jobs:
 build-and-test:
 runs-on: ubuntu-latest

 services:
 postgres:
 image: postgres:latest
 ports:
 - 5432:5432
 env:
 POSTGRES_DB: postgres
 POSTGRES_USER: postgres
 POSTGRES_PASSWORD: postgres
 options: >-
 --health-cmd pg_isready
 --health-interval 10s
 --health-timeout 5s
 --health-retries 5

 steps:
 - name: Checkout code
 uses: actions/checkout@v4
 with:
 path: rust-lightning
 - name: Checkout VSS
 uses: actions/checkout@v4
 with:
 repository: lightningdevkit/vss-server
 path: vss-server

 - name: Build and Deploy VSS Server
 run: |
 cd vss-server/rust
 cargo run server/vss-server-config.toml > /tmp/vss-server.log 2>&1 &
 until curl -sf http://localhost:8080/vss > /dev/null; do sleep 1; done
 - name: Run VSS tests
 run: |
 cd rust-lightning/lightning-persister
 export TEST_VSS_BASE_URL="http://localhost:8080/vss"
 RUSTFLAGS="--cfg vss_test" cargo test --features vss vss_store
Comment thread
tnull marked this conversation as resolved.


1 change: 1 addition & 0 deletions
Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,4 +67,5 @@ check-cfg = [
 "cfg(simple_close)",
 "cfg(peer_storage)",
 "cfg(tor)",
 "cfg(vss_test)",
]

5 changes: 5 additions & 0 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,11 +17,15 @@ rustdoc-args = ["--cfg", "docsrs"]

[features]
tokio = ["dep:tokio"]
vss = ["dep:vss-client", "dep:tokio", "dep:getrandom", "dep:lightning-macros"]
Comment thread
tnull marked this conversation as resolved.


[dependencies]
bitcoin = "0.32.2"
lightning = { version = "0.3.0", path = "../lightning" }
lightning-macros = { version = "0.2.0", path = "../lightning-macros", optional = true }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
@ldk-claude-review-botldk-claude-review-botMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The code uses tokio::sync::Mutex extensively (7+ call sites in vss_store.rs), but the tokio dependency only declares features = ["rt-multi-thread"]. The sync feature is required for tokio::sync::Mutex to be available.
This likely compiles today only because vss-client-ng transitively enables tokio/sync. If that crate ever changes its tokio feature requirements, this will break.

Suggested change

tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread", "sync"] }
vss-client = { package = "vss-client-ng", version = "0.5", optional = true }
getrandom = { version = "0.3", optional = true }

[target.'cfg(windows)'.dependencies]
windows-sys = { version = "0.48.0", default-features = false, features = ["Win32_Storage_FileSystem", "Win32_Foundation"] }
Expand All@@ -32,6 +36,7 @@ criterion = { version = "0.4", optional = true, default-features = false }
[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
bitcoin = { version = "0.32.2", default-features = false }
rand = { version = "0.9.2", default-features = false, features = ["thread_rng"] }
tokio = { version = "1.35", default-features = false, features = ["macros"] }

[lints]
Expand Down

6 changes: 6 additions & 0 deletions
lightning-persister/src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,12 @@ extern crate criterion;

pub mod fs_store;

#[cfg(feature = "vss")]
pub mod vss_store;

#[cfg(feature = "vss")]
pub use vss_client;

mod utils;

#[cfg(test)]
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister` by tnull · Pull Request #4323 · lightningdevkit/rust-lightning · GitHub
Skip to content
Upstream VssStoreBuilder and VssStore to lightning-persister#4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

tnull
wants to merge
13
commits into

from

 Closed


Upstream VssStoreBuilder and VssStore to lightning-persister#4323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
2f2b6bd

Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Jan 19, 2026
2827b96

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
34db635

f s/ldk-node/ldk/g


tnull Mar 23, 2026
7414d20

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
d861d3d

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
f9a9a81

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ad76745

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ba5aea6

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
6667ac1

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
67b24f9

Add CI job running basic VSS tests


tnull Jan 19, 2026
9bafd93

f Add CI job running basic VSS tests


tnull Mar 23, 2026
43a38c9

f Add CI job running basic VSS tests


tnull Mar 23, 2026
9686cb9

Fix: Handle V0 empty-namespace keys consistently


tnull Mar 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


48 changes: 48 additions & 0 deletions
.github/workflows/vss-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
name: VSS Tests

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.ref }}
 cancel-in-progress: true

jobs:
 build-and-test:
 runs-on: ubuntu-latest

 services:
 postgres:
 image: postgres:latest
 ports:
 - 5432:5432
 env:
 POSTGRES_DB: postgres
 POSTGRES_USER: postgres
 POSTGRES_PASSWORD: postgres
 options: >-
 --health-cmd pg_isready
 --health-interval 10s
 --health-timeout 5s
 --health-retries 5

 steps:
 - name: Checkout code
 uses: actions/checkout@v4
 with:
 path: rust-lightning
 - name: Checkout VSS
 uses: actions/checkout@v4
 with:
 repository: lightningdevkit/vss-server
 path: vss-server

 - name: Build and Deploy VSS Server
 run: |
 cd vss-server/rust
 cargo run server/vss-server-config.toml > /tmp/vss-server.log 2>&1 &
 until curl -sf http://localhost:8080/vss > /dev/null; do sleep 1; done
 - name: Run VSS tests
 run: |
 cd rust-lightning/lightning-persister
 export TEST_VSS_BASE_URL="http://localhost:8080/vss"
 RUSTFLAGS="--cfg vss_test" cargo test --features vss vss_store
Comment thread
tnull marked this conversation as resolved.


1 change: 1 addition & 0 deletions
Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,4 +67,5 @@ check-cfg = [
 "cfg(simple_close)",
 "cfg(peer_storage)",
 "cfg(tor)",
 "cfg(vss_test)",
]

5 changes: 5 additions & 0 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,11 +17,15 @@ rustdoc-args = ["--cfg", "docsrs"]

[features]
tokio = ["dep:tokio"]
vss = ["dep:vss-client", "dep:tokio", "dep:getrandom", "dep:lightning-macros"]
Comment thread
tnull marked this conversation as resolved.


[dependencies]
bitcoin = "0.32.2"
lightning = { version = "0.3.0", path = "../lightning" }
lightning-macros = { version = "0.2.0", path = "../lightning-macros", optional = true }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
@ldk-claude-review-botldk-claude-review-botMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The code uses tokio::sync::Mutex extensively (7+ call sites in vss_store.rs), but the tokio dependency only declares features = ["rt-multi-thread"]. The sync feature is required for tokio::sync::Mutex to be available.
This likely compiles today only because vss-client-ng transitively enables tokio/sync. If that crate ever changes its tokio feature requirements, this will break.

Suggested change

tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread", "sync"] }
vss-client = { package = "vss-client-ng", version = "0.5", optional = true }
getrandom = { version = "0.3", optional = true }

[target.'cfg(windows)'.dependencies]
windows-sys = { version = "0.48.0", default-features = false, features = ["Win32_Storage_FileSystem", "Win32_Foundation"] }
Expand All@@ -32,6 +36,7 @@ criterion = { version = "0.4", optional = true, default-features = false }
[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
bitcoin = { version = "0.32.2", default-features = false }
rand = { version = "0.9.2", default-features = false, features = ["thread_rng"] }
tokio = { version = "1.35", default-features = false, features = ["macros"] }

[lints]
Expand Down

6 changes: 6 additions & 0 deletions
lightning-persister/src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,12 @@ extern crate criterion;

pub mod fs_store;

#[cfg(feature = "vss")]
pub mod vss_store;

#[cfg(feature = "vss")]
pub use vss_client;

mod utils;

#[cfg(test)]
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister` by tnull · Pull Request #4323 · lightningdevkit/rust-lightning · GitHub
Skip to content
Upstream VssStoreBuilder and VssStore to lightning-persister#4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

tnull
wants to merge
13
commits into

from

 Closed


Upstream VssStoreBuilder and VssStore to lightning-persister#4323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
2f2b6bd

Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Jan 19, 2026
2827b96

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
34db635

f s/ldk-node/ldk/g


tnull Mar 23, 2026
7414d20

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
d861d3d

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
f9a9a81

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ad76745

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ba5aea6

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
6667ac1

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
67b24f9

Add CI job running basic VSS tests


tnull Jan 19, 2026
9bafd93

f Add CI job running basic VSS tests


tnull Mar 23, 2026
43a38c9

f Add CI job running basic VSS tests


tnull Mar 23, 2026
9686cb9

Fix: Handle V0 empty-namespace keys consistently


tnull Mar 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


48 changes: 48 additions & 0 deletions
.github/workflows/vss-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
name: VSS Tests

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.ref }}
 cancel-in-progress: true

jobs:
 build-and-test:
 runs-on: ubuntu-latest

 services:
 postgres:
 image: postgres:latest
 ports:
 - 5432:5432
 env:
 POSTGRES_DB: postgres
 POSTGRES_USER: postgres
 POSTGRES_PASSWORD: postgres
 options: >-
 --health-cmd pg_isready
 --health-interval 10s
 --health-timeout 5s
 --health-retries 5

 steps:
 - name: Checkout code
 uses: actions/checkout@v4
 with:
 path: rust-lightning
 - name: Checkout VSS
 uses: actions/checkout@v4
 with:
 repository: lightningdevkit/vss-server
 path: vss-server

 - name: Build and Deploy VSS Server
 run: |
 cd vss-server/rust
 cargo run server/vss-server-config.toml > /tmp/vss-server.log 2>&1 &
 until curl -sf http://localhost:8080/vss > /dev/null; do sleep 1; done
 - name: Run VSS tests
 run: |
 cd rust-lightning/lightning-persister
 export TEST_VSS_BASE_URL="http://localhost:8080/vss"
 RUSTFLAGS="--cfg vss_test" cargo test --features vss vss_store
Comment thread
tnull marked this conversation as resolved.


1 change: 1 addition & 0 deletions
Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,4 +67,5 @@ check-cfg = [
 "cfg(simple_close)",
 "cfg(peer_storage)",
 "cfg(tor)",
 "cfg(vss_test)",
]

5 changes: 5 additions & 0 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,11 +17,15 @@ rustdoc-args = ["--cfg", "docsrs"]

[features]
tokio = ["dep:tokio"]
vss = ["dep:vss-client", "dep:tokio", "dep:getrandom", "dep:lightning-macros"]
Comment thread
tnull marked this conversation as resolved.


[dependencies]
bitcoin = "0.32.2"
lightning = { version = "0.3.0", path = "../lightning" }
lightning-macros = { version = "0.2.0", path = "../lightning-macros", optional = true }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
@ldk-claude-review-botldk-claude-review-botMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The code uses tokio::sync::Mutex extensively (7+ call sites in vss_store.rs), but the tokio dependency only declares features = ["rt-multi-thread"]. The sync feature is required for tokio::sync::Mutex to be available.
This likely compiles today only because vss-client-ng transitively enables tokio/sync. If that crate ever changes its tokio feature requirements, this will break.

Suggested change

tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread", "sync"] }
vss-client = { package = "vss-client-ng", version = "0.5", optional = true }
getrandom = { version = "0.3", optional = true }

[target.'cfg(windows)'.dependencies]
windows-sys = { version = "0.48.0", default-features = false, features = ["Win32_Storage_FileSystem", "Win32_Foundation"] }
Expand All@@ -32,6 +36,7 @@ criterion = { version = "0.4", optional = true, default-features = false }
[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
bitcoin = { version = "0.32.2", default-features = false }
rand = { version = "0.9.2", default-features = false, features = ["thread_rng"] }
tokio = { version = "1.35", default-features = false, features = ["macros"] }

[lints]
Expand Down

6 changes: 6 additions & 0 deletions
lightning-persister/src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,12 @@ extern crate criterion;

pub mod fs_store;

#[cfg(feature = "vss")]
pub mod vss_store;

#[cfg(feature = "vss")]
pub use vss_client;

mod utils;

#[cfg(test)]
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister` by tnull · Pull Request #4323 · lightningdevkit/rust-lightning · GitHub
Skip to content
Upstream VssStoreBuilder and VssStore to lightning-persister#4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

tnull
wants to merge
13
commits into

from

 Closed


Upstream VssStoreBuilder and VssStore to lightning-persister#4323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
2f2b6bd

Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Jan 19, 2026
2827b96

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
34db635

f s/ldk-node/ldk/g


tnull Mar 23, 2026
7414d20

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
d861d3d

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
f9a9a81

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ad76745

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ba5aea6

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
6667ac1

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
67b24f9

Add CI job running basic VSS tests


tnull Jan 19, 2026
9bafd93

f Add CI job running basic VSS tests


tnull Mar 23, 2026
43a38c9

f Add CI job running basic VSS tests


tnull Mar 23, 2026
9686cb9

Fix: Handle V0 empty-namespace keys consistently


tnull Mar 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


48 changes: 48 additions & 0 deletions
.github/workflows/vss-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
name: VSS Tests

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.ref }}
 cancel-in-progress: true

jobs:
 build-and-test:
 runs-on: ubuntu-latest

 services:
 postgres:
 image: postgres:latest
 ports:
 - 5432:5432
 env:
 POSTGRES_DB: postgres
 POSTGRES_USER: postgres
 POSTGRES_PASSWORD: postgres
 options: >-
 --health-cmd pg_isready
 --health-interval 10s
 --health-timeout 5s
 --health-retries 5

 steps:
 - name: Checkout code
 uses: actions/checkout@v4
 with:
 path: rust-lightning
 - name: Checkout VSS
 uses: actions/checkout@v4
 with:
 repository: lightningdevkit/vss-server
 path: vss-server

 - name: Build and Deploy VSS Server
 run: |
 cd vss-server/rust
 cargo run server/vss-server-config.toml > /tmp/vss-server.log 2>&1 &
 until curl -sf http://localhost:8080/vss > /dev/null; do sleep 1; done
 - name: Run VSS tests
 run: |
 cd rust-lightning/lightning-persister
 export TEST_VSS_BASE_URL="http://localhost:8080/vss"
 RUSTFLAGS="--cfg vss_test" cargo test --features vss vss_store
Comment thread
tnull marked this conversation as resolved.


1 change: 1 addition & 0 deletions
Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,4 +67,5 @@ check-cfg = [
 "cfg(simple_close)",
 "cfg(peer_storage)",
 "cfg(tor)",
 "cfg(vss_test)",
]

5 changes: 5 additions & 0 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,11 +17,15 @@ rustdoc-args = ["--cfg", "docsrs"]

[features]
tokio = ["dep:tokio"]
vss = ["dep:vss-client", "dep:tokio", "dep:getrandom", "dep:lightning-macros"]
Comment thread
tnull marked this conversation as resolved.


[dependencies]
bitcoin = "0.32.2"
lightning = { version = "0.3.0", path = "../lightning" }
lightning-macros = { version = "0.2.0", path = "../lightning-macros", optional = true }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
@ldk-claude-review-botldk-claude-review-botMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The code uses tokio::sync::Mutex extensively (7+ call sites in vss_store.rs), but the tokio dependency only declares features = ["rt-multi-thread"]. The sync feature is required for tokio::sync::Mutex to be available.
This likely compiles today only because vss-client-ng transitively enables tokio/sync. If that crate ever changes its tokio feature requirements, this will break.

Suggested change

tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread", "sync"] }
vss-client = { package = "vss-client-ng", version = "0.5", optional = true }
getrandom = { version = "0.3", optional = true }

[target.'cfg(windows)'.dependencies]
windows-sys = { version = "0.48.0", default-features = false, features = ["Win32_Storage_FileSystem", "Win32_Foundation"] }
Expand All@@ -32,6 +36,7 @@ criterion = { version = "0.4", optional = true, default-features = false }
[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
bitcoin = { version = "0.32.2", default-features = false }
rand = { version = "0.9.2", default-features = false, features = ["thread_rng"] }
tokio = { version = "1.35", default-features = false, features = ["macros"] }

[lints]
Expand Down

6 changes: 6 additions & 0 deletions
lightning-persister/src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,12 @@ extern crate criterion;

pub mod fs_store;

#[cfg(feature = "vss")]
pub mod vss_store;

#[cfg(feature = "vss")]
pub use vss_client;

mod utils;

#[cfg(test)]
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister` by tnull · Pull Request #4323 · lightningdevkit/rust-lightning · GitHub
Skip to content
Upstream VssStoreBuilder and VssStore to lightning-persister#4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

tnull
wants to merge
13
commits into

from

 Closed


Upstream VssStoreBuilder and VssStore to lightning-persister#4323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
2f2b6bd

Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Jan 19, 2026
2827b96

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
34db635

f s/ldk-node/ldk/g


tnull Mar 23, 2026
7414d20

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
d861d3d

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
f9a9a81

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ad76745

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ba5aea6

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
6667ac1

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
67b24f9

Add CI job running basic VSS tests


tnull Jan 19, 2026
9bafd93

f Add CI job running basic VSS tests


tnull Mar 23, 2026
43a38c9

f Add CI job running basic VSS tests


tnull Mar 23, 2026
9686cb9

Fix: Handle V0 empty-namespace keys consistently


tnull Mar 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


48 changes: 48 additions & 0 deletions
.github/workflows/vss-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
name: VSS Tests

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.ref }}
 cancel-in-progress: true

jobs:
 build-and-test:
 runs-on: ubuntu-latest

 services:
 postgres:
 image: postgres:latest
 ports:
 - 5432:5432
 env:
 POSTGRES_DB: postgres
 POSTGRES_USER: postgres
 POSTGRES_PASSWORD: postgres
 options: >-
 --health-cmd pg_isready
 --health-interval 10s
 --health-timeout 5s
 --health-retries 5

 steps:
 - name: Checkout code
 uses: actions/checkout@v4
 with:
 path: rust-lightning
 - name: Checkout VSS
 uses: actions/checkout@v4
 with:
 repository: lightningdevkit/vss-server
 path: vss-server

 - name: Build and Deploy VSS Server
 run: |
 cd vss-server/rust
 cargo run server/vss-server-config.toml > /tmp/vss-server.log 2>&1 &
 until curl -sf http://localhost:8080/vss > /dev/null; do sleep 1; done
 - name: Run VSS tests
 run: |
 cd rust-lightning/lightning-persister
 export TEST_VSS_BASE_URL="http://localhost:8080/vss"
 RUSTFLAGS="--cfg vss_test" cargo test --features vss vss_store
Comment thread
tnull marked this conversation as resolved.


1 change: 1 addition & 0 deletions
Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,4 +67,5 @@ check-cfg = [
 "cfg(simple_close)",
 "cfg(peer_storage)",
 "cfg(tor)",
 "cfg(vss_test)",
]

5 changes: 5 additions & 0 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,11 +17,15 @@ rustdoc-args = ["--cfg", "docsrs"]

[features]
tokio = ["dep:tokio"]
vss = ["dep:vss-client", "dep:tokio", "dep:getrandom", "dep:lightning-macros"]
Comment thread
tnull marked this conversation as resolved.


[dependencies]
bitcoin = "0.32.2"
lightning = { version = "0.3.0", path = "../lightning" }
lightning-macros = { version = "0.2.0", path = "../lightning-macros", optional = true }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
@ldk-claude-review-botldk-claude-review-botMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The code uses tokio::sync::Mutex extensively (7+ call sites in vss_store.rs), but the tokio dependency only declares features = ["rt-multi-thread"]. The sync feature is required for tokio::sync::Mutex to be available.
This likely compiles today only because vss-client-ng transitively enables tokio/sync. If that crate ever changes its tokio feature requirements, this will break.

Suggested change

tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread", "sync"] }
vss-client = { package = "vss-client-ng", version = "0.5", optional = true }
getrandom = { version = "0.3", optional = true }

[target.'cfg(windows)'.dependencies]
windows-sys = { version = "0.48.0", default-features = false, features = ["Win32_Storage_FileSystem", "Win32_Foundation"] }
Expand All@@ -32,6 +36,7 @@ criterion = { version = "0.4", optional = true, default-features = false }
[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
bitcoin = { version = "0.32.2", default-features = false }
rand = { version = "0.9.2", default-features = false, features = ["thread_rng"] }
tokio = { version = "1.35", default-features = false, features = ["macros"] }

[lints]
Expand Down

6 changes: 6 additions & 0 deletions
lightning-persister/src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,12 @@ extern crate criterion;

pub mod fs_store;

#[cfg(feature = "vss")]
pub mod vss_store;

#[cfg(feature = "vss")]
pub use vss_client;

mod utils;

#[cfg(test)]
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister` by tnull · Pull Request #4323 · lightningdevkit/rust-lightning · GitHub
Skip to content
Upstream VssStoreBuilder and VssStore to lightning-persister#4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

tnull
wants to merge
13
commits into

from

 Closed


Upstream VssStoreBuilder and VssStore to lightning-persister#4323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
2f2b6bd

Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Jan 19, 2026
2827b96

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
34db635

f s/ldk-node/ldk/g


tnull Mar 23, 2026
7414d20

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
d861d3d

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
f9a9a81

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ad76745

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
ba5aea6

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
6667ac1

f Upstream `VssStoreBuilder` and `VssStore` to `lightning-persister`


tnull Mar 23, 2026
67b24f9

Add CI job running basic VSS tests


tnull Jan 19, 2026
9bafd93

f Add CI job running basic VSS tests


tnull Mar 23, 2026
43a38c9

f Add CI job running basic VSS tests


tnull Mar 23, 2026
9686cb9

Fix: Handle V0 empty-namespace keys consistently


tnull Mar 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


48 changes: 48 additions & 0 deletions
.github/workflows/vss-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
name: VSS Tests

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.ref }}
 cancel-in-progress: true

jobs:
 build-and-test:
 runs-on: ubuntu-latest

 services:
 postgres:
 image: postgres:latest
 ports:
 - 5432:5432
 env:
 POSTGRES_DB: postgres
 POSTGRES_USER: postgres
 POSTGRES_PASSWORD: postgres
 options: >-
 --health-cmd pg_isready
 --health-interval 10s
 --health-timeout 5s
 --health-retries 5

 steps:
 - name: Checkout code
 uses: actions/checkout@v4
 with:
 path: rust-lightning
 - name: Checkout VSS
 uses: actions/checkout@v4
 with:
 repository: lightningdevkit/vss-server
 path: vss-server

 - name: Build and Deploy VSS Server
 run: |
 cd vss-server/rust
 cargo run server/vss-server-config.toml > /tmp/vss-server.log 2>&1 &
 until curl -sf http://localhost:8080/vss > /dev/null; do sleep 1; done
 - name: Run VSS tests
 run: |
 cd rust-lightning/lightning-persister
 export TEST_VSS_BASE_URL="http://localhost:8080/vss"
 RUSTFLAGS="--cfg vss_test" cargo test --features vss vss_store
Comment thread
tnull marked this conversation as resolved.


1 change: 1 addition & 0 deletions
Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,4 +67,5 @@ check-cfg = [
 "cfg(simple_close)",
 "cfg(peer_storage)",
 "cfg(tor)",
 "cfg(vss_test)",
]

5 changes: 5 additions & 0 deletions
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,11 +17,15 @@ rustdoc-args = ["--cfg", "docsrs"]

[features]
tokio = ["dep:tokio"]
vss = ["dep:vss-client", "dep:tokio", "dep:getrandom", "dep:lightning-macros"]
Comment thread
tnull marked this conversation as resolved.


[dependencies]
bitcoin = "0.32.2"
lightning = { version = "0.3.0", path = "../lightning" }
lightning-macros = { version = "0.2.0", path = "../lightning-macros", optional = true }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
@ldk-claude-review-botldk-claude-review-botMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The code uses tokio::sync::Mutex extensively (7+ call sites in vss_store.rs), but the tokio dependency only declares features = ["rt-multi-thread"]. The sync feature is required for tokio::sync::Mutex to be available.
This likely compiles today only because vss-client-ng transitively enables tokio/sync. If that crate ever changes its tokio feature requirements, this will break.

Suggested change

tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] }
tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread", "sync"] }
vss-client = { package = "vss-client-ng", version = "0.5", optional = true }
getrandom = { version = "0.3", optional = true }

[target.'cfg(windows)'.dependencies]
windows-sys = { version = "0.48.0", default-features = false, features = ["Win32_Storage_FileSystem", "Win32_Foundation"] }
Expand All@@ -32,6 +36,7 @@ criterion = { version = "0.4", optional = true, default-features = false }
[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
bitcoin = { version = "0.32.2", default-features = false }
rand = { version = "0.9.2", default-features = false, features = ["thread_rng"] }
tokio = { version = "1.35", default-features = false, features = ["macros"] }

[lints]
Expand Down

6 changes: 6 additions & 0 deletions
lightning-persister/src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,12 @@ extern crate criterion;

pub mod fs_store;

#[cfg(feature = "vss")]
pub mod vss_store;

#[cfg(feature = "vss")]
pub use vss_client;

mod utils;

#[cfg(test)]
Expand Down
Loading
Loading