Skip to content

Support async signing of interactive-tx initial commitment signatures - #4355

Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
wpaulino:splice-async-signing
Feb 6, 2026
Merged

Support async signing of interactive-tx initial commitment signatures#4355
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
wpaulino:splice-async-signing

Conversation

@wpaulino

@wpaulinowpaulino commented Jan 28, 2026

Copy link
Copy Markdown
Contributor
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.

Depends on #4336.

@wpaulinowpaulino added this to the 0.3 milestone Jan 28, 2026
@wpaulinowpaulino self-assigned this Jan 28, 2026
@ldk-reviews-bot

ldk-reviews-bot commented Jan 28, 2026•
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov

codecovBot commented Jan 28, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.27451% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.03%. Comparing base (dde2c82) to head (ee74209).
⚠️ Report is 13 commits behind head on main.

Files with missing linesPatch %Lines
lightning/src/ln/channel.rs83.33%11 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #4355 +/- ##
==========================================
+ Coverage 86.00% 86.03% +0.02% 
==========================================
Files 156 156 Lines 102857 102909 +52 Branches 102857 102909 +52 ==========================================
+ Hits 88465 88538 +73 + Misses 11883 11865 -18 + Partials 2509 2506 -3
FlagCoverage Δ
tests86.03% <86.27%> (+0.02%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TheBlueMatt
TheBlueMatt previously approved these changes Jan 28, 2026
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Easy enough. We should ask claude to add async signing to the chanmon_consistency fuzzer as a followup.

This was linked to issues Jan 29, 2026
async signing completion #3489
Closed
Async + Fallible Signing #2088
Closed
@TheBlueMatt

TheBlueMatt commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Marked this as fixing #3489 and #2088 though we should probably see if we need to address #3109 (review) as well.

@wpaulino

wpaulino commented Jan 29, 2026

Copy link
Copy Markdown
ContributorAuthor

Marked this as fixing #3489 and #2088

There's one more case for dual-funding that still needs to be addressed -- the first_per_commitment_point in open_channel2.

@TheBlueMatt

TheBlueMatt commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Sure but we don't actually do dual-funding yet, so that's just a part of doing dual-funding now :)

@wpaulino
wpaulinoforce-pushed the splice-async-signing branch from 9933019 to eb9fc0cCompareJanuary 30, 2026 03:32
@ldk-reviews-bot

ldk-reviews-bot commented Jan 31, 2026

Copy link
Copy Markdown

🔔 1st Reminder

Hey @jkczyz! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Feb 2, 2026

Copy link
Copy Markdown

🔔 2nd Reminder

Hey @jkczyz! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Feb 4, 2026

Copy link
Copy Markdown

🔔 3rd Reminder

Hey @jkczyz! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

jkczyz
jkczyz reviewed Feb 5, 2026
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/ln/channel.rs Outdated
Comment threadlightning/src/ln/channel.rs Outdated
Comment threadlightning/src/ln/channelmanager.rs
@wpaulino
wpaulinoforce-pushed the splice-async-signing branch from eb9fc0c to 252545cCompareFebruary 5, 2026 17:57
@wpaulino
Support async signing of interactive-tx initial commitment signatures
ee74209
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.
@wpaulino
wpaulinoforce-pushed the splice-async-signing branch from 252545c to ee74209CompareFebruary 5, 2026 18:01
@wpaulino

wpaulino commented Feb 5, 2026

Copy link
Copy Markdown
ContributorAuthor

Had to rebase due to small conflict after #4311

@wpaulino
wpaulino requested a review from jkczyzFebruary 5, 2026 18:02
@TheBlueMatt
TheBlueMatt merged commit 372ba65 into lightningdevkit:mainFeb 6, 2026
19 checks passed
@wpaulino
wpaulino deleted the splice-async-signing branch February 6, 2026 16:45
@jkczyzjkczyz mentioned this pull request Mar 19, 2026
Open
50 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@wpaulinowpaulino

Labels

None yet

Projects

Weekly Goals
Status: Done

Milestone

0.3

Development

Successfully merging this pull request may close these issues.

async signing completion Async + Fallible Signing

4 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt@jkczyz
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Support async signing of interactive-tx initial commitment signatures by wpaulino · Pull Request #4355 · lightningdevkit/rust-lightning · GitHub
Skip to content
Support async signing of interactive-tx initial commitment signatures - #4355
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Feb 6, 2026
Merged
Support async signing of interactive-tx initial commitment signatures#4355
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Conversation
@wpaulino
@wpaulinowpaulino
commented
Jan 28, 2026

Copy link


Copy Markdown

Contributor
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.

Depends on #4336.
@wpaulinowpaulino
added this to the 0.3 milestone
Jan 28, 2026
@wpaulinowpaulino
self-assigned this
Jan 28, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 86.27451% with 14 lines in your changes missing coverage. Please review.

✅ Project coverage is 86.03%. Comparing base (dde2c82) to head (ee74209).
⚠️ Report is 13 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/ln/channel.rs83.33%11 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #4355 +/- ##
==========================================
+ Coverage 86.00% 86.03% +0.02% 
==========================================
Files 156 156 Lines 102857 102909 +52 Branches 102857 102909 +52 ==========================================
+ Hits 88465 88538 +73 + Misses 11883 11865 -18 + Partials 2509 2506 -3 
FlagCoverage Δ
tests86.03% <86.27%> (+0.02%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 28, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Easy enough. We should ask claude to add async signing to the chanmon_consistency fuzzer as a followup.

This was
linked to
issues
Jan 29, 2026

async signing completion
#3489

Closed


Async + Fallible Signing #2088

Closed

@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Marked this as fixing #3489 and #2088 though we should probably see if we need to address #3109 (review) as well.
@wpaulino
wpaulino
commented
Jan 29, 2026

Copy link


Copy Markdown

ContributorAuthor
Marked this as fixing #3489 and #2088
There's one more case for dual-funding that still needs to be addressed -- the first_per_commitment_point in open_channel2.
@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Sure but we don't actually do dual-funding yet, so that's just a part of doing dual-funding now :)
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
9933019 to
eb9fc0cCompareJanuary 30, 2026 03:32
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 31, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 2, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 4, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
jkczyz
jkczyz
reviewed
Feb 5, 2026
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channelmanager.rs
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
eb9fc0c to
252545cCompareFebruary 5, 2026 17:57
@wpaulino
Support async signing of interactive-tx initial commitment signatures
ee74209
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
252545c to
ee74209CompareFebruary 5, 2026 18:01
@wpaulino
wpaulino
commented
Feb 5, 2026

Copy link


Copy Markdown

ContributorAuthor
Had to rebase due to small conflict after #4311
@wpaulino
wpaulino
requested a review
from jkczyzFebruary 5, 2026 18:02
@TheBlueMatt
TheBlueMatt
merged commit 372ba65
into
lightningdevkit:mainFeb 6, 2026

19 checks passed

@wpaulino
wpaulino
deleted the

splice-async-signing

branch
February 6, 2026 16:45
@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

async signing completion

Async + Fallible Signing 

4 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support async signing of interactive-tx initial commitment signatures by wpaulino · Pull Request #4355 · lightningdevkit/rust-lightning · GitHub
Skip to content
Support async signing of interactive-tx initial commitment signatures - #4355
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Feb 6, 2026
Merged
Support async signing of interactive-tx initial commitment signatures#4355
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Conversation
@wpaulino
@wpaulinowpaulino
commented
Jan 28, 2026

Copy link


Copy Markdown

Contributor
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.

Depends on #4336.
@wpaulinowpaulino
added this to the 0.3 milestone
Jan 28, 2026
@wpaulinowpaulino
self-assigned this
Jan 28, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 86.27451% with 14 lines in your changes missing coverage. Please review.

✅ Project coverage is 86.03%. Comparing base (dde2c82) to head (ee74209).
⚠️ Report is 13 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/ln/channel.rs83.33%11 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #4355 +/- ##
==========================================
+ Coverage 86.00% 86.03% +0.02% 
==========================================
Files 156 156 Lines 102857 102909 +52 Branches 102857 102909 +52 ==========================================
+ Hits 88465 88538 +73 + Misses 11883 11865 -18 + Partials 2509 2506 -3 
FlagCoverage Δ
tests86.03% <86.27%> (+0.02%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 28, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Easy enough. We should ask claude to add async signing to the chanmon_consistency fuzzer as a followup.

This was
linked to
issues
Jan 29, 2026

async signing completion
#3489

Closed


Async + Fallible Signing #2088

Closed

@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Marked this as fixing #3489 and #2088 though we should probably see if we need to address #3109 (review) as well.
@wpaulino
wpaulino
commented
Jan 29, 2026

Copy link


Copy Markdown

ContributorAuthor
Marked this as fixing #3489 and #2088
There's one more case for dual-funding that still needs to be addressed -- the first_per_commitment_point in open_channel2.
@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Sure but we don't actually do dual-funding yet, so that's just a part of doing dual-funding now :)
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
9933019 to
eb9fc0cCompareJanuary 30, 2026 03:32
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 31, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 2, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 4, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
jkczyz
jkczyz
reviewed
Feb 5, 2026
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channelmanager.rs
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
eb9fc0c to
252545cCompareFebruary 5, 2026 17:57
@wpaulino
Support async signing of interactive-tx initial commitment signatures
ee74209
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
252545c to
ee74209CompareFebruary 5, 2026 18:01
@wpaulino
wpaulino
commented
Feb 5, 2026

Copy link


Copy Markdown

ContributorAuthor
Had to rebase due to small conflict after #4311
@wpaulino
wpaulino
requested a review
from jkczyzFebruary 5, 2026 18:02
@TheBlueMatt
TheBlueMatt
merged commit 372ba65
into
lightningdevkit:mainFeb 6, 2026

19 checks passed

@wpaulino
wpaulino
deleted the

splice-async-signing

branch
February 6, 2026 16:45
@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

async signing completion

Async + Fallible Signing 

4 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support async signing of interactive-tx initial commitment signatures by wpaulino · Pull Request #4355 · lightningdevkit/rust-lightning · GitHub
Skip to content
Support async signing of interactive-tx initial commitment signatures - #4355
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Feb 6, 2026
Merged
Support async signing of interactive-tx initial commitment signatures#4355
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Conversation
@wpaulino
@wpaulinowpaulino
commented
Jan 28, 2026

Copy link


Copy Markdown

Contributor
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.

Depends on #4336.
@wpaulinowpaulino
added this to the 0.3 milestone
Jan 28, 2026
@wpaulinowpaulino
self-assigned this
Jan 28, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 86.27451% with 14 lines in your changes missing coverage. Please review.

✅ Project coverage is 86.03%. Comparing base (dde2c82) to head (ee74209).
⚠️ Report is 13 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/ln/channel.rs83.33%11 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #4355 +/- ##
==========================================
+ Coverage 86.00% 86.03% +0.02% 
==========================================
Files 156 156 Lines 102857 102909 +52 Branches 102857 102909 +52 ==========================================
+ Hits 88465 88538 +73 + Misses 11883 11865 -18 + Partials 2509 2506 -3 
FlagCoverage Δ
tests86.03% <86.27%> (+0.02%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 28, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Easy enough. We should ask claude to add async signing to the chanmon_consistency fuzzer as a followup.

This was
linked to
issues
Jan 29, 2026

async signing completion
#3489

Closed


Async + Fallible Signing #2088

Closed

@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Marked this as fixing #3489 and #2088 though we should probably see if we need to address #3109 (review) as well.
@wpaulino
wpaulino
commented
Jan 29, 2026

Copy link


Copy Markdown

ContributorAuthor
Marked this as fixing #3489 and #2088
There's one more case for dual-funding that still needs to be addressed -- the first_per_commitment_point in open_channel2.
@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Sure but we don't actually do dual-funding yet, so that's just a part of doing dual-funding now :)
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
9933019 to
eb9fc0cCompareJanuary 30, 2026 03:32
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 31, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 2, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 4, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
jkczyz
jkczyz
reviewed
Feb 5, 2026
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channelmanager.rs
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
eb9fc0c to
252545cCompareFebruary 5, 2026 17:57
@wpaulino
Support async signing of interactive-tx initial commitment signatures
ee74209
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
252545c to
ee74209CompareFebruary 5, 2026 18:01
@wpaulino
wpaulino
commented
Feb 5, 2026

Copy link


Copy Markdown

ContributorAuthor
Had to rebase due to small conflict after #4311
@wpaulino
wpaulino
requested a review
from jkczyzFebruary 5, 2026 18:02
@TheBlueMatt
TheBlueMatt
merged commit 372ba65
into
lightningdevkit:mainFeb 6, 2026

19 checks passed

@wpaulino
wpaulino
deleted the

splice-async-signing

branch
February 6, 2026 16:45
@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

async signing completion

Async + Fallible Signing 

4 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Support async signing of interactive-tx initial commitment signatures by wpaulino · Pull Request #4355 · lightningdevkit/rust-lightning · GitHub
Skip to content
Support async signing of interactive-tx initial commitment signatures - #4355
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Feb 6, 2026
Merged
Support async signing of interactive-tx initial commitment signatures#4355
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Conversation
@wpaulino
@wpaulinowpaulino
commented
Jan 28, 2026

Copy link


Copy Markdown

Contributor
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.

Depends on #4336.
@wpaulinowpaulino
added this to the 0.3 milestone
Jan 28, 2026
@wpaulinowpaulino
self-assigned this
Jan 28, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 86.27451% with 14 lines in your changes missing coverage. Please review.

✅ Project coverage is 86.03%. Comparing base (dde2c82) to head (ee74209).
⚠️ Report is 13 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/ln/channel.rs83.33%11 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #4355 +/- ##
==========================================
+ Coverage 86.00% 86.03% +0.02% 
==========================================
Files 156 156 Lines 102857 102909 +52 Branches 102857 102909 +52 ==========================================
+ Hits 88465 88538 +73 + Misses 11883 11865 -18 + Partials 2509 2506 -3 
FlagCoverage Δ
tests86.03% <86.27%> (+0.02%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 28, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Easy enough. We should ask claude to add async signing to the chanmon_consistency fuzzer as a followup.

This was
linked to
issues
Jan 29, 2026

async signing completion
#3489

Closed


Async + Fallible Signing #2088

Closed

@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Marked this as fixing #3489 and #2088 though we should probably see if we need to address #3109 (review) as well.
@wpaulino
wpaulino
commented
Jan 29, 2026

Copy link


Copy Markdown

ContributorAuthor
Marked this as fixing #3489 and #2088
There's one more case for dual-funding that still needs to be addressed -- the first_per_commitment_point in open_channel2.
@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Sure but we don't actually do dual-funding yet, so that's just a part of doing dual-funding now :)
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
9933019 to
eb9fc0cCompareJanuary 30, 2026 03:32
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 31, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 2, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 4, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
jkczyz
jkczyz
reviewed
Feb 5, 2026
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channelmanager.rs
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
eb9fc0c to
252545cCompareFebruary 5, 2026 17:57
@wpaulino
Support async signing of interactive-tx initial commitment signatures
ee74209
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
252545c to
ee74209CompareFebruary 5, 2026 18:01
@wpaulino
wpaulino
commented
Feb 5, 2026

Copy link


Copy Markdown

ContributorAuthor
Had to rebase due to small conflict after #4311
@wpaulino
wpaulino
requested a review
from jkczyzFebruary 5, 2026 18:02
@TheBlueMatt
TheBlueMatt
merged commit 372ba65
into
lightningdevkit:mainFeb 6, 2026

19 checks passed

@wpaulino
wpaulino
deleted the

splice-async-signing

branch
February 6, 2026 16:45
@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

async signing completion

Async + Fallible Signing 

4 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support async signing of interactive-tx initial commitment signatures by wpaulino · Pull Request #4355 · lightningdevkit/rust-lightning · GitHub
Skip to content
Support async signing of interactive-tx initial commitment signatures - #4355
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Feb 6, 2026
Merged
Support async signing of interactive-tx initial commitment signatures#4355
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Conversation
@wpaulino
@wpaulinowpaulino
commented
Jan 28, 2026

Copy link


Copy Markdown

Contributor
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.

Depends on #4336.
@wpaulinowpaulino
added this to the 0.3 milestone
Jan 28, 2026
@wpaulinowpaulino
self-assigned this
Jan 28, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 86.27451% with 14 lines in your changes missing coverage. Please review.

✅ Project coverage is 86.03%. Comparing base (dde2c82) to head (ee74209).
⚠️ Report is 13 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/ln/channel.rs83.33%11 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #4355 +/- ##
==========================================
+ Coverage 86.00% 86.03% +0.02% 
==========================================
Files 156 156 Lines 102857 102909 +52 Branches 102857 102909 +52 ==========================================
+ Hits 88465 88538 +73 + Misses 11883 11865 -18 + Partials 2509 2506 -3 
FlagCoverage Δ
tests86.03% <86.27%> (+0.02%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 28, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Easy enough. We should ask claude to add async signing to the chanmon_consistency fuzzer as a followup.

This was
linked to
issues
Jan 29, 2026

async signing completion
#3489

Closed


Async + Fallible Signing #2088

Closed

@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Marked this as fixing #3489 and #2088 though we should probably see if we need to address #3109 (review) as well.
@wpaulino
wpaulino
commented
Jan 29, 2026

Copy link


Copy Markdown

ContributorAuthor
Marked this as fixing #3489 and #2088
There's one more case for dual-funding that still needs to be addressed -- the first_per_commitment_point in open_channel2.
@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Sure but we don't actually do dual-funding yet, so that's just a part of doing dual-funding now :)
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
9933019 to
eb9fc0cCompareJanuary 30, 2026 03:32
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 31, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 2, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 4, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
jkczyz
jkczyz
reviewed
Feb 5, 2026
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channelmanager.rs
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
eb9fc0c to
252545cCompareFebruary 5, 2026 17:57
@wpaulino
Support async signing of interactive-tx initial commitment signatures
ee74209
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
252545c to
ee74209CompareFebruary 5, 2026 18:01
@wpaulino
wpaulino
commented
Feb 5, 2026

Copy link


Copy Markdown

ContributorAuthor
Had to rebase due to small conflict after #4311
@wpaulino
wpaulino
requested a review
from jkczyzFebruary 5, 2026 18:02
@TheBlueMatt
TheBlueMatt
merged commit 372ba65
into
lightningdevkit:mainFeb 6, 2026

19 checks passed

@wpaulino
wpaulino
deleted the

splice-async-signing

branch
February 6, 2026 16:45
@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

async signing completion

Async + Fallible Signing 

4 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support async signing of interactive-tx initial commitment signatures by wpaulino · Pull Request #4355 · lightningdevkit/rust-lightning · GitHub
Skip to content
Support async signing of interactive-tx initial commitment signatures - #4355
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Feb 6, 2026
Merged
Support async signing of interactive-tx initial commitment signatures#4355
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Conversation
@wpaulino
@wpaulinowpaulino
commented
Jan 28, 2026

Copy link


Copy Markdown

Contributor
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.

Depends on #4336.
@wpaulinowpaulino
added this to the 0.3 milestone
Jan 28, 2026
@wpaulinowpaulino
self-assigned this
Jan 28, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 86.27451% with 14 lines in your changes missing coverage. Please review.

✅ Project coverage is 86.03%. Comparing base (dde2c82) to head (ee74209).
⚠️ Report is 13 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/ln/channel.rs83.33%11 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #4355 +/- ##
==========================================
+ Coverage 86.00% 86.03% +0.02% 
==========================================
Files 156 156 Lines 102857 102909 +52 Branches 102857 102909 +52 ==========================================
+ Hits 88465 88538 +73 + Misses 11883 11865 -18 + Partials 2509 2506 -3 
FlagCoverage Δ
tests86.03% <86.27%> (+0.02%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 28, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Easy enough. We should ask claude to add async signing to the chanmon_consistency fuzzer as a followup.

This was
linked to
issues
Jan 29, 2026

async signing completion
#3489

Closed


Async + Fallible Signing #2088

Closed

@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Marked this as fixing #3489 and #2088 though we should probably see if we need to address #3109 (review) as well.
@wpaulino
wpaulino
commented
Jan 29, 2026

Copy link


Copy Markdown

ContributorAuthor
Marked this as fixing #3489 and #2088
There's one more case for dual-funding that still needs to be addressed -- the first_per_commitment_point in open_channel2.
@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Sure but we don't actually do dual-funding yet, so that's just a part of doing dual-funding now :)
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
9933019 to
eb9fc0cCompareJanuary 30, 2026 03:32
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 31, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 2, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 4, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
jkczyz
jkczyz
reviewed
Feb 5, 2026
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channelmanager.rs
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
eb9fc0c to
252545cCompareFebruary 5, 2026 17:57
@wpaulino
Support async signing of interactive-tx initial commitment signatures
ee74209
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
252545c to
ee74209CompareFebruary 5, 2026 18:01
@wpaulino
wpaulino
commented
Feb 5, 2026

Copy link


Copy Markdown

ContributorAuthor
Had to rebase due to small conflict after #4311
@wpaulino
wpaulino
requested a review
from jkczyzFebruary 5, 2026 18:02
@TheBlueMatt
TheBlueMatt
merged commit 372ba65
into
lightningdevkit:mainFeb 6, 2026

19 checks passed

@wpaulino
wpaulino
deleted the

splice-async-signing

branch
February 6, 2026 16:45
@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

async signing completion

Async + Fallible Signing 

4 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Support async signing of interactive-tx initial commitment signatures by wpaulino · Pull Request #4355 · lightningdevkit/rust-lightning · GitHub
Skip to content
Support async signing of interactive-tx initial commitment signatures - #4355
Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Feb 6, 2026
Merged
Support async signing of interactive-tx initial commitment signatures#4355
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom 
wpaulino:splice-async-signing
Conversation
@wpaulino
@wpaulinowpaulino
commented
Jan 28, 2026

Copy link


Copy Markdown

Contributor
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.

Depends on #4336.
@wpaulinowpaulino
added this to the 0.3 milestone
Jan 28, 2026
@wpaulinowpaulino
self-assigned this
Jan 28, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@codecov
codecovBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 86.27451% with 14 lines in your changes missing coverage. Please review.

✅ Project coverage is 86.03%. Comparing base (dde2c82) to head (ee74209).
⚠️ Report is 13 commits behind head on main.
Files with missing linesPatch %Lines
lightning/src/ln/channel.rs83.33%11 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #4355 +/- ##
==========================================
+ Coverage 86.00% 86.03% +0.02% 
==========================================
Files 156 156 Lines 102857 102909 +52 Branches 102857 102909 +52 ==========================================
+ Hits 88465 88538 +73 + Misses 11883 11865 -18 + Partials 2509 2506 -3 
FlagCoverage Δ
tests86.03% <86.27%> (+0.02%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
TheBlueMatt
TheBlueMatt
previously approved these changes
Jan 28, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Easy enough. We should ask claude to add async signing to the chanmon_consistency fuzzer as a followup.

This was
linked to
issues
Jan 29, 2026

async signing completion
#3489

Closed


Async + Fallible Signing #2088

Closed

@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Marked this as fixing #3489 and #2088 though we should probably see if we need to address #3109 (review) as well.
@wpaulino
wpaulino
commented
Jan 29, 2026

Copy link


Copy Markdown

ContributorAuthor
Marked this as fixing #3489 and #2088
There's one more case for dual-funding that still needs to be addressed -- the first_per_commitment_point in open_channel2.
@TheBlueMatt
TheBlueMatt
commented
Jan 29, 2026

Copy link


Copy Markdown

Collaborator
Sure but we don't actually do dual-funding yet, so that's just a part of doing dual-funding now :)
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
9933019 to
eb9fc0cCompareJanuary 30, 2026 03:32
@ldk-reviews-bot
ldk-reviews-bot
commented
Jan 31, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 2, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 4, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @jkczyz! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
jkczyz
jkczyz
reviewed
Feb 5, 2026
View reviewed changes
Comment threadlightning/src/ln/channel.rs
Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channel.rs
Outdated

Comment threadlightning/src/ln/channelmanager.rs
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
eb9fc0c to
252545cCompareFebruary 5, 2026 17:57
@wpaulino
Support async signing of interactive-tx initial commitment signatures
ee74209
This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.
@wpaulino
wpaulinoforce-pushed
the
splice-async-signing
branch
from
252545c to
ee74209CompareFebruary 5, 2026 18:01
@wpaulino
wpaulino
commented
Feb 5, 2026

Copy link


Copy Markdown

ContributorAuthor
Had to rebase due to small conflict after #4311
@wpaulino
wpaulino
requested a review
from jkczyzFebruary 5, 2026 18:02
@TheBlueMatt
TheBlueMatt
merged commit 372ba65
into
lightningdevkit:mainFeb 6, 2026

19 checks passed

@wpaulino
wpaulino
deleted the

splice-async-signing

branch
February 6, 2026 16:45
@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes
@jkczyzjkczyzjkczyz approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

async signing completion

Async + Fallible Signing 

4 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt@jkczyz