Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)#4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wpaulino merged 2 commits into from
Feb 4, 2026
Merged

Correct crate versions and make CI semver test run on all crates (esp lightning-invoice) #4375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
784b85c
Correct crate version numbers that have broken semver
TheBlueMatt Feb 3, 2026
a123cfa
Check semver of all workspace crates rather than an explicit list
TheBlueMatt Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 10 additions & 37 deletions .github/workflows/semver.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,40 +13,13 @@ jobs:
steps:
- name: Checkout source code
uses: actions/checkout@v4
- name: Check SemVer with default features
uses: obi1kenobi/cargo-semver-checks-action@v2
with:
feature-group: default-features
- name: Check SemVer *without* default features
uses: obi1kenobi/cargo-semver-checks-action@v2
with:
feature-group: only-explicit-features
- name: Check lightning-background-processor SemVer
uses: obi1kenobi/cargo-semver-checks-action@v2
with:
package: lightning-background-processor
feature-group: only-explicit-features
- name: Check lightning-block-sync SemVer
uses: obi1kenobi/cargo-semver-checks-action@v2
with:
package: lightning-block-sync
feature-group: only-explicit-features
features: rpc-client,rest-client
- name: Check lightning-transaction-sync electrum SemVer
uses: obi1kenobi/cargo-semver-checks-action@v2
with:
manifest-path: lightning-transaction-sync/Cargo.toml
feature-group: only-explicit-features
features: electrum
- name: Check lightning-transaction-sync esplora-blocking SemVer
uses: obi1kenobi/cargo-semver-checks-action@v2
with:
manifest-path: lightning-transaction-sync/Cargo.toml
feature-group: only-explicit-features
features: esplora-blocking

@tnulltnullFeb 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we did this intentionally for good reason, as esplora-blocking and esplora-async are mutually exclusive for example. If you enable both, you end up just checking the async variant. I think at the time there were more features like this, e.g., BP's futures.

- name: Check lightning-transaction-sync esplora-async SemVer
uses: obi1kenobi/cargo-semver-checks-action@v2
with:
manifest-path: lightning-transaction-sync/Cargo.toml
feature-group: only-explicit-features
features: esplora-async
- name: Install Rust stable toolchain

@tnulltnullFeb 4, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just stick with the appropriate Github action rather than doing something custom?

run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
rustup override set stable
- name: Install SemVer Checker
run: cargo install cargo-semver-checks --locked
- name: Check SemVer with all features
run: cargo semver-checks
- name: Check SemVer without any non-default features
run: cargo semver-checks --only-explicit-features
8 changes: 4 additions & 4 deletions lightning-background-processor/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -25,16 +25,16 @@ bitcoin = { version = "0.32.2", default-features = false }
bitcoin_hashes = { version = "0.14.0", default-features = false }
bitcoin-io = { version = "0.1.2", default-features = false }
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.2.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-rapid-gossip-sync = { version = "0.3.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false }
possiblyrandom = { version = "0.2", path = "../possiblyrandom", default-features = false }

[dev-dependencies]
tokio = { version = "1.35", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice" }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice" }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false, features = ["_test_utils"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister" }
lightning-persister = { version = "0.3.0", path = "../lightning-persister" }

[lints]
workspace = true
2 changes: 1 addition & 1 deletion lightning-custom-message/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down
2 changes: 1 addition & 1 deletion lightning-invoice/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.34.0+git"
version = "0.35.0+git"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand Down
6 changes: 3 additions & 3 deletions lightning-liquidity/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ _test_utils = []
[dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bitcoin = { version = "0.32.2", default-features = false, features = ["serde"] }
Expand All@@ -36,8 +36,8 @@ backtrace = { version = "0.3", optional = true }

[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.3.0", path = "../lightning-persister", default-features = false }

proptest = "1.0.0"
tokio = { version = "1.35", default-features = false, features = [ "rt-multi-thread", "time", "sync", "macros" ] }
Expand Down
2 changes: 1 addition & 1 deletion lightning-macros/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-macros"
version = "0.2.0+git"
version = "0.2.2+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down
2 changes: 1 addition & 1 deletion lightning-net-tokio/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down
2 changes: 1 addition & 1 deletion lightning-persister/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down
2 changes: 1 addition & 1 deletion lightning-rapid-gossip-sync/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down
2 changes: 1 addition & 1 deletion lightning-transaction-sync/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down
2 changes: 1 addition & 1 deletion lightning/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ default = ["std", "grind_signatures"]

[dependencies]
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bech32 = { version = "0.11.0", default-features = false }
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)#4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wpaulino
merged 2 commits into

from

Feb 4, 2026
 Merged


Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)
#4375
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
784b85c

Correct crate version numbers that have broken semver


TheBlueMatt Feb 3, 2026
a123cfa

Check semver of all workspace crates rather than an explicit list


TheBlueMatt Feb 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


47 changes: 10 additions & 37 deletions
.github/workflows/semver.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,40 +13,13 @@ jobs:
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Check SemVer with default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: default-features
 - name: Check SemVer *without* default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: only-explicit-features
 - name: Check lightning-background-processor SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-background-processor
 feature-group: only-explicit-features
 - name: Check lightning-block-sync SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-block-sync
 feature-group: only-explicit-features
 features: rpc-client,rest-client
 - name: Check lightning-transaction-sync electrum SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: electrum
 - name: Check lightning-transaction-sync esplora-blocking SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-blocking
@tnulltnullFeb 4, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we did this intentionally for good reason, as esplora-blocking and esplora-async are mutually exclusive for example. If you enable both, you end up just checking the async variant. I think at the time there were more features like this, e.g., BP's futures.
 - name: Check lightning-transaction-sync esplora-async SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-async
 - name: Install Rust stable toolchain
@tnulltnullFeb 4, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just stick with the appropriate Github action rather than doing something custom?
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
 rustup override set stable
 - name: Install SemVer Checker
 run: cargo install cargo-semver-checks --locked
 - name: Check SemVer with all features
 run: cargo semver-checks
 - name: Check SemVer without any non-default features
 run: cargo semver-checks --only-explicit-features

8 changes: 4 additions & 4 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -25,16 +25,16 @@ bitcoin = { version = "0.32.2", default-features = false }
bitcoin_hashes = { version = "0.14.0", default-features = false }
bitcoin-io = { version = "0.1.2", default-features = false }
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.2.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-rapid-gossip-sync = { version = "0.3.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false }
possiblyrandom = { version = "0.2", path = "../possiblyrandom", default-features = false }

[dev-dependencies]
tokio = { version = "1.35", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice" }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice" }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false, features = ["_test_utils"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister" }
lightning-persister = { version = "0.3.0", path = "../lightning-persister" }

[lints]
workspace = true

2 changes: 1 addition & 1 deletion
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.34.0+git"
version = "0.35.0+git"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand Down

6 changes: 3 additions & 3 deletions
lightning-liquidity/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ _test_utils = []
[dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bitcoin = { version = "0.32.2", default-features = false, features = ["serde"] }
Expand All@@ -36,8 +36,8 @@ backtrace = { version = "0.3", optional = true }

[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.3.0", path = "../lightning-persister", default-features = false }

proptest = "1.0.0"
tokio = { version = "1.35", default-features = false, features = [ "rt-multi-thread", "time", "sync", "macros" ] }
Expand Down

2 changes: 1 addition & 1 deletion
lightning-macros/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-macros"
version = "0.2.0+git"
version = "0.2.2+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ default = ["std", "grind_signatures"]

[dependencies]
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bech32 = { version = "0.11.0", default-features = false }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)#4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wpaulino
merged 2 commits into

from

Feb 4, 2026
 Merged


Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)
#4375
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
784b85c

Correct crate version numbers that have broken semver


TheBlueMatt Feb 3, 2026
a123cfa

Check semver of all workspace crates rather than an explicit list


TheBlueMatt Feb 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


47 changes: 10 additions & 37 deletions
.github/workflows/semver.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,40 +13,13 @@ jobs:
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Check SemVer with default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: default-features
 - name: Check SemVer *without* default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: only-explicit-features
 - name: Check lightning-background-processor SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-background-processor
 feature-group: only-explicit-features
 - name: Check lightning-block-sync SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-block-sync
 feature-group: only-explicit-features
 features: rpc-client,rest-client
 - name: Check lightning-transaction-sync electrum SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: electrum
 - name: Check lightning-transaction-sync esplora-blocking SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-blocking
@tnulltnullFeb 4, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we did this intentionally for good reason, as esplora-blocking and esplora-async are mutually exclusive for example. If you enable both, you end up just checking the async variant. I think at the time there were more features like this, e.g., BP's futures.
 - name: Check lightning-transaction-sync esplora-async SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-async
 - name: Install Rust stable toolchain
@tnulltnullFeb 4, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just stick with the appropriate Github action rather than doing something custom?
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
 rustup override set stable
 - name: Install SemVer Checker
 run: cargo install cargo-semver-checks --locked
 - name: Check SemVer with all features
 run: cargo semver-checks
 - name: Check SemVer without any non-default features
 run: cargo semver-checks --only-explicit-features

8 changes: 4 additions & 4 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -25,16 +25,16 @@ bitcoin = { version = "0.32.2", default-features = false }
bitcoin_hashes = { version = "0.14.0", default-features = false }
bitcoin-io = { version = "0.1.2", default-features = false }
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.2.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-rapid-gossip-sync = { version = "0.3.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false }
possiblyrandom = { version = "0.2", path = "../possiblyrandom", default-features = false }

[dev-dependencies]
tokio = { version = "1.35", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice" }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice" }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false, features = ["_test_utils"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister" }
lightning-persister = { version = "0.3.0", path = "../lightning-persister" }

[lints]
workspace = true

2 changes: 1 addition & 1 deletion
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.34.0+git"
version = "0.35.0+git"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand Down

6 changes: 3 additions & 3 deletions
lightning-liquidity/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ _test_utils = []
[dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bitcoin = { version = "0.32.2", default-features = false, features = ["serde"] }
Expand All@@ -36,8 +36,8 @@ backtrace = { version = "0.3", optional = true }

[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.3.0", path = "../lightning-persister", default-features = false }

proptest = "1.0.0"
tokio = { version = "1.35", default-features = false, features = [ "rt-multi-thread", "time", "sync", "macros" ] }
Expand Down

2 changes: 1 addition & 1 deletion
lightning-macros/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-macros"
version = "0.2.0+git"
version = "0.2.2+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ default = ["std", "grind_signatures"]

[dependencies]
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bech32 = { version = "0.11.0", default-features = false }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)#4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wpaulino
merged 2 commits into

from

Feb 4, 2026
 Merged


Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)
#4375
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
784b85c

Correct crate version numbers that have broken semver


TheBlueMatt Feb 3, 2026
a123cfa

Check semver of all workspace crates rather than an explicit list


TheBlueMatt Feb 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


47 changes: 10 additions & 37 deletions
.github/workflows/semver.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,40 +13,13 @@ jobs:
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Check SemVer with default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: default-features
 - name: Check SemVer *without* default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: only-explicit-features
 - name: Check lightning-background-processor SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-background-processor
 feature-group: only-explicit-features
 - name: Check lightning-block-sync SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-block-sync
 feature-group: only-explicit-features
 features: rpc-client,rest-client
 - name: Check lightning-transaction-sync electrum SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: electrum
 - name: Check lightning-transaction-sync esplora-blocking SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-blocking
@tnulltnullFeb 4, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we did this intentionally for good reason, as esplora-blocking and esplora-async are mutually exclusive for example. If you enable both, you end up just checking the async variant. I think at the time there were more features like this, e.g., BP's futures.
 - name: Check lightning-transaction-sync esplora-async SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-async
 - name: Install Rust stable toolchain
@tnulltnullFeb 4, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just stick with the appropriate Github action rather than doing something custom?
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
 rustup override set stable
 - name: Install SemVer Checker
 run: cargo install cargo-semver-checks --locked
 - name: Check SemVer with all features
 run: cargo semver-checks
 - name: Check SemVer without any non-default features
 run: cargo semver-checks --only-explicit-features

8 changes: 4 additions & 4 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -25,16 +25,16 @@ bitcoin = { version = "0.32.2", default-features = false }
bitcoin_hashes = { version = "0.14.0", default-features = false }
bitcoin-io = { version = "0.1.2", default-features = false }
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.2.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-rapid-gossip-sync = { version = "0.3.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false }
possiblyrandom = { version = "0.2", path = "../possiblyrandom", default-features = false }

[dev-dependencies]
tokio = { version = "1.35", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice" }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice" }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false, features = ["_test_utils"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister" }
lightning-persister = { version = "0.3.0", path = "../lightning-persister" }

[lints]
workspace = true

2 changes: 1 addition & 1 deletion
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.34.0+git"
version = "0.35.0+git"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand Down

6 changes: 3 additions & 3 deletions
lightning-liquidity/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ _test_utils = []
[dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bitcoin = { version = "0.32.2", default-features = false, features = ["serde"] }
Expand All@@ -36,8 +36,8 @@ backtrace = { version = "0.3", optional = true }

[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.3.0", path = "../lightning-persister", default-features = false }

proptest = "1.0.0"
tokio = { version = "1.35", default-features = false, features = [ "rt-multi-thread", "time", "sync", "macros" ] }
Expand Down

2 changes: 1 addition & 1 deletion
lightning-macros/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-macros"
version = "0.2.0+git"
version = "0.2.2+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ default = ["std", "grind_signatures"]

[dependencies]
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bech32 = { version = "0.11.0", default-features = false }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)#4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wpaulino
merged 2 commits into

from

Feb 4, 2026
 Merged


Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)
#4375
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
784b85c

Correct crate version numbers that have broken semver


TheBlueMatt Feb 3, 2026
a123cfa

Check semver of all workspace crates rather than an explicit list


TheBlueMatt Feb 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


47 changes: 10 additions & 37 deletions
.github/workflows/semver.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,40 +13,13 @@ jobs:
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Check SemVer with default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: default-features
 - name: Check SemVer *without* default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: only-explicit-features
 - name: Check lightning-background-processor SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-background-processor
 feature-group: only-explicit-features
 - name: Check lightning-block-sync SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-block-sync
 feature-group: only-explicit-features
 features: rpc-client,rest-client
 - name: Check lightning-transaction-sync electrum SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: electrum
 - name: Check lightning-transaction-sync esplora-blocking SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-blocking
@tnulltnullFeb 4, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we did this intentionally for good reason, as esplora-blocking and esplora-async are mutually exclusive for example. If you enable both, you end up just checking the async variant. I think at the time there were more features like this, e.g., BP's futures.
 - name: Check lightning-transaction-sync esplora-async SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-async
 - name: Install Rust stable toolchain
@tnulltnullFeb 4, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just stick with the appropriate Github action rather than doing something custom?
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
 rustup override set stable
 - name: Install SemVer Checker
 run: cargo install cargo-semver-checks --locked
 - name: Check SemVer with all features
 run: cargo semver-checks
 - name: Check SemVer without any non-default features
 run: cargo semver-checks --only-explicit-features

8 changes: 4 additions & 4 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -25,16 +25,16 @@ bitcoin = { version = "0.32.2", default-features = false }
bitcoin_hashes = { version = "0.14.0", default-features = false }
bitcoin-io = { version = "0.1.2", default-features = false }
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.2.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-rapid-gossip-sync = { version = "0.3.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false }
possiblyrandom = { version = "0.2", path = "../possiblyrandom", default-features = false }

[dev-dependencies]
tokio = { version = "1.35", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice" }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice" }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false, features = ["_test_utils"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister" }
lightning-persister = { version = "0.3.0", path = "../lightning-persister" }

[lints]
workspace = true

2 changes: 1 addition & 1 deletion
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.34.0+git"
version = "0.35.0+git"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand Down

6 changes: 3 additions & 3 deletions
lightning-liquidity/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ _test_utils = []
[dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bitcoin = { version = "0.32.2", default-features = false, features = ["serde"] }
Expand All@@ -36,8 +36,8 @@ backtrace = { version = "0.3", optional = true }

[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.3.0", path = "../lightning-persister", default-features = false }

proptest = "1.0.0"
tokio = { version = "1.35", default-features = false, features = [ "rt-multi-thread", "time", "sync", "macros" ] }
Expand Down

2 changes: 1 addition & 1 deletion
lightning-macros/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-macros"
version = "0.2.0+git"
version = "0.2.2+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ default = ["std", "grind_signatures"]

[dependencies]
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bech32 = { version = "0.11.0", default-features = false }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)#4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wpaulino
merged 2 commits into

from

Feb 4, 2026
 Merged


Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)
#4375
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
784b85c

Correct crate version numbers that have broken semver


TheBlueMatt Feb 3, 2026
a123cfa

Check semver of all workspace crates rather than an explicit list


TheBlueMatt Feb 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


47 changes: 10 additions & 37 deletions
.github/workflows/semver.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,40 +13,13 @@ jobs:
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Check SemVer with default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: default-features
 - name: Check SemVer *without* default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: only-explicit-features
 - name: Check lightning-background-processor SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-background-processor
 feature-group: only-explicit-features
 - name: Check lightning-block-sync SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-block-sync
 feature-group: only-explicit-features
 features: rpc-client,rest-client
 - name: Check lightning-transaction-sync electrum SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: electrum
 - name: Check lightning-transaction-sync esplora-blocking SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-blocking
@tnulltnullFeb 4, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we did this intentionally for good reason, as esplora-blocking and esplora-async are mutually exclusive for example. If you enable both, you end up just checking the async variant. I think at the time there were more features like this, e.g., BP's futures.
 - name: Check lightning-transaction-sync esplora-async SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-async
 - name: Install Rust stable toolchain
@tnulltnullFeb 4, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just stick with the appropriate Github action rather than doing something custom?
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
 rustup override set stable
 - name: Install SemVer Checker
 run: cargo install cargo-semver-checks --locked
 - name: Check SemVer with all features
 run: cargo semver-checks
 - name: Check SemVer without any non-default features
 run: cargo semver-checks --only-explicit-features

8 changes: 4 additions & 4 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -25,16 +25,16 @@ bitcoin = { version = "0.32.2", default-features = false }
bitcoin_hashes = { version = "0.14.0", default-features = false }
bitcoin-io = { version = "0.1.2", default-features = false }
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.2.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-rapid-gossip-sync = { version = "0.3.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false }
possiblyrandom = { version = "0.2", path = "../possiblyrandom", default-features = false }

[dev-dependencies]
tokio = { version = "1.35", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice" }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice" }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false, features = ["_test_utils"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister" }
lightning-persister = { version = "0.3.0", path = "../lightning-persister" }

[lints]
workspace = true

2 changes: 1 addition & 1 deletion
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.34.0+git"
version = "0.35.0+git"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand Down

6 changes: 3 additions & 3 deletions
lightning-liquidity/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ _test_utils = []
[dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bitcoin = { version = "0.32.2", default-features = false, features = ["serde"] }
Expand All@@ -36,8 +36,8 @@ backtrace = { version = "0.3", optional = true }

[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.3.0", path = "../lightning-persister", default-features = false }

proptest = "1.0.0"
tokio = { version = "1.35", default-features = false, features = [ "rt-multi-thread", "time", "sync", "macros" ] }
Expand Down

2 changes: 1 addition & 1 deletion
lightning-macros/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-macros"
version = "0.2.0+git"
version = "0.2.2+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ default = ["std", "grind_signatures"]

[dependencies]
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bech32 = { version = "0.11.0", default-features = false }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)#4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wpaulino
merged 2 commits into

from

Feb 4, 2026
 Merged


Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)
#4375
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
784b85c

Correct crate version numbers that have broken semver


TheBlueMatt Feb 3, 2026
a123cfa

Check semver of all workspace crates rather than an explicit list


TheBlueMatt Feb 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


47 changes: 10 additions & 37 deletions
.github/workflows/semver.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,40 +13,13 @@ jobs:
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Check SemVer with default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: default-features
 - name: Check SemVer *without* default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: only-explicit-features
 - name: Check lightning-background-processor SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-background-processor
 feature-group: only-explicit-features
 - name: Check lightning-block-sync SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-block-sync
 feature-group: only-explicit-features
 features: rpc-client,rest-client
 - name: Check lightning-transaction-sync electrum SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: electrum
 - name: Check lightning-transaction-sync esplora-blocking SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-blocking
@tnulltnullFeb 4, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we did this intentionally for good reason, as esplora-blocking and esplora-async are mutually exclusive for example. If you enable both, you end up just checking the async variant. I think at the time there were more features like this, e.g., BP's futures.
 - name: Check lightning-transaction-sync esplora-async SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-async
 - name: Install Rust stable toolchain
@tnulltnullFeb 4, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just stick with the appropriate Github action rather than doing something custom?
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
 rustup override set stable
 - name: Install SemVer Checker
 run: cargo install cargo-semver-checks --locked
 - name: Check SemVer with all features
 run: cargo semver-checks
 - name: Check SemVer without any non-default features
 run: cargo semver-checks --only-explicit-features

8 changes: 4 additions & 4 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -25,16 +25,16 @@ bitcoin = { version = "0.32.2", default-features = false }
bitcoin_hashes = { version = "0.14.0", default-features = false }
bitcoin-io = { version = "0.1.2", default-features = false }
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.2.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-rapid-gossip-sync = { version = "0.3.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false }
possiblyrandom = { version = "0.2", path = "../possiblyrandom", default-features = false }

[dev-dependencies]
tokio = { version = "1.35", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice" }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice" }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false, features = ["_test_utils"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister" }
lightning-persister = { version = "0.3.0", path = "../lightning-persister" }

[lints]
workspace = true

2 changes: 1 addition & 1 deletion
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.34.0+git"
version = "0.35.0+git"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand Down

6 changes: 3 additions & 3 deletions
lightning-liquidity/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ _test_utils = []
[dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bitcoin = { version = "0.32.2", default-features = false, features = ["serde"] }
Expand All@@ -36,8 +36,8 @@ backtrace = { version = "0.3", optional = true }

[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.3.0", path = "../lightning-persister", default-features = false }

proptest = "1.0.0"
tokio = { version = "1.35", default-features = false, features = [ "rt-multi-thread", "time", "sync", "macros" ] }
Expand Down

2 changes: 1 addition & 1 deletion
lightning-macros/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-macros"
version = "0.2.0+git"
version = "0.2.2+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ default = ["std", "grind_signatures"]

[dependencies]
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bech32 = { version = "0.11.0", default-features = false }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)#4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wpaulino
merged 2 commits into

from

Feb 4, 2026
 Merged


Correct crate versions and make CI semver test run on all crates (esp lightning-invoice)
#4375
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
784b85c

Correct crate version numbers that have broken semver


TheBlueMatt Feb 3, 2026
a123cfa

Check semver of all workspace crates rather than an explicit list


TheBlueMatt Feb 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


47 changes: 10 additions & 37 deletions
.github/workflows/semver.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,40 +13,13 @@ jobs:
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Check SemVer with default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: default-features
 - name: Check SemVer *without* default features
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 feature-group: only-explicit-features
 - name: Check lightning-background-processor SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-background-processor
 feature-group: only-explicit-features
 - name: Check lightning-block-sync SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 package: lightning-block-sync
 feature-group: only-explicit-features
 features: rpc-client,rest-client
 - name: Check lightning-transaction-sync electrum SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: electrum
 - name: Check lightning-transaction-sync esplora-blocking SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-blocking
@tnulltnullFeb 4, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we did this intentionally for good reason, as esplora-blocking and esplora-async are mutually exclusive for example. If you enable both, you end up just checking the async variant. I think at the time there were more features like this, e.g., BP's futures.
 - name: Check lightning-transaction-sync esplora-async SemVer
 uses: obi1kenobi/cargo-semver-checks-action@v2
 with:
 manifest-path: lightning-transaction-sync/Cargo.toml
 feature-group: only-explicit-features
 features: esplora-async
 - name: Install Rust stable toolchain
@tnulltnullFeb 4, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just stick with the appropriate Github action rather than doing something custom?
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
 rustup override set stable
 - name: Install SemVer Checker
 run: cargo install cargo-semver-checks --locked
 - name: Check SemVer with all features
 run: cargo semver-checks
 - name: Check SemVer without any non-default features
 run: cargo semver-checks --only-explicit-features

8 changes: 4 additions & 4 deletions
lightning-background-processor/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All@@ -25,16 +25,16 @@ bitcoin = { version = "0.32.2", default-features = false }
bitcoin_hashes = { version = "0.14.0", default-features = false }
bitcoin-io = { version = "0.1.2", default-features = false }
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.2.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-rapid-gossip-sync = { version = "0.3.0", path = "../lightning-rapid-gossip-sync", default-features = false }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false }
possiblyrandom = { version = "0.2", path = "../possiblyrandom", default-features = false }

[dev-dependencies]
tokio = { version = "1.35", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice" }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice" }
lightning-liquidity = { version = "0.3.0", path = "../lightning-liquidity", default-features = false, features = ["_test_utils"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister" }
lightning-persister = { version = "0.3.0", path = "../lightning-persister" }

[lints]
workspace = true

2 changes: 1 addition & 1 deletion
lightning-custom-message/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-custom-message"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Jeffrey Czyz"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-invoice/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.34.0+git"
version = "0.35.0+git"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand Down

6 changes: 3 additions & 3 deletions
lightning-liquidity/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ _test_utils = []
[dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false }
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bitcoin = { version = "0.32.2", default-features = false, features = ["serde"] }
Expand All@@ -36,8 +36,8 @@ backtrace = { version = "0.3", optional = true }

[dev-dependencies]
lightning = { version = "0.3.0", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.2.0", path = "../lightning-persister", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false, features = ["serde", "std"] }
lightning-persister = { version = "0.3.0", path = "../lightning-persister", default-features = false }

proptest = "1.0.0"
tokio = { version = "1.35", default-features = false, features = [ "rt-multi-thread", "time", "sync", "macros" ] }
Expand Down

2 changes: 1 addition & 1 deletion
lightning-macros/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-macros"
version = "0.2.0+git"
version = "0.2.2+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-net-tokio/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-persister/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-rapid-gossip-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning-transaction-sync/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-transaction-sync"
version = "0.2.0+git"
version = "0.3.0+git"
authors = ["Elias Rohrer"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand Down

2 changes: 1 addition & 1 deletion
lightning/Cargo.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ default = ["std", "grind_signatures"]

[dependencies]
lightning-types = { version = "0.3.0", path = "../lightning-types", default-features = false }
lightning-invoice = { version = "0.34.0", path = "../lightning-invoice", default-features = false }
lightning-invoice = { version = "0.35.0", path = "../lightning-invoice", default-features = false }
lightning-macros = { version = "0.2", path = "../lightning-macros" }

bech32 = { version = "0.11.0", default-features = false }
Expand Down