Skip to content

Drive splices to completion in chanmon_consistency - #4411

Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom
wpaulino:splice-fuzzing-fixes
Feb 18, 2026
Merged

Drive splices to completion in chanmon_consistency#4411
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom
wpaulino:splice-fuzzing-fixes

Conversation

@wpaulino

@wpaulinowpaulino commented Feb 12, 2026

Copy link
Copy Markdown
Contributor
There were two bugs preventing splices from negotiating up to the
`tx_signatures` exchange:
1. A `serial_id` collision because its generation used the first 4 bytes
of `get_secure_random_bytes`.
2. Opcodes 0xa2 and 0xa3 used the wrong vout for the input to splice in.
This commit fixes both, while also adding support for locking splices.
This required confirming transactions, which this target previously
didn't consider.

This PR also includes support for fuzzing async signing (though not during initial channel open) and a few miscellaneous fixes as a result of #4367.

After running the fuzzer for a bit with these changes, a few bugs were discovered that will be addressed separately.

@wpaulinowpaulino added this to the 0.3 milestone Feb 12, 2026
@wpaulinowpaulino self-assigned this Feb 12, 2026
@ldk-reviews-bot

ldk-reviews-bot commented Feb 12, 2026•
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

TheBlueMatt
TheBlueMatt reviewed Feb 12, 2026
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

Comment threadfuzz/src/chanmon_consistency.rs Outdated
Comment threadfuzz/src/chanmon_consistency.rs Outdated
@ldk-reviews-bot

ldk-reviews-bot commented Feb 12, 2026

Copy link
Copy Markdown

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@codecov

codecovBot commented Feb 12, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.89%. Comparing base (d09f1d2) to head (ff39dff).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #4411 +/- ##
==========================================
- Coverage 85.91% 85.89% -0.02% 
==========================================
Files 156 156 Lines 103958 103933 -25 Branches 103958 103933 -25 ==========================================
- Hits 89317 89277 -40 - Misses 12122 12137 +15 
Partials 2519 2519
FlagCoverage Δ
tests85.89% <ø> (-0.02%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpaulino
wpaulinoforce-pushed the splice-fuzzing-fixes branch 2 times, most recently from f6403f8 to a10750dCompareFebruary 17, 2026 17:29
TheBlueMatt
TheBlueMatt reviewed Feb 18, 2026
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase.

@wpaulino
Support async signing in chanmon_consistency
ed520ae
This commit adds new opcodes to enable/disable signer operations one by
one. Note that this only covers signer operations post-funding.
@wpaulino
Drive splices to completion in chanmon_consistency
3c09513
This commit adds support for locking splices. This required confirming
transactions, which this target previously didn't consider.
It also fixes a `serial_id` collision, due to its generation using
the first 4 bytes of `get_secure_random_bytes`, that was preventing
splices from negotiating up to the `tx_signatures` exchange.
@wpaulino
Use channel_id over short_channel_id for payments in chanmon_consistency
c0c09c7
The `short_channel_id` is no longer guaranteed to be stable with
splicing now that the fuzzer can actually lock splices.
@wpaulino
Consider probe events for stuck payments check in chanmon_consistency
28ef7a8
Even though we don't explicitly send probes, because probes are detected
based on hashing the payment hash+preimage, it's rather trivial for the
fuzzer to build payments that accidentally end up looking like probes.
@wpaulino
Time out incomplete MPP payments in chanmon_consistency
520dcbb
This requires calling `timer_tick_occurred`. As a result, when
`timer_tick_occurred` is called, disabled/enabled updates and
`WarnAndDisconnect` events may be triggered.
@wpaulino
Add newline to fuzz log statements
7b8c68c
This regressed at some point, making the logs harder to parse on a
failed test run.
@wpaulino
Refactor channel splice operations into helper in chanmon_consistency
ff39dff
TheBlueMatt
TheBlueMatt approved these changes Feb 18, 2026
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks one comment for a followup, if you want.

Comment threadfuzz/src/chanmon_consistency.rs
@TheBlueMatt
TheBlueMatt merged commit d627ce1 into lightningdevkit:mainFeb 18, 2026
16 of 17 checks passed
@wpaulino
wpaulino deleted the splice-fuzzing-fixes branch February 18, 2026 22:58
@wpaulinowpaulino mentioned this pull request Mar 17, 2026
Merged
@jkczyzjkczyz mentioned this pull request Mar 19, 2026
Open
50 tasks
@joostjagerjoostjager mentioned this pull request Mar 23, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes

Assignees

@wpaulinowpaulino

Labels

None yet

Projects

Weekly Goals
Status: Done

Milestone

0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Drive splices to completion in chanmon_consistency by wpaulino · Pull Request #4411 · lightningdevkit/rust-lightning · GitHub
Skip to content
Drive splices to completion in chanmon_consistency - #4411
Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Feb 18, 2026
Merged
Drive splices to completion in chanmon_consistency#4411
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Conversation
@wpaulino
@wpaulinowpaulino
commented
Feb 12, 2026

Copy link


Copy Markdown

Contributor
There were two bugs preventing splices from negotiating up to the
`tx_signatures` exchange:
1. A `serial_id` collision because its generation used the first 4 bytes
of `get_secure_random_bytes`.
2. Opcodes 0xa2 and 0xa3 used the wrong vout for the input to splice in.
This commit fixes both, while also adding support for locking splices.
This required confirming transactions, which this target previously
didn't consider.

This PR also includes support for fuzzing async signing (though not during initial channel open) and a few miscellaneous fixes as a result of #4367.
After running the fuzzer for a bit with these changes, a few bugs were discovered that will be addressed separately.
@wpaulinowpaulino
added this to the 0.3 milestone
Feb 12, 2026
@wpaulinowpaulino
self-assigned this
Feb 12, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
TheBlueMatt
TheBlueMatt
reviewed
Feb 12, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm
Comment threadfuzz/src/chanmon_consistency.rs
Outdated

Comment threadfuzz/src/chanmon_consistency.rs
Outdated

@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026

Copy link


Copy Markdown

👋 The first review has been submitted!
Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.
@codecov
codecovBot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 85.89%. Comparing base (d09f1d2) to head (ff39dff).
⚠️ Report is 11 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #4411 +/- ##
==========================================
- Coverage 85.91% 85.89% -0.02% 
==========================================
Files 156 156 Lines 103958 103933 -25 Branches 103958 103933 -25 ==========================================
- Hits 89317 89277 -40 - Misses 12122 12137 +15 
Partials 2519 2519 
FlagCoverage Δ
tests85.89% <ø> (-0.02%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@wpaulino
wpaulinoforce-pushed
the
splice-fuzzing-fixes
branch
2 times, most recently
from
f6403f8 to
a10750dCompareFebruary 17, 2026 17:29
TheBlueMatt
TheBlueMatt
reviewed
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase.
@wpaulino
Support async signing in chanmon_consistency
ed520ae
This commit adds new opcodes to enable/disable signer operations one by
one. Note that this only covers signer operations post-funding.
@wpaulino
Drive splices to completion in chanmon_consistency
3c09513
This commit adds support for locking splices. This required confirming
transactions, which this target previously didn't consider.
It also fixes a `serial_id` collision, due to its generation using
the first 4 bytes of `get_secure_random_bytes`, that was preventing
splices from negotiating up to the `tx_signatures` exchange.
@wpaulino
Use channel_id over short_channel_id for payments in chanmon_consistency
c0c09c7
The `short_channel_id` is no longer guaranteed to be stable with
splicing now that the fuzzer can actually lock splices.
@wpaulino
Consider probe events for stuck payments check in chanmon_consistency
28ef7a8
Even though we don't explicitly send probes, because probes are detected
based on hashing the payment hash+preimage, it's rather trivial for the
fuzzer to build payments that accidentally end up looking like probes.
@wpaulino
Time out incomplete MPP payments in chanmon_consistency
520dcbb
This requires calling `timer_tick_occurred`. As a result, when
`timer_tick_occurred` is called, disabled/enabled updates and
`WarnAndDisconnect` events may be triggered.
@wpaulino
Add newline to fuzz log statements
7b8c68c
This regressed at some point, making the logs harder to parse on a
failed test run.
@wpaulino
Refactor channel splice operations into helper in chanmon_consistency
ff39dff
TheBlueMatt
TheBlueMatt
approved these changes
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks one comment for a followup, if you want.
Comment threadfuzz/src/chanmon_consistency.rs
@TheBlueMatt
TheBlueMatt
merged commit d627ce1
into
lightningdevkit:mainFeb 18, 2026

16 of 17 checks passed

@wpaulino
wpaulino
deleted the

splice-fuzzing-fixes

branch
February 18, 2026 22:58
@wpaulinowpaulino
mentioned this pull request
Mar 17, 2026
 Merged

@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
@joostjagerjoostjager
mentioned this pull request
Mar 23, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Drive splices to completion in chanmon_consistency by wpaulino · Pull Request #4411 · lightningdevkit/rust-lightning · GitHub
Skip to content
Drive splices to completion in chanmon_consistency - #4411
Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Feb 18, 2026
Merged
Drive splices to completion in chanmon_consistency#4411
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Conversation
@wpaulino
@wpaulinowpaulino
commented
Feb 12, 2026

Copy link


Copy Markdown

Contributor
There were two bugs preventing splices from negotiating up to the
`tx_signatures` exchange:
1. A `serial_id` collision because its generation used the first 4 bytes
of `get_secure_random_bytes`.
2. Opcodes 0xa2 and 0xa3 used the wrong vout for the input to splice in.
This commit fixes both, while also adding support for locking splices.
This required confirming transactions, which this target previously
didn't consider.

This PR also includes support for fuzzing async signing (though not during initial channel open) and a few miscellaneous fixes as a result of #4367.
After running the fuzzer for a bit with these changes, a few bugs were discovered that will be addressed separately.
@wpaulinowpaulino
added this to the 0.3 milestone
Feb 12, 2026
@wpaulinowpaulino
self-assigned this
Feb 12, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
TheBlueMatt
TheBlueMatt
reviewed
Feb 12, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm
Comment threadfuzz/src/chanmon_consistency.rs
Outdated

Comment threadfuzz/src/chanmon_consistency.rs
Outdated

@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026

Copy link


Copy Markdown

👋 The first review has been submitted!
Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.
@codecov
codecovBot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 85.89%. Comparing base (d09f1d2) to head (ff39dff).
⚠️ Report is 11 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #4411 +/- ##
==========================================
- Coverage 85.91% 85.89% -0.02% 
==========================================
Files 156 156 Lines 103958 103933 -25 Branches 103958 103933 -25 ==========================================
- Hits 89317 89277 -40 - Misses 12122 12137 +15 
Partials 2519 2519 
FlagCoverage Δ
tests85.89% <ø> (-0.02%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@wpaulino
wpaulinoforce-pushed
the
splice-fuzzing-fixes
branch
2 times, most recently
from
f6403f8 to
a10750dCompareFebruary 17, 2026 17:29
TheBlueMatt
TheBlueMatt
reviewed
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase.
@wpaulino
Support async signing in chanmon_consistency
ed520ae
This commit adds new opcodes to enable/disable signer operations one by
one. Note that this only covers signer operations post-funding.
@wpaulino
Drive splices to completion in chanmon_consistency
3c09513
This commit adds support for locking splices. This required confirming
transactions, which this target previously didn't consider.
It also fixes a `serial_id` collision, due to its generation using
the first 4 bytes of `get_secure_random_bytes`, that was preventing
splices from negotiating up to the `tx_signatures` exchange.
@wpaulino
Use channel_id over short_channel_id for payments in chanmon_consistency
c0c09c7
The `short_channel_id` is no longer guaranteed to be stable with
splicing now that the fuzzer can actually lock splices.
@wpaulino
Consider probe events for stuck payments check in chanmon_consistency
28ef7a8
Even though we don't explicitly send probes, because probes are detected
based on hashing the payment hash+preimage, it's rather trivial for the
fuzzer to build payments that accidentally end up looking like probes.
@wpaulino
Time out incomplete MPP payments in chanmon_consistency
520dcbb
This requires calling `timer_tick_occurred`. As a result, when
`timer_tick_occurred` is called, disabled/enabled updates and
`WarnAndDisconnect` events may be triggered.
@wpaulino
Add newline to fuzz log statements
7b8c68c
This regressed at some point, making the logs harder to parse on a
failed test run.
@wpaulino
Refactor channel splice operations into helper in chanmon_consistency
ff39dff
TheBlueMatt
TheBlueMatt
approved these changes
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks one comment for a followup, if you want.
Comment threadfuzz/src/chanmon_consistency.rs
@TheBlueMatt
TheBlueMatt
merged commit d627ce1
into
lightningdevkit:mainFeb 18, 2026

16 of 17 checks passed

@wpaulino
wpaulino
deleted the

splice-fuzzing-fixes

branch
February 18, 2026 22:58
@wpaulinowpaulino
mentioned this pull request
Mar 17, 2026
 Merged

@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
@joostjagerjoostjager
mentioned this pull request
Mar 23, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Drive splices to completion in chanmon_consistency by wpaulino · Pull Request #4411 · lightningdevkit/rust-lightning · GitHub
Skip to content
Drive splices to completion in chanmon_consistency - #4411
Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Feb 18, 2026
Merged
Drive splices to completion in chanmon_consistency#4411
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Conversation
@wpaulino
@wpaulinowpaulino
commented
Feb 12, 2026

Copy link


Copy Markdown

Contributor
There were two bugs preventing splices from negotiating up to the
`tx_signatures` exchange:
1. A `serial_id` collision because its generation used the first 4 bytes
of `get_secure_random_bytes`.
2. Opcodes 0xa2 and 0xa3 used the wrong vout for the input to splice in.
This commit fixes both, while also adding support for locking splices.
This required confirming transactions, which this target previously
didn't consider.

This PR also includes support for fuzzing async signing (though not during initial channel open) and a few miscellaneous fixes as a result of #4367.
After running the fuzzer for a bit with these changes, a few bugs were discovered that will be addressed separately.
@wpaulinowpaulino
added this to the 0.3 milestone
Feb 12, 2026
@wpaulinowpaulino
self-assigned this
Feb 12, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
TheBlueMatt
TheBlueMatt
reviewed
Feb 12, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm
Comment threadfuzz/src/chanmon_consistency.rs
Outdated

Comment threadfuzz/src/chanmon_consistency.rs
Outdated

@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026

Copy link


Copy Markdown

👋 The first review has been submitted!
Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.
@codecov
codecovBot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 85.89%. Comparing base (d09f1d2) to head (ff39dff).
⚠️ Report is 11 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #4411 +/- ##
==========================================
- Coverage 85.91% 85.89% -0.02% 
==========================================
Files 156 156 Lines 103958 103933 -25 Branches 103958 103933 -25 ==========================================
- Hits 89317 89277 -40 - Misses 12122 12137 +15 
Partials 2519 2519 
FlagCoverage Δ
tests85.89% <ø> (-0.02%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@wpaulino
wpaulinoforce-pushed
the
splice-fuzzing-fixes
branch
2 times, most recently
from
f6403f8 to
a10750dCompareFebruary 17, 2026 17:29
TheBlueMatt
TheBlueMatt
reviewed
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase.
@wpaulino
Support async signing in chanmon_consistency
ed520ae
This commit adds new opcodes to enable/disable signer operations one by
one. Note that this only covers signer operations post-funding.
@wpaulino
Drive splices to completion in chanmon_consistency
3c09513
This commit adds support for locking splices. This required confirming
transactions, which this target previously didn't consider.
It also fixes a `serial_id` collision, due to its generation using
the first 4 bytes of `get_secure_random_bytes`, that was preventing
splices from negotiating up to the `tx_signatures` exchange.
@wpaulino
Use channel_id over short_channel_id for payments in chanmon_consistency
c0c09c7
The `short_channel_id` is no longer guaranteed to be stable with
splicing now that the fuzzer can actually lock splices.
@wpaulino
Consider probe events for stuck payments check in chanmon_consistency
28ef7a8
Even though we don't explicitly send probes, because probes are detected
based on hashing the payment hash+preimage, it's rather trivial for the
fuzzer to build payments that accidentally end up looking like probes.
@wpaulino
Time out incomplete MPP payments in chanmon_consistency
520dcbb
This requires calling `timer_tick_occurred`. As a result, when
`timer_tick_occurred` is called, disabled/enabled updates and
`WarnAndDisconnect` events may be triggered.
@wpaulino
Add newline to fuzz log statements
7b8c68c
This regressed at some point, making the logs harder to parse on a
failed test run.
@wpaulino
Refactor channel splice operations into helper in chanmon_consistency
ff39dff
TheBlueMatt
TheBlueMatt
approved these changes
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks one comment for a followup, if you want.
Comment threadfuzz/src/chanmon_consistency.rs
@TheBlueMatt
TheBlueMatt
merged commit d627ce1
into
lightningdevkit:mainFeb 18, 2026

16 of 17 checks passed

@wpaulino
wpaulino
deleted the

splice-fuzzing-fixes

branch
February 18, 2026 22:58
@wpaulinowpaulino
mentioned this pull request
Mar 17, 2026
 Merged

@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
@joostjagerjoostjager
mentioned this pull request
Mar 23, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Drive splices to completion in chanmon_consistency by wpaulino · Pull Request #4411 · lightningdevkit/rust-lightning · GitHub
Skip to content
Drive splices to completion in chanmon_consistency - #4411
Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Feb 18, 2026
Merged
Drive splices to completion in chanmon_consistency#4411
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Conversation
@wpaulino
@wpaulinowpaulino
commented
Feb 12, 2026

Copy link


Copy Markdown

Contributor
There were two bugs preventing splices from negotiating up to the
`tx_signatures` exchange:
1. A `serial_id` collision because its generation used the first 4 bytes
of `get_secure_random_bytes`.
2. Opcodes 0xa2 and 0xa3 used the wrong vout for the input to splice in.
This commit fixes both, while also adding support for locking splices.
This required confirming transactions, which this target previously
didn't consider.

This PR also includes support for fuzzing async signing (though not during initial channel open) and a few miscellaneous fixes as a result of #4367.
After running the fuzzer for a bit with these changes, a few bugs were discovered that will be addressed separately.
@wpaulinowpaulino
added this to the 0.3 milestone
Feb 12, 2026
@wpaulinowpaulino
self-assigned this
Feb 12, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
TheBlueMatt
TheBlueMatt
reviewed
Feb 12, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm
Comment threadfuzz/src/chanmon_consistency.rs
Outdated

Comment threadfuzz/src/chanmon_consistency.rs
Outdated

@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026

Copy link


Copy Markdown

👋 The first review has been submitted!
Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.
@codecov
codecovBot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 85.89%. Comparing base (d09f1d2) to head (ff39dff).
⚠️ Report is 11 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #4411 +/- ##
==========================================
- Coverage 85.91% 85.89% -0.02% 
==========================================
Files 156 156 Lines 103958 103933 -25 Branches 103958 103933 -25 ==========================================
- Hits 89317 89277 -40 - Misses 12122 12137 +15 
Partials 2519 2519 
FlagCoverage Δ
tests85.89% <ø> (-0.02%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@wpaulino
wpaulinoforce-pushed
the
splice-fuzzing-fixes
branch
2 times, most recently
from
f6403f8 to
a10750dCompareFebruary 17, 2026 17:29
TheBlueMatt
TheBlueMatt
reviewed
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase.
@wpaulino
Support async signing in chanmon_consistency
ed520ae
This commit adds new opcodes to enable/disable signer operations one by
one. Note that this only covers signer operations post-funding.
@wpaulino
Drive splices to completion in chanmon_consistency
3c09513
This commit adds support for locking splices. This required confirming
transactions, which this target previously didn't consider.
It also fixes a `serial_id` collision, due to its generation using
the first 4 bytes of `get_secure_random_bytes`, that was preventing
splices from negotiating up to the `tx_signatures` exchange.
@wpaulino
Use channel_id over short_channel_id for payments in chanmon_consistency
c0c09c7
The `short_channel_id` is no longer guaranteed to be stable with
splicing now that the fuzzer can actually lock splices.
@wpaulino
Consider probe events for stuck payments check in chanmon_consistency
28ef7a8
Even though we don't explicitly send probes, because probes are detected
based on hashing the payment hash+preimage, it's rather trivial for the
fuzzer to build payments that accidentally end up looking like probes.
@wpaulino
Time out incomplete MPP payments in chanmon_consistency
520dcbb
This requires calling `timer_tick_occurred`. As a result, when
`timer_tick_occurred` is called, disabled/enabled updates and
`WarnAndDisconnect` events may be triggered.
@wpaulino
Add newline to fuzz log statements
7b8c68c
This regressed at some point, making the logs harder to parse on a
failed test run.
@wpaulino
Refactor channel splice operations into helper in chanmon_consistency
ff39dff
TheBlueMatt
TheBlueMatt
approved these changes
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks one comment for a followup, if you want.
Comment threadfuzz/src/chanmon_consistency.rs
@TheBlueMatt
TheBlueMatt
merged commit d627ce1
into
lightningdevkit:mainFeb 18, 2026

16 of 17 checks passed

@wpaulino
wpaulino
deleted the

splice-fuzzing-fixes

branch
February 18, 2026 22:58
@wpaulinowpaulino
mentioned this pull request
Mar 17, 2026
 Merged

@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
@joostjagerjoostjager
mentioned this pull request
Mar 23, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Drive splices to completion in chanmon_consistency by wpaulino · Pull Request #4411 · lightningdevkit/rust-lightning · GitHub
Skip to content
Drive splices to completion in chanmon_consistency - #4411
Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Feb 18, 2026
Merged
Drive splices to completion in chanmon_consistency#4411
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Conversation
@wpaulino
@wpaulinowpaulino
commented
Feb 12, 2026

Copy link


Copy Markdown

Contributor
There were two bugs preventing splices from negotiating up to the
`tx_signatures` exchange:
1. A `serial_id` collision because its generation used the first 4 bytes
of `get_secure_random_bytes`.
2. Opcodes 0xa2 and 0xa3 used the wrong vout for the input to splice in.
This commit fixes both, while also adding support for locking splices.
This required confirming transactions, which this target previously
didn't consider.

This PR also includes support for fuzzing async signing (though not during initial channel open) and a few miscellaneous fixes as a result of #4367.
After running the fuzzer for a bit with these changes, a few bugs were discovered that will be addressed separately.
@wpaulinowpaulino
added this to the 0.3 milestone
Feb 12, 2026
@wpaulinowpaulino
self-assigned this
Feb 12, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
TheBlueMatt
TheBlueMatt
reviewed
Feb 12, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm
Comment threadfuzz/src/chanmon_consistency.rs
Outdated

Comment threadfuzz/src/chanmon_consistency.rs
Outdated

@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026

Copy link


Copy Markdown

👋 The first review has been submitted!
Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.
@codecov
codecovBot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 85.89%. Comparing base (d09f1d2) to head (ff39dff).
⚠️ Report is 11 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #4411 +/- ##
==========================================
- Coverage 85.91% 85.89% -0.02% 
==========================================
Files 156 156 Lines 103958 103933 -25 Branches 103958 103933 -25 ==========================================
- Hits 89317 89277 -40 - Misses 12122 12137 +15 
Partials 2519 2519 
FlagCoverage Δ
tests85.89% <ø> (-0.02%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@wpaulino
wpaulinoforce-pushed
the
splice-fuzzing-fixes
branch
2 times, most recently
from
f6403f8 to
a10750dCompareFebruary 17, 2026 17:29
TheBlueMatt
TheBlueMatt
reviewed
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase.
@wpaulino
Support async signing in chanmon_consistency
ed520ae
This commit adds new opcodes to enable/disable signer operations one by
one. Note that this only covers signer operations post-funding.
@wpaulino
Drive splices to completion in chanmon_consistency
3c09513
This commit adds support for locking splices. This required confirming
transactions, which this target previously didn't consider.
It also fixes a `serial_id` collision, due to its generation using
the first 4 bytes of `get_secure_random_bytes`, that was preventing
splices from negotiating up to the `tx_signatures` exchange.
@wpaulino
Use channel_id over short_channel_id for payments in chanmon_consistency
c0c09c7
The `short_channel_id` is no longer guaranteed to be stable with
splicing now that the fuzzer can actually lock splices.
@wpaulino
Consider probe events for stuck payments check in chanmon_consistency
28ef7a8
Even though we don't explicitly send probes, because probes are detected
based on hashing the payment hash+preimage, it's rather trivial for the
fuzzer to build payments that accidentally end up looking like probes.
@wpaulino
Time out incomplete MPP payments in chanmon_consistency
520dcbb
This requires calling `timer_tick_occurred`. As a result, when
`timer_tick_occurred` is called, disabled/enabled updates and
`WarnAndDisconnect` events may be triggered.
@wpaulino
Add newline to fuzz log statements
7b8c68c
This regressed at some point, making the logs harder to parse on a
failed test run.
@wpaulino
Refactor channel splice operations into helper in chanmon_consistency
ff39dff
TheBlueMatt
TheBlueMatt
approved these changes
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks one comment for a followup, if you want.
Comment threadfuzz/src/chanmon_consistency.rs
@TheBlueMatt
TheBlueMatt
merged commit d627ce1
into
lightningdevkit:mainFeb 18, 2026

16 of 17 checks passed

@wpaulino
wpaulino
deleted the

splice-fuzzing-fixes

branch
February 18, 2026 22:58
@wpaulinowpaulino
mentioned this pull request
Mar 17, 2026
 Merged

@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
@joostjagerjoostjager
mentioned this pull request
Mar 23, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Drive splices to completion in chanmon_consistency by wpaulino · Pull Request #4411 · lightningdevkit/rust-lightning · GitHub
Skip to content
Drive splices to completion in chanmon_consistency - #4411
Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Feb 18, 2026
Merged
Drive splices to completion in chanmon_consistency#4411
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Conversation
@wpaulino
@wpaulinowpaulino
commented
Feb 12, 2026

Copy link


Copy Markdown

Contributor
There were two bugs preventing splices from negotiating up to the
`tx_signatures` exchange:
1. A `serial_id` collision because its generation used the first 4 bytes
of `get_secure_random_bytes`.
2. Opcodes 0xa2 and 0xa3 used the wrong vout for the input to splice in.
This commit fixes both, while also adding support for locking splices.
This required confirming transactions, which this target previously
didn't consider.

This PR also includes support for fuzzing async signing (though not during initial channel open) and a few miscellaneous fixes as a result of #4367.
After running the fuzzer for a bit with these changes, a few bugs were discovered that will be addressed separately.
@wpaulinowpaulino
added this to the 0.3 milestone
Feb 12, 2026
@wpaulinowpaulino
self-assigned this
Feb 12, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
TheBlueMatt
TheBlueMatt
reviewed
Feb 12, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm
Comment threadfuzz/src/chanmon_consistency.rs
Outdated

Comment threadfuzz/src/chanmon_consistency.rs
Outdated

@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026

Copy link


Copy Markdown

👋 The first review has been submitted!
Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.
@codecov
codecovBot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 85.89%. Comparing base (d09f1d2) to head (ff39dff).
⚠️ Report is 11 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #4411 +/- ##
==========================================
- Coverage 85.91% 85.89% -0.02% 
==========================================
Files 156 156 Lines 103958 103933 -25 Branches 103958 103933 -25 ==========================================
- Hits 89317 89277 -40 - Misses 12122 12137 +15 
Partials 2519 2519 
FlagCoverage Δ
tests85.89% <ø> (-0.02%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@wpaulino
wpaulinoforce-pushed
the
splice-fuzzing-fixes
branch
2 times, most recently
from
f6403f8 to
a10750dCompareFebruary 17, 2026 17:29
TheBlueMatt
TheBlueMatt
reviewed
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase.
@wpaulino
Support async signing in chanmon_consistency
ed520ae
This commit adds new opcodes to enable/disable signer operations one by
one. Note that this only covers signer operations post-funding.
@wpaulino
Drive splices to completion in chanmon_consistency
3c09513
This commit adds support for locking splices. This required confirming
transactions, which this target previously didn't consider.
It also fixes a `serial_id` collision, due to its generation using
the first 4 bytes of `get_secure_random_bytes`, that was preventing
splices from negotiating up to the `tx_signatures` exchange.
@wpaulino
Use channel_id over short_channel_id for payments in chanmon_consistency
c0c09c7
The `short_channel_id` is no longer guaranteed to be stable with
splicing now that the fuzzer can actually lock splices.
@wpaulino
Consider probe events for stuck payments check in chanmon_consistency
28ef7a8
Even though we don't explicitly send probes, because probes are detected
based on hashing the payment hash+preimage, it's rather trivial for the
fuzzer to build payments that accidentally end up looking like probes.
@wpaulino
Time out incomplete MPP payments in chanmon_consistency
520dcbb
This requires calling `timer_tick_occurred`. As a result, when
`timer_tick_occurred` is called, disabled/enabled updates and
`WarnAndDisconnect` events may be triggered.
@wpaulino
Add newline to fuzz log statements
7b8c68c
This regressed at some point, making the logs harder to parse on a
failed test run.
@wpaulino
Refactor channel splice operations into helper in chanmon_consistency
ff39dff
TheBlueMatt
TheBlueMatt
approved these changes
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks one comment for a followup, if you want.
Comment threadfuzz/src/chanmon_consistency.rs
@TheBlueMatt
TheBlueMatt
merged commit d627ce1
into
lightningdevkit:mainFeb 18, 2026

16 of 17 checks passed

@wpaulino
wpaulino
deleted the

splice-fuzzing-fixes

branch
February 18, 2026 22:58
@wpaulinowpaulino
mentioned this pull request
Mar 17, 2026
 Merged

@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
@joostjagerjoostjager
mentioned this pull request
Mar 23, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Drive splices to completion in chanmon_consistency by wpaulino · Pull Request #4411 · lightningdevkit/rust-lightning · GitHub
Skip to content
Drive splices to completion in chanmon_consistency - #4411
Merged
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Feb 18, 2026
Merged
Drive splices to completion in chanmon_consistency#4411
TheBlueMatt merged 7 commits into
lightningdevkit:mainfrom 
wpaulino:splice-fuzzing-fixes
Conversation
@wpaulino
@wpaulinowpaulino
commented
Feb 12, 2026

Copy link


Copy Markdown

Contributor
There were two bugs preventing splices from negotiating up to the
`tx_signatures` exchange:
1. A `serial_id` collision because its generation used the first 4 bytes
of `get_secure_random_bytes`.
2. Opcodes 0xa2 and 0xa3 used the wrong vout for the input to splice in.
This commit fixes both, while also adding support for locking splices.
This required confirming transactions, which this target previously
didn't consider.

This PR also includes support for fuzzing async signing (though not during initial channel open) and a few miscellaneous fixes as a result of #4367.
After running the fuzzer for a bit with these changes, a few bugs were discovered that will be addressed separately.
@wpaulinowpaulino
added this to the 0.3 milestone
Feb 12, 2026
@wpaulinowpaulino
self-assigned this
Feb 12, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
TheBlueMatt
TheBlueMatt
reviewed
Feb 12, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm
Comment threadfuzz/src/chanmon_consistency.rs
Outdated

Comment threadfuzz/src/chanmon_consistency.rs
Outdated

@ldk-reviews-bot
ldk-reviews-bot
commented
Feb 12, 2026

Copy link


Copy Markdown

👋 The first review has been submitted!
Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.
@codecov
codecovBot
commented
Feb 12, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 85.89%. Comparing base (d09f1d2) to head (ff39dff).
⚠️ Report is 11 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #4411 +/- ##
==========================================
- Coverage 85.91% 85.89% -0.02% 
==========================================
Files 156 156 Lines 103958 103933 -25 Branches 103958 103933 -25 ==========================================
- Hits 89317 89277 -40 - Misses 12122 12137 +15 
Partials 2519 2519 
FlagCoverage Δ
tests85.89% <ø> (-0.02%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@wpaulino
wpaulinoforce-pushed
the
splice-fuzzing-fixes
branch
2 times, most recently
from
f6403f8 to
a10750dCompareFebruary 17, 2026 17:29
TheBlueMatt
TheBlueMatt
reviewed
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase.
@wpaulino
Support async signing in chanmon_consistency
ed520ae
This commit adds new opcodes to enable/disable signer operations one by
one. Note that this only covers signer operations post-funding.
@wpaulino
Drive splices to completion in chanmon_consistency
3c09513
This commit adds support for locking splices. This required confirming
transactions, which this target previously didn't consider.
It also fixes a `serial_id` collision, due to its generation using
the first 4 bytes of `get_secure_random_bytes`, that was preventing
splices from negotiating up to the `tx_signatures` exchange.
@wpaulino
Use channel_id over short_channel_id for payments in chanmon_consistency
c0c09c7
The `short_channel_id` is no longer guaranteed to be stable with
splicing now that the fuzzer can actually lock splices.
@wpaulino
Consider probe events for stuck payments check in chanmon_consistency
28ef7a8
Even though we don't explicitly send probes, because probes are detected
based on hashing the payment hash+preimage, it's rather trivial for the
fuzzer to build payments that accidentally end up looking like probes.
@wpaulino
Time out incomplete MPP payments in chanmon_consistency
520dcbb
This requires calling `timer_tick_occurred`. As a result, when
`timer_tick_occurred` is called, disabled/enabled updates and
`WarnAndDisconnect` events may be triggered.
@wpaulino
Add newline to fuzz log statements
7b8c68c
This regressed at some point, making the logs harder to parse on a
failed test run.
@wpaulino
Refactor channel splice operations into helper in chanmon_consistency
ff39dff
TheBlueMatt
TheBlueMatt
approved these changes
Feb 18, 2026
View reviewed changes
@TheBlueMattTheBlueMatt
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks one comment for a followup, if you want.
Comment threadfuzz/src/chanmon_consistency.rs
@TheBlueMatt
TheBlueMatt
merged commit d627ce1
into
lightningdevkit:mainFeb 18, 2026

16 of 17 checks passed

@wpaulino
wpaulino
deleted the

splice-fuzzing-fixes

branch
February 18, 2026 22:58
@wpaulinowpaulino
mentioned this pull request
Mar 17, 2026
 Merged

@jkczyzjkczyz
mentioned this pull request
Mar 19, 2026

Open

50 tasks
@joostjagerjoostjager
mentioned this pull request
Mar 23, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattTheBlueMatt approved these changes

Assignees

@wpaulinowpaulino

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone

0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@wpaulino@ldk-reviews-bot@TheBlueMatt