Rustfmt ChannelManager splice message handlers by wpaulino · Pull Request #4412 · lightningdevkit/rust-lightning

wpaulino · 2026-02-12T01:03:02Z

Should we squash all the rustfmt commits into one to keep the git history tidier?

We have the same error being returned from several `ChannelManager` message handlers, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

We have the same error being returned from several `ChannelManager` API methods, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

ldk-reviews-bot · 2026-02-12T01:03:06Z

👋 I see @tankyleo was un-assigned.
If you'd like another reviewer assignment, please click here.

codecov · 2026-02-12T05:23:57Z

Codecov Report

❌ Patch coverage is 52.07756% with 173 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.06%. Comparing base (2647583) to head (fb6d61a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	49.56%	159 Missing and 14 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4412 +/- ##
==========================================
+ Coverage 86.05% 86.06% +0.01% 
==========================================
Files 156 156 Lines 103384 103454 +70 Branches 103384 103454 +70 ==========================================
+ Hits 88971 89042 +71 + Misses 11900 11896 -4 - Partials 2513 2516 +3

Flag	Coverage Δ
tests	`86.06% <52.07%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TheBlueMatt

There's random formatting in the first two prefactors which is weird.

wpaulino · 2026-02-12T22:40:23Z

There's random formatting in the first two prefactors which is weird.

That's because the formatter wasn't actually being applied due to the inlined macro call.

wpaulino · 2026-02-12T01:03:02Z

Should we squash all the rustfmt commits into one to keep the git history tidier?

We have the same error being returned from several `ChannelManager` message handlers, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

We have the same error being returned from several `ChannelManager` API methods, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

ldk-reviews-bot · 2026-02-12T01:03:06Z

👋 I see @tankyleo was un-assigned.
If you'd like another reviewer assignment, please click here.

codecov · 2026-02-12T05:23:57Z

Codecov Report

❌ Patch coverage is 52.07756% with 173 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.06%. Comparing base (2647583) to head (fb6d61a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	49.56%	159 Missing and 14 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4412 +/- ##
==========================================
+ Coverage 86.05% 86.06% +0.01% 
==========================================
Files 156 156 Lines 103384 103454 +70 Branches 103384 103454 +70 ==========================================
+ Hits 88971 89042 +71 + Misses 11900 11896 -4 - Partials 2513 2516 +3

Flag	Coverage Δ
tests	`86.06% <52.07%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TheBlueMatt

There's random formatting in the first two prefactors which is weird.

wpaulino · 2026-02-12T22:40:23Z

There's random formatting in the first two prefactors which is weird.

That's because the formatter wasn't actually being applied due to the inlined macro call.

wpaulino · 2026-02-12T01:03:02Z

Should we squash all the rustfmt commits into one to keep the git history tidier?

We have the same error being returned from several `ChannelManager` message handlers, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

We have the same error being returned from several `ChannelManager` API methods, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

ldk-reviews-bot · 2026-02-12T01:03:06Z

👋 I see @tankyleo was un-assigned.
If you'd like another reviewer assignment, please click here.

codecov · 2026-02-12T05:23:57Z

Codecov Report

❌ Patch coverage is 52.07756% with 173 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.06%. Comparing base (2647583) to head (fb6d61a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	49.56%	159 Missing and 14 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4412 +/- ##
==========================================
+ Coverage 86.05% 86.06% +0.01% 
==========================================
Files 156 156 Lines 103384 103454 +70 Branches 103384 103454 +70 ==========================================
+ Hits 88971 89042 +71 + Misses 11900 11896 -4 - Partials 2513 2516 +3

Flag	Coverage Δ
tests	`86.06% <52.07%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TheBlueMatt

There's random formatting in the first two prefactors which is weird.

wpaulino · 2026-02-12T22:40:23Z

There's random formatting in the first two prefactors which is weird.

That's because the formatter wasn't actually being applied due to the inlined macro call.

wpaulino · 2026-02-12T01:03:02Z

Should we squash all the rustfmt commits into one to keep the git history tidier?

We have the same error being returned from several `ChannelManager` message handlers, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

We have the same error being returned from several `ChannelManager` API methods, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

ldk-reviews-bot · 2026-02-12T01:03:06Z

👋 I see @tankyleo was un-assigned.
If you'd like another reviewer assignment, please click here.

codecov · 2026-02-12T05:23:57Z

Codecov Report

❌ Patch coverage is 52.07756% with 173 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.06%. Comparing base (2647583) to head (fb6d61a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	49.56%	159 Missing and 14 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4412 +/- ##
==========================================
+ Coverage 86.05% 86.06% +0.01% 
==========================================
Files 156 156 Lines 103384 103454 +70 Branches 103384 103454 +70 ==========================================
+ Hits 88971 89042 +71 + Misses 11900 11896 -4 - Partials 2513 2516 +3

Flag	Coverage Δ
tests	`86.06% <52.07%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TheBlueMatt

There's random formatting in the first two prefactors which is weird.

wpaulino · 2026-02-12T22:40:23Z

There's random formatting in the first two prefactors which is weird.

That's because the formatter wasn't actually being applied due to the inlined macro call.

wpaulino · 2026-02-12T01:03:02Z

Should we squash all the rustfmt commits into one to keep the git history tidier?

We have the same error being returned from several `ChannelManager` message handlers, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

We have the same error being returned from several `ChannelManager` API methods, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

ldk-reviews-bot · 2026-02-12T01:03:06Z

👋 I see @tankyleo was un-assigned.
If you'd like another reviewer assignment, please click here.

codecov · 2026-02-12T05:23:57Z

Codecov Report

❌ Patch coverage is 52.07756% with 173 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.06%. Comparing base (2647583) to head (fb6d61a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	49.56%	159 Missing and 14 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4412 +/- ##
==========================================
+ Coverage 86.05% 86.06% +0.01% 
==========================================
Files 156 156 Lines 103384 103454 +70 Branches 103384 103454 +70 ==========================================
+ Hits 88971 89042 +71 + Misses 11900 11896 -4 - Partials 2513 2516 +3

Flag	Coverage Δ
tests	`86.06% <52.07%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TheBlueMatt

There's random formatting in the first two prefactors which is weird.

wpaulino · 2026-02-12T22:40:23Z

There's random formatting in the first two prefactors which is weird.

That's because the formatter wasn't actually being applied due to the inlined macro call.

wpaulino · 2026-02-12T01:03:02Z

Should we squash all the rustfmt commits into one to keep the git history tidier?

We have the same error being returned from several `ChannelManager` message handlers, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

We have the same error being returned from several `ChannelManager` API methods, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

ldk-reviews-bot · 2026-02-12T01:03:06Z

👋 I see @tankyleo was un-assigned.
If you'd like another reviewer assignment, please click here.

codecov · 2026-02-12T05:23:57Z

Codecov Report

❌ Patch coverage is 52.07756% with 173 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.06%. Comparing base (2647583) to head (fb6d61a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	49.56%	159 Missing and 14 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4412 +/- ##
==========================================
+ Coverage 86.05% 86.06% +0.01% 
==========================================
Files 156 156 Lines 103384 103454 +70 Branches 103384 103454 +70 ==========================================
+ Hits 88971 89042 +71 + Misses 11900 11896 -4 - Partials 2513 2516 +3

Flag	Coverage Δ
tests	`86.06% <52.07%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TheBlueMatt

There's random formatting in the first two prefactors which is weird.

wpaulino · 2026-02-12T22:40:23Z

There's random formatting in the first two prefactors which is weird.

That's because the formatter wasn't actually being applied due to the inlined macro call.

wpaulino · 2026-02-12T01:03:02Z

Should we squash all the rustfmt commits into one to keep the git history tidier?

We have the same error being returned from several `ChannelManager` message handlers, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

We have the same error being returned from several `ChannelManager` API methods, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

ldk-reviews-bot · 2026-02-12T01:03:06Z

👋 I see @tankyleo was un-assigned.
If you'd like another reviewer assignment, please click here.

codecov · 2026-02-12T05:23:57Z

Codecov Report

❌ Patch coverage is 52.07756% with 173 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.06%. Comparing base (2647583) to head (fb6d61a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	49.56%	159 Missing and 14 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4412 +/- ##
==========================================
+ Coverage 86.05% 86.06% +0.01% 
==========================================
Files 156 156 Lines 103384 103454 +70 Branches 103384 103454 +70 ==========================================
+ Hits 88971 89042 +71 + Misses 11900 11896 -4 - Partials 2513 2516 +3

Flag	Coverage Δ
tests	`86.06% <52.07%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TheBlueMatt

There's random formatting in the first two prefactors which is weird.

wpaulino · 2026-02-12T22:40:23Z

There's random formatting in the first two prefactors which is weird.

That's because the formatter wasn't actually being applied due to the inlined macro call.

wpaulino · 2026-02-12T01:03:02Z

Should we squash all the rustfmt commits into one to keep the git history tidier?

We have the same error being returned from several `ChannelManager` message handlers, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

We have the same error being returned from several `ChannelManager` API methods, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.

ldk-reviews-bot · 2026-02-12T01:03:06Z

👋 I see @tankyleo was un-assigned.
If you'd like another reviewer assignment, please click here.

codecov · 2026-02-12T05:23:57Z

Codecov Report

❌ Patch coverage is 52.07756% with 173 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.06%. Comparing base (2647583) to head (fb6d61a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/channelmanager.rs	49.56%	159 Missing and 14 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4412 +/- ##
==========================================
+ Coverage 86.05% 86.06% +0.01% 
==========================================
Files 156 156 Lines 103384 103454 +70 Branches 103384 103454 +70 ==========================================
+ Hits 88971 89042 +71 + Misses 11900 11896 -4 - Partials 2513 2516 +3

Flag	Coverage Δ
tests	`86.06% <52.07%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TheBlueMatt

There's random formatting in the first two prefactors which is weird.

wpaulino · 2026-02-12T22:40:23Z

There's random formatting in the first two prefactors which is weird.

That's because the formatter wasn't actually being applied due to the inlined macro call.

wpaulino added 8 commits February 11, 2026 16:59

Rustfmt ChannelManager::internal_tx_complete
4d35de5

Rustfmt ChannelManager::internal_tx_signatures
146f29a

Rustfmt ChannelManager::internal_tx_abort
0eadc17

Rustfmt ChannelManager::internal_splice_ack
e1d0566

Rustfmt ChannelManager::internal_splice_init
7752619

Rustfmt ChannelManager::internal_commitment_signed
fb6d61a

wpaulino self-assigned this Feb 12, 2026

ldk-reviews-bot requested a review from tankyleo February 12, 2026 01:13

wpaulino mentioned this pull request Feb 12, 2026
Free holding cell in remaining quiescence-exit code paths #4415
Merged

TheBlueMatt approved these changes Feb 12, 2026
View reviewed changes

Comment threadlightning/src/ln/channelmanager.rs
Comment threadlightning/src/ln/channelmanager.rs

TheBlueMatt merged commit 0b45bfd into lightningdevkit:mainFeb 12, 2026
16 checks passed

wpaulino deleted the rustfmt-channelmanager-splice-msg-handlers branch February 12, 2026 22:40

tankyleo removed their request for review February 13, 2026 19:48

jkczyz mentioned this pull request Mar 19, 2026
Splicing / Dual Funding #4284
Open
50 tasks