Remove test util macros by elnosh · Pull Request #4425 · lightningdevkit/rust-lightning

elnosh · 2026-02-18T22:21:36Z

Removed some macros that could be replaced 1:1 with function calls by the same name.

check_closed_broadcast
get_payment_preimage_hash
get_closing_signed_broadcast

Did this while trying out claude

ldk-reviews-bot · 2026-02-18T22:21:38Z

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

codecov · 2026-02-19T00:36:36Z

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.90%. Comparing base (1b8617c) to head (28388c4).
⚠️ Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/functional_test_utils.rs	95.23%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4425 +/- ##
=======================================
Coverage 85.90% 85.90% =======================================
Files 156 156 Lines 103990 103983 -7 Branches 103990 103983 -7 =======================================
- Hits 89333 89327 -6 
Misses 12135 12135 + Partials 2522 2521 -1

Flag	Coverage Δ
tests	`85.90% <96.15%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wpaulino · 2026-02-19T00:54:25Z

 	let reason = ClosureReason::HolderForceClosed { broadcasted_latest_txn: Some(true), message };
 	check_closed_event(&nodes[0], 1, reason, &[node_b_id], 100000);
-	check_closed_broadcast!(nodes[0], true);
+	check_closed_broadcast(&nodes[0], 1, true).pop();


Usually we don't call pop since we rely on the length assertion

ldk-reviews-bot · 2026-02-19T00:56:31Z

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

elnosh · 2026-02-18T22:21:36Z

Removed some macros that could be replaced 1:1 with function calls by the same name.

check_closed_broadcast
get_payment_preimage_hash
get_closing_signed_broadcast

Did this while trying out claude

ldk-reviews-bot · 2026-02-18T22:21:38Z

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

codecov · 2026-02-19T00:36:36Z

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.90%. Comparing base (1b8617c) to head (28388c4).
⚠️ Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/functional_test_utils.rs	95.23%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4425 +/- ##
=======================================
Coverage 85.90% 85.90% =======================================
Files 156 156 Lines 103990 103983 -7 Branches 103990 103983 -7 =======================================
- Hits 89333 89327 -6 
Misses 12135 12135 + Partials 2522 2521 -1

Flag	Coverage Δ
tests	`85.90% <96.15%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wpaulino · 2026-02-19T00:54:25Z

 	let reason = ClosureReason::HolderForceClosed { broadcasted_latest_txn: Some(true), message };
 	check_closed_event(&nodes[0], 1, reason, &[node_b_id], 100000);
-	check_closed_broadcast!(nodes[0], true);
+	check_closed_broadcast(&nodes[0], 1, true).pop();


Usually we don't call pop since we rely on the length assertion

ldk-reviews-bot · 2026-02-19T00:56:31Z

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

elnosh · 2026-02-18T22:21:36Z

Removed some macros that could be replaced 1:1 with function calls by the same name.

check_closed_broadcast
get_payment_preimage_hash
get_closing_signed_broadcast

Did this while trying out claude

ldk-reviews-bot · 2026-02-18T22:21:38Z

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

codecov · 2026-02-19T00:36:36Z

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.90%. Comparing base (1b8617c) to head (28388c4).
⚠️ Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/functional_test_utils.rs	95.23%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4425 +/- ##
=======================================
Coverage 85.90% 85.90% =======================================
Files 156 156 Lines 103990 103983 -7 Branches 103990 103983 -7 =======================================
- Hits 89333 89327 -6 
Misses 12135 12135 + Partials 2522 2521 -1

Flag	Coverage Δ
tests	`85.90% <96.15%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wpaulino · 2026-02-19T00:54:25Z

 	let reason = ClosureReason::HolderForceClosed { broadcasted_latest_txn: Some(true), message };
 	check_closed_event(&nodes[0], 1, reason, &[node_b_id], 100000);
-	check_closed_broadcast!(nodes[0], true);
+	check_closed_broadcast(&nodes[0], 1, true).pop();


Usually we don't call pop since we rely on the length assertion

ldk-reviews-bot · 2026-02-19T00:56:31Z

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

elnosh · 2026-02-18T22:21:36Z

Removed some macros that could be replaced 1:1 with function calls by the same name.

check_closed_broadcast
get_payment_preimage_hash
get_closing_signed_broadcast

Did this while trying out claude

ldk-reviews-bot · 2026-02-18T22:21:38Z

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

codecov · 2026-02-19T00:36:36Z

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.90%. Comparing base (1b8617c) to head (28388c4).
⚠️ Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/functional_test_utils.rs	95.23%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4425 +/- ##
=======================================
Coverage 85.90% 85.90% =======================================
Files 156 156 Lines 103990 103983 -7 Branches 103990 103983 -7 =======================================
- Hits 89333 89327 -6 
Misses 12135 12135 + Partials 2522 2521 -1

Flag	Coverage Δ
tests	`85.90% <96.15%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wpaulino · 2026-02-19T00:54:25Z

 	let reason = ClosureReason::HolderForceClosed { broadcasted_latest_txn: Some(true), message };
 	check_closed_event(&nodes[0], 1, reason, &[node_b_id], 100000);
-	check_closed_broadcast!(nodes[0], true);
+	check_closed_broadcast(&nodes[0], 1, true).pop();


Usually we don't call pop since we rely on the length assertion

ldk-reviews-bot · 2026-02-19T00:56:31Z

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

elnosh · 2026-02-18T22:21:36Z

Removed some macros that could be replaced 1:1 with function calls by the same name.

check_closed_broadcast
get_payment_preimage_hash
get_closing_signed_broadcast

Did this while trying out claude

ldk-reviews-bot · 2026-02-18T22:21:38Z

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

codecov · 2026-02-19T00:36:36Z

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.90%. Comparing base (1b8617c) to head (28388c4).
⚠️ Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/functional_test_utils.rs	95.23%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4425 +/- ##
=======================================
Coverage 85.90% 85.90% =======================================
Files 156 156 Lines 103990 103983 -7 Branches 103990 103983 -7 =======================================
- Hits 89333 89327 -6 
Misses 12135 12135 + Partials 2522 2521 -1

Flag	Coverage Δ
tests	`85.90% <96.15%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wpaulino · 2026-02-19T00:54:25Z

 	let reason = ClosureReason::HolderForceClosed { broadcasted_latest_txn: Some(true), message };
 	check_closed_event(&nodes[0], 1, reason, &[node_b_id], 100000);
-	check_closed_broadcast!(nodes[0], true);
+	check_closed_broadcast(&nodes[0], 1, true).pop();


Usually we don't call pop since we rely on the length assertion

ldk-reviews-bot · 2026-02-19T00:56:31Z

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

elnosh · 2026-02-18T22:21:36Z

Removed some macros that could be replaced 1:1 with function calls by the same name.

check_closed_broadcast
get_payment_preimage_hash
get_closing_signed_broadcast

Did this while trying out claude

ldk-reviews-bot · 2026-02-18T22:21:38Z

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

codecov · 2026-02-19T00:36:36Z

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.90%. Comparing base (1b8617c) to head (28388c4).
⚠️ Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/functional_test_utils.rs	95.23%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4425 +/- ##
=======================================
Coverage 85.90% 85.90% =======================================
Files 156 156 Lines 103990 103983 -7 Branches 103990 103983 -7 =======================================
- Hits 89333 89327 -6 
Misses 12135 12135 + Partials 2522 2521 -1

Flag	Coverage Δ
tests	`85.90% <96.15%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wpaulino · 2026-02-19T00:54:25Z

 	let reason = ClosureReason::HolderForceClosed { broadcasted_latest_txn: Some(true), message };
 	check_closed_event(&nodes[0], 1, reason, &[node_b_id], 100000);
-	check_closed_broadcast!(nodes[0], true);
+	check_closed_broadcast(&nodes[0], 1, true).pop();


Usually we don't call pop since we rely on the length assertion

ldk-reviews-bot · 2026-02-19T00:56:31Z

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

elnosh · 2026-02-18T22:21:36Z

Removed some macros that could be replaced 1:1 with function calls by the same name.

check_closed_broadcast
get_payment_preimage_hash
get_closing_signed_broadcast

Did this while trying out claude

ldk-reviews-bot · 2026-02-18T22:21:38Z

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

codecov · 2026-02-19T00:36:36Z

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.90%. Comparing base (1b8617c) to head (28388c4).
⚠️ Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/functional_test_utils.rs	95.23%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4425 +/- ##
=======================================
Coverage 85.90% 85.90% =======================================
Files 156 156 Lines 103990 103983 -7 Branches 103990 103983 -7 =======================================
- Hits 89333 89327 -6 
Misses 12135 12135 + Partials 2522 2521 -1

Flag	Coverage Δ
tests	`85.90% <96.15%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wpaulino · 2026-02-19T00:54:25Z

 	let reason = ClosureReason::HolderForceClosed { broadcasted_latest_txn: Some(true), message };
 	check_closed_event(&nodes[0], 1, reason, &[node_b_id], 100000);
-	check_closed_broadcast!(nodes[0], true);
+	check_closed_broadcast(&nodes[0], 1, true).pop();


Usually we don't call pop since we rely on the length assertion

ldk-reviews-bot · 2026-02-19T00:56:31Z

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

elnosh · 2026-02-18T22:21:36Z

Removed some macros that could be replaced 1:1 with function calls by the same name.

check_closed_broadcast
get_payment_preimage_hash
get_closing_signed_broadcast

Did this while trying out claude

ldk-reviews-bot · 2026-02-18T22:21:38Z

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

codecov · 2026-02-19T00:36:36Z

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.90%. Comparing base (1b8617c) to head (28388c4).
⚠️ Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/functional_test_utils.rs	95.23%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #4425 +/- ##
=======================================
Coverage 85.90% 85.90% =======================================
Files 156 156 Lines 103990 103983 -7 Branches 103990 103983 -7 =======================================
- Hits 89333 89327 -6 
Misses 12135 12135 + Partials 2522 2521 -1

Flag	Coverage Δ
tests	`85.90% <96.15%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wpaulino · 2026-02-19T00:54:25Z

 	let reason = ClosureReason::HolderForceClosed { broadcasted_latest_txn: Some(true), message };
 	check_closed_event(&nodes[0], 1, reason, &[node_b_id], 100000);
-	check_closed_broadcast!(nodes[0], true);
+	check_closed_broadcast(&nodes[0], 1, true).pop();


Usually we don't call pop since we rely on the length assertion

ldk-reviews-bot · 2026-02-19T00:56:31Z

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ldk-reviews-bot requested a review from wpaulino February 18, 2026 22:31

wpaulino reviewed Feb 19, 2026
View reviewed changes

elnoshand others added 3 commits February 19, 2026 08:52

Replace check_closed_broadcast! macro with direct function calls
63f4f8f
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Replace get_payment_preimage_hash! macro with direct function calls
e48478a
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Replace get_closing_signed_broadcast! macro with direct function calls
28388c4
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

elnosh force-pushed the remove-macro branch from 67d666a to 28388c4Compare February 19, 2026 14:00

wpaulino approved these changes Feb 19, 2026
View reviewed changes

wpaulino merged commit 2203e2d into lightningdevkit:mainFeb 19, 2026
20 of 21 checks passed

jkczyz mentioned this pull request Feb 20, 2026
Update LDK dependency for splicing, http, and wallet_utils lightningdevkit/ldk-node#794
Merged

elnosh deleted the remove-macro branch August 13, 2026 13:58