Enforce ChannelTransactionParameters completeness - #4464

Closed
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom
jkczyz:2026-03-channel-tx-param-refactor
Closed

Enforce ChannelTransactionParameters completeness#4464
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom
jkczyz:2026-03-channel-tx-param-refactor

Conversation

@jkczyz

@jkczyzjkczyz commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Introduces intermediate channel phases (PendingV1, PendingV2) between unfunded and funded states, then leverages them to enforce ChannelTransactionParameters completeness rather than relying on runtime unwrap()/expect() calls.

  • Add PendingV1 phase between UnfundedOutboundV1 and Funded, making the V1 state machine explicit: UnfundedOutboundV1 → PendingV1 → Funded
  • Add PendingV2 phase between UnfundedV2 and Funded for V2 channels that have constructed a funding transaction but not yet received commitment_signed
  • Split ChannelTransactionParameters into PartialChannelTransactionParameters (counterparty parameters and funding outpoint are Option) and ChannelTransactionParameters (all fields required). Previously a single struct used Option fields with is_populated() runtime guards scattered across signer code.
  • Make FundingScope generic over the parameters type (FundingScope<P>) so unfunded phases use PartialChannelTransactionParameters and funded phases use ChannelTransactionParameters, letting the compiler enforce which phases have complete data.
  • Concretize methods that only apply to funded channels to take FundingScope<ChannelTransactionParameters> directly, replacing trait-based Option-returning accessors with direct field access and eliminating the InitialRemoteCommitmentReceiver trait.
  • Flatten DirectedChannelTransactionParameters to store resolved fields directly since the Option-based fields it previously delegated to are now split across two types
  • Replace unset_funding_info with Channel::unfund(), which transitions a funded channel back to its unfunded phase since FundedChannel uses FundingScope<ChannelTransactionParameters> where the funding outpoint and counterparty parameters are non-Option and can't be cleared

jkczyzand others added 4 commits March 5, 2026 14:41
@jkczyz@claude
Add PendingV1 channel phase between UnfundedOutboundV1 and Funded
da68f2c
Introduce PendingV1Channel to represent the intermediate state where
funding_created has been generated but funding_signed has not yet been
received. This makes the channel state machine more explicit:
UnfundedOutboundV1 -> PendingV1 -> Funded
Move get_funding_created_msg, funding_signed, signer_maybe_unblocked
(funding path), unset_funding_info, and the InitialRemoteCommitmentReceiver
impl from OutboundV1Channel to PendingV1Channel.
Change OutboundV1Channel::get_funding_created to consume self and return
(PendingV1Channel, Option<FundingCreated>).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Rename PendingV2Channel to UnfundedV2Channel
717c854
Mechanical rename to free the PendingV2Channel name for a new struct
that will hold V2 channels with complete funding parameters, following
the PendingV1 pattern.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jkczyz@claude
Add PendingV2 channel phase between UnfundedV2 and Funded
c6c28f7
Introduce a PendingV2Channel struct and ChannelPhase::PendingV2 variant
to represent V2 channels that have completed funding transaction
construction but have not yet received commitment_signed.
The funding_tx_constructed method now performs the UnfundedV2 → PendingV2
phase transition using core::mem::replace, and funding_transaction_signed
and commitment_signed now match on PendingV2 instead of UnfundedV2.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Enforce ChannelTransactionParameters completeness at the type level
59f2ede
ChannelTransactionParameters used Option fields for counterparty
parameters and funding outpoint, relying on runtime unwrap/expect calls
scattered throughout the codebase. This was fragile since it was easy to
call code that assumed populated parameters on a not-yet-funded channel.
Split into PartialChannelTransactionParameters (used during negotiation)
and ChannelTransactionParameters (fully populated, used once funded).
Make FundingScope generic over the parameters type so the compiler
enforces which channel phases have complete data, eliminating the need
for runtime is_populated() guards in signers and elsewhere.
With the type-level distinction in place, also:
- Remove the InitialRemoteCommitmentReceiver trait, replacing it with a
ChannelContext method that takes complete parameters directly.
- Replace unset_funding_info with Channel::unfund(), which properly
transitions a funded channel back to unfunded state rather than
leaving it in an inconsistent "funded without funding info" state.
- Flatten DirectedChannelTransactionParameters to store resolved fields
directly instead of computing them on each access.
- Concretize methods that only work with complete parameters to take
FundingScope<ChannelTransactionParameters> directly, using field
access instead of trait-based Option-returning accessors.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ldk-reviews-bot

ldk-reviews-bot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@TheBlueMatt
TheBlueMatt self-requested a review March 17, 2026 13:14
@ldk-reviews-bot

ldk-reviews-bot commented Mar 19, 2026

Copy link
Copy Markdown

🔔 1st Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@jkczyzjkczyz self-assigned this Mar 19, 2026
@ldk-reviews-bot

ldk-reviews-bot commented Mar 21, 2026

Copy link
Copy Markdown

🔔 2nd Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Mar 23, 2026

Copy link
Copy Markdown

🔔 3rd Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Mar 25, 2026

Copy link
Copy Markdown

🔔 4th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Mar 28, 2026

Copy link
Copy Markdown

🔔 5th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Mar 30, 2026

Copy link
Copy Markdown

🔔 6th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Apr 1, 2026

Copy link
Copy Markdown

🔔 7th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Apr 4, 2026

Copy link
Copy Markdown

🔔 8th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Apr 6, 2026

Copy link
Copy Markdown

🔔 9th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Apr 8, 2026

Copy link
Copy Markdown

🔔 10th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Apr 11, 2026

Copy link
Copy Markdown

🔔 11th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Apr 13, 2026

Copy link
Copy Markdown

🔔 12th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Apr 15, 2026

Copy link
Copy Markdown

🔔 13th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Apr 18, 2026

Copy link
Copy Markdown

🔔 14th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Apr 20, 2026

Copy link
Copy Markdown

🔔 15th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Apr 22, 2026

Copy link
Copy Markdown

🔔 16th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Apr 25, 2026

Copy link
Copy Markdown

🔔 17th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Apr 27, 2026

Copy link
Copy Markdown

🔔 18th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Apr 29, 2026

Copy link
Copy Markdown

🔔 19th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented May 2, 2026

Copy link
Copy Markdown

🔔 20th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented May 4, 2026

Copy link
Copy Markdown

🔔 21st Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented May 6, 2026

Copy link
Copy Markdown

🔔 22nd Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented May 9, 2026

Copy link
Copy Markdown

🔔 23rd Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented May 11, 2026

Copy link
Copy Markdown

🔔 24th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented May 13, 2026

Copy link
Copy Markdown

🔔 25th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented May 16, 2026

Copy link
Copy Markdown

🔔 26th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented May 18, 2026

Copy link
Copy Markdown

🔔 27th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented May 20, 2026

Copy link
Copy Markdown

🔔 28th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented May 23, 2026

Copy link
Copy Markdown

🔔 29th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented May 25, 2026

Copy link
Copy Markdown

🔔 30th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented May 27, 2026

Copy link
Copy Markdown

🔔 31st Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented May 30, 2026

Copy link
Copy Markdown

🔔 32nd Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 1, 2026

Copy link
Copy Markdown

🔔 33rd Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 3, 2026

Copy link
Copy Markdown

🔔 34th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 6, 2026

Copy link
Copy Markdown

🔔 35th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 8, 2026

Copy link
Copy Markdown

🔔 36th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 10, 2026

Copy link
Copy Markdown

🔔 37th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 13, 2026

Copy link
Copy Markdown

🔔 38th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 15, 2026

Copy link
Copy Markdown

🔔 39th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 17, 2026

Copy link
Copy Markdown

🔔 40th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 20, 2026

Copy link
Copy Markdown

🔔 41st Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 22, 2026

Copy link
Copy Markdown

🔔 42nd Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@joostjagerjoostjager mentioned this pull request Jun 22, 2026
Closed
@ldk-reviews-bot

ldk-reviews-bot commented Jun 24, 2026

Copy link
Copy Markdown

🔔 43rd Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 27, 2026

Copy link
Copy Markdown

🔔 44th Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jul 3, 2026

Copy link
Copy Markdown

Hi @jkczyz,

Thanks for your contributions to rust-lightning!

After too many struggles with bugs, outages, contributor bans, and, finally, a multi-week CI ban, the rust-lightning project is moving off of GitHub for day-to-day development.

You can still file issues and access the git tree here, but PRs will now take place exclusively at https://git.rust-bitcoin.org/. As such, this PR has been migrated to https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4464

If you log in using GitHub (or otherwise link your GitHub account from https://git.rust-bitcoin.org/user/settings/security), ownership of your PRs, issues, and comments will automatically transfer. To push updates to this PR, you'll need to use git push git@gitea-ssh.bitcoin.ninja:lightningdevkit/rust-lightning YOUR_LOCAL_COMMIT_OR_BRANCH:jkczyz/2026-03-channel-tx-param-refactor. This may require a permissions change - if it doesn't work initially just leave a comment and we'll get you access.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMattTheBlueMattAwaiting requested review from TheBlueMatt

Assignees

@jkczyzjkczyz

Labels

None yet

Projects

Weekly Goals
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkczyz@ldk-reviews-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Enforce ChannelTransactionParameters completeness - #4464
Closed
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Closed
Enforce ChannelTransactionParameters completeness#4464
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Conversation
@jkczyz
@jkczyzjkczyz
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
Introduces intermediate channel phases (PendingV1, PendingV2) between unfunded and funded states, then leverages them to enforce ChannelTransactionParameters completeness rather than relying on runtime unwrap()/expect() calls.
  • Add PendingV1 phase between UnfundedOutboundV1 and Funded, making the V1 state machine explicit: UnfundedOutboundV1 → PendingV1 → Funded
  • Add PendingV2 phase between UnfundedV2 and Funded for V2 channels that have constructed a funding transaction but not yet received commitment_signed
  • Split ChannelTransactionParameters into PartialChannelTransactionParameters (counterparty parameters and funding outpoint are Option) and ChannelTransactionParameters (all fields required). Previously a single struct used Option fields with is_populated() runtime guards scattered across signer code.
  • Make FundingScope generic over the parameters type (FundingScope<P>) so unfunded phases use PartialChannelTransactionParameters and funded phases use ChannelTransactionParameters, letting the compiler enforce which phases have complete data.
  • Concretize methods that only apply to funded channels to take FundingScope<ChannelTransactionParameters> directly, replacing trait-based Option-returning accessors with direct field access and eliminating the InitialRemoteCommitmentReceiver trait.
  • Flatten DirectedChannelTransactionParameters to store resolved fields directly since the Option-based fields it previously delegated to are now split across two types
  • Replace unset_funding_info with Channel::unfund(), which transitions a funded channel back to its unfunded phase since FundedChannel uses FundingScope<ChannelTransactionParameters> where the funding outpoint and counterparty parameters are non-Option and can't be cleared
jkczyzand others
added 4 commits
March 5, 2026 14:41
@jkczyz@claude
Add PendingV1 channel phase between UnfundedOutboundV1 and Funded
da68f2c
Introduce PendingV1Channel to represent the intermediate state where
funding_created has been generated but funding_signed has not yet been
received. This makes the channel state machine more explicit:
UnfundedOutboundV1 -> PendingV1 -> Funded
Move get_funding_created_msg, funding_signed, signer_maybe_unblocked
(funding path), unset_funding_info, and the InitialRemoteCommitmentReceiver
impl from OutboundV1Channel to PendingV1Channel.
Change OutboundV1Channel::get_funding_created to consume self and return
(PendingV1Channel, Option<FundingCreated>).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Rename PendingV2Channel to UnfundedV2Channel
717c854
Mechanical rename to free the PendingV2Channel name for a new struct
that will hold V2 channels with complete funding parameters, following
the PendingV1 pattern.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jkczyz@claude
Add PendingV2 channel phase between UnfundedV2 and Funded
c6c28f7
Introduce a PendingV2Channel struct and ChannelPhase::PendingV2 variant
to represent V2 channels that have completed funding transaction
construction but have not yet received commitment_signed.
The funding_tx_constructed method now performs the UnfundedV2 → PendingV2
phase transition using core::mem::replace, and funding_transaction_signed
and commitment_signed now match on PendingV2 instead of UnfundedV2.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Enforce ChannelTransactionParameters completeness at the type level
59f2ede
ChannelTransactionParameters used Option fields for counterparty
parameters and funding outpoint, relying on runtime unwrap/expect calls
scattered throughout the codebase. This was fragile since it was easy to
call code that assumed populated parameters on a not-yet-funded channel.
Split into PartialChannelTransactionParameters (used during negotiation)
and ChannelTransactionParameters (fully populated, used once funded).
Make FundingScope generic over the parameters type so the compiler
enforces which channel phases have complete data, eliminating the need
for runtime is_populated() guards in signers and elsewhere.
With the type-level distinction in place, also:
- Remove the InitialRemoteCommitmentReceiver trait, replacing it with a
ChannelContext method that takes complete parameters directly.
- Replace unset_funding_info with Channel::unfund(), which properly
transitions a funded channel back to unfunded state rather than
leaving it in an inconsistent "funded without funding info" state.
- Flatten DirectedChannelTransactionParameters to store resolved fields
directly instead of computing them on each access.
- Concretize methods that only work with complete parameters to take
FundingScope<ChannelTransactionParameters> directly, using field
access instead of trait-based Option-returning accessors.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@TheBlueMatt
TheBlueMatt
self-requested a review
March 17, 2026 13:14
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 19, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@jkczyzjkczyz
self-assigned this
Mar 19, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 21, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 23, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 25, 2026

Copy link


Copy Markdown

🔔 4th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 28, 2026

Copy link


Copy Markdown

🔔 5th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 30, 2026

Copy link


Copy Markdown

🔔 6th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 1, 2026

Copy link


Copy Markdown

🔔 7th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 4, 2026

Copy link


Copy Markdown

🔔 8th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 6, 2026

Copy link


Copy Markdown

🔔 9th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 8, 2026

Copy link


Copy Markdown

🔔 10th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 11, 2026

Copy link


Copy Markdown

🔔 11th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 13, 2026

Copy link


Copy Markdown

🔔 12th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 15, 2026

Copy link


Copy Markdown

🔔 13th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 18, 2026

Copy link


Copy Markdown

🔔 14th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 20, 2026

Copy link


Copy Markdown

🔔 15th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

🔔 16th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 25, 2026

Copy link


Copy Markdown

🔔 17th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 27, 2026

Copy link


Copy Markdown

🔔 18th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 29, 2026

Copy link


Copy Markdown

🔔 19th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 2, 2026

Copy link


Copy Markdown

🔔 20th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 4, 2026

Copy link


Copy Markdown

🔔 21st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 6, 2026

Copy link


Copy Markdown

🔔 22nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 9, 2026

Copy link


Copy Markdown

🔔 23rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 11, 2026

Copy link


Copy Markdown

🔔 24th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 13, 2026

Copy link


Copy Markdown

🔔 25th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 16, 2026

Copy link


Copy Markdown

🔔 26th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 18, 2026

Copy link


Copy Markdown

🔔 27th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 20, 2026

Copy link


Copy Markdown

🔔 28th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 23, 2026

Copy link


Copy Markdown

🔔 29th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 25, 2026

Copy link


Copy Markdown

🔔 30th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 27, 2026

Copy link


Copy Markdown

🔔 31st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 30, 2026

Copy link


Copy Markdown

🔔 32nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 1, 2026

Copy link


Copy Markdown

🔔 33rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 3, 2026

Copy link


Copy Markdown

🔔 34th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 6, 2026

Copy link


Copy Markdown

🔔 35th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

🔔 36th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 10, 2026

Copy link


Copy Markdown

🔔 37th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 13, 2026

Copy link


Copy Markdown

🔔 38th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 15, 2026

Copy link


Copy Markdown

🔔 39th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 17, 2026

Copy link


Copy Markdown

🔔 40th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 20, 2026

Copy link


Copy Markdown

🔔 41st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 22, 2026

Copy link


Copy Markdown

🔔 42nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@joostjagerjoostjager
mentioned this pull request
Jun 22, 2026

Closed

@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 24, 2026

Copy link


Copy Markdown

🔔 43rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 27, 2026

Copy link


Copy Markdown

🔔 44th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jul 3, 2026

Copy link


Copy Markdown

Hi @jkczyz,
Thanks for your contributions to rust-lightning!
After too many struggles with bugs, outages, contributor bans, and, finally, a multi-week CI ban, the rust-lightning project is moving off of GitHub for day-to-day development.
You can still file issues and access the git tree here, but PRs will now take place exclusively at https://git.rust-bitcoin.org/. As such, this PR has been migrated to https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4464
If you log in using GitHub (or otherwise link your GitHub account from https://git.rust-bitcoin.org/user/settings/security), ownership of your PRs, issues, and comments will automatically transfer. To push updates to this PR, you'll need to use git push git@gitea-ssh.bitcoin.ninja:lightningdevkit/rust-lightning YOUR_LOCAL_COMMIT_OR_BRANCH:jkczyz/2026-03-channel-tx-param-refactor. This may require a permissions change - if it doesn't work initially just leave a comment and we'll get you access.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattAwaiting requested review from TheBlueMatt

Assignees

@jkczyzjkczyz

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jkczyz@ldk-reviews-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Enforce ChannelTransactionParameters completeness - #4464
Closed
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Closed
Enforce ChannelTransactionParameters completeness#4464
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Conversation
@jkczyz
@jkczyzjkczyz
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
Introduces intermediate channel phases (PendingV1, PendingV2) between unfunded and funded states, then leverages them to enforce ChannelTransactionParameters completeness rather than relying on runtime unwrap()/expect() calls.
  • Add PendingV1 phase between UnfundedOutboundV1 and Funded, making the V1 state machine explicit: UnfundedOutboundV1 → PendingV1 → Funded
  • Add PendingV2 phase between UnfundedV2 and Funded for V2 channels that have constructed a funding transaction but not yet received commitment_signed
  • Split ChannelTransactionParameters into PartialChannelTransactionParameters (counterparty parameters and funding outpoint are Option) and ChannelTransactionParameters (all fields required). Previously a single struct used Option fields with is_populated() runtime guards scattered across signer code.
  • Make FundingScope generic over the parameters type (FundingScope<P>) so unfunded phases use PartialChannelTransactionParameters and funded phases use ChannelTransactionParameters, letting the compiler enforce which phases have complete data.
  • Concretize methods that only apply to funded channels to take FundingScope<ChannelTransactionParameters> directly, replacing trait-based Option-returning accessors with direct field access and eliminating the InitialRemoteCommitmentReceiver trait.
  • Flatten DirectedChannelTransactionParameters to store resolved fields directly since the Option-based fields it previously delegated to are now split across two types
  • Replace unset_funding_info with Channel::unfund(), which transitions a funded channel back to its unfunded phase since FundedChannel uses FundingScope<ChannelTransactionParameters> where the funding outpoint and counterparty parameters are non-Option and can't be cleared
jkczyzand others
added 4 commits
March 5, 2026 14:41
@jkczyz@claude
Add PendingV1 channel phase between UnfundedOutboundV1 and Funded
da68f2c
Introduce PendingV1Channel to represent the intermediate state where
funding_created has been generated but funding_signed has not yet been
received. This makes the channel state machine more explicit:
UnfundedOutboundV1 -> PendingV1 -> Funded
Move get_funding_created_msg, funding_signed, signer_maybe_unblocked
(funding path), unset_funding_info, and the InitialRemoteCommitmentReceiver
impl from OutboundV1Channel to PendingV1Channel.
Change OutboundV1Channel::get_funding_created to consume self and return
(PendingV1Channel, Option<FundingCreated>).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Rename PendingV2Channel to UnfundedV2Channel
717c854
Mechanical rename to free the PendingV2Channel name for a new struct
that will hold V2 channels with complete funding parameters, following
the PendingV1 pattern.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jkczyz@claude
Add PendingV2 channel phase between UnfundedV2 and Funded
c6c28f7
Introduce a PendingV2Channel struct and ChannelPhase::PendingV2 variant
to represent V2 channels that have completed funding transaction
construction but have not yet received commitment_signed.
The funding_tx_constructed method now performs the UnfundedV2 → PendingV2
phase transition using core::mem::replace, and funding_transaction_signed
and commitment_signed now match on PendingV2 instead of UnfundedV2.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Enforce ChannelTransactionParameters completeness at the type level
59f2ede
ChannelTransactionParameters used Option fields for counterparty
parameters and funding outpoint, relying on runtime unwrap/expect calls
scattered throughout the codebase. This was fragile since it was easy to
call code that assumed populated parameters on a not-yet-funded channel.
Split into PartialChannelTransactionParameters (used during negotiation)
and ChannelTransactionParameters (fully populated, used once funded).
Make FundingScope generic over the parameters type so the compiler
enforces which channel phases have complete data, eliminating the need
for runtime is_populated() guards in signers and elsewhere.
With the type-level distinction in place, also:
- Remove the InitialRemoteCommitmentReceiver trait, replacing it with a
ChannelContext method that takes complete parameters directly.
- Replace unset_funding_info with Channel::unfund(), which properly
transitions a funded channel back to unfunded state rather than
leaving it in an inconsistent "funded without funding info" state.
- Flatten DirectedChannelTransactionParameters to store resolved fields
directly instead of computing them on each access.
- Concretize methods that only work with complete parameters to take
FundingScope<ChannelTransactionParameters> directly, using field
access instead of trait-based Option-returning accessors.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@TheBlueMatt
TheBlueMatt
self-requested a review
March 17, 2026 13:14
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 19, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@jkczyzjkczyz
self-assigned this
Mar 19, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 21, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 23, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 25, 2026

Copy link


Copy Markdown

🔔 4th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 28, 2026

Copy link


Copy Markdown

🔔 5th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 30, 2026

Copy link


Copy Markdown

🔔 6th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 1, 2026

Copy link


Copy Markdown

🔔 7th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 4, 2026

Copy link


Copy Markdown

🔔 8th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 6, 2026

Copy link


Copy Markdown

🔔 9th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 8, 2026

Copy link


Copy Markdown

🔔 10th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 11, 2026

Copy link


Copy Markdown

🔔 11th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 13, 2026

Copy link


Copy Markdown

🔔 12th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 15, 2026

Copy link


Copy Markdown

🔔 13th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 18, 2026

Copy link


Copy Markdown

🔔 14th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 20, 2026

Copy link


Copy Markdown

🔔 15th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

🔔 16th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 25, 2026

Copy link


Copy Markdown

🔔 17th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 27, 2026

Copy link


Copy Markdown

🔔 18th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 29, 2026

Copy link


Copy Markdown

🔔 19th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 2, 2026

Copy link


Copy Markdown

🔔 20th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 4, 2026

Copy link


Copy Markdown

🔔 21st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 6, 2026

Copy link


Copy Markdown

🔔 22nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 9, 2026

Copy link


Copy Markdown

🔔 23rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 11, 2026

Copy link


Copy Markdown

🔔 24th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 13, 2026

Copy link


Copy Markdown

🔔 25th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 16, 2026

Copy link


Copy Markdown

🔔 26th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 18, 2026

Copy link


Copy Markdown

🔔 27th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 20, 2026

Copy link


Copy Markdown

🔔 28th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 23, 2026

Copy link


Copy Markdown

🔔 29th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 25, 2026

Copy link


Copy Markdown

🔔 30th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 27, 2026

Copy link


Copy Markdown

🔔 31st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 30, 2026

Copy link


Copy Markdown

🔔 32nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 1, 2026

Copy link


Copy Markdown

🔔 33rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 3, 2026

Copy link


Copy Markdown

🔔 34th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 6, 2026

Copy link


Copy Markdown

🔔 35th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

🔔 36th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 10, 2026

Copy link


Copy Markdown

🔔 37th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 13, 2026

Copy link


Copy Markdown

🔔 38th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 15, 2026

Copy link


Copy Markdown

🔔 39th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 17, 2026

Copy link


Copy Markdown

🔔 40th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 20, 2026

Copy link


Copy Markdown

🔔 41st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 22, 2026

Copy link


Copy Markdown

🔔 42nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@joostjagerjoostjager
mentioned this pull request
Jun 22, 2026

Closed

@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 24, 2026

Copy link


Copy Markdown

🔔 43rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 27, 2026

Copy link


Copy Markdown

🔔 44th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jul 3, 2026

Copy link


Copy Markdown

Hi @jkczyz,
Thanks for your contributions to rust-lightning!
After too many struggles with bugs, outages, contributor bans, and, finally, a multi-week CI ban, the rust-lightning project is moving off of GitHub for day-to-day development.
You can still file issues and access the git tree here, but PRs will now take place exclusively at https://git.rust-bitcoin.org/. As such, this PR has been migrated to https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4464
If you log in using GitHub (or otherwise link your GitHub account from https://git.rust-bitcoin.org/user/settings/security), ownership of your PRs, issues, and comments will automatically transfer. To push updates to this PR, you'll need to use git push git@gitea-ssh.bitcoin.ninja:lightningdevkit/rust-lightning YOUR_LOCAL_COMMIT_OR_BRANCH:jkczyz/2026-03-channel-tx-param-refactor. This may require a permissions change - if it doesn't work initially just leave a comment and we'll get you access.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattAwaiting requested review from TheBlueMatt

Assignees

@jkczyzjkczyz

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jkczyz@ldk-reviews-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Enforce ChannelTransactionParameters completeness - #4464
Closed
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Closed
Enforce ChannelTransactionParameters completeness#4464
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Conversation
@jkczyz
@jkczyzjkczyz
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
Introduces intermediate channel phases (PendingV1, PendingV2) between unfunded and funded states, then leverages them to enforce ChannelTransactionParameters completeness rather than relying on runtime unwrap()/expect() calls.
  • Add PendingV1 phase between UnfundedOutboundV1 and Funded, making the V1 state machine explicit: UnfundedOutboundV1 → PendingV1 → Funded
  • Add PendingV2 phase between UnfundedV2 and Funded for V2 channels that have constructed a funding transaction but not yet received commitment_signed
  • Split ChannelTransactionParameters into PartialChannelTransactionParameters (counterparty parameters and funding outpoint are Option) and ChannelTransactionParameters (all fields required). Previously a single struct used Option fields with is_populated() runtime guards scattered across signer code.
  • Make FundingScope generic over the parameters type (FundingScope<P>) so unfunded phases use PartialChannelTransactionParameters and funded phases use ChannelTransactionParameters, letting the compiler enforce which phases have complete data.
  • Concretize methods that only apply to funded channels to take FundingScope<ChannelTransactionParameters> directly, replacing trait-based Option-returning accessors with direct field access and eliminating the InitialRemoteCommitmentReceiver trait.
  • Flatten DirectedChannelTransactionParameters to store resolved fields directly since the Option-based fields it previously delegated to are now split across two types
  • Replace unset_funding_info with Channel::unfund(), which transitions a funded channel back to its unfunded phase since FundedChannel uses FundingScope<ChannelTransactionParameters> where the funding outpoint and counterparty parameters are non-Option and can't be cleared
jkczyzand others
added 4 commits
March 5, 2026 14:41
@jkczyz@claude
Add PendingV1 channel phase between UnfundedOutboundV1 and Funded
da68f2c
Introduce PendingV1Channel to represent the intermediate state where
funding_created has been generated but funding_signed has not yet been
received. This makes the channel state machine more explicit:
UnfundedOutboundV1 -> PendingV1 -> Funded
Move get_funding_created_msg, funding_signed, signer_maybe_unblocked
(funding path), unset_funding_info, and the InitialRemoteCommitmentReceiver
impl from OutboundV1Channel to PendingV1Channel.
Change OutboundV1Channel::get_funding_created to consume self and return
(PendingV1Channel, Option<FundingCreated>).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Rename PendingV2Channel to UnfundedV2Channel
717c854
Mechanical rename to free the PendingV2Channel name for a new struct
that will hold V2 channels with complete funding parameters, following
the PendingV1 pattern.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jkczyz@claude
Add PendingV2 channel phase between UnfundedV2 and Funded
c6c28f7
Introduce a PendingV2Channel struct and ChannelPhase::PendingV2 variant
to represent V2 channels that have completed funding transaction
construction but have not yet received commitment_signed.
The funding_tx_constructed method now performs the UnfundedV2 → PendingV2
phase transition using core::mem::replace, and funding_transaction_signed
and commitment_signed now match on PendingV2 instead of UnfundedV2.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Enforce ChannelTransactionParameters completeness at the type level
59f2ede
ChannelTransactionParameters used Option fields for counterparty
parameters and funding outpoint, relying on runtime unwrap/expect calls
scattered throughout the codebase. This was fragile since it was easy to
call code that assumed populated parameters on a not-yet-funded channel.
Split into PartialChannelTransactionParameters (used during negotiation)
and ChannelTransactionParameters (fully populated, used once funded).
Make FundingScope generic over the parameters type so the compiler
enforces which channel phases have complete data, eliminating the need
for runtime is_populated() guards in signers and elsewhere.
With the type-level distinction in place, also:
- Remove the InitialRemoteCommitmentReceiver trait, replacing it with a
ChannelContext method that takes complete parameters directly.
- Replace unset_funding_info with Channel::unfund(), which properly
transitions a funded channel back to unfunded state rather than
leaving it in an inconsistent "funded without funding info" state.
- Flatten DirectedChannelTransactionParameters to store resolved fields
directly instead of computing them on each access.
- Concretize methods that only work with complete parameters to take
FundingScope<ChannelTransactionParameters> directly, using field
access instead of trait-based Option-returning accessors.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@TheBlueMatt
TheBlueMatt
self-requested a review
March 17, 2026 13:14
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 19, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@jkczyzjkczyz
self-assigned this
Mar 19, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 21, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 23, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 25, 2026

Copy link


Copy Markdown

🔔 4th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 28, 2026

Copy link


Copy Markdown

🔔 5th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 30, 2026

Copy link


Copy Markdown

🔔 6th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 1, 2026

Copy link


Copy Markdown

🔔 7th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 4, 2026

Copy link


Copy Markdown

🔔 8th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 6, 2026

Copy link


Copy Markdown

🔔 9th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 8, 2026

Copy link


Copy Markdown

🔔 10th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 11, 2026

Copy link


Copy Markdown

🔔 11th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 13, 2026

Copy link


Copy Markdown

🔔 12th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 15, 2026

Copy link


Copy Markdown

🔔 13th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 18, 2026

Copy link


Copy Markdown

🔔 14th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 20, 2026

Copy link


Copy Markdown

🔔 15th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

🔔 16th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 25, 2026

Copy link


Copy Markdown

🔔 17th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 27, 2026

Copy link


Copy Markdown

🔔 18th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 29, 2026

Copy link


Copy Markdown

🔔 19th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 2, 2026

Copy link


Copy Markdown

🔔 20th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 4, 2026

Copy link


Copy Markdown

🔔 21st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 6, 2026

Copy link


Copy Markdown

🔔 22nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 9, 2026

Copy link


Copy Markdown

🔔 23rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 11, 2026

Copy link


Copy Markdown

🔔 24th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 13, 2026

Copy link


Copy Markdown

🔔 25th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 16, 2026

Copy link


Copy Markdown

🔔 26th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 18, 2026

Copy link


Copy Markdown

🔔 27th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 20, 2026

Copy link


Copy Markdown

🔔 28th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 23, 2026

Copy link


Copy Markdown

🔔 29th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 25, 2026

Copy link


Copy Markdown

🔔 30th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 27, 2026

Copy link


Copy Markdown

🔔 31st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 30, 2026

Copy link


Copy Markdown

🔔 32nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 1, 2026

Copy link


Copy Markdown

🔔 33rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 3, 2026

Copy link


Copy Markdown

🔔 34th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 6, 2026

Copy link


Copy Markdown

🔔 35th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

🔔 36th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 10, 2026

Copy link


Copy Markdown

🔔 37th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 13, 2026

Copy link


Copy Markdown

🔔 38th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 15, 2026

Copy link


Copy Markdown

🔔 39th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 17, 2026

Copy link


Copy Markdown

🔔 40th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 20, 2026

Copy link


Copy Markdown

🔔 41st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 22, 2026

Copy link


Copy Markdown

🔔 42nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@joostjagerjoostjager
mentioned this pull request
Jun 22, 2026

Closed

@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 24, 2026

Copy link


Copy Markdown

🔔 43rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 27, 2026

Copy link


Copy Markdown

🔔 44th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jul 3, 2026

Copy link


Copy Markdown

Hi @jkczyz,
Thanks for your contributions to rust-lightning!
After too many struggles with bugs, outages, contributor bans, and, finally, a multi-week CI ban, the rust-lightning project is moving off of GitHub for day-to-day development.
You can still file issues and access the git tree here, but PRs will now take place exclusively at https://git.rust-bitcoin.org/. As such, this PR has been migrated to https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4464
If you log in using GitHub (or otherwise link your GitHub account from https://git.rust-bitcoin.org/user/settings/security), ownership of your PRs, issues, and comments will automatically transfer. To push updates to this PR, you'll need to use git push git@gitea-ssh.bitcoin.ninja:lightningdevkit/rust-lightning YOUR_LOCAL_COMMIT_OR_BRANCH:jkczyz/2026-03-channel-tx-param-refactor. This may require a permissions change - if it doesn't work initially just leave a comment and we'll get you access.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattAwaiting requested review from TheBlueMatt

Assignees

@jkczyzjkczyz

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jkczyz@ldk-reviews-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Enforce ChannelTransactionParameters completeness - #4464
Closed
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Closed
Enforce ChannelTransactionParameters completeness#4464
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Conversation
@jkczyz
@jkczyzjkczyz
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
Introduces intermediate channel phases (PendingV1, PendingV2) between unfunded and funded states, then leverages them to enforce ChannelTransactionParameters completeness rather than relying on runtime unwrap()/expect() calls.
  • Add PendingV1 phase between UnfundedOutboundV1 and Funded, making the V1 state machine explicit: UnfundedOutboundV1 → PendingV1 → Funded
  • Add PendingV2 phase between UnfundedV2 and Funded for V2 channels that have constructed a funding transaction but not yet received commitment_signed
  • Split ChannelTransactionParameters into PartialChannelTransactionParameters (counterparty parameters and funding outpoint are Option) and ChannelTransactionParameters (all fields required). Previously a single struct used Option fields with is_populated() runtime guards scattered across signer code.
  • Make FundingScope generic over the parameters type (FundingScope<P>) so unfunded phases use PartialChannelTransactionParameters and funded phases use ChannelTransactionParameters, letting the compiler enforce which phases have complete data.
  • Concretize methods that only apply to funded channels to take FundingScope<ChannelTransactionParameters> directly, replacing trait-based Option-returning accessors with direct field access and eliminating the InitialRemoteCommitmentReceiver trait.
  • Flatten DirectedChannelTransactionParameters to store resolved fields directly since the Option-based fields it previously delegated to are now split across two types
  • Replace unset_funding_info with Channel::unfund(), which transitions a funded channel back to its unfunded phase since FundedChannel uses FundingScope<ChannelTransactionParameters> where the funding outpoint and counterparty parameters are non-Option and can't be cleared
jkczyzand others
added 4 commits
March 5, 2026 14:41
@jkczyz@claude
Add PendingV1 channel phase between UnfundedOutboundV1 and Funded
da68f2c
Introduce PendingV1Channel to represent the intermediate state where
funding_created has been generated but funding_signed has not yet been
received. This makes the channel state machine more explicit:
UnfundedOutboundV1 -> PendingV1 -> Funded
Move get_funding_created_msg, funding_signed, signer_maybe_unblocked
(funding path), unset_funding_info, and the InitialRemoteCommitmentReceiver
impl from OutboundV1Channel to PendingV1Channel.
Change OutboundV1Channel::get_funding_created to consume self and return
(PendingV1Channel, Option<FundingCreated>).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Rename PendingV2Channel to UnfundedV2Channel
717c854
Mechanical rename to free the PendingV2Channel name for a new struct
that will hold V2 channels with complete funding parameters, following
the PendingV1 pattern.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jkczyz@claude
Add PendingV2 channel phase between UnfundedV2 and Funded
c6c28f7
Introduce a PendingV2Channel struct and ChannelPhase::PendingV2 variant
to represent V2 channels that have completed funding transaction
construction but have not yet received commitment_signed.
The funding_tx_constructed method now performs the UnfundedV2 → PendingV2
phase transition using core::mem::replace, and funding_transaction_signed
and commitment_signed now match on PendingV2 instead of UnfundedV2.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Enforce ChannelTransactionParameters completeness at the type level
59f2ede
ChannelTransactionParameters used Option fields for counterparty
parameters and funding outpoint, relying on runtime unwrap/expect calls
scattered throughout the codebase. This was fragile since it was easy to
call code that assumed populated parameters on a not-yet-funded channel.
Split into PartialChannelTransactionParameters (used during negotiation)
and ChannelTransactionParameters (fully populated, used once funded).
Make FundingScope generic over the parameters type so the compiler
enforces which channel phases have complete data, eliminating the need
for runtime is_populated() guards in signers and elsewhere.
With the type-level distinction in place, also:
- Remove the InitialRemoteCommitmentReceiver trait, replacing it with a
ChannelContext method that takes complete parameters directly.
- Replace unset_funding_info with Channel::unfund(), which properly
transitions a funded channel back to unfunded state rather than
leaving it in an inconsistent "funded without funding info" state.
- Flatten DirectedChannelTransactionParameters to store resolved fields
directly instead of computing them on each access.
- Concretize methods that only work with complete parameters to take
FundingScope<ChannelTransactionParameters> directly, using field
access instead of trait-based Option-returning accessors.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@TheBlueMatt
TheBlueMatt
self-requested a review
March 17, 2026 13:14
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 19, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@jkczyzjkczyz
self-assigned this
Mar 19, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 21, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 23, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 25, 2026

Copy link


Copy Markdown

🔔 4th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 28, 2026

Copy link


Copy Markdown

🔔 5th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 30, 2026

Copy link


Copy Markdown

🔔 6th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 1, 2026

Copy link


Copy Markdown

🔔 7th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 4, 2026

Copy link


Copy Markdown

🔔 8th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 6, 2026

Copy link


Copy Markdown

🔔 9th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 8, 2026

Copy link


Copy Markdown

🔔 10th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 11, 2026

Copy link


Copy Markdown

🔔 11th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 13, 2026

Copy link


Copy Markdown

🔔 12th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 15, 2026

Copy link


Copy Markdown

🔔 13th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 18, 2026

Copy link


Copy Markdown

🔔 14th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 20, 2026

Copy link


Copy Markdown

🔔 15th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

🔔 16th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 25, 2026

Copy link


Copy Markdown

🔔 17th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 27, 2026

Copy link


Copy Markdown

🔔 18th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 29, 2026

Copy link


Copy Markdown

🔔 19th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 2, 2026

Copy link


Copy Markdown

🔔 20th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 4, 2026

Copy link


Copy Markdown

🔔 21st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 6, 2026

Copy link


Copy Markdown

🔔 22nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 9, 2026

Copy link


Copy Markdown

🔔 23rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 11, 2026

Copy link


Copy Markdown

🔔 24th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 13, 2026

Copy link


Copy Markdown

🔔 25th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 16, 2026

Copy link


Copy Markdown

🔔 26th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 18, 2026

Copy link


Copy Markdown

🔔 27th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 20, 2026

Copy link


Copy Markdown

🔔 28th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 23, 2026

Copy link


Copy Markdown

🔔 29th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 25, 2026

Copy link


Copy Markdown

🔔 30th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 27, 2026

Copy link


Copy Markdown

🔔 31st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 30, 2026

Copy link


Copy Markdown

🔔 32nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 1, 2026

Copy link


Copy Markdown

🔔 33rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 3, 2026

Copy link


Copy Markdown

🔔 34th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 6, 2026

Copy link


Copy Markdown

🔔 35th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

🔔 36th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 10, 2026

Copy link


Copy Markdown

🔔 37th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 13, 2026

Copy link


Copy Markdown

🔔 38th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 15, 2026

Copy link


Copy Markdown

🔔 39th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 17, 2026

Copy link


Copy Markdown

🔔 40th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 20, 2026

Copy link


Copy Markdown

🔔 41st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 22, 2026

Copy link


Copy Markdown

🔔 42nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@joostjagerjoostjager
mentioned this pull request
Jun 22, 2026

Closed

@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 24, 2026

Copy link


Copy Markdown

🔔 43rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 27, 2026

Copy link


Copy Markdown

🔔 44th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jul 3, 2026

Copy link


Copy Markdown

Hi @jkczyz,
Thanks for your contributions to rust-lightning!
After too many struggles with bugs, outages, contributor bans, and, finally, a multi-week CI ban, the rust-lightning project is moving off of GitHub for day-to-day development.
You can still file issues and access the git tree here, but PRs will now take place exclusively at https://git.rust-bitcoin.org/. As such, this PR has been migrated to https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4464
If you log in using GitHub (or otherwise link your GitHub account from https://git.rust-bitcoin.org/user/settings/security), ownership of your PRs, issues, and comments will automatically transfer. To push updates to this PR, you'll need to use git push git@gitea-ssh.bitcoin.ninja:lightningdevkit/rust-lightning YOUR_LOCAL_COMMIT_OR_BRANCH:jkczyz/2026-03-channel-tx-param-refactor. This may require a permissions change - if it doesn't work initially just leave a comment and we'll get you access.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattAwaiting requested review from TheBlueMatt

Assignees

@jkczyzjkczyz

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jkczyz@ldk-reviews-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Enforce ChannelTransactionParameters completeness - #4464
Closed
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Closed
Enforce ChannelTransactionParameters completeness#4464
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Conversation
@jkczyz
@jkczyzjkczyz
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
Introduces intermediate channel phases (PendingV1, PendingV2) between unfunded and funded states, then leverages them to enforce ChannelTransactionParameters completeness rather than relying on runtime unwrap()/expect() calls.
  • Add PendingV1 phase between UnfundedOutboundV1 and Funded, making the V1 state machine explicit: UnfundedOutboundV1 → PendingV1 → Funded
  • Add PendingV2 phase between UnfundedV2 and Funded for V2 channels that have constructed a funding transaction but not yet received commitment_signed
  • Split ChannelTransactionParameters into PartialChannelTransactionParameters (counterparty parameters and funding outpoint are Option) and ChannelTransactionParameters (all fields required). Previously a single struct used Option fields with is_populated() runtime guards scattered across signer code.
  • Make FundingScope generic over the parameters type (FundingScope<P>) so unfunded phases use PartialChannelTransactionParameters and funded phases use ChannelTransactionParameters, letting the compiler enforce which phases have complete data.
  • Concretize methods that only apply to funded channels to take FundingScope<ChannelTransactionParameters> directly, replacing trait-based Option-returning accessors with direct field access and eliminating the InitialRemoteCommitmentReceiver trait.
  • Flatten DirectedChannelTransactionParameters to store resolved fields directly since the Option-based fields it previously delegated to are now split across two types
  • Replace unset_funding_info with Channel::unfund(), which transitions a funded channel back to its unfunded phase since FundedChannel uses FundingScope<ChannelTransactionParameters> where the funding outpoint and counterparty parameters are non-Option and can't be cleared
jkczyzand others
added 4 commits
March 5, 2026 14:41
@jkczyz@claude
Add PendingV1 channel phase between UnfundedOutboundV1 and Funded
da68f2c
Introduce PendingV1Channel to represent the intermediate state where
funding_created has been generated but funding_signed has not yet been
received. This makes the channel state machine more explicit:
UnfundedOutboundV1 -> PendingV1 -> Funded
Move get_funding_created_msg, funding_signed, signer_maybe_unblocked
(funding path), unset_funding_info, and the InitialRemoteCommitmentReceiver
impl from OutboundV1Channel to PendingV1Channel.
Change OutboundV1Channel::get_funding_created to consume self and return
(PendingV1Channel, Option<FundingCreated>).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Rename PendingV2Channel to UnfundedV2Channel
717c854
Mechanical rename to free the PendingV2Channel name for a new struct
that will hold V2 channels with complete funding parameters, following
the PendingV1 pattern.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jkczyz@claude
Add PendingV2 channel phase between UnfundedV2 and Funded
c6c28f7
Introduce a PendingV2Channel struct and ChannelPhase::PendingV2 variant
to represent V2 channels that have completed funding transaction
construction but have not yet received commitment_signed.
The funding_tx_constructed method now performs the UnfundedV2 → PendingV2
phase transition using core::mem::replace, and funding_transaction_signed
and commitment_signed now match on PendingV2 instead of UnfundedV2.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Enforce ChannelTransactionParameters completeness at the type level
59f2ede
ChannelTransactionParameters used Option fields for counterparty
parameters and funding outpoint, relying on runtime unwrap/expect calls
scattered throughout the codebase. This was fragile since it was easy to
call code that assumed populated parameters on a not-yet-funded channel.
Split into PartialChannelTransactionParameters (used during negotiation)
and ChannelTransactionParameters (fully populated, used once funded).
Make FundingScope generic over the parameters type so the compiler
enforces which channel phases have complete data, eliminating the need
for runtime is_populated() guards in signers and elsewhere.
With the type-level distinction in place, also:
- Remove the InitialRemoteCommitmentReceiver trait, replacing it with a
ChannelContext method that takes complete parameters directly.
- Replace unset_funding_info with Channel::unfund(), which properly
transitions a funded channel back to unfunded state rather than
leaving it in an inconsistent "funded without funding info" state.
- Flatten DirectedChannelTransactionParameters to store resolved fields
directly instead of computing them on each access.
- Concretize methods that only work with complete parameters to take
FundingScope<ChannelTransactionParameters> directly, using field
access instead of trait-based Option-returning accessors.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@TheBlueMatt
TheBlueMatt
self-requested a review
March 17, 2026 13:14
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 19, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@jkczyzjkczyz
self-assigned this
Mar 19, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 21, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 23, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 25, 2026

Copy link


Copy Markdown

🔔 4th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 28, 2026

Copy link


Copy Markdown

🔔 5th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 30, 2026

Copy link


Copy Markdown

🔔 6th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 1, 2026

Copy link


Copy Markdown

🔔 7th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 4, 2026

Copy link


Copy Markdown

🔔 8th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 6, 2026

Copy link


Copy Markdown

🔔 9th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 8, 2026

Copy link


Copy Markdown

🔔 10th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 11, 2026

Copy link


Copy Markdown

🔔 11th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 13, 2026

Copy link


Copy Markdown

🔔 12th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 15, 2026

Copy link


Copy Markdown

🔔 13th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 18, 2026

Copy link


Copy Markdown

🔔 14th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 20, 2026

Copy link


Copy Markdown

🔔 15th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

🔔 16th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 25, 2026

Copy link


Copy Markdown

🔔 17th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 27, 2026

Copy link


Copy Markdown

🔔 18th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 29, 2026

Copy link


Copy Markdown

🔔 19th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 2, 2026

Copy link


Copy Markdown

🔔 20th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 4, 2026

Copy link


Copy Markdown

🔔 21st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 6, 2026

Copy link


Copy Markdown

🔔 22nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 9, 2026

Copy link


Copy Markdown

🔔 23rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 11, 2026

Copy link


Copy Markdown

🔔 24th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 13, 2026

Copy link


Copy Markdown

🔔 25th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 16, 2026

Copy link


Copy Markdown

🔔 26th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 18, 2026

Copy link


Copy Markdown

🔔 27th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 20, 2026

Copy link


Copy Markdown

🔔 28th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 23, 2026

Copy link


Copy Markdown

🔔 29th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 25, 2026

Copy link


Copy Markdown

🔔 30th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 27, 2026

Copy link


Copy Markdown

🔔 31st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 30, 2026

Copy link


Copy Markdown

🔔 32nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 1, 2026

Copy link


Copy Markdown

🔔 33rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 3, 2026

Copy link


Copy Markdown

🔔 34th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 6, 2026

Copy link


Copy Markdown

🔔 35th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

🔔 36th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 10, 2026

Copy link


Copy Markdown

🔔 37th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 13, 2026

Copy link


Copy Markdown

🔔 38th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 15, 2026

Copy link


Copy Markdown

🔔 39th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 17, 2026

Copy link


Copy Markdown

🔔 40th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 20, 2026

Copy link


Copy Markdown

🔔 41st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 22, 2026

Copy link


Copy Markdown

🔔 42nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@joostjagerjoostjager
mentioned this pull request
Jun 22, 2026

Closed

@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 24, 2026

Copy link


Copy Markdown

🔔 43rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 27, 2026

Copy link


Copy Markdown

🔔 44th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jul 3, 2026

Copy link


Copy Markdown

Hi @jkczyz,
Thanks for your contributions to rust-lightning!
After too many struggles with bugs, outages, contributor bans, and, finally, a multi-week CI ban, the rust-lightning project is moving off of GitHub for day-to-day development.
You can still file issues and access the git tree here, but PRs will now take place exclusively at https://git.rust-bitcoin.org/. As such, this PR has been migrated to https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4464
If you log in using GitHub (or otherwise link your GitHub account from https://git.rust-bitcoin.org/user/settings/security), ownership of your PRs, issues, and comments will automatically transfer. To push updates to this PR, you'll need to use git push git@gitea-ssh.bitcoin.ninja:lightningdevkit/rust-lightning YOUR_LOCAL_COMMIT_OR_BRANCH:jkczyz/2026-03-channel-tx-param-refactor. This may require a permissions change - if it doesn't work initially just leave a comment and we'll get you access.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattAwaiting requested review from TheBlueMatt

Assignees

@jkczyzjkczyz

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jkczyz@ldk-reviews-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Enforce ChannelTransactionParameters completeness - #4464
Closed
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Closed
Enforce ChannelTransactionParameters completeness#4464
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Conversation
@jkczyz
@jkczyzjkczyz
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
Introduces intermediate channel phases (PendingV1, PendingV2) between unfunded and funded states, then leverages them to enforce ChannelTransactionParameters completeness rather than relying on runtime unwrap()/expect() calls.
  • Add PendingV1 phase between UnfundedOutboundV1 and Funded, making the V1 state machine explicit: UnfundedOutboundV1 → PendingV1 → Funded
  • Add PendingV2 phase between UnfundedV2 and Funded for V2 channels that have constructed a funding transaction but not yet received commitment_signed
  • Split ChannelTransactionParameters into PartialChannelTransactionParameters (counterparty parameters and funding outpoint are Option) and ChannelTransactionParameters (all fields required). Previously a single struct used Option fields with is_populated() runtime guards scattered across signer code.
  • Make FundingScope generic over the parameters type (FundingScope<P>) so unfunded phases use PartialChannelTransactionParameters and funded phases use ChannelTransactionParameters, letting the compiler enforce which phases have complete data.
  • Concretize methods that only apply to funded channels to take FundingScope<ChannelTransactionParameters> directly, replacing trait-based Option-returning accessors with direct field access and eliminating the InitialRemoteCommitmentReceiver trait.
  • Flatten DirectedChannelTransactionParameters to store resolved fields directly since the Option-based fields it previously delegated to are now split across two types
  • Replace unset_funding_info with Channel::unfund(), which transitions a funded channel back to its unfunded phase since FundedChannel uses FundingScope<ChannelTransactionParameters> where the funding outpoint and counterparty parameters are non-Option and can't be cleared
jkczyzand others
added 4 commits
March 5, 2026 14:41
@jkczyz@claude
Add PendingV1 channel phase between UnfundedOutboundV1 and Funded
da68f2c
Introduce PendingV1Channel to represent the intermediate state where
funding_created has been generated but funding_signed has not yet been
received. This makes the channel state machine more explicit:
UnfundedOutboundV1 -> PendingV1 -> Funded
Move get_funding_created_msg, funding_signed, signer_maybe_unblocked
(funding path), unset_funding_info, and the InitialRemoteCommitmentReceiver
impl from OutboundV1Channel to PendingV1Channel.
Change OutboundV1Channel::get_funding_created to consume self and return
(PendingV1Channel, Option<FundingCreated>).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Rename PendingV2Channel to UnfundedV2Channel
717c854
Mechanical rename to free the PendingV2Channel name for a new struct
that will hold V2 channels with complete funding parameters, following
the PendingV1 pattern.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jkczyz@claude
Add PendingV2 channel phase between UnfundedV2 and Funded
c6c28f7
Introduce a PendingV2Channel struct and ChannelPhase::PendingV2 variant
to represent V2 channels that have completed funding transaction
construction but have not yet received commitment_signed.
The funding_tx_constructed method now performs the UnfundedV2 → PendingV2
phase transition using core::mem::replace, and funding_transaction_signed
and commitment_signed now match on PendingV2 instead of UnfundedV2.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Enforce ChannelTransactionParameters completeness at the type level
59f2ede
ChannelTransactionParameters used Option fields for counterparty
parameters and funding outpoint, relying on runtime unwrap/expect calls
scattered throughout the codebase. This was fragile since it was easy to
call code that assumed populated parameters on a not-yet-funded channel.
Split into PartialChannelTransactionParameters (used during negotiation)
and ChannelTransactionParameters (fully populated, used once funded).
Make FundingScope generic over the parameters type so the compiler
enforces which channel phases have complete data, eliminating the need
for runtime is_populated() guards in signers and elsewhere.
With the type-level distinction in place, also:
- Remove the InitialRemoteCommitmentReceiver trait, replacing it with a
ChannelContext method that takes complete parameters directly.
- Replace unset_funding_info with Channel::unfund(), which properly
transitions a funded channel back to unfunded state rather than
leaving it in an inconsistent "funded without funding info" state.
- Flatten DirectedChannelTransactionParameters to store resolved fields
directly instead of computing them on each access.
- Concretize methods that only work with complete parameters to take
FundingScope<ChannelTransactionParameters> directly, using field
access instead of trait-based Option-returning accessors.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@TheBlueMatt
TheBlueMatt
self-requested a review
March 17, 2026 13:14
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 19, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@jkczyzjkczyz
self-assigned this
Mar 19, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 21, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 23, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 25, 2026

Copy link


Copy Markdown

🔔 4th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 28, 2026

Copy link


Copy Markdown

🔔 5th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 30, 2026

Copy link


Copy Markdown

🔔 6th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 1, 2026

Copy link


Copy Markdown

🔔 7th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 4, 2026

Copy link


Copy Markdown

🔔 8th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 6, 2026

Copy link


Copy Markdown

🔔 9th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 8, 2026

Copy link


Copy Markdown

🔔 10th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 11, 2026

Copy link


Copy Markdown

🔔 11th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 13, 2026

Copy link


Copy Markdown

🔔 12th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 15, 2026

Copy link


Copy Markdown

🔔 13th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 18, 2026

Copy link


Copy Markdown

🔔 14th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 20, 2026

Copy link


Copy Markdown

🔔 15th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

🔔 16th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 25, 2026

Copy link


Copy Markdown

🔔 17th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 27, 2026

Copy link


Copy Markdown

🔔 18th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 29, 2026

Copy link


Copy Markdown

🔔 19th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 2, 2026

Copy link


Copy Markdown

🔔 20th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 4, 2026

Copy link


Copy Markdown

🔔 21st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 6, 2026

Copy link


Copy Markdown

🔔 22nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 9, 2026

Copy link


Copy Markdown

🔔 23rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 11, 2026

Copy link


Copy Markdown

🔔 24th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 13, 2026

Copy link


Copy Markdown

🔔 25th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 16, 2026

Copy link


Copy Markdown

🔔 26th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 18, 2026

Copy link


Copy Markdown

🔔 27th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 20, 2026

Copy link


Copy Markdown

🔔 28th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 23, 2026

Copy link


Copy Markdown

🔔 29th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 25, 2026

Copy link


Copy Markdown

🔔 30th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 27, 2026

Copy link


Copy Markdown

🔔 31st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 30, 2026

Copy link


Copy Markdown

🔔 32nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 1, 2026

Copy link


Copy Markdown

🔔 33rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 3, 2026

Copy link


Copy Markdown

🔔 34th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 6, 2026

Copy link


Copy Markdown

🔔 35th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

🔔 36th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 10, 2026

Copy link


Copy Markdown

🔔 37th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 13, 2026

Copy link


Copy Markdown

🔔 38th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 15, 2026

Copy link


Copy Markdown

🔔 39th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 17, 2026

Copy link


Copy Markdown

🔔 40th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 20, 2026

Copy link


Copy Markdown

🔔 41st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 22, 2026

Copy link


Copy Markdown

🔔 42nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@joostjagerjoostjager
mentioned this pull request
Jun 22, 2026

Closed

@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 24, 2026

Copy link


Copy Markdown

🔔 43rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 27, 2026

Copy link


Copy Markdown

🔔 44th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jul 3, 2026

Copy link


Copy Markdown

Hi @jkczyz,
Thanks for your contributions to rust-lightning!
After too many struggles with bugs, outages, contributor bans, and, finally, a multi-week CI ban, the rust-lightning project is moving off of GitHub for day-to-day development.
You can still file issues and access the git tree here, but PRs will now take place exclusively at https://git.rust-bitcoin.org/. As such, this PR has been migrated to https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4464
If you log in using GitHub (or otherwise link your GitHub account from https://git.rust-bitcoin.org/user/settings/security), ownership of your PRs, issues, and comments will automatically transfer. To push updates to this PR, you'll need to use git push git@gitea-ssh.bitcoin.ninja:lightningdevkit/rust-lightning YOUR_LOCAL_COMMIT_OR_BRANCH:jkczyz/2026-03-channel-tx-param-refactor. This may require a permissions change - if it doesn't work initially just leave a comment and we'll get you access.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattAwaiting requested review from TheBlueMatt

Assignees

@jkczyzjkczyz

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jkczyz@ldk-reviews-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Enforce ChannelTransactionParameters completeness - #4464
Closed
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Closed
Enforce ChannelTransactionParameters completeness#4464
jkczyz wants to merge 4 commits into
lightningdevkit:mainfrom 
jkczyz:2026-03-channel-tx-param-refactor
Conversation
@jkczyz
@jkczyzjkczyz
commented
Mar 5, 2026

Copy link


Copy Markdown

Contributor
Introduces intermediate channel phases (PendingV1, PendingV2) between unfunded and funded states, then leverages them to enforce ChannelTransactionParameters completeness rather than relying on runtime unwrap()/expect() calls.
  • Add PendingV1 phase between UnfundedOutboundV1 and Funded, making the V1 state machine explicit: UnfundedOutboundV1 → PendingV1 → Funded
  • Add PendingV2 phase between UnfundedV2 and Funded for V2 channels that have constructed a funding transaction but not yet received commitment_signed
  • Split ChannelTransactionParameters into PartialChannelTransactionParameters (counterparty parameters and funding outpoint are Option) and ChannelTransactionParameters (all fields required). Previously a single struct used Option fields with is_populated() runtime guards scattered across signer code.
  • Make FundingScope generic over the parameters type (FundingScope<P>) so unfunded phases use PartialChannelTransactionParameters and funded phases use ChannelTransactionParameters, letting the compiler enforce which phases have complete data.
  • Concretize methods that only apply to funded channels to take FundingScope<ChannelTransactionParameters> directly, replacing trait-based Option-returning accessors with direct field access and eliminating the InitialRemoteCommitmentReceiver trait.
  • Flatten DirectedChannelTransactionParameters to store resolved fields directly since the Option-based fields it previously delegated to are now split across two types
  • Replace unset_funding_info with Channel::unfund(), which transitions a funded channel back to its unfunded phase since FundedChannel uses FundingScope<ChannelTransactionParameters> where the funding outpoint and counterparty parameters are non-Option and can't be cleared
jkczyzand others
added 4 commits
March 5, 2026 14:41
@jkczyz@claude
Add PendingV1 channel phase between UnfundedOutboundV1 and Funded
da68f2c
Introduce PendingV1Channel to represent the intermediate state where
funding_created has been generated but funding_signed has not yet been
received. This makes the channel state machine more explicit:
UnfundedOutboundV1 -> PendingV1 -> Funded
Move get_funding_created_msg, funding_signed, signer_maybe_unblocked
(funding path), unset_funding_info, and the InitialRemoteCommitmentReceiver
impl from OutboundV1Channel to PendingV1Channel.
Change OutboundV1Channel::get_funding_created to consume self and return
(PendingV1Channel, Option<FundingCreated>).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Rename PendingV2Channel to UnfundedV2Channel
717c854
Mechanical rename to free the PendingV2Channel name for a new struct
that will hold V2 channels with complete funding parameters, following
the PendingV1 pattern.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jkczyz@claude
Add PendingV2 channel phase between UnfundedV2 and Funded
c6c28f7
Introduce a PendingV2Channel struct and ChannelPhase::PendingV2 variant
to represent V2 channels that have completed funding transaction
construction but have not yet received commitment_signed.
The funding_tx_constructed method now performs the UnfundedV2 → PendingV2
phase transition using core::mem::replace, and funding_transaction_signed
and commitment_signed now match on PendingV2 instead of UnfundedV2.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkczyz@claude
Enforce ChannelTransactionParameters completeness at the type level
59f2ede
ChannelTransactionParameters used Option fields for counterparty
parameters and funding outpoint, relying on runtime unwrap/expect calls
scattered throughout the codebase. This was fragile since it was easy to
call code that assumed populated parameters on a not-yet-funded channel.
Split into PartialChannelTransactionParameters (used during negotiation)
and ChannelTransactionParameters (fully populated, used once funded).
Make FundingScope generic over the parameters type so the compiler
enforces which channel phases have complete data, eliminating the need
for runtime is_populated() guards in signers and elsewhere.
With the type-level distinction in place, also:
- Remove the InitialRemoteCommitmentReceiver trait, replacing it with a
ChannelContext method that takes complete parameters directly.
- Replace unset_funding_info with Channel::unfund(), which properly
transitions a funded channel back to unfunded state rather than
leaving it in an inconsistent "funded without funding info" state.
- Flatten DirectedChannelTransactionParameters to store resolved fields
directly instead of computing them on each access.
- Concretize methods that only work with complete parameters to take
FundingScope<ChannelTransactionParameters> directly, using field
access instead of trait-based Option-returning accessors.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 5, 2026•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @TheBlueMatt as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@TheBlueMatt
TheBlueMatt
self-requested a review
March 17, 2026 13:14
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 19, 2026

Copy link


Copy Markdown

🔔 1st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@jkczyzjkczyz
self-assigned this
Mar 19, 2026
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 21, 2026

Copy link


Copy Markdown

🔔 2nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 23, 2026

Copy link


Copy Markdown

🔔 3rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 25, 2026

Copy link


Copy Markdown

🔔 4th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 28, 2026

Copy link


Copy Markdown

🔔 5th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Mar 30, 2026

Copy link


Copy Markdown

🔔 6th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 1, 2026

Copy link


Copy Markdown

🔔 7th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 4, 2026

Copy link


Copy Markdown

🔔 8th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 6, 2026

Copy link


Copy Markdown

🔔 9th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 8, 2026

Copy link


Copy Markdown

🔔 10th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 11, 2026

Copy link


Copy Markdown

🔔 11th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 13, 2026

Copy link


Copy Markdown

🔔 12th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 15, 2026

Copy link


Copy Markdown

🔔 13th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 18, 2026

Copy link


Copy Markdown

🔔 14th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 20, 2026

Copy link


Copy Markdown

🔔 15th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

🔔 16th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 25, 2026

Copy link


Copy Markdown

🔔 17th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 27, 2026

Copy link


Copy Markdown

🔔 18th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Apr 29, 2026

Copy link


Copy Markdown

🔔 19th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 2, 2026

Copy link


Copy Markdown

🔔 20th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 4, 2026

Copy link


Copy Markdown

🔔 21st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 6, 2026

Copy link


Copy Markdown

🔔 22nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 9, 2026

Copy link


Copy Markdown

🔔 23rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 11, 2026

Copy link


Copy Markdown

🔔 24th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 13, 2026

Copy link


Copy Markdown

🔔 25th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 16, 2026

Copy link


Copy Markdown

🔔 26th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 18, 2026

Copy link


Copy Markdown

🔔 27th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 20, 2026

Copy link


Copy Markdown

🔔 28th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 23, 2026

Copy link


Copy Markdown

🔔 29th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 25, 2026

Copy link


Copy Markdown

🔔 30th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 27, 2026

Copy link


Copy Markdown

🔔 31st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
May 30, 2026

Copy link


Copy Markdown

🔔 32nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 1, 2026

Copy link


Copy Markdown

🔔 33rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 3, 2026

Copy link


Copy Markdown

🔔 34th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 6, 2026

Copy link


Copy Markdown

🔔 35th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

🔔 36th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 10, 2026

Copy link


Copy Markdown

🔔 37th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 13, 2026

Copy link


Copy Markdown

🔔 38th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 15, 2026

Copy link


Copy Markdown

🔔 39th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 17, 2026

Copy link


Copy Markdown

🔔 40th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 20, 2026

Copy link


Copy Markdown

🔔 41st Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 22, 2026

Copy link


Copy Markdown

🔔 42nd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@joostjagerjoostjager
mentioned this pull request
Jun 22, 2026

Closed

@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 24, 2026

Copy link


Copy Markdown

🔔 43rd Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jun 27, 2026

Copy link


Copy Markdown

🔔 44th Reminder
Hey @TheBlueMatt! This PR has been waiting for your review.

Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.
@ldk-reviews-bot
ldk-reviews-bot
commented
Jul 3, 2026

Copy link


Copy Markdown

Hi @jkczyz,
Thanks for your contributions to rust-lightning!
After too many struggles with bugs, outages, contributor bans, and, finally, a multi-week CI ban, the rust-lightning project is moving off of GitHub for day-to-day development.
You can still file issues and access the git tree here, but PRs will now take place exclusively at https://git.rust-bitcoin.org/. As such, this PR has been migrated to https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4464
If you log in using GitHub (or otherwise link your GitHub account from https://git.rust-bitcoin.org/user/settings/security), ownership of your PRs, issues, and comments will automatically transfer. To push updates to this PR, you'll need to use git push git@gitea-ssh.bitcoin.ninja:lightningdevkit/rust-lightning YOUR_LOCAL_COMMIT_OR_BRANCH:jkczyz/2026-03-channel-tx-param-refactor. This may require a permissions change - if it doesn't work initially just leave a comment and we'll get you access.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheBlueMattTheBlueMattAwaiting requested review from TheBlueMatt

Assignees

@jkczyzjkczyz

Labels


None yet


Projects

Weekly Goals

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jkczyz@ldk-reviews-bot