This PR addresses the out-of-memory (OOM) errors during the artifact upload stage in the CI pipeline.

[Atishyy27]

Key Changes:

• Action Updates: Upgraded actions/upload-artifact, actions/download-artifact, and actions/checkout to @v4 to ensure Node 20 compatibility and improved performance.
• Memory Optimization: Set compression-level: 0 for the hfuzz-corpus upload in build.yml. Disabling compression prevents the runner from exhausting memory while processing large fuzzing datasets.
• SemVer Fix: Added fetch-depth: 0 to the SemVer check workflow to prevent tool panics during baseline comparisons.

Note: I'm opening this as a Draft because jobs were stuck in the queue on my fork. I'd like to verify the fixes using the main repository's runners.

[ldk-reviews-bot]

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.20%. Comparing base (066859b) to head (43066b7).
⚠️ Report is 2759 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #4478 +/- ##
==========================================
+ Coverage 84.55% 86.20% +1.64% 
==========================================
Files 135 161 +26 Lines 76569 107332 +30763 Branches 76569 107332 +30763 ==========================================
+ Hits 64745 92525 +27780 - Misses 9783 12192 +2409 - Partials 2041 2615 +574 

Flag	Coverage Δ
tests	86.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Atishyy27]

Hey @TheBlueMatt@carlaKC ,

All the primary CI checks have passed successfully on the main runners! The OOM issue is resolved with the compression-level: 0 fix (the fuzz job passed in ~74m).

The only failing check is the LDK Node Integration Tests. Looking at the logs, this seems to be a breakage caused by recent API changes in rust-lightning (PaymentForwarded event fields and splice_channel arguments) that haven't been reflected in ldk-node yet.

Let me know if you want me to squash the merge commits, or if this is good to go from my end once the ldk-node repo is updated!

[TheBlueMatt]

Please rebase your branch so that there are just commits on top of the existing LDK git tree, rather than including a merge commit.

[TheBlueMatt]

Please dont drop the EOL newline?

[TheBlueMatt]

Why do we need this?

[Atishyy27]

cargo-semver-checks needs to compare your current code against the "baseline" (the last release). By default, GitHub Actions does a "shallow clone" (only the last commit). Without the full history, the tool cannot find the previous version and crashes (it was giving Exit Code 101).

[Atishyy27]

Hey @TheBlueMatt@carlaKC,

Thanks for the feedback! I just force-pushed an update with these changes:

• Rebase: Rebased the branch to drop the merge commit, so it's just one clean commit on top of main now.
• v6 Updates: I went ahead and updated the action versions to v6 in all the other workflow files too, since Carla suggested bumping them everywhere.
• Formatting: Fixed the missing newline at the end of semver.yml and removed that duplicate line.
• fetch-depth: Regarding fetch-depth: 0—cargo-semver-checks was panicking (Exit Code 101) because the default shallow clone doesn't pull the old release tags it needs for the baseline comparison. Fetching the full history fixed the crash.

Let me know if this looks good to go

[ldk-reviews-bot]

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[TheBlueMatt]

CI is complaining because this doesn't exist.

[ldk-claude-review-bot]

This PR removes the trailing newline from the file (note the \ No newline at end of file marker in the diff). POSIX convention and most linters expect files to end with a newline. Please add the newline back.

[joostjager]

Removed

[ldk-claude-review-bot]

[joostjager]

@Atishyy27 reverted the v4->v6 change because it isn't compatible with the self-hosted runners. Given the urgency of fixing the fuzzer, I pushed the change.

[Atishyy27]

Key Changes:

• Action Updates: Upgraded actions/upload-artifact, actions/download-artifact, and actions/checkout to @v4 to ensure Node 20 compatibility and improved performance.
• Memory Optimization: Set compression-level: 0 for the hfuzz-corpus upload in build.yml. Disabling compression prevents the runner from exhausting memory while processing large fuzzing datasets.
• SemVer Fix: Added fetch-depth: 0 to the SemVer check workflow to prevent tool panics during baseline comparisons.

Note: I'm opening this as a Draft because jobs were stuck in the queue on my fork. I'd like to verify the fixes using the main repository's runners.

[ldk-reviews-bot]

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.20%. Comparing base (066859b) to head (43066b7).
⚠️ Report is 2759 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #4478 +/- ##
==========================================
+ Coverage 84.55% 86.20% +1.64% 
==========================================
Files 135 161 +26 Lines 76569 107332 +30763 Branches 76569 107332 +30763 ==========================================
+ Hits 64745 92525 +27780 - Misses 9783 12192 +2409 - Partials 2041 2615 +574 

Flag	Coverage Δ
tests	86.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Atishyy27]

Hey @TheBlueMatt@carlaKC ,

All the primary CI checks have passed successfully on the main runners! The OOM issue is resolved with the compression-level: 0 fix (the fuzz job passed in ~74m).

The only failing check is the LDK Node Integration Tests. Looking at the logs, this seems to be a breakage caused by recent API changes in rust-lightning (PaymentForwarded event fields and splice_channel arguments) that haven't been reflected in ldk-node yet.

Let me know if you want me to squash the merge commits, or if this is good to go from my end once the ldk-node repo is updated!

[TheBlueMatt]

Please rebase your branch so that there are just commits on top of the existing LDK git tree, rather than including a merge commit.

[TheBlueMatt]

Please dont drop the EOL newline?

[TheBlueMatt]

Why do we need this?

[Atishyy27]

cargo-semver-checks needs to compare your current code against the "baseline" (the last release). By default, GitHub Actions does a "shallow clone" (only the last commit). Without the full history, the tool cannot find the previous version and crashes (it was giving Exit Code 101).

[Atishyy27]

Hey @TheBlueMatt@carlaKC,

Thanks for the feedback! I just force-pushed an update with these changes:

• Rebase: Rebased the branch to drop the merge commit, so it's just one clean commit on top of main now.
• v6 Updates: I went ahead and updated the action versions to v6 in all the other workflow files too, since Carla suggested bumping them everywhere.
• Formatting: Fixed the missing newline at the end of semver.yml and removed that duplicate line.
• fetch-depth: Regarding fetch-depth: 0—cargo-semver-checks was panicking (Exit Code 101) because the default shallow clone doesn't pull the old release tags it needs for the baseline comparison. Fetching the full history fixed the crash.

Let me know if this looks good to go

[ldk-reviews-bot]

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[TheBlueMatt]

CI is complaining because this doesn't exist.

[ldk-claude-review-bot]

This PR removes the trailing newline from the file (note the \ No newline at end of file marker in the diff). POSIX convention and most linters expect files to end with a newline. Please add the newline back.

[joostjager]

Removed

[ldk-claude-review-bot]

[joostjager]

@Atishyy27 reverted the v4->v6 change because it isn't compatible with the self-hosted runners. Given the urgency of fixing the fuzzer, I pushed the change.

[Atishyy27]

Key Changes:

• Action Updates: Upgraded actions/upload-artifact, actions/download-artifact, and actions/checkout to @v4 to ensure Node 20 compatibility and improved performance.
• Memory Optimization: Set compression-level: 0 for the hfuzz-corpus upload in build.yml. Disabling compression prevents the runner from exhausting memory while processing large fuzzing datasets.
• SemVer Fix: Added fetch-depth: 0 to the SemVer check workflow to prevent tool panics during baseline comparisons.

Note: I'm opening this as a Draft because jobs were stuck in the queue on my fork. I'd like to verify the fixes using the main repository's runners.

[ldk-reviews-bot]

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.20%. Comparing base (066859b) to head (43066b7).
⚠️ Report is 2759 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #4478 +/- ##
==========================================
+ Coverage 84.55% 86.20% +1.64% 
==========================================
Files 135 161 +26 Lines 76569 107332 +30763 Branches 76569 107332 +30763 ==========================================
+ Hits 64745 92525 +27780 - Misses 9783 12192 +2409 - Partials 2041 2615 +574 

Flag	Coverage Δ
tests	86.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Atishyy27]

Hey @TheBlueMatt@carlaKC ,

All the primary CI checks have passed successfully on the main runners! The OOM issue is resolved with the compression-level: 0 fix (the fuzz job passed in ~74m).

The only failing check is the LDK Node Integration Tests. Looking at the logs, this seems to be a breakage caused by recent API changes in rust-lightning (PaymentForwarded event fields and splice_channel arguments) that haven't been reflected in ldk-node yet.

Let me know if you want me to squash the merge commits, or if this is good to go from my end once the ldk-node repo is updated!

[TheBlueMatt]

Please rebase your branch so that there are just commits on top of the existing LDK git tree, rather than including a merge commit.

[TheBlueMatt]

Please dont drop the EOL newline?

[TheBlueMatt]

Why do we need this?

[Atishyy27]

cargo-semver-checks needs to compare your current code against the "baseline" (the last release). By default, GitHub Actions does a "shallow clone" (only the last commit). Without the full history, the tool cannot find the previous version and crashes (it was giving Exit Code 101).

[Atishyy27]

Hey @TheBlueMatt@carlaKC,

Thanks for the feedback! I just force-pushed an update with these changes:

• Rebase: Rebased the branch to drop the merge commit, so it's just one clean commit on top of main now.
• v6 Updates: I went ahead and updated the action versions to v6 in all the other workflow files too, since Carla suggested bumping them everywhere.
• Formatting: Fixed the missing newline at the end of semver.yml and removed that duplicate line.
• fetch-depth: Regarding fetch-depth: 0—cargo-semver-checks was panicking (Exit Code 101) because the default shallow clone doesn't pull the old release tags it needs for the baseline comparison. Fetching the full history fixed the crash.

Let me know if this looks good to go

[ldk-reviews-bot]

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[TheBlueMatt]

CI is complaining because this doesn't exist.

[ldk-claude-review-bot]

This PR removes the trailing newline from the file (note the \ No newline at end of file marker in the diff). POSIX convention and most linters expect files to end with a newline. Please add the newline back.

[joostjager]

Removed

[ldk-claude-review-bot]

[joostjager]

@Atishyy27 reverted the v4->v6 change because it isn't compatible with the self-hosted runners. Given the urgency of fixing the fuzzer, I pushed the change.

[Atishyy27]

Key Changes:

• Action Updates: Upgraded actions/upload-artifact, actions/download-artifact, and actions/checkout to @v4 to ensure Node 20 compatibility and improved performance.
• Memory Optimization: Set compression-level: 0 for the hfuzz-corpus upload in build.yml. Disabling compression prevents the runner from exhausting memory while processing large fuzzing datasets.
• SemVer Fix: Added fetch-depth: 0 to the SemVer check workflow to prevent tool panics during baseline comparisons.

Note: I'm opening this as a Draft because jobs were stuck in the queue on my fork. I'd like to verify the fixes using the main repository's runners.

[ldk-reviews-bot]

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.20%. Comparing base (066859b) to head (43066b7).
⚠️ Report is 2759 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #4478 +/- ##
==========================================
+ Coverage 84.55% 86.20% +1.64% 
==========================================
Files 135 161 +26 Lines 76569 107332 +30763 Branches 76569 107332 +30763 ==========================================
+ Hits 64745 92525 +27780 - Misses 9783 12192 +2409 - Partials 2041 2615 +574 

Flag	Coverage Δ
tests	86.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Atishyy27]

Hey @TheBlueMatt@carlaKC ,

All the primary CI checks have passed successfully on the main runners! The OOM issue is resolved with the compression-level: 0 fix (the fuzz job passed in ~74m).

The only failing check is the LDK Node Integration Tests. Looking at the logs, this seems to be a breakage caused by recent API changes in rust-lightning (PaymentForwarded event fields and splice_channel arguments) that haven't been reflected in ldk-node yet.

Let me know if you want me to squash the merge commits, or if this is good to go from my end once the ldk-node repo is updated!

[TheBlueMatt]

Please rebase your branch so that there are just commits on top of the existing LDK git tree, rather than including a merge commit.

[TheBlueMatt]

Please dont drop the EOL newline?

[TheBlueMatt]

Why do we need this?

[Atishyy27]

cargo-semver-checks needs to compare your current code against the "baseline" (the last release). By default, GitHub Actions does a "shallow clone" (only the last commit). Without the full history, the tool cannot find the previous version and crashes (it was giving Exit Code 101).

[Atishyy27]

Hey @TheBlueMatt@carlaKC,

Thanks for the feedback! I just force-pushed an update with these changes:

• Rebase: Rebased the branch to drop the merge commit, so it's just one clean commit on top of main now.
• v6 Updates: I went ahead and updated the action versions to v6 in all the other workflow files too, since Carla suggested bumping them everywhere.
• Formatting: Fixed the missing newline at the end of semver.yml and removed that duplicate line.
• fetch-depth: Regarding fetch-depth: 0—cargo-semver-checks was panicking (Exit Code 101) because the default shallow clone doesn't pull the old release tags it needs for the baseline comparison. Fetching the full history fixed the crash.

Let me know if this looks good to go

[ldk-reviews-bot]

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[TheBlueMatt]

CI is complaining because this doesn't exist.

[ldk-claude-review-bot]

This PR removes the trailing newline from the file (note the \ No newline at end of file marker in the diff). POSIX convention and most linters expect files to end with a newline. Please add the newline back.

[joostjager]

Removed

[ldk-claude-review-bot]

[joostjager]

@Atishyy27 reverted the v4->v6 change because it isn't compatible with the self-hosted runners. Given the urgency of fixing the fuzzer, I pushed the change.

[Atishyy27]

Key Changes:

• Action Updates: Upgraded actions/upload-artifact, actions/download-artifact, and actions/checkout to @v4 to ensure Node 20 compatibility and improved performance.
• Memory Optimization: Set compression-level: 0 for the hfuzz-corpus upload in build.yml. Disabling compression prevents the runner from exhausting memory while processing large fuzzing datasets.
• SemVer Fix: Added fetch-depth: 0 to the SemVer check workflow to prevent tool panics during baseline comparisons.

Note: I'm opening this as a Draft because jobs were stuck in the queue on my fork. I'd like to verify the fixes using the main repository's runners.

[ldk-reviews-bot]

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.20%. Comparing base (066859b) to head (43066b7).
⚠️ Report is 2759 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #4478 +/- ##
==========================================
+ Coverage 84.55% 86.20% +1.64% 
==========================================
Files 135 161 +26 Lines 76569 107332 +30763 Branches 76569 107332 +30763 ==========================================
+ Hits 64745 92525 +27780 - Misses 9783 12192 +2409 - Partials 2041 2615 +574 

Flag	Coverage Δ
tests	86.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Atishyy27]

Hey @TheBlueMatt@carlaKC ,

All the primary CI checks have passed successfully on the main runners! The OOM issue is resolved with the compression-level: 0 fix (the fuzz job passed in ~74m).

The only failing check is the LDK Node Integration Tests. Looking at the logs, this seems to be a breakage caused by recent API changes in rust-lightning (PaymentForwarded event fields and splice_channel arguments) that haven't been reflected in ldk-node yet.

Let me know if you want me to squash the merge commits, or if this is good to go from my end once the ldk-node repo is updated!

[TheBlueMatt]

Please rebase your branch so that there are just commits on top of the existing LDK git tree, rather than including a merge commit.

[TheBlueMatt]

Please dont drop the EOL newline?

[TheBlueMatt]

Why do we need this?

[Atishyy27]

cargo-semver-checks needs to compare your current code against the "baseline" (the last release). By default, GitHub Actions does a "shallow clone" (only the last commit). Without the full history, the tool cannot find the previous version and crashes (it was giving Exit Code 101).

[Atishyy27]

Hey @TheBlueMatt@carlaKC,

Thanks for the feedback! I just force-pushed an update with these changes:

• Rebase: Rebased the branch to drop the merge commit, so it's just one clean commit on top of main now.
• v6 Updates: I went ahead and updated the action versions to v6 in all the other workflow files too, since Carla suggested bumping them everywhere.
• Formatting: Fixed the missing newline at the end of semver.yml and removed that duplicate line.
• fetch-depth: Regarding fetch-depth: 0—cargo-semver-checks was panicking (Exit Code 101) because the default shallow clone doesn't pull the old release tags it needs for the baseline comparison. Fetching the full history fixed the crash.

Let me know if this looks good to go

[ldk-reviews-bot]

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[TheBlueMatt]

CI is complaining because this doesn't exist.

[ldk-claude-review-bot]

This PR removes the trailing newline from the file (note the \ No newline at end of file marker in the diff). POSIX convention and most linters expect files to end with a newline. Please add the newline back.

[joostjager]

Removed

[ldk-claude-review-bot]

[joostjager]

@Atishyy27 reverted the v4->v6 change because it isn't compatible with the self-hosted runners. Given the urgency of fixing the fuzzer, I pushed the change.

[Atishyy27]

Key Changes:

• Action Updates: Upgraded actions/upload-artifact, actions/download-artifact, and actions/checkout to @v4 to ensure Node 20 compatibility and improved performance.
• Memory Optimization: Set compression-level: 0 for the hfuzz-corpus upload in build.yml. Disabling compression prevents the runner from exhausting memory while processing large fuzzing datasets.
• SemVer Fix: Added fetch-depth: 0 to the SemVer check workflow to prevent tool panics during baseline comparisons.

Note: I'm opening this as a Draft because jobs were stuck in the queue on my fork. I'd like to verify the fixes using the main repository's runners.

[ldk-reviews-bot]

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.20%. Comparing base (066859b) to head (43066b7).
⚠️ Report is 2759 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #4478 +/- ##
==========================================
+ Coverage 84.55% 86.20% +1.64% 
==========================================
Files 135 161 +26 Lines 76569 107332 +30763 Branches 76569 107332 +30763 ==========================================
+ Hits 64745 92525 +27780 - Misses 9783 12192 +2409 - Partials 2041 2615 +574 

Flag	Coverage Δ
tests	86.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Atishyy27]

Hey @TheBlueMatt@carlaKC ,

All the primary CI checks have passed successfully on the main runners! The OOM issue is resolved with the compression-level: 0 fix (the fuzz job passed in ~74m).

The only failing check is the LDK Node Integration Tests. Looking at the logs, this seems to be a breakage caused by recent API changes in rust-lightning (PaymentForwarded event fields and splice_channel arguments) that haven't been reflected in ldk-node yet.

Let me know if you want me to squash the merge commits, or if this is good to go from my end once the ldk-node repo is updated!

[TheBlueMatt]

Please rebase your branch so that there are just commits on top of the existing LDK git tree, rather than including a merge commit.

[TheBlueMatt]

Please dont drop the EOL newline?

[TheBlueMatt]

Why do we need this?

[Atishyy27]

cargo-semver-checks needs to compare your current code against the "baseline" (the last release). By default, GitHub Actions does a "shallow clone" (only the last commit). Without the full history, the tool cannot find the previous version and crashes (it was giving Exit Code 101).

[Atishyy27]

Hey @TheBlueMatt@carlaKC,

Thanks for the feedback! I just force-pushed an update with these changes:

• Rebase: Rebased the branch to drop the merge commit, so it's just one clean commit on top of main now.
• v6 Updates: I went ahead and updated the action versions to v6 in all the other workflow files too, since Carla suggested bumping them everywhere.
• Formatting: Fixed the missing newline at the end of semver.yml and removed that duplicate line.
• fetch-depth: Regarding fetch-depth: 0—cargo-semver-checks was panicking (Exit Code 101) because the default shallow clone doesn't pull the old release tags it needs for the baseline comparison. Fetching the full history fixed the crash.

Let me know if this looks good to go

[ldk-reviews-bot]

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[TheBlueMatt]

CI is complaining because this doesn't exist.

[ldk-claude-review-bot]

This PR removes the trailing newline from the file (note the \ No newline at end of file marker in the diff). POSIX convention and most linters expect files to end with a newline. Please add the newline back.

[joostjager]

Removed

[ldk-claude-review-bot]

[joostjager]

@Atishyy27 reverted the v4->v6 change because it isn't compatible with the self-hosted runners. Given the urgency of fixing the fuzzer, I pushed the change.

[Atishyy27]

Key Changes:

• Action Updates: Upgraded actions/upload-artifact, actions/download-artifact, and actions/checkout to @v4 to ensure Node 20 compatibility and improved performance.
• Memory Optimization: Set compression-level: 0 for the hfuzz-corpus upload in build.yml. Disabling compression prevents the runner from exhausting memory while processing large fuzzing datasets.
• SemVer Fix: Added fetch-depth: 0 to the SemVer check workflow to prevent tool panics during baseline comparisons.

Note: I'm opening this as a Draft because jobs were stuck in the queue on my fork. I'd like to verify the fixes using the main repository's runners.

[ldk-reviews-bot]

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.20%. Comparing base (066859b) to head (43066b7).
⚠️ Report is 2759 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #4478 +/- ##
==========================================
+ Coverage 84.55% 86.20% +1.64% 
==========================================
Files 135 161 +26 Lines 76569 107332 +30763 Branches 76569 107332 +30763 ==========================================
+ Hits 64745 92525 +27780 - Misses 9783 12192 +2409 - Partials 2041 2615 +574 

Flag	Coverage Δ
tests	86.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Atishyy27]

Hey @TheBlueMatt@carlaKC ,

All the primary CI checks have passed successfully on the main runners! The OOM issue is resolved with the compression-level: 0 fix (the fuzz job passed in ~74m).

The only failing check is the LDK Node Integration Tests. Looking at the logs, this seems to be a breakage caused by recent API changes in rust-lightning (PaymentForwarded event fields and splice_channel arguments) that haven't been reflected in ldk-node yet.

Let me know if you want me to squash the merge commits, or if this is good to go from my end once the ldk-node repo is updated!

[TheBlueMatt]

Please rebase your branch so that there are just commits on top of the existing LDK git tree, rather than including a merge commit.

[TheBlueMatt]

Please dont drop the EOL newline?

[TheBlueMatt]

Why do we need this?

[Atishyy27]

cargo-semver-checks needs to compare your current code against the "baseline" (the last release). By default, GitHub Actions does a "shallow clone" (only the last commit). Without the full history, the tool cannot find the previous version and crashes (it was giving Exit Code 101).

[Atishyy27]

Hey @TheBlueMatt@carlaKC,

Thanks for the feedback! I just force-pushed an update with these changes:

• Rebase: Rebased the branch to drop the merge commit, so it's just one clean commit on top of main now.
• v6 Updates: I went ahead and updated the action versions to v6 in all the other workflow files too, since Carla suggested bumping them everywhere.
• Formatting: Fixed the missing newline at the end of semver.yml and removed that duplicate line.
• fetch-depth: Regarding fetch-depth: 0—cargo-semver-checks was panicking (Exit Code 101) because the default shallow clone doesn't pull the old release tags it needs for the baseline comparison. Fetching the full history fixed the crash.

Let me know if this looks good to go

[ldk-reviews-bot]

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[TheBlueMatt]

CI is complaining because this doesn't exist.

[ldk-claude-review-bot]

This PR removes the trailing newline from the file (note the \ No newline at end of file marker in the diff). POSIX convention and most linters expect files to end with a newline. Please add the newline back.

[joostjager]

Removed

[ldk-claude-review-bot]

[joostjager]

@Atishyy27 reverted the v4->v6 change because it isn't compatible with the self-hosted runners. Given the urgency of fixing the fuzzer, I pushed the change.

[Atishyy27]

Key Changes:

• Action Updates: Upgraded actions/upload-artifact, actions/download-artifact, and actions/checkout to @v4 to ensure Node 20 compatibility and improved performance.
• Memory Optimization: Set compression-level: 0 for the hfuzz-corpus upload in build.yml. Disabling compression prevents the runner from exhausting memory while processing large fuzzing datasets.
• SemVer Fix: Added fetch-depth: 0 to the SemVer check workflow to prevent tool panics during baseline comparisons.

Note: I'm opening this as a Draft because jobs were stuck in the queue on my fork. I'd like to verify the fixes using the main repository's runners.

[ldk-reviews-bot]

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.20%. Comparing base (066859b) to head (43066b7).
⚠️ Report is 2759 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #4478 +/- ##
==========================================
+ Coverage 84.55% 86.20% +1.64% 
==========================================
Files 135 161 +26 Lines 76569 107332 +30763 Branches 76569 107332 +30763 ==========================================
+ Hits 64745 92525 +27780 - Misses 9783 12192 +2409 - Partials 2041 2615 +574 

Flag	Coverage Δ
tests	86.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Atishyy27]

Hey @TheBlueMatt@carlaKC ,

All the primary CI checks have passed successfully on the main runners! The OOM issue is resolved with the compression-level: 0 fix (the fuzz job passed in ~74m).

The only failing check is the LDK Node Integration Tests. Looking at the logs, this seems to be a breakage caused by recent API changes in rust-lightning (PaymentForwarded event fields and splice_channel arguments) that haven't been reflected in ldk-node yet.

Let me know if you want me to squash the merge commits, or if this is good to go from my end once the ldk-node repo is updated!

[TheBlueMatt]

Please rebase your branch so that there are just commits on top of the existing LDK git tree, rather than including a merge commit.

[TheBlueMatt]

Please dont drop the EOL newline?

[TheBlueMatt]

Why do we need this?

[Atishyy27]

cargo-semver-checks needs to compare your current code against the "baseline" (the last release). By default, GitHub Actions does a "shallow clone" (only the last commit). Without the full history, the tool cannot find the previous version and crashes (it was giving Exit Code 101).

[Atishyy27]

Hey @TheBlueMatt@carlaKC,

Thanks for the feedback! I just force-pushed an update with these changes:

• Rebase: Rebased the branch to drop the merge commit, so it's just one clean commit on top of main now.
• v6 Updates: I went ahead and updated the action versions to v6 in all the other workflow files too, since Carla suggested bumping them everywhere.
• Formatting: Fixed the missing newline at the end of semver.yml and removed that duplicate line.
• fetch-depth: Regarding fetch-depth: 0—cargo-semver-checks was panicking (Exit Code 101) because the default shallow clone doesn't pull the old release tags it needs for the baseline comparison. Fetching the full history fixed the crash.

Let me know if this looks good to go

[ldk-reviews-bot]

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[TheBlueMatt]

CI is complaining because this doesn't exist.

[ldk-claude-review-bot]

This PR removes the trailing newline from the file (note the \ No newline at end of file marker in the diff). POSIX convention and most linters expect files to end with a newline. Please add the newline back.

[joostjager]

Removed

[ldk-claude-review-bot]

[joostjager]

@Atishyy27 reverted the v4->v6 change because it isn't compatible with the self-hosted runners. Given the urgency of fixing the fuzzer, I pushed the change.