fuzz: improve CI iteration strategy, add corpus minimization and summary reporting#4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 2 commits into from
Mar 24, 2026
Merged

fuzz: improve CI iteration strategy, add corpus minimization and summary reporting #4497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b41fa33
ci: split fuzz sanity check into separate parallel job
joostjager Mar 20, 2026
24bbb4a
fuzz: improve iteration scaling, add minimization and summary table
joostjager Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -205,6 +205,21 @@ jobs:
- name: Simulate docs.rs build
run: ci/check-docsrs.sh

fuzz_sanity:
runs-on: self-hosted
env:
TOOLCHAIN: 1.75
steps:
- name: Checkout source code
uses: actions/checkout@v4
- name: Install Rust ${{ env.TOOLCHAIN }} toolchain
run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
- name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
run: |
cd fuzz
cargo test --quiet --color always --lib --bins -j8

fuzz:
runs-on: self-hosted
env:
Expand DownExpand Up@@ -238,13 +253,10 @@ jobs:
key: fuzz-corpus-refs/heads/main-${{ github.sha }}
restore-keys: |
fuzz-corpus-refs/heads/main-
- name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
run: |
cd fuzz
cargo test --verbose --color always --lib --bins -j8
cargo clean
- name: Run fuzzers
run: cd fuzz && ./ci-fuzz.sh && cd ..
env:
FUZZ_MINIMIZE: ${{ contains(github.event.pull_request.labels.*.name, 'fuzz-minimize') }}

@TheBlueMattTheBlueMattMar 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bother if we do this on main every time anyway?

@joostjagerjoostjagerMar 21, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it just for testing. Or maybe if a fuzz-affecting refactor PR is open for a long time and has accumulated a large corpus.

Can also remove the label trigger. Do you prefer that?

@TheBlueMattTheBlueMattMar 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just seems like something we'll never remember to do and isn't very useful, but it certainly also doesn't matter that much.

- name: Upload honggfuzz corpus
uses: actions/upload-artifact@v4
with:
Expand DownExpand Up@@ -308,7 +320,7 @@ jobs:
TOR_PROXY="127.0.0.1:9050" RUSTFLAGS="--cfg=tor" cargo test --verbose --color always -p lightning-net-tokio

notify-failure:
needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz_sanity, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
if: failure() && github.ref == 'refs/heads/main'
runs-on: ubuntu-latest
permissions:
Expand Down
76 changes: 69 additions & 7 deletions fuzz/ci-fuzz.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,20 +30,82 @@ sed -i 's/lto = true//' Cargo.toml
export HFUZZ_BUILD_ARGS="--features honggfuzz_fuzz"

cargo --color always hfuzz build -j8

SUMMARY=""

check_crash() {
local FILE=$1
if [ -f "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT" ]; then
cat "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT"
for CASE in "hfuzz_workspace/$FILE"/SIG*; do
cat "$CASE" | xxd -p
done
exit 1
fi
}

for TARGET in src/bin/*.rs; do
FILENAME=$(basename $TARGET)
FILE="${FILENAME%.*}"
HFUZZ_RUN_ARGS="--exit_upon_crash -v -n8 --run_time 30"
CORPUS_DIR="hfuzz_workspace/$FILE/input"
CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
# Run 8x the corpus size plus a baseline, ensuring full corpus replay
# with room for new mutations. The 10-minute hard cap (--run_time 600)
# prevents slow-per-iteration targets from running too long.
ITERATIONS=$((CORPUS_COUNT * 8 + 1000))
HFUZZ_RUN_ARGS="--exit_upon_crash -q -n8 -t 3 -N $ITERATIONS --run_time 600"
if [ "$FILE" = "chanmon_consistency_target" -o "$FILE" = "fs_store_target" ]; then
HFUZZ_RUN_ARGS="$HFUZZ_RUN_ARGS -F 64"
fi
export HFUZZ_RUN_ARGS
FUZZ_START=$(date +%s)
cargo --color always hfuzz run $FILE
if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ]; then
cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
for CASE in hfuzz_workspace/$FILE/SIG*; do
cat $CASE | xxd -p
done
exit 1
FUZZ_END=$(date +%s)
FUZZ_TIME=$((FUZZ_END - FUZZ_START))
FUZZ_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
check_crash "$FILE"
if [ "$GITHUB_REF" = "refs/heads/main" ] || [ "$FUZZ_MINIMIZE" = "true" ]; then
HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
MIN_START=$(date +%s)
cargo --color always hfuzz run $FILE
MIN_END=$(date +%s)
MIN_TIME=$((MIN_END - MIN_START))
MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
Comment on lines +67 to +74

@ldk-claude-review-botldk-claude-review-botMar 21, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crash check (lines 55-61) runs only after the fuzz step, but not after the minimization step here. Minimization still executes every corpus input through the target binary. If a crash occurs during minimization (e.g., a newly-mutated input from the fuzz step that was added to the corpus but didn't crash during fuzzing due to timing, or a non-deterministic crash), the HONGGFUZZ.REPORT.TXT would be written but never checked.

Consider adding a crash check after the minimization run as well:

Suggested change
if [ "$GITHUB_REF"="refs/heads/main" ] || [ "$FUZZ_MINIMIZE"="true" ];then
HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
MIN_START=$(date +%s)
cargo --color always hfuzz run $FILE
MIN_END=$(date +%s)
MIN_TIME=$((MIN_END - MIN_START))
MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
MIN_START=$(date +%s)
cargo --color always hfuzz run $FILE
MIN_END=$(date +%s)
MIN_TIME=$((MIN_END - MIN_START))
MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ];then
cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
forCASEin hfuzz_workspace/$FILE/SIG*;do
cat $CASE| xxd -p
done
exit 1
fi

@TheBlueMattTheBlueMattMar 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, probably worth doing this.

@joostjagerjoostjagerMar 23, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

check_crash "$FILE"
SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|${MIN_CORPUS_COUNT}|${MIN_TIME}\n"
else
SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|-|-\n"
fi
done

fmt_time() {
local secs=$1
local m=$((secs / 60))
local s=$((secs % 60))
if [ "$m" -gt 0 ]; then
printf "%dm %ds" "$m" "$s"
else
printf "%ds" "$s"
fi
}

# Print summary table
set +x
echo ""
echo "==== Fuzz Summary ===="
HDR="%-40s %7s %7s %-15s %9s %-15s %9s\n"
FMT="%-40s %7s %7s %6s %-9s %9s %6s %-9s %9s\n"
printf "$HDR" "Target" "Iters" "Corpus" " Fuzzed" "Fuzz time" " Minimized" "Min. time"
printf "$HDR" "------" "-----" "------" "---------------" "---------" "---------------" "---------"
echo -e "$SUMMARY" | while IFS='|' read -r name iters orig fuzzed ftime minimized mtime; do
[ -z "$name" ] && continue
fuzz_delta=$((fuzzed - orig))
if [ "$minimized" = "-" ]; then
printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "-" "" "-"
else
min_delta=$((minimized - fuzzed))
printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "$minimized" "($min_delta)" "$(fmt_time "$mtime")"
fi
done
echo "======================"
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fuzz: improve CI iteration strategy, add corpus minimization and summary reporting#4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Mar 24, 2026
 Merged


fuzz: improve CI iteration strategy, add corpus minimization and summary reporting
#4497
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
b41fa33

ci: split fuzz sanity check into separate parallel job


joostjager Mar 20, 2026
24bbb4a

fuzz: improve iteration scaling, add minimization and summary table


joostjager Mar 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 18 additions & 6 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,6 +205,21 @@ jobs:
 - name: Simulate docs.rs build
 run: ci/check-docsrs.sh

 fuzz_sanity:
 runs-on: self-hosted
 env:
 TOOLCHAIN: 1.75
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --quiet --color always --lib --bins -j8

 fuzz:
 runs-on: self-hosted
 env:
Expand DownExpand Up@@ -238,13 +253,10 @@ jobs:
 key: fuzz-corpus-refs/heads/main-${{ github.sha }}
 restore-keys: |
 fuzz-corpus-refs/heads/main-
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --verbose --color always --lib --bins -j8
 cargo clean
 - name: Run fuzzers
 run: cd fuzz && ./ci-fuzz.sh && cd ..
 env:
 FUZZ_MINIMIZE: ${{ contains(github.event.pull_request.labels.*.name, 'fuzz-minimize') }}
@TheBlueMattTheBlueMattMar 20, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bother if we do this on main every time anyway?
@joostjagerjoostjagerMar 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it just for testing. Or maybe if a fuzz-affecting refactor PR is open for a long time and has accumulated a large corpus.
Can also remove the label trigger. Do you prefer that?
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just seems like something we'll never remember to do and isn't very useful, but it certainly also doesn't matter that much.
 - name: Upload honggfuzz corpus
 uses: actions/upload-artifact@v4
 with:
Expand DownExpand Up@@ -308,7 +320,7 @@ jobs:
 TOR_PROXY="127.0.0.1:9050" RUSTFLAGS="--cfg=tor" cargo test --verbose --color always -p lightning-net-tokio

 notify-failure:
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz_sanity, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 if: failure() && github.ref == 'refs/heads/main'
 runs-on: ubuntu-latest
 permissions:
Expand Down

76 changes: 69 additions & 7 deletions
fuzz/ci-fuzz.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,20 +30,82 @@ sed -i 's/lto = true//' Cargo.toml
export HFUZZ_BUILD_ARGS="--features honggfuzz_fuzz"

cargo --color always hfuzz build -j8

SUMMARY=""

check_crash() {
	local FILE=$1
	if [ -f "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT" ]; then
 cat "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT"
 for CASE in "hfuzz_workspace/$FILE"/SIG*; do
 cat "$CASE" | xxd -p
 done
 exit 1
	fi
}

for TARGET in src/bin/*.rs; do
	FILENAME=$(basename $TARGET)
	FILE="${FILENAME%.*}"
	HFUZZ_RUN_ARGS="--exit_upon_crash -v -n8 --run_time 30"
	CORPUS_DIR="hfuzz_workspace/$FILE/input"
	CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	# Run 8x the corpus size plus a baseline, ensuring full corpus replay
	# with room for new mutations. The 10-minute hard cap (--run_time 600)
	# prevents slow-per-iteration targets from running too long.
	ITERATIONS=$((CORPUS_COUNT * 8 + 1000))
	HFUZZ_RUN_ARGS="--exit_upon_crash -q -n8 -t 3 -N $ITERATIONS --run_time 600"
	if [ "$FILE" = "chanmon_consistency_target" -o "$FILE" = "fs_store_target" ]; then
 HFUZZ_RUN_ARGS="$HFUZZ_RUN_ARGS -F 64"
	fi
	export HFUZZ_RUN_ARGS
	FUZZ_START=$(date +%s)
	cargo --color always hfuzz run $FILE
	if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ]; then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
 for CASE in hfuzz_workspace/$FILE/SIG*; do
 cat $CASE | xxd -p
 done
 exit 1
	FUZZ_END=$(date +%s)
	FUZZ_TIME=$((FUZZ_END - FUZZ_START))
	FUZZ_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	check_crash "$FILE"
	if [ "$GITHUB_REF" = "refs/heads/main" ] || [ "$FUZZ_MINIMIZE" = "true" ]; then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
 export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)

Comment on lines

+67
 to 
+74

@ldk-claude-review-botldk-claude-review-botMar 21, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crash check (lines 55-61) runs only after the fuzz step, but not after the minimization step here. Minimization still executes every corpus input through the target binary. If a crash occurs during minimization (e.g., a newly-mutated input from the fuzz step that was added to the corpus but didn't crash during fuzzing due to timing, or a non-deterministic crash), the HONGGFUZZ.REPORT.TXT would be written but never checked.
Consider adding a crash check after the minimization run as well:

Suggested change

if [ "$GITHUB_REF"="refs/heads/main" ] || [ "$FUZZ_MINIMIZE"="true" ];then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ];then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
forCASEin hfuzz_workspace/$FILE/SIG*;do
 cat $CASE| xxd -p
done
exit 1
fi
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, probably worth doing this.
@joostjagerjoostjagerMar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
 check_crash "$FILE"
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|${MIN_CORPUS_COUNT}|${MIN_TIME}\n"
	else
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|-|-\n"
	fi
done

fmt_time() {
	local secs=$1
	local m=$((secs / 60))
	local s=$((secs % 60))
	if [ "$m" -gt 0 ]; then
 printf "%dm %ds" "$m" "$s"
	else
 printf "%ds" "$s"
	fi
}

# Print summary table
set +x
echo ""
echo "==== Fuzz Summary ===="
HDR="%-40s %7s %7s %-15s %9s %-15s %9s\n"
FMT="%-40s %7s %7s %6s %-9s %9s %6s %-9s %9s\n"
printf "$HDR" "Target" "Iters" "Corpus" " Fuzzed" "Fuzz time" " Minimized" "Min. time"
printf "$HDR" "------" "-----" "------" "---------------" "---------" "---------------" "---------"
echo -e "$SUMMARY" | while IFS='|' read -r name iters orig fuzzed ftime minimized mtime; do
	[ -z "$name" ] && continue
	fuzz_delta=$((fuzzed - orig))
	if [ "$minimized" = "-" ]; then
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "-" "" "-"
	else
 min_delta=$((minimized - fuzzed))
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "$minimized" "($min_delta)" "$(fmt_time "$mtime")"
	fi
done
echo "======================"
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fuzz: improve CI iteration strategy, add corpus minimization and summary reporting#4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Mar 24, 2026
 Merged


fuzz: improve CI iteration strategy, add corpus minimization and summary reporting
#4497
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
b41fa33

ci: split fuzz sanity check into separate parallel job


joostjager Mar 20, 2026
24bbb4a

fuzz: improve iteration scaling, add minimization and summary table


joostjager Mar 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 18 additions & 6 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,6 +205,21 @@ jobs:
 - name: Simulate docs.rs build
 run: ci/check-docsrs.sh

 fuzz_sanity:
 runs-on: self-hosted
 env:
 TOOLCHAIN: 1.75
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --quiet --color always --lib --bins -j8

 fuzz:
 runs-on: self-hosted
 env:
Expand DownExpand Up@@ -238,13 +253,10 @@ jobs:
 key: fuzz-corpus-refs/heads/main-${{ github.sha }}
 restore-keys: |
 fuzz-corpus-refs/heads/main-
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --verbose --color always --lib --bins -j8
 cargo clean
 - name: Run fuzzers
 run: cd fuzz && ./ci-fuzz.sh && cd ..
 env:
 FUZZ_MINIMIZE: ${{ contains(github.event.pull_request.labels.*.name, 'fuzz-minimize') }}
@TheBlueMattTheBlueMattMar 20, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bother if we do this on main every time anyway?
@joostjagerjoostjagerMar 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it just for testing. Or maybe if a fuzz-affecting refactor PR is open for a long time and has accumulated a large corpus.
Can also remove the label trigger. Do you prefer that?
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just seems like something we'll never remember to do and isn't very useful, but it certainly also doesn't matter that much.
 - name: Upload honggfuzz corpus
 uses: actions/upload-artifact@v4
 with:
Expand DownExpand Up@@ -308,7 +320,7 @@ jobs:
 TOR_PROXY="127.0.0.1:9050" RUSTFLAGS="--cfg=tor" cargo test --verbose --color always -p lightning-net-tokio

 notify-failure:
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz_sanity, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 if: failure() && github.ref == 'refs/heads/main'
 runs-on: ubuntu-latest
 permissions:
Expand Down

76 changes: 69 additions & 7 deletions
fuzz/ci-fuzz.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,20 +30,82 @@ sed -i 's/lto = true//' Cargo.toml
export HFUZZ_BUILD_ARGS="--features honggfuzz_fuzz"

cargo --color always hfuzz build -j8

SUMMARY=""

check_crash() {
	local FILE=$1
	if [ -f "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT" ]; then
 cat "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT"
 for CASE in "hfuzz_workspace/$FILE"/SIG*; do
 cat "$CASE" | xxd -p
 done
 exit 1
	fi
}

for TARGET in src/bin/*.rs; do
	FILENAME=$(basename $TARGET)
	FILE="${FILENAME%.*}"
	HFUZZ_RUN_ARGS="--exit_upon_crash -v -n8 --run_time 30"
	CORPUS_DIR="hfuzz_workspace/$FILE/input"
	CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	# Run 8x the corpus size plus a baseline, ensuring full corpus replay
	# with room for new mutations. The 10-minute hard cap (--run_time 600)
	# prevents slow-per-iteration targets from running too long.
	ITERATIONS=$((CORPUS_COUNT * 8 + 1000))
	HFUZZ_RUN_ARGS="--exit_upon_crash -q -n8 -t 3 -N $ITERATIONS --run_time 600"
	if [ "$FILE" = "chanmon_consistency_target" -o "$FILE" = "fs_store_target" ]; then
 HFUZZ_RUN_ARGS="$HFUZZ_RUN_ARGS -F 64"
	fi
	export HFUZZ_RUN_ARGS
	FUZZ_START=$(date +%s)
	cargo --color always hfuzz run $FILE
	if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ]; then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
 for CASE in hfuzz_workspace/$FILE/SIG*; do
 cat $CASE | xxd -p
 done
 exit 1
	FUZZ_END=$(date +%s)
	FUZZ_TIME=$((FUZZ_END - FUZZ_START))
	FUZZ_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	check_crash "$FILE"
	if [ "$GITHUB_REF" = "refs/heads/main" ] || [ "$FUZZ_MINIMIZE" = "true" ]; then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
 export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)

Comment on lines

+67
 to 
+74

@ldk-claude-review-botldk-claude-review-botMar 21, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crash check (lines 55-61) runs only after the fuzz step, but not after the minimization step here. Minimization still executes every corpus input through the target binary. If a crash occurs during minimization (e.g., a newly-mutated input from the fuzz step that was added to the corpus but didn't crash during fuzzing due to timing, or a non-deterministic crash), the HONGGFUZZ.REPORT.TXT would be written but never checked.
Consider adding a crash check after the minimization run as well:

Suggested change

if [ "$GITHUB_REF"="refs/heads/main" ] || [ "$FUZZ_MINIMIZE"="true" ];then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ];then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
forCASEin hfuzz_workspace/$FILE/SIG*;do
 cat $CASE| xxd -p
done
exit 1
fi
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, probably worth doing this.
@joostjagerjoostjagerMar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
 check_crash "$FILE"
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|${MIN_CORPUS_COUNT}|${MIN_TIME}\n"
	else
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|-|-\n"
	fi
done

fmt_time() {
	local secs=$1
	local m=$((secs / 60))
	local s=$((secs % 60))
	if [ "$m" -gt 0 ]; then
 printf "%dm %ds" "$m" "$s"
	else
 printf "%ds" "$s"
	fi
}

# Print summary table
set +x
echo ""
echo "==== Fuzz Summary ===="
HDR="%-40s %7s %7s %-15s %9s %-15s %9s\n"
FMT="%-40s %7s %7s %6s %-9s %9s %6s %-9s %9s\n"
printf "$HDR" "Target" "Iters" "Corpus" " Fuzzed" "Fuzz time" " Minimized" "Min. time"
printf "$HDR" "------" "-----" "------" "---------------" "---------" "---------------" "---------"
echo -e "$SUMMARY" | while IFS='|' read -r name iters orig fuzzed ftime minimized mtime; do
	[ -z "$name" ] && continue
	fuzz_delta=$((fuzzed - orig))
	if [ "$minimized" = "-" ]; then
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "-" "" "-"
	else
 min_delta=$((minimized - fuzzed))
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "$minimized" "($min_delta)" "$(fmt_time "$mtime")"
	fi
done
echo "======================"
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fuzz: improve CI iteration strategy, add corpus minimization and summary reporting#4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Mar 24, 2026
 Merged


fuzz: improve CI iteration strategy, add corpus minimization and summary reporting
#4497
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
b41fa33

ci: split fuzz sanity check into separate parallel job


joostjager Mar 20, 2026
24bbb4a

fuzz: improve iteration scaling, add minimization and summary table


joostjager Mar 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 18 additions & 6 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,6 +205,21 @@ jobs:
 - name: Simulate docs.rs build
 run: ci/check-docsrs.sh

 fuzz_sanity:
 runs-on: self-hosted
 env:
 TOOLCHAIN: 1.75
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --quiet --color always --lib --bins -j8

 fuzz:
 runs-on: self-hosted
 env:
Expand DownExpand Up@@ -238,13 +253,10 @@ jobs:
 key: fuzz-corpus-refs/heads/main-${{ github.sha }}
 restore-keys: |
 fuzz-corpus-refs/heads/main-
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --verbose --color always --lib --bins -j8
 cargo clean
 - name: Run fuzzers
 run: cd fuzz && ./ci-fuzz.sh && cd ..
 env:
 FUZZ_MINIMIZE: ${{ contains(github.event.pull_request.labels.*.name, 'fuzz-minimize') }}
@TheBlueMattTheBlueMattMar 20, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bother if we do this on main every time anyway?
@joostjagerjoostjagerMar 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it just for testing. Or maybe if a fuzz-affecting refactor PR is open for a long time and has accumulated a large corpus.
Can also remove the label trigger. Do you prefer that?
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just seems like something we'll never remember to do and isn't very useful, but it certainly also doesn't matter that much.
 - name: Upload honggfuzz corpus
 uses: actions/upload-artifact@v4
 with:
Expand DownExpand Up@@ -308,7 +320,7 @@ jobs:
 TOR_PROXY="127.0.0.1:9050" RUSTFLAGS="--cfg=tor" cargo test --verbose --color always -p lightning-net-tokio

 notify-failure:
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz_sanity, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 if: failure() && github.ref == 'refs/heads/main'
 runs-on: ubuntu-latest
 permissions:
Expand Down

76 changes: 69 additions & 7 deletions
fuzz/ci-fuzz.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,20 +30,82 @@ sed -i 's/lto = true//' Cargo.toml
export HFUZZ_BUILD_ARGS="--features honggfuzz_fuzz"

cargo --color always hfuzz build -j8

SUMMARY=""

check_crash() {
	local FILE=$1
	if [ -f "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT" ]; then
 cat "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT"
 for CASE in "hfuzz_workspace/$FILE"/SIG*; do
 cat "$CASE" | xxd -p
 done
 exit 1
	fi
}

for TARGET in src/bin/*.rs; do
	FILENAME=$(basename $TARGET)
	FILE="${FILENAME%.*}"
	HFUZZ_RUN_ARGS="--exit_upon_crash -v -n8 --run_time 30"
	CORPUS_DIR="hfuzz_workspace/$FILE/input"
	CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	# Run 8x the corpus size plus a baseline, ensuring full corpus replay
	# with room for new mutations. The 10-minute hard cap (--run_time 600)
	# prevents slow-per-iteration targets from running too long.
	ITERATIONS=$((CORPUS_COUNT * 8 + 1000))
	HFUZZ_RUN_ARGS="--exit_upon_crash -q -n8 -t 3 -N $ITERATIONS --run_time 600"
	if [ "$FILE" = "chanmon_consistency_target" -o "$FILE" = "fs_store_target" ]; then
 HFUZZ_RUN_ARGS="$HFUZZ_RUN_ARGS -F 64"
	fi
	export HFUZZ_RUN_ARGS
	FUZZ_START=$(date +%s)
	cargo --color always hfuzz run $FILE
	if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ]; then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
 for CASE in hfuzz_workspace/$FILE/SIG*; do
 cat $CASE | xxd -p
 done
 exit 1
	FUZZ_END=$(date +%s)
	FUZZ_TIME=$((FUZZ_END - FUZZ_START))
	FUZZ_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	check_crash "$FILE"
	if [ "$GITHUB_REF" = "refs/heads/main" ] || [ "$FUZZ_MINIMIZE" = "true" ]; then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
 export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)

Comment on lines

+67
 to 
+74

@ldk-claude-review-botldk-claude-review-botMar 21, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crash check (lines 55-61) runs only after the fuzz step, but not after the minimization step here. Minimization still executes every corpus input through the target binary. If a crash occurs during minimization (e.g., a newly-mutated input from the fuzz step that was added to the corpus but didn't crash during fuzzing due to timing, or a non-deterministic crash), the HONGGFUZZ.REPORT.TXT would be written but never checked.
Consider adding a crash check after the minimization run as well:

Suggested change

if [ "$GITHUB_REF"="refs/heads/main" ] || [ "$FUZZ_MINIMIZE"="true" ];then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ];then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
forCASEin hfuzz_workspace/$FILE/SIG*;do
 cat $CASE| xxd -p
done
exit 1
fi
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, probably worth doing this.
@joostjagerjoostjagerMar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
 check_crash "$FILE"
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|${MIN_CORPUS_COUNT}|${MIN_TIME}\n"
	else
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|-|-\n"
	fi
done

fmt_time() {
	local secs=$1
	local m=$((secs / 60))
	local s=$((secs % 60))
	if [ "$m" -gt 0 ]; then
 printf "%dm %ds" "$m" "$s"
	else
 printf "%ds" "$s"
	fi
}

# Print summary table
set +x
echo ""
echo "==== Fuzz Summary ===="
HDR="%-40s %7s %7s %-15s %9s %-15s %9s\n"
FMT="%-40s %7s %7s %6s %-9s %9s %6s %-9s %9s\n"
printf "$HDR" "Target" "Iters" "Corpus" " Fuzzed" "Fuzz time" " Minimized" "Min. time"
printf "$HDR" "------" "-----" "------" "---------------" "---------" "---------------" "---------"
echo -e "$SUMMARY" | while IFS='|' read -r name iters orig fuzzed ftime minimized mtime; do
	[ -z "$name" ] && continue
	fuzz_delta=$((fuzzed - orig))
	if [ "$minimized" = "-" ]; then
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "-" "" "-"
	else
 min_delta=$((minimized - fuzzed))
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "$minimized" "($min_delta)" "$(fmt_time "$mtime")"
	fi
done
echo "======================"
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fuzz: improve CI iteration strategy, add corpus minimization and summary reporting#4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Mar 24, 2026
 Merged


fuzz: improve CI iteration strategy, add corpus minimization and summary reporting
#4497
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
b41fa33

ci: split fuzz sanity check into separate parallel job


joostjager Mar 20, 2026
24bbb4a

fuzz: improve iteration scaling, add minimization and summary table


joostjager Mar 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 18 additions & 6 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,6 +205,21 @@ jobs:
 - name: Simulate docs.rs build
 run: ci/check-docsrs.sh

 fuzz_sanity:
 runs-on: self-hosted
 env:
 TOOLCHAIN: 1.75
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --quiet --color always --lib --bins -j8

 fuzz:
 runs-on: self-hosted
 env:
Expand DownExpand Up@@ -238,13 +253,10 @@ jobs:
 key: fuzz-corpus-refs/heads/main-${{ github.sha }}
 restore-keys: |
 fuzz-corpus-refs/heads/main-
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --verbose --color always --lib --bins -j8
 cargo clean
 - name: Run fuzzers
 run: cd fuzz && ./ci-fuzz.sh && cd ..
 env:
 FUZZ_MINIMIZE: ${{ contains(github.event.pull_request.labels.*.name, 'fuzz-minimize') }}
@TheBlueMattTheBlueMattMar 20, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bother if we do this on main every time anyway?
@joostjagerjoostjagerMar 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it just for testing. Or maybe if a fuzz-affecting refactor PR is open for a long time and has accumulated a large corpus.
Can also remove the label trigger. Do you prefer that?
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just seems like something we'll never remember to do and isn't very useful, but it certainly also doesn't matter that much.
 - name: Upload honggfuzz corpus
 uses: actions/upload-artifact@v4
 with:
Expand DownExpand Up@@ -308,7 +320,7 @@ jobs:
 TOR_PROXY="127.0.0.1:9050" RUSTFLAGS="--cfg=tor" cargo test --verbose --color always -p lightning-net-tokio

 notify-failure:
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz_sanity, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 if: failure() && github.ref == 'refs/heads/main'
 runs-on: ubuntu-latest
 permissions:
Expand Down

76 changes: 69 additions & 7 deletions
fuzz/ci-fuzz.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,20 +30,82 @@ sed -i 's/lto = true//' Cargo.toml
export HFUZZ_BUILD_ARGS="--features honggfuzz_fuzz"

cargo --color always hfuzz build -j8

SUMMARY=""

check_crash() {
	local FILE=$1
	if [ -f "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT" ]; then
 cat "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT"
 for CASE in "hfuzz_workspace/$FILE"/SIG*; do
 cat "$CASE" | xxd -p
 done
 exit 1
	fi
}

for TARGET in src/bin/*.rs; do
	FILENAME=$(basename $TARGET)
	FILE="${FILENAME%.*}"
	HFUZZ_RUN_ARGS="--exit_upon_crash -v -n8 --run_time 30"
	CORPUS_DIR="hfuzz_workspace/$FILE/input"
	CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	# Run 8x the corpus size plus a baseline, ensuring full corpus replay
	# with room for new mutations. The 10-minute hard cap (--run_time 600)
	# prevents slow-per-iteration targets from running too long.
	ITERATIONS=$((CORPUS_COUNT * 8 + 1000))
	HFUZZ_RUN_ARGS="--exit_upon_crash -q -n8 -t 3 -N $ITERATIONS --run_time 600"
	if [ "$FILE" = "chanmon_consistency_target" -o "$FILE" = "fs_store_target" ]; then
 HFUZZ_RUN_ARGS="$HFUZZ_RUN_ARGS -F 64"
	fi
	export HFUZZ_RUN_ARGS
	FUZZ_START=$(date +%s)
	cargo --color always hfuzz run $FILE
	if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ]; then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
 for CASE in hfuzz_workspace/$FILE/SIG*; do
 cat $CASE | xxd -p
 done
 exit 1
	FUZZ_END=$(date +%s)
	FUZZ_TIME=$((FUZZ_END - FUZZ_START))
	FUZZ_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	check_crash "$FILE"
	if [ "$GITHUB_REF" = "refs/heads/main" ] || [ "$FUZZ_MINIMIZE" = "true" ]; then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
 export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)

Comment on lines

+67
 to 
+74

@ldk-claude-review-botldk-claude-review-botMar 21, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crash check (lines 55-61) runs only after the fuzz step, but not after the minimization step here. Minimization still executes every corpus input through the target binary. If a crash occurs during minimization (e.g., a newly-mutated input from the fuzz step that was added to the corpus but didn't crash during fuzzing due to timing, or a non-deterministic crash), the HONGGFUZZ.REPORT.TXT would be written but never checked.
Consider adding a crash check after the minimization run as well:

Suggested change

if [ "$GITHUB_REF"="refs/heads/main" ] || [ "$FUZZ_MINIMIZE"="true" ];then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ];then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
forCASEin hfuzz_workspace/$FILE/SIG*;do
 cat $CASE| xxd -p
done
exit 1
fi
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, probably worth doing this.
@joostjagerjoostjagerMar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
 check_crash "$FILE"
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|${MIN_CORPUS_COUNT}|${MIN_TIME}\n"
	else
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|-|-\n"
	fi
done

fmt_time() {
	local secs=$1
	local m=$((secs / 60))
	local s=$((secs % 60))
	if [ "$m" -gt 0 ]; then
 printf "%dm %ds" "$m" "$s"
	else
 printf "%ds" "$s"
	fi
}

# Print summary table
set +x
echo ""
echo "==== Fuzz Summary ===="
HDR="%-40s %7s %7s %-15s %9s %-15s %9s\n"
FMT="%-40s %7s %7s %6s %-9s %9s %6s %-9s %9s\n"
printf "$HDR" "Target" "Iters" "Corpus" " Fuzzed" "Fuzz time" " Minimized" "Min. time"
printf "$HDR" "------" "-----" "------" "---------------" "---------" "---------------" "---------"
echo -e "$SUMMARY" | while IFS='|' read -r name iters orig fuzzed ftime minimized mtime; do
	[ -z "$name" ] && continue
	fuzz_delta=$((fuzzed - orig))
	if [ "$minimized" = "-" ]; then
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "-" "" "-"
	else
 min_delta=$((minimized - fuzzed))
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "$minimized" "($min_delta)" "$(fmt_time "$mtime")"
	fi
done
echo "======================"
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fuzz: improve CI iteration strategy, add corpus minimization and summary reporting#4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Mar 24, 2026
 Merged


fuzz: improve CI iteration strategy, add corpus minimization and summary reporting
#4497
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
b41fa33

ci: split fuzz sanity check into separate parallel job


joostjager Mar 20, 2026
24bbb4a

fuzz: improve iteration scaling, add minimization and summary table


joostjager Mar 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 18 additions & 6 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,6 +205,21 @@ jobs:
 - name: Simulate docs.rs build
 run: ci/check-docsrs.sh

 fuzz_sanity:
 runs-on: self-hosted
 env:
 TOOLCHAIN: 1.75
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --quiet --color always --lib --bins -j8

 fuzz:
 runs-on: self-hosted
 env:
Expand DownExpand Up@@ -238,13 +253,10 @@ jobs:
 key: fuzz-corpus-refs/heads/main-${{ github.sha }}
 restore-keys: |
 fuzz-corpus-refs/heads/main-
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --verbose --color always --lib --bins -j8
 cargo clean
 - name: Run fuzzers
 run: cd fuzz && ./ci-fuzz.sh && cd ..
 env:
 FUZZ_MINIMIZE: ${{ contains(github.event.pull_request.labels.*.name, 'fuzz-minimize') }}
@TheBlueMattTheBlueMattMar 20, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bother if we do this on main every time anyway?
@joostjagerjoostjagerMar 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it just for testing. Or maybe if a fuzz-affecting refactor PR is open for a long time and has accumulated a large corpus.
Can also remove the label trigger. Do you prefer that?
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just seems like something we'll never remember to do and isn't very useful, but it certainly also doesn't matter that much.
 - name: Upload honggfuzz corpus
 uses: actions/upload-artifact@v4
 with:
Expand DownExpand Up@@ -308,7 +320,7 @@ jobs:
 TOR_PROXY="127.0.0.1:9050" RUSTFLAGS="--cfg=tor" cargo test --verbose --color always -p lightning-net-tokio

 notify-failure:
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz_sanity, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 if: failure() && github.ref == 'refs/heads/main'
 runs-on: ubuntu-latest
 permissions:
Expand Down

76 changes: 69 additions & 7 deletions
fuzz/ci-fuzz.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,20 +30,82 @@ sed -i 's/lto = true//' Cargo.toml
export HFUZZ_BUILD_ARGS="--features honggfuzz_fuzz"

cargo --color always hfuzz build -j8

SUMMARY=""

check_crash() {
	local FILE=$1
	if [ -f "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT" ]; then
 cat "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT"
 for CASE in "hfuzz_workspace/$FILE"/SIG*; do
 cat "$CASE" | xxd -p
 done
 exit 1
	fi
}

for TARGET in src/bin/*.rs; do
	FILENAME=$(basename $TARGET)
	FILE="${FILENAME%.*}"
	HFUZZ_RUN_ARGS="--exit_upon_crash -v -n8 --run_time 30"
	CORPUS_DIR="hfuzz_workspace/$FILE/input"
	CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	# Run 8x the corpus size plus a baseline, ensuring full corpus replay
	# with room for new mutations. The 10-minute hard cap (--run_time 600)
	# prevents slow-per-iteration targets from running too long.
	ITERATIONS=$((CORPUS_COUNT * 8 + 1000))
	HFUZZ_RUN_ARGS="--exit_upon_crash -q -n8 -t 3 -N $ITERATIONS --run_time 600"
	if [ "$FILE" = "chanmon_consistency_target" -o "$FILE" = "fs_store_target" ]; then
 HFUZZ_RUN_ARGS="$HFUZZ_RUN_ARGS -F 64"
	fi
	export HFUZZ_RUN_ARGS
	FUZZ_START=$(date +%s)
	cargo --color always hfuzz run $FILE
	if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ]; then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
 for CASE in hfuzz_workspace/$FILE/SIG*; do
 cat $CASE | xxd -p
 done
 exit 1
	FUZZ_END=$(date +%s)
	FUZZ_TIME=$((FUZZ_END - FUZZ_START))
	FUZZ_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	check_crash "$FILE"
	if [ "$GITHUB_REF" = "refs/heads/main" ] || [ "$FUZZ_MINIMIZE" = "true" ]; then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
 export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)

Comment on lines

+67
 to 
+74

@ldk-claude-review-botldk-claude-review-botMar 21, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crash check (lines 55-61) runs only after the fuzz step, but not after the minimization step here. Minimization still executes every corpus input through the target binary. If a crash occurs during minimization (e.g., a newly-mutated input from the fuzz step that was added to the corpus but didn't crash during fuzzing due to timing, or a non-deterministic crash), the HONGGFUZZ.REPORT.TXT would be written but never checked.
Consider adding a crash check after the minimization run as well:

Suggested change

if [ "$GITHUB_REF"="refs/heads/main" ] || [ "$FUZZ_MINIMIZE"="true" ];then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ];then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
forCASEin hfuzz_workspace/$FILE/SIG*;do
 cat $CASE| xxd -p
done
exit 1
fi
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, probably worth doing this.
@joostjagerjoostjagerMar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
 check_crash "$FILE"
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|${MIN_CORPUS_COUNT}|${MIN_TIME}\n"
	else
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|-|-\n"
	fi
done

fmt_time() {
	local secs=$1
	local m=$((secs / 60))
	local s=$((secs % 60))
	if [ "$m" -gt 0 ]; then
 printf "%dm %ds" "$m" "$s"
	else
 printf "%ds" "$s"
	fi
}

# Print summary table
set +x
echo ""
echo "==== Fuzz Summary ===="
HDR="%-40s %7s %7s %-15s %9s %-15s %9s\n"
FMT="%-40s %7s %7s %6s %-9s %9s %6s %-9s %9s\n"
printf "$HDR" "Target" "Iters" "Corpus" " Fuzzed" "Fuzz time" " Minimized" "Min. time"
printf "$HDR" "------" "-----" "------" "---------------" "---------" "---------------" "---------"
echo -e "$SUMMARY" | while IFS='|' read -r name iters orig fuzzed ftime minimized mtime; do
	[ -z "$name" ] && continue
	fuzz_delta=$((fuzzed - orig))
	if [ "$minimized" = "-" ]; then
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "-" "" "-"
	else
 min_delta=$((minimized - fuzzed))
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "$minimized" "($min_delta)" "$(fmt_time "$mtime")"
	fi
done
echo "======================"
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fuzz: improve CI iteration strategy, add corpus minimization and summary reporting#4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Mar 24, 2026
 Merged


fuzz: improve CI iteration strategy, add corpus minimization and summary reporting
#4497
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
b41fa33

ci: split fuzz sanity check into separate parallel job


joostjager Mar 20, 2026
24bbb4a

fuzz: improve iteration scaling, add minimization and summary table


joostjager Mar 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 18 additions & 6 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,6 +205,21 @@ jobs:
 - name: Simulate docs.rs build
 run: ci/check-docsrs.sh

 fuzz_sanity:
 runs-on: self-hosted
 env:
 TOOLCHAIN: 1.75
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --quiet --color always --lib --bins -j8

 fuzz:
 runs-on: self-hosted
 env:
Expand DownExpand Up@@ -238,13 +253,10 @@ jobs:
 key: fuzz-corpus-refs/heads/main-${{ github.sha }}
 restore-keys: |
 fuzz-corpus-refs/heads/main-
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --verbose --color always --lib --bins -j8
 cargo clean
 - name: Run fuzzers
 run: cd fuzz && ./ci-fuzz.sh && cd ..
 env:
 FUZZ_MINIMIZE: ${{ contains(github.event.pull_request.labels.*.name, 'fuzz-minimize') }}
@TheBlueMattTheBlueMattMar 20, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bother if we do this on main every time anyway?
@joostjagerjoostjagerMar 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it just for testing. Or maybe if a fuzz-affecting refactor PR is open for a long time and has accumulated a large corpus.
Can also remove the label trigger. Do you prefer that?
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just seems like something we'll never remember to do and isn't very useful, but it certainly also doesn't matter that much.
 - name: Upload honggfuzz corpus
 uses: actions/upload-artifact@v4
 with:
Expand DownExpand Up@@ -308,7 +320,7 @@ jobs:
 TOR_PROXY="127.0.0.1:9050" RUSTFLAGS="--cfg=tor" cargo test --verbose --color always -p lightning-net-tokio

 notify-failure:
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz_sanity, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 if: failure() && github.ref == 'refs/heads/main'
 runs-on: ubuntu-latest
 permissions:
Expand Down

76 changes: 69 additions & 7 deletions
fuzz/ci-fuzz.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,20 +30,82 @@ sed -i 's/lto = true//' Cargo.toml
export HFUZZ_BUILD_ARGS="--features honggfuzz_fuzz"

cargo --color always hfuzz build -j8

SUMMARY=""

check_crash() {
	local FILE=$1
	if [ -f "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT" ]; then
 cat "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT"
 for CASE in "hfuzz_workspace/$FILE"/SIG*; do
 cat "$CASE" | xxd -p
 done
 exit 1
	fi
}

for TARGET in src/bin/*.rs; do
	FILENAME=$(basename $TARGET)
	FILE="${FILENAME%.*}"
	HFUZZ_RUN_ARGS="--exit_upon_crash -v -n8 --run_time 30"
	CORPUS_DIR="hfuzz_workspace/$FILE/input"
	CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	# Run 8x the corpus size plus a baseline, ensuring full corpus replay
	# with room for new mutations. The 10-minute hard cap (--run_time 600)
	# prevents slow-per-iteration targets from running too long.
	ITERATIONS=$((CORPUS_COUNT * 8 + 1000))
	HFUZZ_RUN_ARGS="--exit_upon_crash -q -n8 -t 3 -N $ITERATIONS --run_time 600"
	if [ "$FILE" = "chanmon_consistency_target" -o "$FILE" = "fs_store_target" ]; then
 HFUZZ_RUN_ARGS="$HFUZZ_RUN_ARGS -F 64"
	fi
	export HFUZZ_RUN_ARGS
	FUZZ_START=$(date +%s)
	cargo --color always hfuzz run $FILE
	if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ]; then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
 for CASE in hfuzz_workspace/$FILE/SIG*; do
 cat $CASE | xxd -p
 done
 exit 1
	FUZZ_END=$(date +%s)
	FUZZ_TIME=$((FUZZ_END - FUZZ_START))
	FUZZ_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	check_crash "$FILE"
	if [ "$GITHUB_REF" = "refs/heads/main" ] || [ "$FUZZ_MINIMIZE" = "true" ]; then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
 export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)

Comment on lines

+67
 to 
+74

@ldk-claude-review-botldk-claude-review-botMar 21, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crash check (lines 55-61) runs only after the fuzz step, but not after the minimization step here. Minimization still executes every corpus input through the target binary. If a crash occurs during minimization (e.g., a newly-mutated input from the fuzz step that was added to the corpus but didn't crash during fuzzing due to timing, or a non-deterministic crash), the HONGGFUZZ.REPORT.TXT would be written but never checked.
Consider adding a crash check after the minimization run as well:

Suggested change

if [ "$GITHUB_REF"="refs/heads/main" ] || [ "$FUZZ_MINIMIZE"="true" ];then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ];then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
forCASEin hfuzz_workspace/$FILE/SIG*;do
 cat $CASE| xxd -p
done
exit 1
fi
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, probably worth doing this.
@joostjagerjoostjagerMar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
 check_crash "$FILE"
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|${MIN_CORPUS_COUNT}|${MIN_TIME}\n"
	else
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|-|-\n"
	fi
done

fmt_time() {
	local secs=$1
	local m=$((secs / 60))
	local s=$((secs % 60))
	if [ "$m" -gt 0 ]; then
 printf "%dm %ds" "$m" "$s"
	else
 printf "%ds" "$s"
	fi
}

# Print summary table
set +x
echo ""
echo "==== Fuzz Summary ===="
HDR="%-40s %7s %7s %-15s %9s %-15s %9s\n"
FMT="%-40s %7s %7s %6s %-9s %9s %6s %-9s %9s\n"
printf "$HDR" "Target" "Iters" "Corpus" " Fuzzed" "Fuzz time" " Minimized" "Min. time"
printf "$HDR" "------" "-----" "------" "---------------" "---------" "---------------" "---------"
echo -e "$SUMMARY" | while IFS='|' read -r name iters orig fuzzed ftime minimized mtime; do
	[ -z "$name" ] && continue
	fuzz_delta=$((fuzzed - orig))
	if [ "$minimized" = "-" ]; then
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "-" "" "-"
	else
 min_delta=$((minimized - fuzzed))
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "$minimized" "($min_delta)" "$(fmt_time "$mtime")"
	fi
done
echo "======================"
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fuzz: improve CI iteration strategy, add corpus minimization and summary reporting#4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Mar 24, 2026
 Merged


fuzz: improve CI iteration strategy, add corpus minimization and summary reporting
#4497
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
b41fa33

ci: split fuzz sanity check into separate parallel job


joostjager Mar 20, 2026
24bbb4a

fuzz: improve iteration scaling, add minimization and summary table


joostjager Mar 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 18 additions & 6 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,6 +205,21 @@ jobs:
 - name: Simulate docs.rs build
 run: ci/check-docsrs.sh

 fuzz_sanity:
 runs-on: self-hosted
 env:
 TOOLCHAIN: 1.75
 steps:
 - name: Checkout source code
 uses: actions/checkout@v4
 - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
 run: |
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --quiet --color always --lib --bins -j8

 fuzz:
 runs-on: self-hosted
 env:
Expand DownExpand Up@@ -238,13 +253,10 @@ jobs:
 key: fuzz-corpus-refs/heads/main-${{ github.sha }}
 restore-keys: |
 fuzz-corpus-refs/heads/main-
 - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
 run: |
 cd fuzz
 cargo test --verbose --color always --lib --bins -j8
 cargo clean
 - name: Run fuzzers
 run: cd fuzz && ./ci-fuzz.sh && cd ..
 env:
 FUZZ_MINIMIZE: ${{ contains(github.event.pull_request.labels.*.name, 'fuzz-minimize') }}
@TheBlueMattTheBlueMattMar 20, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bother if we do this on main every time anyway?
@joostjagerjoostjagerMar 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it just for testing. Or maybe if a fuzz-affecting refactor PR is open for a long time and has accumulated a large corpus.
Can also remove the label trigger. Do you prefer that?
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just seems like something we'll never remember to do and isn't very useful, but it certainly also doesn't matter that much.
 - name: Upload honggfuzz corpus
 uses: actions/upload-artifact@v4
 with:
Expand DownExpand Up@@ -308,7 +320,7 @@ jobs:
 TOR_PROXY="127.0.0.1:9050" RUSTFLAGS="--cfg=tor" cargo test --verbose --color always -p lightning-net-tokio

 notify-failure:
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 needs: [build-workspace, build-features, build-bindings, build-nostd, build-cfg-flags, build-sync, fuzz_sanity, fuzz, linting, rustfmt, check_release, check_docs, benchmark, ext-test, tor-connect, coverage]
 if: failure() && github.ref == 'refs/heads/main'
 runs-on: ubuntu-latest
 permissions:
Expand Down

76 changes: 69 additions & 7 deletions
fuzz/ci-fuzz.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,20 +30,82 @@ sed -i 's/lto = true//' Cargo.toml
export HFUZZ_BUILD_ARGS="--features honggfuzz_fuzz"

cargo --color always hfuzz build -j8

SUMMARY=""

check_crash() {
	local FILE=$1
	if [ -f "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT" ]; then
 cat "hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT"
 for CASE in "hfuzz_workspace/$FILE"/SIG*; do
 cat "$CASE" | xxd -p
 done
 exit 1
	fi
}

for TARGET in src/bin/*.rs; do
	FILENAME=$(basename $TARGET)
	FILE="${FILENAME%.*}"
	HFUZZ_RUN_ARGS="--exit_upon_crash -v -n8 --run_time 30"
	CORPUS_DIR="hfuzz_workspace/$FILE/input"
	CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	# Run 8x the corpus size plus a baseline, ensuring full corpus replay
	# with room for new mutations. The 10-minute hard cap (--run_time 600)
	# prevents slow-per-iteration targets from running too long.
	ITERATIONS=$((CORPUS_COUNT * 8 + 1000))
	HFUZZ_RUN_ARGS="--exit_upon_crash -q -n8 -t 3 -N $ITERATIONS --run_time 600"
	if [ "$FILE" = "chanmon_consistency_target" -o "$FILE" = "fs_store_target" ]; then
 HFUZZ_RUN_ARGS="$HFUZZ_RUN_ARGS -F 64"
	fi
	export HFUZZ_RUN_ARGS
	FUZZ_START=$(date +%s)
	cargo --color always hfuzz run $FILE
	if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ]; then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
 for CASE in hfuzz_workspace/$FILE/SIG*; do
 cat $CASE | xxd -p
 done
 exit 1
	FUZZ_END=$(date +%s)
	FUZZ_TIME=$((FUZZ_END - FUZZ_START))
	FUZZ_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
	check_crash "$FILE"
	if [ "$GITHUB_REF" = "refs/heads/main" ] || [ "$FUZZ_MINIMIZE" = "true" ]; then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
 export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)

Comment on lines

+67
 to 
+74

@ldk-claude-review-botldk-claude-review-botMar 21, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crash check (lines 55-61) runs only after the fuzz step, but not after the minimization step here. Minimization still executes every corpus input through the target binary. If a crash occurs during minimization (e.g., a newly-mutated input from the fuzz step that was added to the corpus but didn't crash during fuzzing due to timing, or a non-deterministic crash), the HONGGFUZZ.REPORT.TXT would be written but never checked.
Consider adding a crash check after the minimization run as well:

Suggested change

if [ "$GITHUB_REF"="refs/heads/main" ] || [ "$FUZZ_MINIMIZE"="true" ];then
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
 HFUZZ_RUN_ARGS="-M -q -n8 -t 3"
export HFUZZ_RUN_ARGS
 MIN_START=$(date +%s)
 cargo --color always hfuzz run $FILE
 MIN_END=$(date +%s)
 MIN_TIME=$((MIN_END - MIN_START))
 MIN_CORPUS_COUNT=$(find "$CORPUS_DIR" -type f 2>/dev/null | wc -l)
if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ];then
 cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT
forCASEin hfuzz_workspace/$FILE/SIG*;do
 cat $CASE| xxd -p
done
exit 1
fi
@TheBlueMattTheBlueMattMar 23, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, probably worth doing this.
@joostjagerjoostjagerMar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
 check_crash "$FILE"
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|${MIN_CORPUS_COUNT}|${MIN_TIME}\n"
	else
 SUMMARY="${SUMMARY}${FILE}|${ITERATIONS}|${CORPUS_COUNT}|${FUZZ_CORPUS_COUNT}|${FUZZ_TIME}|-|-\n"
	fi
done

fmt_time() {
	local secs=$1
	local m=$((secs / 60))
	local s=$((secs % 60))
	if [ "$m" -gt 0 ]; then
 printf "%dm %ds" "$m" "$s"
	else
 printf "%ds" "$s"
	fi
}

# Print summary table
set +x
echo ""
echo "==== Fuzz Summary ===="
HDR="%-40s %7s %7s %-15s %9s %-15s %9s\n"
FMT="%-40s %7s %7s %6s %-9s %9s %6s %-9s %9s\n"
printf "$HDR" "Target" "Iters" "Corpus" " Fuzzed" "Fuzz time" " Minimized" "Min. time"
printf "$HDR" "------" "-----" "------" "---------------" "---------" "---------------" "---------"
echo -e "$SUMMARY" | while IFS='|' read -r name iters orig fuzzed ftime minimized mtime; do
	[ -z "$name" ] && continue
	fuzz_delta=$((fuzzed - orig))
	if [ "$minimized" = "-" ]; then
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "-" "" "-"
	else
 min_delta=$((minimized - fuzzed))
 printf "$FMT" "$name" "$iters" "$orig" "$fuzzed" "(+$fuzz_delta)" "$(fmt_time "$ftime")" "$minimized" "($min_delta)" "$(fmt_time "$mtime")"
	fi
done
echo "======================"
Loading