Skip to content

Channelmanager: improve block connection logging#4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alkamal01 wants to merge 2 commits into
base:main
Choose a base branch
from
+10 −1
Open

Channelmanager: improve block connection logging #4586

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdfef44
channelmanager: improve block connection logging
Alkamal01 May 2, 2026
985a82b
Address review feedback: defer double-SHA256 computations in debug lo…
Alkamal01 May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lightning/src/ln/channelmanager.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15968,6 +15968,15 @@ impl<

let block_hash = header.block_hash();
log_trace!(self.logger, "{} transactions included in block {} at height {} provided", txdata.len(), block_hash, height);
struct LazyTxid<'a>(&'a Transaction);
impl<'a> core::fmt::Display for LazyTxid<'a> {
fn fmt(&self, f: &mut core::fmt::Formatter) -> core::fmt::Result {
write!(f, "{}", self.0.compute_txid())
}
}
for (_, tx) in txdata.iter() {
log_debug!(self.logger, "Confirmed transaction {} in block {} at height {}", LazyTxid(tx), block_hash, height);
}
Comment on lines +15977 to +15979

@ldk-claude-review-botldk-claude-review-botMay 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compute_txid() performs a double-SHA256 over the serialized transaction, and the log_given_level! macro evaluates its arguments unconditionally (the level check is inside the Logger::log implementation, not before argument evaluation). This means the loop runs and hashes every transaction even when the logger's level is above DEBUG.

Consider either:

  1. Guarding the loop behind a level check, or
  2. Folding these per-txid details into the existing TRACE log, or
  3. Using a lazy wrapper (e.g., a Display impl that computes on fmt) — though this still wouldn't avoid the loop itself.

While txdata only contains matching transactions (not the full block), computing txids unconditionally on every block connection is unnecessary overhead for users who don't have DEBUG enabled.


let _persistence_guard =
PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand DownExpand Up@@ -15999,7 +16008,7 @@ impl<
// See the docs for `ChannelManagerReadArgs` for more.

let block_hash = header.block_hash();
log_trace!(self.logger, "New best block: {} at height {}", block_hash, height);
log_info!(self.logger, "New best block: {} at height {}", block_hash, height);

let _persistence_guard =
PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Channelmanager: improve block connection logging by Alkamal01 · Pull Request #4586 · lightningdevkit/rust-lightning · GitHub
Skip to content
Channelmanager: improve block connection logging#4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

Alkamal01
wants to merge
2
commits into

base:main
Choose a base branch

from


+10

−1

 Open


Channelmanager: improve block connection logging
#4586
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
fdfef44

channelmanager: improve block connection logging


Alkamal01 May 2, 2026
985a82b

Address review feedback: defer double-SHA256 computations in debug lo…


Alkamal01 May 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 10 additions & 1 deletion
lightning/src/ln/channelmanager.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15968,6 +15968,15 @@ impl<

 let block_hash = header.block_hash();
 log_trace!(self.logger, "{} transactions included in block {} at height {} provided", txdata.len(), block_hash, height);
 struct LazyTxid<'a>(&'a Transaction);
 impl<'a> core::fmt::Display for LazyTxid<'a> {
 fn fmt(&self, f: &mut core::fmt::Formatter) -> core::fmt::Result {
 write!(f, "{}", self.0.compute_txid())
 }
 }
 for (_, tx) in txdata.iter() {
 log_debug!(self.logger, "Confirmed transaction {} in block {} at height {}", LazyTxid(tx), block_hash, height);
 }

Comment on lines

+15977
 to 
+15979

@ldk-claude-review-botldk-claude-review-botMay 2, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compute_txid() performs a double-SHA256 over the serialized transaction, and the log_given_level! macro evaluates its arguments unconditionally (the level check is inside the Logger::log implementation, not before argument evaluation). This means the loop runs and hashes every transaction even when the logger's level is above DEBUG.
Consider either:
  1. Guarding the loop behind a level check, or
  2. Folding these per-txid details into the existing TRACE log, or
  3. Using a lazy wrapper (e.g., a Display impl that computes on fmt) — though this still wouldn't avoid the loop itself.
While txdata only contains matching transactions (not the full block), computing txids unconditionally on every block connection is unnecessary overhead for users who don't have DEBUG enabled.

 let _persistence_guard =
 PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand DownExpand Up@@ -15999,7 +16008,7 @@ impl<
 // See the docs for `ChannelManagerReadArgs` for more.

 let block_hash = header.block_hash();
log_trace!(self.logger, "New best block: {} at height {}", block_hash, height);
log_info!(self.logger, "New best block: {} at height {}", block_hash, height);

 let _persistence_guard =
 PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Channelmanager: improve block connection logging by Alkamal01 · Pull Request #4586 · lightningdevkit/rust-lightning · GitHub
Skip to content
Channelmanager: improve block connection logging#4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

Alkamal01
wants to merge
2
commits into

base:main
Choose a base branch

from


+10

−1

 Open


Channelmanager: improve block connection logging
#4586
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
fdfef44

channelmanager: improve block connection logging


Alkamal01 May 2, 2026
985a82b

Address review feedback: defer double-SHA256 computations in debug lo…


Alkamal01 May 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 10 additions & 1 deletion
lightning/src/ln/channelmanager.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15968,6 +15968,15 @@ impl<

 let block_hash = header.block_hash();
 log_trace!(self.logger, "{} transactions included in block {} at height {} provided", txdata.len(), block_hash, height);
 struct LazyTxid<'a>(&'a Transaction);
 impl<'a> core::fmt::Display for LazyTxid<'a> {
 fn fmt(&self, f: &mut core::fmt::Formatter) -> core::fmt::Result {
 write!(f, "{}", self.0.compute_txid())
 }
 }
 for (_, tx) in txdata.iter() {
 log_debug!(self.logger, "Confirmed transaction {} in block {} at height {}", LazyTxid(tx), block_hash, height);
 }

Comment on lines

+15977
 to 
+15979

@ldk-claude-review-botldk-claude-review-botMay 2, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compute_txid() performs a double-SHA256 over the serialized transaction, and the log_given_level! macro evaluates its arguments unconditionally (the level check is inside the Logger::log implementation, not before argument evaluation). This means the loop runs and hashes every transaction even when the logger's level is above DEBUG.
Consider either:
  1. Guarding the loop behind a level check, or
  2. Folding these per-txid details into the existing TRACE log, or
  3. Using a lazy wrapper (e.g., a Display impl that computes on fmt) — though this still wouldn't avoid the loop itself.
While txdata only contains matching transactions (not the full block), computing txids unconditionally on every block connection is unnecessary overhead for users who don't have DEBUG enabled.

 let _persistence_guard =
 PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand DownExpand Up@@ -15999,7 +16008,7 @@ impl<
 // See the docs for `ChannelManagerReadArgs` for more.

 let block_hash = header.block_hash();
log_trace!(self.logger, "New best block: {} at height {}", block_hash, height);
log_info!(self.logger, "New best block: {} at height {}", block_hash, height);

 let _persistence_guard =
 PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Channelmanager: improve block connection logging by Alkamal01 · Pull Request #4586 · lightningdevkit/rust-lightning · GitHub
Skip to content
Channelmanager: improve block connection logging#4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

Alkamal01
wants to merge
2
commits into

base:main
Choose a base branch

from


+10

−1

 Open


Channelmanager: improve block connection logging
#4586
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
fdfef44

channelmanager: improve block connection logging


Alkamal01 May 2, 2026
985a82b

Address review feedback: defer double-SHA256 computations in debug lo…


Alkamal01 May 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 10 additions & 1 deletion
lightning/src/ln/channelmanager.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15968,6 +15968,15 @@ impl<

 let block_hash = header.block_hash();
 log_trace!(self.logger, "{} transactions included in block {} at height {} provided", txdata.len(), block_hash, height);
 struct LazyTxid<'a>(&'a Transaction);
 impl<'a> core::fmt::Display for LazyTxid<'a> {
 fn fmt(&self, f: &mut core::fmt::Formatter) -> core::fmt::Result {
 write!(f, "{}", self.0.compute_txid())
 }
 }
 for (_, tx) in txdata.iter() {
 log_debug!(self.logger, "Confirmed transaction {} in block {} at height {}", LazyTxid(tx), block_hash, height);
 }

Comment on lines

+15977
 to 
+15979

@ldk-claude-review-botldk-claude-review-botMay 2, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compute_txid() performs a double-SHA256 over the serialized transaction, and the log_given_level! macro evaluates its arguments unconditionally (the level check is inside the Logger::log implementation, not before argument evaluation). This means the loop runs and hashes every transaction even when the logger's level is above DEBUG.
Consider either:
  1. Guarding the loop behind a level check, or
  2. Folding these per-txid details into the existing TRACE log, or
  3. Using a lazy wrapper (e.g., a Display impl that computes on fmt) — though this still wouldn't avoid the loop itself.
While txdata only contains matching transactions (not the full block), computing txids unconditionally on every block connection is unnecessary overhead for users who don't have DEBUG enabled.

 let _persistence_guard =
 PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand DownExpand Up@@ -15999,7 +16008,7 @@ impl<
 // See the docs for `ChannelManagerReadArgs` for more.

 let block_hash = header.block_hash();
log_trace!(self.logger, "New best block: {} at height {}", block_hash, height);
log_info!(self.logger, "New best block: {} at height {}", block_hash, height);

 let _persistence_guard =
 PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Channelmanager: improve block connection logging by Alkamal01 · Pull Request #4586 · lightningdevkit/rust-lightning · GitHub
Skip to content
Channelmanager: improve block connection logging#4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

Alkamal01
wants to merge
2
commits into

base:main
Choose a base branch

from


+10

−1

 Open


Channelmanager: improve block connection logging
#4586
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
fdfef44

channelmanager: improve block connection logging


Alkamal01 May 2, 2026
985a82b

Address review feedback: defer double-SHA256 computations in debug lo…


Alkamal01 May 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 10 additions & 1 deletion
lightning/src/ln/channelmanager.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15968,6 +15968,15 @@ impl<

 let block_hash = header.block_hash();
 log_trace!(self.logger, "{} transactions included in block {} at height {} provided", txdata.len(), block_hash, height);
 struct LazyTxid<'a>(&'a Transaction);
 impl<'a> core::fmt::Display for LazyTxid<'a> {
 fn fmt(&self, f: &mut core::fmt::Formatter) -> core::fmt::Result {
 write!(f, "{}", self.0.compute_txid())
 }
 }
 for (_, tx) in txdata.iter() {
 log_debug!(self.logger, "Confirmed transaction {} in block {} at height {}", LazyTxid(tx), block_hash, height);
 }

Comment on lines

+15977
 to 
+15979

@ldk-claude-review-botldk-claude-review-botMay 2, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compute_txid() performs a double-SHA256 over the serialized transaction, and the log_given_level! macro evaluates its arguments unconditionally (the level check is inside the Logger::log implementation, not before argument evaluation). This means the loop runs and hashes every transaction even when the logger's level is above DEBUG.
Consider either:
  1. Guarding the loop behind a level check, or
  2. Folding these per-txid details into the existing TRACE log, or
  3. Using a lazy wrapper (e.g., a Display impl that computes on fmt) — though this still wouldn't avoid the loop itself.
While txdata only contains matching transactions (not the full block), computing txids unconditionally on every block connection is unnecessary overhead for users who don't have DEBUG enabled.

 let _persistence_guard =
 PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand DownExpand Up@@ -15999,7 +16008,7 @@ impl<
 // See the docs for `ChannelManagerReadArgs` for more.

 let block_hash = header.block_hash();
log_trace!(self.logger, "New best block: {} at height {}", block_hash, height);
log_info!(self.logger, "New best block: {} at height {}", block_hash, height);

 let _persistence_guard =
 PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Channelmanager: improve block connection logging by Alkamal01 · Pull Request #4586 · lightningdevkit/rust-lightning · GitHub
Skip to content
Channelmanager: improve block connection logging#4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

Alkamal01
wants to merge
2
commits into

base:main
Choose a base branch

from


+10

−1

 Open


Channelmanager: improve block connection logging
#4586
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
fdfef44

channelmanager: improve block connection logging


Alkamal01 May 2, 2026
985a82b

Address review feedback: defer double-SHA256 computations in debug lo…


Alkamal01 May 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 10 additions & 1 deletion
lightning/src/ln/channelmanager.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15968,6 +15968,15 @@ impl<

 let block_hash = header.block_hash();
 log_trace!(self.logger, "{} transactions included in block {} at height {} provided", txdata.len(), block_hash, height);
 struct LazyTxid<'a>(&'a Transaction);
 impl<'a> core::fmt::Display for LazyTxid<'a> {
 fn fmt(&self, f: &mut core::fmt::Formatter) -> core::fmt::Result {
 write!(f, "{}", self.0.compute_txid())
 }
 }
 for (_, tx) in txdata.iter() {
 log_debug!(self.logger, "Confirmed transaction {} in block {} at height {}", LazyTxid(tx), block_hash, height);
 }

Comment on lines

+15977
 to 
+15979

@ldk-claude-review-botldk-claude-review-botMay 2, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compute_txid() performs a double-SHA256 over the serialized transaction, and the log_given_level! macro evaluates its arguments unconditionally (the level check is inside the Logger::log implementation, not before argument evaluation). This means the loop runs and hashes every transaction even when the logger's level is above DEBUG.
Consider either:
  1. Guarding the loop behind a level check, or
  2. Folding these per-txid details into the existing TRACE log, or
  3. Using a lazy wrapper (e.g., a Display impl that computes on fmt) — though this still wouldn't avoid the loop itself.
While txdata only contains matching transactions (not the full block), computing txids unconditionally on every block connection is unnecessary overhead for users who don't have DEBUG enabled.

 let _persistence_guard =
 PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand DownExpand Up@@ -15999,7 +16008,7 @@ impl<
 // See the docs for `ChannelManagerReadArgs` for more.

 let block_hash = header.block_hash();
log_trace!(self.logger, "New best block: {} at height {}", block_hash, height);
log_info!(self.logger, "New best block: {} at height {}", block_hash, height);

 let _persistence_guard =
 PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Channelmanager: improve block connection logging by Alkamal01 · Pull Request #4586 · lightningdevkit/rust-lightning · GitHub
Skip to content
Channelmanager: improve block connection logging#4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

Alkamal01
wants to merge
2
commits into

base:main
Choose a base branch

from


+10

−1

 Open


Channelmanager: improve block connection logging
#4586
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
fdfef44

channelmanager: improve block connection logging


Alkamal01 May 2, 2026
985a82b

Address review feedback: defer double-SHA256 computations in debug lo…


Alkamal01 May 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 10 additions & 1 deletion
lightning/src/ln/channelmanager.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15968,6 +15968,15 @@ impl<

 let block_hash = header.block_hash();
 log_trace!(self.logger, "{} transactions included in block {} at height {} provided", txdata.len(), block_hash, height);
 struct LazyTxid<'a>(&'a Transaction);
 impl<'a> core::fmt::Display for LazyTxid<'a> {
 fn fmt(&self, f: &mut core::fmt::Formatter) -> core::fmt::Result {
 write!(f, "{}", self.0.compute_txid())
 }
 }
 for (_, tx) in txdata.iter() {
 log_debug!(self.logger, "Confirmed transaction {} in block {} at height {}", LazyTxid(tx), block_hash, height);
 }

Comment on lines

+15977
 to 
+15979

@ldk-claude-review-botldk-claude-review-botMay 2, 2026

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compute_txid() performs a double-SHA256 over the serialized transaction, and the log_given_level! macro evaluates its arguments unconditionally (the level check is inside the Logger::log implementation, not before argument evaluation). This means the loop runs and hashes every transaction even when the logger's level is above DEBUG.
Consider either:
  1. Guarding the loop behind a level check, or
  2. Folding these per-txid details into the existing TRACE log, or
  3. Using a lazy wrapper (e.g., a Display impl that computes on fmt) — though this still wouldn't avoid the loop itself.
While txdata only contains matching transactions (not the full block), computing txids unconditionally on every block connection is unnecessary overhead for users who don't have DEBUG enabled.

 let _persistence_guard =
 PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand DownExpand Up@@ -15999,7 +16008,7 @@ impl<
 // See the docs for `ChannelManagerReadArgs` for more.

 let block_hash = header.block_hash();
log_trace!(self.logger, "New best block: {} at height {}", block_hash, height);
log_info!(self.logger, "New best block: {} at height {}", block_hash, height);

 let _persistence_guard =
 PersistenceNotifierGuard::optionally_notify_skipping_background_events(
Expand Down
Loading