Explicit Message Padding for OnionRealm0HopData by varunsrin · Pull Request #469 · lightningdevkit/rust-lightning

varunsrin · 2020-01-31T05:01:40Z

jkczyz

Thanks for the quick turnaround! Looks good.

jkczyz · 2020-01-31T19:21:03Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


It's too bad RFC 2000 (rust-lang/rust#44580) isn't in the stable Rust release yet. Then we could type alias this as:
pub(crate)typeBytePadding<constN:usize> = ::std::marker::PhantomData<[u8;N]>;
So this should be fine for now.

We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-01-31T19:31:12Z

+
+impl Writeable for PhantomData<[u8; 12]> {
+	fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
+ w.write_all(&[0;12])?;


Nit: Space between ; and 12.

TheBlueMatt

Happy to take this before 434, since it looks like that may get delayed a few days.

TheBlueMatt · 2020-02-03T19:07:55Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-02-18T19:50:44Z

@varunsrin #434 has been merged, so you should be able to rebase now.

varunsrin · 2020-02-21T01:33:14Z

perfect, ill get to this by early next week

TheBlueMatt · 2021-03-08T22:06:12Z

Closing as abandoned. If you want to pick this back up just respond here and we can open it again :)

varunsrin · 2020-01-31T05:01:40Z

Fixes#467

jkczyz

Thanks for the quick turnaround! Looks good.

jkczyz · 2020-01-31T19:21:03Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


It's too bad RFC 2000 (rust-lang/rust#44580) isn't in the stable Rust release yet. Then we could type alias this as:
pub(crate)typeBytePadding<constN:usize> = ::std::marker::PhantomData<[u8;N]>;
So this should be fine for now.

We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-01-31T19:31:12Z

+
+impl Writeable for PhantomData<[u8; 12]> {
+	fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
+ w.write_all(&[0;12])?;


Nit: Space between ; and 12.

TheBlueMatt

Happy to take this before 434, since it looks like that may get delayed a few days.

TheBlueMatt · 2020-02-03T19:07:55Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-02-18T19:50:44Z

@varunsrin #434 has been merged, so you should be able to rebase now.

varunsrin · 2020-02-21T01:33:14Z

perfect, ill get to this by early next week

TheBlueMatt · 2021-03-08T22:06:12Z

Closing as abandoned. If you want to pick this back up just respond here and we can open it again :)

varunsrin · 2020-01-31T05:01:40Z

Fixes#467

jkczyz

Thanks for the quick turnaround! Looks good.

jkczyz · 2020-01-31T19:21:03Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


It's too bad RFC 2000 (rust-lang/rust#44580) isn't in the stable Rust release yet. Then we could type alias this as:
pub(crate)typeBytePadding<constN:usize> = ::std::marker::PhantomData<[u8;N]>;
So this should be fine for now.

We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-01-31T19:31:12Z

+
+impl Writeable for PhantomData<[u8; 12]> {
+	fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
+ w.write_all(&[0;12])?;


Nit: Space between ; and 12.

TheBlueMatt

Happy to take this before 434, since it looks like that may get delayed a few days.

TheBlueMatt · 2020-02-03T19:07:55Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-02-18T19:50:44Z

@varunsrin #434 has been merged, so you should be able to rebase now.

varunsrin · 2020-02-21T01:33:14Z

perfect, ill get to this by early next week

TheBlueMatt · 2021-03-08T22:06:12Z

Closing as abandoned. If you want to pick this back up just respond here and we can open it again :)

varunsrin · 2020-01-31T05:01:40Z

Fixes#467

jkczyz

Thanks for the quick turnaround! Looks good.

jkczyz · 2020-01-31T19:21:03Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


It's too bad RFC 2000 (rust-lang/rust#44580) isn't in the stable Rust release yet. Then we could type alias this as:
pub(crate)typeBytePadding<constN:usize> = ::std::marker::PhantomData<[u8;N]>;
So this should be fine for now.

We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-01-31T19:31:12Z

+
+impl Writeable for PhantomData<[u8; 12]> {
+	fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
+ w.write_all(&[0;12])?;


Nit: Space between ; and 12.

TheBlueMatt

Happy to take this before 434, since it looks like that may get delayed a few days.

TheBlueMatt · 2020-02-03T19:07:55Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-02-18T19:50:44Z

@varunsrin #434 has been merged, so you should be able to rebase now.

varunsrin · 2020-02-21T01:33:14Z

perfect, ill get to this by early next week

TheBlueMatt · 2021-03-08T22:06:12Z

Closing as abandoned. If you want to pick this back up just respond here and we can open it again :)

varunsrin · 2020-01-31T05:01:40Z

Fixes#467

jkczyz

Thanks for the quick turnaround! Looks good.

jkczyz · 2020-01-31T19:21:03Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


It's too bad RFC 2000 (rust-lang/rust#44580) isn't in the stable Rust release yet. Then we could type alias this as:
pub(crate)typeBytePadding<constN:usize> = ::std::marker::PhantomData<[u8;N]>;
So this should be fine for now.

We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-01-31T19:31:12Z

+
+impl Writeable for PhantomData<[u8; 12]> {
+	fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
+ w.write_all(&[0;12])?;


Nit: Space between ; and 12.

TheBlueMatt

Happy to take this before 434, since it looks like that may get delayed a few days.

TheBlueMatt · 2020-02-03T19:07:55Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-02-18T19:50:44Z

@varunsrin #434 has been merged, so you should be able to rebase now.

varunsrin · 2020-02-21T01:33:14Z

perfect, ill get to this by early next week

TheBlueMatt · 2021-03-08T22:06:12Z

Closing as abandoned. If you want to pick this back up just respond here and we can open it again :)

varunsrin · 2020-01-31T05:01:40Z

Fixes#467

jkczyz

Thanks for the quick turnaround! Looks good.

jkczyz · 2020-01-31T19:21:03Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


It's too bad RFC 2000 (rust-lang/rust#44580) isn't in the stable Rust release yet. Then we could type alias this as:
pub(crate)typeBytePadding<constN:usize> = ::std::marker::PhantomData<[u8;N]>;
So this should be fine for now.

We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-01-31T19:31:12Z

+
+impl Writeable for PhantomData<[u8; 12]> {
+	fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
+ w.write_all(&[0;12])?;


Nit: Space between ; and 12.

TheBlueMatt

Happy to take this before 434, since it looks like that may get delayed a few days.

TheBlueMatt · 2020-02-03T19:07:55Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-02-18T19:50:44Z

@varunsrin #434 has been merged, so you should be able to rebase now.

varunsrin · 2020-02-21T01:33:14Z

perfect, ill get to this by early next week

TheBlueMatt · 2021-03-08T22:06:12Z

Closing as abandoned. If you want to pick this back up just respond here and we can open it again :)

varunsrin · 2020-01-31T05:01:40Z

Fixes#467

jkczyz

Thanks for the quick turnaround! Looks good.

jkczyz · 2020-01-31T19:21:03Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


It's too bad RFC 2000 (rust-lang/rust#44580) isn't in the stable Rust release yet. Then we could type alias this as:
pub(crate)typeBytePadding<constN:usize> = ::std::marker::PhantomData<[u8;N]>;
So this should be fine for now.

We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-01-31T19:31:12Z

+
+impl Writeable for PhantomData<[u8; 12]> {
+	fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
+ w.write_all(&[0;12])?;


Nit: Space between ; and 12.

TheBlueMatt

Happy to take this before 434, since it looks like that may get delayed a few days.

TheBlueMatt · 2020-02-03T19:07:55Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-02-18T19:50:44Z

@varunsrin #434 has been merged, so you should be able to rebase now.

varunsrin · 2020-02-21T01:33:14Z

perfect, ill get to this by early next week

TheBlueMatt · 2021-03-08T22:06:12Z

Closing as abandoned. If you want to pick this back up just respond here and we can open it again :)

varunsrin · 2020-01-31T05:01:40Z

Fixes#467

jkczyz

Thanks for the quick turnaround! Looks good.

jkczyz · 2020-01-31T19:21:03Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


It's too bad RFC 2000 (rust-lang/rust#44580) isn't in the stable Rust release yet. Then we could type alias this as:
pub(crate)typeBytePadding<constN:usize> = ::std::marker::PhantomData<[u8;N]>;
So this should be fine for now.

We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-01-31T19:31:12Z

+
+impl Writeable for PhantomData<[u8; 12]> {
+	fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> {
+ w.write_all(&[0;12])?;


Nit: Space between ; and 12.

TheBlueMatt

Happy to take this before 434, since it looks like that may get delayed a few days.

TheBlueMatt · 2020-02-03T19:07:55Z

 	pub(crate) amt_to_forward: u64,
 	pub(crate) outgoing_cltv_value: u32,
-// 12 bytes of 0-padding
+pub(crate) padding: PhantomData<[u8; 12]>,


We should probably do something like this anyway without generic constants. PhantomData has a somewhat specific meaning in Rust (that we have a template type that we're not going to instantiate). We probably just want a new type in ser.rs like (but with better names):
pub(crate) struct PaddingData<T: Default + std::convert::AsRef<[u8]>> { t: std::marker::PhantomData<T>, } impl<T: Default + std::convert::AsRef<[u8]>> Writeable for PaddingData<T> { #[inline] fn write<W: Writer>(&self, w: &mut W) -> Result<(), ::std::io::Error> { let nt: T = Default::default(); w.write_all(nt.as_ref()) } }

jkczyz · 2020-02-18T19:50:44Z

@varunsrin #434 has been merged, so you should be able to rebase now.

varunsrin · 2020-02-21T01:33:14Z

perfect, ill get to this by early next week

TheBlueMatt · 2021-03-08T22:06:12Z

Closing as abandoned. If you want to pick this back up just respond here and we can open it again :)

varunsrin mentioned this pull request Jan 31, 2020
Use zero-sized field for message padding #467
Closed

jkczyz self-requested a review January 31, 2020 05:25

varunsrin requested a review from TheBlueMatt January 31, 2020 17:02

jkczyz reviewed Jan 31, 2020
View reviewed changes

Explicit Message Padding for OnionRealm0HopData
1b2a1ba

varunsrin force-pushed the zero-sized-message-padding branch from 9a0a3b7 to 1b2a1baCompare February 1, 2020 01:00

jkczyz approved these changes Feb 1, 2020
View reviewed changes

TheBlueMatt reviewed Feb 3, 2020
View reviewed changes

TheBlueMatt closed this Mar 8, 2021

varunsrin mentioned this pull request Jan 31, 2020
Use zero-sized field for message padding #467
Closed

jkczyz self-requested a review January 31, 2020 05:25

varunsrin requested a review from TheBlueMatt January 31, 2020 17:02

jkczyz reviewed Jan 31, 2020
View reviewed changes

Explicit Message Padding for OnionRealm0HopData
1b2a1ba

varunsrin force-pushed the zero-sized-message-padding branch from 9a0a3b7 to 1b2a1baCompare February 1, 2020 01:00

jkczyz approved these changes Feb 1, 2020
View reviewed changes

TheBlueMatt reviewed Feb 3, 2020
View reviewed changes

TheBlueMatt closed this Mar 8, 2021

varunsrin mentioned this pull request Jan 31, 2020
Use zero-sized field for message padding #467
Closed

jkczyz self-requested a review January 31, 2020 05:25

varunsrin requested a review from TheBlueMatt January 31, 2020 17:02

jkczyz reviewed Jan 31, 2020
View reviewed changes

Explicit Message Padding for OnionRealm0HopData
1b2a1ba

varunsrin force-pushed the zero-sized-message-padding branch from 9a0a3b7 to 1b2a1baCompare February 1, 2020 01:00

jkczyz approved these changes Feb 1, 2020
View reviewed changes

TheBlueMatt reviewed Feb 3, 2020
View reviewed changes

TheBlueMatt closed this Mar 8, 2021

varunsrin mentioned this pull request Jan 31, 2020
Use zero-sized field for message padding #467
Closed

jkczyz self-requested a review January 31, 2020 05:25

varunsrin requested a review from TheBlueMatt January 31, 2020 17:02

jkczyz reviewed Jan 31, 2020
View reviewed changes

Explicit Message Padding for OnionRealm0HopData
1b2a1ba

varunsrin force-pushed the zero-sized-message-padding branch from 9a0a3b7 to 1b2a1baCompare February 1, 2020 01:00

jkczyz approved these changes Feb 1, 2020
View reviewed changes

TheBlueMatt reviewed Feb 3, 2020
View reviewed changes

TheBlueMatt closed this Mar 8, 2021

varunsrin mentioned this pull request Jan 31, 2020
Use zero-sized field for message padding #467
Closed

jkczyz self-requested a review January 31, 2020 05:25

varunsrin requested a review from TheBlueMatt January 31, 2020 17:02

jkczyz reviewed Jan 31, 2020
View reviewed changes

Explicit Message Padding for OnionRealm0HopData
1b2a1ba

varunsrin force-pushed the zero-sized-message-padding branch from 9a0a3b7 to 1b2a1baCompare February 1, 2020 01:00

jkczyz approved these changes Feb 1, 2020
View reviewed changes

TheBlueMatt reviewed Feb 3, 2020
View reviewed changes

TheBlueMatt closed this Mar 8, 2021

varunsrin mentioned this pull request Jan 31, 2020
Use zero-sized field for message padding #467
Closed

jkczyz self-requested a review January 31, 2020 05:25

varunsrin requested a review from TheBlueMatt January 31, 2020 17:02

jkczyz reviewed Jan 31, 2020
View reviewed changes

Explicit Message Padding for OnionRealm0HopData
1b2a1ba

varunsrin force-pushed the zero-sized-message-padding branch from 9a0a3b7 to 1b2a1baCompare February 1, 2020 01:00

jkczyz approved these changes Feb 1, 2020
View reviewed changes

TheBlueMatt reviewed Feb 3, 2020
View reviewed changes

TheBlueMatt closed this Mar 8, 2021

varunsrin mentioned this pull request Jan 31, 2020
Use zero-sized field for message padding #467
Closed

jkczyz self-requested a review January 31, 2020 05:25

varunsrin requested a review from TheBlueMatt January 31, 2020 17:02

jkczyz reviewed Jan 31, 2020
View reviewed changes

Explicit Message Padding for OnionRealm0HopData
1b2a1ba

varunsrin force-pushed the zero-sized-message-padding branch from 9a0a3b7 to 1b2a1baCompare February 1, 2020 01:00

jkczyz approved these changes Feb 1, 2020
View reviewed changes

TheBlueMatt reviewed Feb 3, 2020
View reviewed changes

TheBlueMatt closed this Mar 8, 2021

varunsrin mentioned this pull request Jan 31, 2020
Use zero-sized field for message padding #467
Closed

jkczyz self-requested a review January 31, 2020 05:25

varunsrin requested a review from TheBlueMatt January 31, 2020 17:02

jkczyz reviewed Jan 31, 2020
View reviewed changes

Explicit Message Padding for OnionRealm0HopData
1b2a1ba

varunsrin force-pushed the zero-sized-message-padding branch from 9a0a3b7 to 1b2a1baCompare February 1, 2020 01:00

jkczyz approved these changes Feb 1, 2020
View reviewed changes

TheBlueMatt reviewed Feb 3, 2020
View reviewed changes

TheBlueMatt closed this Mar 8, 2021

Uh oh!

Conversation

varunsrin commented Jan 31, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkczyz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkczyz commented Feb 18, 2020

Uh oh!

varunsrin commented Feb 21, 2020

Uh oh!

TheBlueMatt commented Mar 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

varunsrin commented Jan 31, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkczyz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkczyz commented Feb 18, 2020

Uh oh!

varunsrin commented Feb 21, 2020

Uh oh!

TheBlueMatt commented Mar 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

varunsrin commented Jan 31, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkczyz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

varunsrin commented Jan 31, 2020•
edited
Loading

varunsrin commented Jan 31, 2020•
edited
Loading

varunsrin commented Jan 31, 2020•
edited
Loading

varunsrin commented Jan 31, 2020•
edited
Loading