Add Unit tests for VssAccessor by G8XSU · Pull Request #3 · lightningdevkit/vss-client

G8XSU · 2023-04-27T00:23:22Z

Depends on #1 and #2

tnull · 2023-05-04T11:04:44Z

Needs a rebase it seems:

> cargo test
Compiling vss-accessor v0.1.0 (/Users/ero/workspace/vss-rust-client/vss-accessor)
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:32:31
|
32 | let actual_result = vss_acc.get("store", "k1").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:29:15
|
29 | pub async fn get(&self, store: String, key: String) -> Result<GetObjectResponse, VssError> {
| ^^^
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store".to_string(), "k1").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store", "k1".to_string()).await.unwrap();
| ++++++++++++
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:64:31
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1", 2, b"k1v3").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:46:15
|
46 | pub async fn put(
| ^^^
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store".to_string(), Some(4), "k1", 2, b"k1v3").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1".to_string(), 2, b"k1v3").await.unwrap();
| ++++++++++++
...

tnull

Some more comments, let me know if this is good for another round of review.

G8XSU · 2023-07-20T19:51:55Z


 [dependencies]
-prost = "0.11.9"
+prost = "0.11.6"


to keep msrv low
will eventually start enforcing it

jkczyz · 2023-08-02T21:01:09Z

+ let base_url = mockito::server_url().to_string();
+
+ // Set up the mock request/response.
+ let get_request = build_get_request();


It would be better to inline the request here so the test is self-contained. Otherwise, you have to jump to the end of the file to see how this relates to the response.

I agree,
in fact it was like that earlier, only reason i extracted it to function was because it was repeated ~4 times.
Personally i prefer test to be self-contained as well than to over-emphasize on not repeating.
Inlining such functions.

jkczyz · 2023-08-02T21:08:24Z

+ let mut mock_response = GetObjectResponse::default();
+ mock_response.value = Some(KeyValue { key: "k1".to_string(), version: 2, value: b"k1v2".to_vec() });


Little more idiomatic to initialize using one statement.
let mock_response = GetObjectResponse{value:Some(KeyValue{key:"k1".to_string(),version:2,value:b"k1v2".to_vec()}), ..Default::default()};

Makes sense!

jkczyz · 2023-08-07T20:22:01Z

+ // Requests to endpoints are no longer mocked and will result in network error.
+ drop(_mock_server);
+
+ let get_network_err = vss_client.get_object(&get_request).await;
+ assert!(matches!(get_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let put_network_err = vss_client.put_object(&put_request).await;
+ assert!(matches!(put_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let list_network_err = vss_client.list_key_versions(&list_request).await;
+ assert!(matches!(list_network_err.unwrap_err(), VssError::InternalError { .. }));


Wasn't clear to me why this results in an InternalError. In a separate commit, could you add documentation to the enum variants and configure the library as following?
#![deny(missing_docs)]#![deny(unsafe_code)]

Sounds Good, it is already on my todo list 👍

tnull

LGTM, mod the outstanding comments.

G8XSU · 2023-04-27T00:23:22Z

Depends on #1 and #2

tnull · 2023-05-04T11:04:44Z

Needs a rebase it seems:

> cargo test
Compiling vss-accessor v0.1.0 (/Users/ero/workspace/vss-rust-client/vss-accessor)
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:32:31
|
32 | let actual_result = vss_acc.get("store", "k1").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:29:15
|
29 | pub async fn get(&self, store: String, key: String) -> Result<GetObjectResponse, VssError> {
| ^^^
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store".to_string(), "k1").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store", "k1".to_string()).await.unwrap();
| ++++++++++++
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:64:31
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1", 2, b"k1v3").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:46:15
|
46 | pub async fn put(
| ^^^
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store".to_string(), Some(4), "k1", 2, b"k1v3").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1".to_string(), 2, b"k1v3").await.unwrap();
| ++++++++++++
...

tnull

Some more comments, let me know if this is good for another round of review.

G8XSU · 2023-07-20T19:51:55Z


 [dependencies]
-prost = "0.11.9"
+prost = "0.11.6"


to keep msrv low
will eventually start enforcing it

jkczyz · 2023-08-02T21:01:09Z

+ let base_url = mockito::server_url().to_string();
+
+ // Set up the mock request/response.
+ let get_request = build_get_request();


It would be better to inline the request here so the test is self-contained. Otherwise, you have to jump to the end of the file to see how this relates to the response.

I agree,
in fact it was like that earlier, only reason i extracted it to function was because it was repeated ~4 times.
Personally i prefer test to be self-contained as well than to over-emphasize on not repeating.
Inlining such functions.

jkczyz · 2023-08-02T21:08:24Z

+ let mut mock_response = GetObjectResponse::default();
+ mock_response.value = Some(KeyValue { key: "k1".to_string(), version: 2, value: b"k1v2".to_vec() });


Little more idiomatic to initialize using one statement.
let mock_response = GetObjectResponse{value:Some(KeyValue{key:"k1".to_string(),version:2,value:b"k1v2".to_vec()}), ..Default::default()};

Makes sense!

jkczyz · 2023-08-07T20:22:01Z

+ // Requests to endpoints are no longer mocked and will result in network error.
+ drop(_mock_server);
+
+ let get_network_err = vss_client.get_object(&get_request).await;
+ assert!(matches!(get_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let put_network_err = vss_client.put_object(&put_request).await;
+ assert!(matches!(put_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let list_network_err = vss_client.list_key_versions(&list_request).await;
+ assert!(matches!(list_network_err.unwrap_err(), VssError::InternalError { .. }));


Wasn't clear to me why this results in an InternalError. In a separate commit, could you add documentation to the enum variants and configure the library as following?
#![deny(missing_docs)]#![deny(unsafe_code)]

Sounds Good, it is already on my todo list 👍

tnull

LGTM, mod the outstanding comments.

G8XSU · 2023-04-27T00:23:22Z

Depends on #1 and #2

tnull · 2023-05-04T11:04:44Z

Needs a rebase it seems:

> cargo test
Compiling vss-accessor v0.1.0 (/Users/ero/workspace/vss-rust-client/vss-accessor)
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:32:31
|
32 | let actual_result = vss_acc.get("store", "k1").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:29:15
|
29 | pub async fn get(&self, store: String, key: String) -> Result<GetObjectResponse, VssError> {
| ^^^
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store".to_string(), "k1").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store", "k1".to_string()).await.unwrap();
| ++++++++++++
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:64:31
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1", 2, b"k1v3").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:46:15
|
46 | pub async fn put(
| ^^^
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store".to_string(), Some(4), "k1", 2, b"k1v3").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1".to_string(), 2, b"k1v3").await.unwrap();
| ++++++++++++
...

tnull

Some more comments, let me know if this is good for another round of review.

G8XSU · 2023-07-20T19:51:55Z


 [dependencies]
-prost = "0.11.9"
+prost = "0.11.6"


to keep msrv low
will eventually start enforcing it

jkczyz · 2023-08-02T21:01:09Z

+ let base_url = mockito::server_url().to_string();
+
+ // Set up the mock request/response.
+ let get_request = build_get_request();


It would be better to inline the request here so the test is self-contained. Otherwise, you have to jump to the end of the file to see how this relates to the response.

I agree,
in fact it was like that earlier, only reason i extracted it to function was because it was repeated ~4 times.
Personally i prefer test to be self-contained as well than to over-emphasize on not repeating.
Inlining such functions.

jkczyz · 2023-08-02T21:08:24Z

+ let mut mock_response = GetObjectResponse::default();
+ mock_response.value = Some(KeyValue { key: "k1".to_string(), version: 2, value: b"k1v2".to_vec() });


Little more idiomatic to initialize using one statement.
let mock_response = GetObjectResponse{value:Some(KeyValue{key:"k1".to_string(),version:2,value:b"k1v2".to_vec()}), ..Default::default()};

Makes sense!

jkczyz · 2023-08-07T20:22:01Z

+ // Requests to endpoints are no longer mocked and will result in network error.
+ drop(_mock_server);
+
+ let get_network_err = vss_client.get_object(&get_request).await;
+ assert!(matches!(get_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let put_network_err = vss_client.put_object(&put_request).await;
+ assert!(matches!(put_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let list_network_err = vss_client.list_key_versions(&list_request).await;
+ assert!(matches!(list_network_err.unwrap_err(), VssError::InternalError { .. }));


Wasn't clear to me why this results in an InternalError. In a separate commit, could you add documentation to the enum variants and configure the library as following?
#![deny(missing_docs)]#![deny(unsafe_code)]

Sounds Good, it is already on my todo list 👍

tnull

LGTM, mod the outstanding comments.

G8XSU · 2023-04-27T00:23:22Z

Depends on #1 and #2

tnull · 2023-05-04T11:04:44Z

Needs a rebase it seems:

> cargo test
Compiling vss-accessor v0.1.0 (/Users/ero/workspace/vss-rust-client/vss-accessor)
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:32:31
|
32 | let actual_result = vss_acc.get("store", "k1").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:29:15
|
29 | pub async fn get(&self, store: String, key: String) -> Result<GetObjectResponse, VssError> {
| ^^^
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store".to_string(), "k1").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store", "k1".to_string()).await.unwrap();
| ++++++++++++
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:64:31
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1", 2, b"k1v3").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:46:15
|
46 | pub async fn put(
| ^^^
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store".to_string(), Some(4), "k1", 2, b"k1v3").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1".to_string(), 2, b"k1v3").await.unwrap();
| ++++++++++++
...

tnull

Some more comments, let me know if this is good for another round of review.

G8XSU · 2023-07-20T19:51:55Z


 [dependencies]
-prost = "0.11.9"
+prost = "0.11.6"


to keep msrv low
will eventually start enforcing it

jkczyz · 2023-08-02T21:01:09Z

+ let base_url = mockito::server_url().to_string();
+
+ // Set up the mock request/response.
+ let get_request = build_get_request();


It would be better to inline the request here so the test is self-contained. Otherwise, you have to jump to the end of the file to see how this relates to the response.

I agree,
in fact it was like that earlier, only reason i extracted it to function was because it was repeated ~4 times.
Personally i prefer test to be self-contained as well than to over-emphasize on not repeating.
Inlining such functions.

jkczyz · 2023-08-02T21:08:24Z

+ let mut mock_response = GetObjectResponse::default();
+ mock_response.value = Some(KeyValue { key: "k1".to_string(), version: 2, value: b"k1v2".to_vec() });


Little more idiomatic to initialize using one statement.
let mock_response = GetObjectResponse{value:Some(KeyValue{key:"k1".to_string(),version:2,value:b"k1v2".to_vec()}), ..Default::default()};

Makes sense!

jkczyz · 2023-08-07T20:22:01Z

+ // Requests to endpoints are no longer mocked and will result in network error.
+ drop(_mock_server);
+
+ let get_network_err = vss_client.get_object(&get_request).await;
+ assert!(matches!(get_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let put_network_err = vss_client.put_object(&put_request).await;
+ assert!(matches!(put_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let list_network_err = vss_client.list_key_versions(&list_request).await;
+ assert!(matches!(list_network_err.unwrap_err(), VssError::InternalError { .. }));


Wasn't clear to me why this results in an InternalError. In a separate commit, could you add documentation to the enum variants and configure the library as following?
#![deny(missing_docs)]#![deny(unsafe_code)]

Sounds Good, it is already on my todo list 👍

tnull

LGTM, mod the outstanding comments.

G8XSU · 2023-04-27T00:23:22Z

Depends on #1 and #2

tnull · 2023-05-04T11:04:44Z

Needs a rebase it seems:

> cargo test
Compiling vss-accessor v0.1.0 (/Users/ero/workspace/vss-rust-client/vss-accessor)
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:32:31
|
32 | let actual_result = vss_acc.get("store", "k1").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:29:15
|
29 | pub async fn get(&self, store: String, key: String) -> Result<GetObjectResponse, VssError> {
| ^^^
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store".to_string(), "k1").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store", "k1".to_string()).await.unwrap();
| ++++++++++++
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:64:31
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1", 2, b"k1v3").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:46:15
|
46 | pub async fn put(
| ^^^
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store".to_string(), Some(4), "k1", 2, b"k1v3").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1".to_string(), 2, b"k1v3").await.unwrap();
| ++++++++++++
...

tnull

Some more comments, let me know if this is good for another round of review.

G8XSU · 2023-07-20T19:51:55Z


 [dependencies]
-prost = "0.11.9"
+prost = "0.11.6"


to keep msrv low
will eventually start enforcing it

jkczyz · 2023-08-02T21:01:09Z

+ let base_url = mockito::server_url().to_string();
+
+ // Set up the mock request/response.
+ let get_request = build_get_request();


It would be better to inline the request here so the test is self-contained. Otherwise, you have to jump to the end of the file to see how this relates to the response.

I agree,
in fact it was like that earlier, only reason i extracted it to function was because it was repeated ~4 times.
Personally i prefer test to be self-contained as well than to over-emphasize on not repeating.
Inlining such functions.

jkczyz · 2023-08-02T21:08:24Z

+ let mut mock_response = GetObjectResponse::default();
+ mock_response.value = Some(KeyValue { key: "k1".to_string(), version: 2, value: b"k1v2".to_vec() });


Little more idiomatic to initialize using one statement.
let mock_response = GetObjectResponse{value:Some(KeyValue{key:"k1".to_string(),version:2,value:b"k1v2".to_vec()}), ..Default::default()};

Makes sense!

jkczyz · 2023-08-07T20:22:01Z

+ // Requests to endpoints are no longer mocked and will result in network error.
+ drop(_mock_server);
+
+ let get_network_err = vss_client.get_object(&get_request).await;
+ assert!(matches!(get_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let put_network_err = vss_client.put_object(&put_request).await;
+ assert!(matches!(put_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let list_network_err = vss_client.list_key_versions(&list_request).await;
+ assert!(matches!(list_network_err.unwrap_err(), VssError::InternalError { .. }));


Wasn't clear to me why this results in an InternalError. In a separate commit, could you add documentation to the enum variants and configure the library as following?
#![deny(missing_docs)]#![deny(unsafe_code)]

Sounds Good, it is already on my todo list 👍

tnull

LGTM, mod the outstanding comments.

G8XSU · 2023-04-27T00:23:22Z

Depends on #1 and #2

tnull · 2023-05-04T11:04:44Z

Needs a rebase it seems:

> cargo test
Compiling vss-accessor v0.1.0 (/Users/ero/workspace/vss-rust-client/vss-accessor)
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:32:31
|
32 | let actual_result = vss_acc.get("store", "k1").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:29:15
|
29 | pub async fn get(&self, store: String, key: String) -> Result<GetObjectResponse, VssError> {
| ^^^
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store".to_string(), "k1").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store", "k1".to_string()).await.unwrap();
| ++++++++++++
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:64:31
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1", 2, b"k1v3").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:46:15
|
46 | pub async fn put(
| ^^^
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store".to_string(), Some(4), "k1", 2, b"k1v3").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1".to_string(), 2, b"k1v3").await.unwrap();
| ++++++++++++
...

tnull

Some more comments, let me know if this is good for another round of review.

G8XSU · 2023-07-20T19:51:55Z


 [dependencies]
-prost = "0.11.9"
+prost = "0.11.6"


to keep msrv low
will eventually start enforcing it

jkczyz · 2023-08-02T21:01:09Z

+ let base_url = mockito::server_url().to_string();
+
+ // Set up the mock request/response.
+ let get_request = build_get_request();


It would be better to inline the request here so the test is self-contained. Otherwise, you have to jump to the end of the file to see how this relates to the response.

I agree,
in fact it was like that earlier, only reason i extracted it to function was because it was repeated ~4 times.
Personally i prefer test to be self-contained as well than to over-emphasize on not repeating.
Inlining such functions.

jkczyz · 2023-08-02T21:08:24Z

+ let mut mock_response = GetObjectResponse::default();
+ mock_response.value = Some(KeyValue { key: "k1".to_string(), version: 2, value: b"k1v2".to_vec() });


Little more idiomatic to initialize using one statement.
let mock_response = GetObjectResponse{value:Some(KeyValue{key:"k1".to_string(),version:2,value:b"k1v2".to_vec()}), ..Default::default()};

Makes sense!

jkczyz · 2023-08-07T20:22:01Z

+ // Requests to endpoints are no longer mocked and will result in network error.
+ drop(_mock_server);
+
+ let get_network_err = vss_client.get_object(&get_request).await;
+ assert!(matches!(get_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let put_network_err = vss_client.put_object(&put_request).await;
+ assert!(matches!(put_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let list_network_err = vss_client.list_key_versions(&list_request).await;
+ assert!(matches!(list_network_err.unwrap_err(), VssError::InternalError { .. }));


Wasn't clear to me why this results in an InternalError. In a separate commit, could you add documentation to the enum variants and configure the library as following?
#![deny(missing_docs)]#![deny(unsafe_code)]

Sounds Good, it is already on my todo list 👍

tnull

LGTM, mod the outstanding comments.

G8XSU · 2023-04-27T00:23:22Z

Depends on #1 and #2

tnull · 2023-05-04T11:04:44Z

Needs a rebase it seems:

> cargo test
Compiling vss-accessor v0.1.0 (/Users/ero/workspace/vss-rust-client/vss-accessor)
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:32:31
|
32 | let actual_result = vss_acc.get("store", "k1").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:29:15
|
29 | pub async fn get(&self, store: String, key: String) -> Result<GetObjectResponse, VssError> {
| ^^^
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store".to_string(), "k1").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store", "k1".to_string()).await.unwrap();
| ++++++++++++
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:64:31
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1", 2, b"k1v3").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:46:15
|
46 | pub async fn put(
| ^^^
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store".to_string(), Some(4), "k1", 2, b"k1v3").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1".to_string(), 2, b"k1v3").await.unwrap();
| ++++++++++++
...

tnull

Some more comments, let me know if this is good for another round of review.

G8XSU · 2023-07-20T19:51:55Z


 [dependencies]
-prost = "0.11.9"
+prost = "0.11.6"


to keep msrv low
will eventually start enforcing it

jkczyz · 2023-08-02T21:01:09Z

+ let base_url = mockito::server_url().to_string();
+
+ // Set up the mock request/response.
+ let get_request = build_get_request();


It would be better to inline the request here so the test is self-contained. Otherwise, you have to jump to the end of the file to see how this relates to the response.

I agree,
in fact it was like that earlier, only reason i extracted it to function was because it was repeated ~4 times.
Personally i prefer test to be self-contained as well than to over-emphasize on not repeating.
Inlining such functions.

jkczyz · 2023-08-02T21:08:24Z

+ let mut mock_response = GetObjectResponse::default();
+ mock_response.value = Some(KeyValue { key: "k1".to_string(), version: 2, value: b"k1v2".to_vec() });


Little more idiomatic to initialize using one statement.
let mock_response = GetObjectResponse{value:Some(KeyValue{key:"k1".to_string(),version:2,value:b"k1v2".to_vec()}), ..Default::default()};

Makes sense!

jkczyz · 2023-08-07T20:22:01Z

+ // Requests to endpoints are no longer mocked and will result in network error.
+ drop(_mock_server);
+
+ let get_network_err = vss_client.get_object(&get_request).await;
+ assert!(matches!(get_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let put_network_err = vss_client.put_object(&put_request).await;
+ assert!(matches!(put_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let list_network_err = vss_client.list_key_versions(&list_request).await;
+ assert!(matches!(list_network_err.unwrap_err(), VssError::InternalError { .. }));


Wasn't clear to me why this results in an InternalError. In a separate commit, could you add documentation to the enum variants and configure the library as following?
#![deny(missing_docs)]#![deny(unsafe_code)]

Sounds Good, it is already on my todo list 👍

tnull

LGTM, mod the outstanding comments.

G8XSU · 2023-04-27T00:23:22Z

Depends on #1 and #2

tnull · 2023-05-04T11:04:44Z

Needs a rebase it seems:

> cargo test
Compiling vss-accessor v0.1.0 (/Users/ero/workspace/vss-rust-client/vss-accessor)
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:32:31
|
32 | let actual_result = vss_acc.get("store", "k1").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:29:15
|
29 | pub async fn get(&self, store: String, key: String) -> Result<GetObjectResponse, VssError> {
| ^^^
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store".to_string(), "k1").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
32 | let actual_result = vss_acc.get("store", "k1".to_string()).await.unwrap();
| ++++++++++++
error[E0308]: arguments to this method are incorrect
--> vss-accessor/tests/tests.rs:64:31
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1", 2, b"k1v3").await.unwrap();
| ^^^ ------- ---- expected struct `String`, found `&str`
| |
| expected struct `String`, found `&str`
|
note: associated function defined here
--> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:46:15
|
46 | pub async fn put(
| ^^^
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store".to_string(), Some(4), "k1", 2, b"k1v3").await.unwrap();
| ++++++++++++
help: try using a conversion method
|
64 | let actual_result = vss_acc.put("store", Some(4), "k1".to_string(), 2, b"k1v3").await.unwrap();
| ++++++++++++
...

tnull

Some more comments, let me know if this is good for another round of review.

G8XSU · 2023-07-20T19:51:55Z


 [dependencies]
-prost = "0.11.9"
+prost = "0.11.6"


to keep msrv low
will eventually start enforcing it

jkczyz · 2023-08-02T21:01:09Z

+ let base_url = mockito::server_url().to_string();
+
+ // Set up the mock request/response.
+ let get_request = build_get_request();


It would be better to inline the request here so the test is self-contained. Otherwise, you have to jump to the end of the file to see how this relates to the response.

I agree,
in fact it was like that earlier, only reason i extracted it to function was because it was repeated ~4 times.
Personally i prefer test to be self-contained as well than to over-emphasize on not repeating.
Inlining such functions.

jkczyz · 2023-08-02T21:08:24Z

+ let mut mock_response = GetObjectResponse::default();
+ mock_response.value = Some(KeyValue { key: "k1".to_string(), version: 2, value: b"k1v2".to_vec() });


Little more idiomatic to initialize using one statement.
let mock_response = GetObjectResponse{value:Some(KeyValue{key:"k1".to_string(),version:2,value:b"k1v2".to_vec()}), ..Default::default()};

Makes sense!

jkczyz · 2023-08-07T20:22:01Z

+ // Requests to endpoints are no longer mocked and will result in network error.
+ drop(_mock_server);
+
+ let get_network_err = vss_client.get_object(&get_request).await;
+ assert!(matches!(get_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let put_network_err = vss_client.put_object(&put_request).await;
+ assert!(matches!(put_network_err.unwrap_err(), VssError::InternalError { .. }));
+
+ let list_network_err = vss_client.list_key_versions(&list_request).await;
+ assert!(matches!(list_network_err.unwrap_err(), VssError::InternalError { .. }));


Wasn't clear to me why this results in an InternalError. In a separate commit, could you add documentation to the enum variants and configure the library as following?
#![deny(missing_docs)]#![deny(unsafe_code)]

Sounds Good, it is already on my todo list 👍

tnull

LGTM, mod the outstanding comments.

G8XSU marked this pull request as ready for review April 27, 2023 17:14

tnull reviewed May 2, 2023
View reviewed changes

Comment threadvss-accessor/src/vss_error.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from 506e45f to 0d4dd8dCompare May 4, 2023 03:04

G8XSU force-pushed the accessor_tests branch from 0d4dd8d to 38795acCompare May 5, 2023 23:25

G8XSU mentioned this pull request May 10, 2023
VSS Tracking Issue lightningdevkit/vss-server#9
Closed
31 tasks

tnull reviewed May 30, 2023
View reviewed changes

Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU mentioned this pull request Jul 19, 2023
Add VSS Http thin client implementation for get/put/listKeyVersions api's #1
Merged

G8XSU force-pushed the accessor_tests branch 2 times, most recently from f4e55f8 to 5ee8edfCompare July 20, 2023 19:49

G8XSU commented Jul 20, 2023
View reviewed changes

G8XSU requested a review from jkczyz July 20, 2023 19:52

jkczyz reviewed Aug 2, 2023
View reviewed changes

G8XSU force-pushed the accessor_tests branch from 5ee8edf to d64c50fCompare August 7, 2023 03:00

G8XSU requested a review from jkczyz August 7, 2023 03:06

jkczyz reviewed Aug 7, 2023
View reviewed changes

tnull reviewed Aug 8, 2023
View reviewed changes

Comment threadCargo.toml Outdated
Comment threadtests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from d64c50f to 7595304Compare August 8, 2023 19:26

Add Unit tests for VssAccessor
91fb6aa

G8XSU force-pushed the accessor_tests branch from 7595304 to 91fb6aaCompare August 8, 2023 19:46

G8XSU requested a review from jkczyz August 8, 2023 19:50

jkczyz approved these changes Aug 8, 2023
View reviewed changes

G8XSU merged commit 3770cef into lightningdevkit:mainAug 8, 2023

G8XSU marked this pull request as ready for review April 27, 2023 17:14

tnull reviewed May 2, 2023
View reviewed changes

Comment threadvss-accessor/src/vss_error.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from 506e45f to 0d4dd8dCompare May 4, 2023 03:04

G8XSU force-pushed the accessor_tests branch from 0d4dd8d to 38795acCompare May 5, 2023 23:25

G8XSU mentioned this pull request May 10, 2023
VSS Tracking Issue lightningdevkit/vss-server#9
Closed
31 tasks

tnull reviewed May 30, 2023
View reviewed changes

Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU mentioned this pull request Jul 19, 2023
Add VSS Http thin client implementation for get/put/listKeyVersions api's #1
Merged

G8XSU force-pushed the accessor_tests branch 2 times, most recently from f4e55f8 to 5ee8edfCompare July 20, 2023 19:49

G8XSU commented Jul 20, 2023
View reviewed changes

G8XSU requested a review from jkczyz July 20, 2023 19:52

jkczyz reviewed Aug 2, 2023
View reviewed changes

G8XSU force-pushed the accessor_tests branch from 5ee8edf to d64c50fCompare August 7, 2023 03:00

G8XSU requested a review from jkczyz August 7, 2023 03:06

jkczyz reviewed Aug 7, 2023
View reviewed changes

tnull reviewed Aug 8, 2023
View reviewed changes

Comment threadCargo.toml Outdated
Comment threadtests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from d64c50f to 7595304Compare August 8, 2023 19:26

Add Unit tests for VssAccessor
91fb6aa

G8XSU force-pushed the accessor_tests branch from 7595304 to 91fb6aaCompare August 8, 2023 19:46

G8XSU requested a review from jkczyz August 8, 2023 19:50

jkczyz approved these changes Aug 8, 2023
View reviewed changes

G8XSU merged commit 3770cef into lightningdevkit:mainAug 8, 2023

G8XSU marked this pull request as ready for review April 27, 2023 17:14

tnull reviewed May 2, 2023
View reviewed changes

Comment threadvss-accessor/src/vss_error.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from 506e45f to 0d4dd8dCompare May 4, 2023 03:04

G8XSU force-pushed the accessor_tests branch from 0d4dd8d to 38795acCompare May 5, 2023 23:25

G8XSU mentioned this pull request May 10, 2023
VSS Tracking Issue lightningdevkit/vss-server#9
Closed
31 tasks

tnull reviewed May 30, 2023
View reviewed changes

Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU mentioned this pull request Jul 19, 2023
Add VSS Http thin client implementation for get/put/listKeyVersions api's #1
Merged

G8XSU force-pushed the accessor_tests branch 2 times, most recently from f4e55f8 to 5ee8edfCompare July 20, 2023 19:49

G8XSU commented Jul 20, 2023
View reviewed changes

G8XSU requested a review from jkczyz July 20, 2023 19:52

jkczyz reviewed Aug 2, 2023
View reviewed changes

G8XSU force-pushed the accessor_tests branch from 5ee8edf to d64c50fCompare August 7, 2023 03:00

G8XSU requested a review from jkczyz August 7, 2023 03:06

jkczyz reviewed Aug 7, 2023
View reviewed changes

tnull reviewed Aug 8, 2023
View reviewed changes

Comment threadCargo.toml Outdated
Comment threadtests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from d64c50f to 7595304Compare August 8, 2023 19:26

Add Unit tests for VssAccessor
91fb6aa

G8XSU force-pushed the accessor_tests branch from 7595304 to 91fb6aaCompare August 8, 2023 19:46

G8XSU requested a review from jkczyz August 8, 2023 19:50

jkczyz approved these changes Aug 8, 2023
View reviewed changes

G8XSU merged commit 3770cef into lightningdevkit:mainAug 8, 2023

G8XSU marked this pull request as ready for review April 27, 2023 17:14

tnull reviewed May 2, 2023
View reviewed changes

Comment threadvss-accessor/src/vss_error.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from 506e45f to 0d4dd8dCompare May 4, 2023 03:04

G8XSU force-pushed the accessor_tests branch from 0d4dd8d to 38795acCompare May 5, 2023 23:25

G8XSU mentioned this pull request May 10, 2023
VSS Tracking Issue lightningdevkit/vss-server#9
Closed
31 tasks

tnull reviewed May 30, 2023
View reviewed changes

Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU mentioned this pull request Jul 19, 2023
Add VSS Http thin client implementation for get/put/listKeyVersions api's #1
Merged

G8XSU force-pushed the accessor_tests branch 2 times, most recently from f4e55f8 to 5ee8edfCompare July 20, 2023 19:49

G8XSU commented Jul 20, 2023
View reviewed changes

G8XSU requested a review from jkczyz July 20, 2023 19:52

jkczyz reviewed Aug 2, 2023
View reviewed changes

G8XSU force-pushed the accessor_tests branch from 5ee8edf to d64c50fCompare August 7, 2023 03:00

G8XSU requested a review from jkczyz August 7, 2023 03:06

jkczyz reviewed Aug 7, 2023
View reviewed changes

tnull reviewed Aug 8, 2023
View reviewed changes

Comment threadCargo.toml Outdated
Comment threadtests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from d64c50f to 7595304Compare August 8, 2023 19:26

Add Unit tests for VssAccessor
91fb6aa

G8XSU force-pushed the accessor_tests branch from 7595304 to 91fb6aaCompare August 8, 2023 19:46

G8XSU requested a review from jkczyz August 8, 2023 19:50

jkczyz approved these changes Aug 8, 2023
View reviewed changes

G8XSU merged commit 3770cef into lightningdevkit:mainAug 8, 2023

G8XSU marked this pull request as ready for review April 27, 2023 17:14

tnull reviewed May 2, 2023
View reviewed changes

Comment threadvss-accessor/src/vss_error.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from 506e45f to 0d4dd8dCompare May 4, 2023 03:04

G8XSU force-pushed the accessor_tests branch from 0d4dd8d to 38795acCompare May 5, 2023 23:25

G8XSU mentioned this pull request May 10, 2023
VSS Tracking Issue lightningdevkit/vss-server#9
Closed
31 tasks

tnull reviewed May 30, 2023
View reviewed changes

Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU mentioned this pull request Jul 19, 2023
Add VSS Http thin client implementation for get/put/listKeyVersions api's #1
Merged

G8XSU force-pushed the accessor_tests branch 2 times, most recently from f4e55f8 to 5ee8edfCompare July 20, 2023 19:49

G8XSU commented Jul 20, 2023
View reviewed changes

G8XSU requested a review from jkczyz July 20, 2023 19:52

jkczyz reviewed Aug 2, 2023
View reviewed changes

G8XSU force-pushed the accessor_tests branch from 5ee8edf to d64c50fCompare August 7, 2023 03:00

G8XSU requested a review from jkczyz August 7, 2023 03:06

jkczyz reviewed Aug 7, 2023
View reviewed changes

tnull reviewed Aug 8, 2023
View reviewed changes

Comment threadCargo.toml Outdated
Comment threadtests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from d64c50f to 7595304Compare August 8, 2023 19:26

Add Unit tests for VssAccessor
91fb6aa

G8XSU force-pushed the accessor_tests branch from 7595304 to 91fb6aaCompare August 8, 2023 19:46

G8XSU requested a review from jkczyz August 8, 2023 19:50

jkczyz approved these changes Aug 8, 2023
View reviewed changes

G8XSU merged commit 3770cef into lightningdevkit:mainAug 8, 2023

G8XSU marked this pull request as ready for review April 27, 2023 17:14

tnull reviewed May 2, 2023
View reviewed changes

Comment threadvss-accessor/src/vss_error.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from 506e45f to 0d4dd8dCompare May 4, 2023 03:04

G8XSU force-pushed the accessor_tests branch from 0d4dd8d to 38795acCompare May 5, 2023 23:25

G8XSU mentioned this pull request May 10, 2023
VSS Tracking Issue lightningdevkit/vss-server#9
Closed
31 tasks

tnull reviewed May 30, 2023
View reviewed changes

Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU mentioned this pull request Jul 19, 2023
Add VSS Http thin client implementation for get/put/listKeyVersions api's #1
Merged

G8XSU force-pushed the accessor_tests branch 2 times, most recently from f4e55f8 to 5ee8edfCompare July 20, 2023 19:49

G8XSU commented Jul 20, 2023
View reviewed changes

G8XSU requested a review from jkczyz July 20, 2023 19:52

jkczyz reviewed Aug 2, 2023
View reviewed changes

G8XSU force-pushed the accessor_tests branch from 5ee8edf to d64c50fCompare August 7, 2023 03:00

G8XSU requested a review from jkczyz August 7, 2023 03:06

jkczyz reviewed Aug 7, 2023
View reviewed changes

tnull reviewed Aug 8, 2023
View reviewed changes

Comment threadCargo.toml Outdated
Comment threadtests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from d64c50f to 7595304Compare August 8, 2023 19:26

Add Unit tests for VssAccessor
91fb6aa

G8XSU force-pushed the accessor_tests branch from 7595304 to 91fb6aaCompare August 8, 2023 19:46

G8XSU requested a review from jkczyz August 8, 2023 19:50

jkczyz approved these changes Aug 8, 2023
View reviewed changes

G8XSU merged commit 3770cef into lightningdevkit:mainAug 8, 2023

G8XSU marked this pull request as ready for review April 27, 2023 17:14

tnull reviewed May 2, 2023
View reviewed changes

Comment threadvss-accessor/src/vss_error.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from 506e45f to 0d4dd8dCompare May 4, 2023 03:04

G8XSU force-pushed the accessor_tests branch from 0d4dd8d to 38795acCompare May 5, 2023 23:25

G8XSU mentioned this pull request May 10, 2023
VSS Tracking Issue lightningdevkit/vss-server#9
Closed
31 tasks

tnull reviewed May 30, 2023
View reviewed changes

Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU mentioned this pull request Jul 19, 2023
Add VSS Http thin client implementation for get/put/listKeyVersions api's #1
Merged

G8XSU force-pushed the accessor_tests branch 2 times, most recently from f4e55f8 to 5ee8edfCompare July 20, 2023 19:49

G8XSU commented Jul 20, 2023
View reviewed changes

G8XSU requested a review from jkczyz July 20, 2023 19:52

jkczyz reviewed Aug 2, 2023
View reviewed changes

G8XSU force-pushed the accessor_tests branch from 5ee8edf to d64c50fCompare August 7, 2023 03:00

G8XSU requested a review from jkczyz August 7, 2023 03:06

jkczyz reviewed Aug 7, 2023
View reviewed changes

tnull reviewed Aug 8, 2023
View reviewed changes

Comment threadCargo.toml Outdated
Comment threadtests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from d64c50f to 7595304Compare August 8, 2023 19:26

Add Unit tests for VssAccessor
91fb6aa

G8XSU force-pushed the accessor_tests branch from 7595304 to 91fb6aaCompare August 8, 2023 19:46

G8XSU requested a review from jkczyz August 8, 2023 19:50

jkczyz approved these changes Aug 8, 2023
View reviewed changes

G8XSU merged commit 3770cef into lightningdevkit:mainAug 8, 2023

G8XSU marked this pull request as ready for review April 27, 2023 17:14

tnull reviewed May 2, 2023
View reviewed changes

Comment threadvss-accessor/src/vss_error.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from 506e45f to 0d4dd8dCompare May 4, 2023 03:04

G8XSU force-pushed the accessor_tests branch from 0d4dd8d to 38795acCompare May 5, 2023 23:25

G8XSU mentioned this pull request May 10, 2023
VSS Tracking Issue lightningdevkit/vss-server#9
Closed
31 tasks

tnull reviewed May 30, 2023
View reviewed changes

Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/generate_protos.rs Outdated
Comment threadvss-accessor/tests/tests.rs Outdated

G8XSU mentioned this pull request Jul 19, 2023
Add VSS Http thin client implementation for get/put/listKeyVersions api's #1
Merged

G8XSU force-pushed the accessor_tests branch 2 times, most recently from f4e55f8 to 5ee8edfCompare July 20, 2023 19:49

G8XSU commented Jul 20, 2023
View reviewed changes

G8XSU requested a review from jkczyz July 20, 2023 19:52

jkczyz reviewed Aug 2, 2023
View reviewed changes

G8XSU force-pushed the accessor_tests branch from 5ee8edf to d64c50fCompare August 7, 2023 03:00

G8XSU requested a review from jkczyz August 7, 2023 03:06

jkczyz reviewed Aug 7, 2023
View reviewed changes

tnull reviewed Aug 8, 2023
View reviewed changes

Comment threadCargo.toml Outdated
Comment threadtests/tests.rs Outdated

G8XSU force-pushed the accessor_tests branch from d64c50f to 7595304Compare August 8, 2023 19:26

Add Unit tests for VssAccessor
91fb6aa

G8XSU force-pushed the accessor_tests branch from 7595304 to 91fb6aaCompare August 8, 2023 19:46

G8XSU requested a review from jkczyz August 8, 2023 19:50

jkczyz approved these changes Aug 8, 2023
View reviewed changes

G8XSU merged commit 3770cef into lightningdevkit:mainAug 8, 2023

		let mut mock_response = GetObjectResponse::default();
		mock_response.value = Some(KeyValue { key: "k1".to_string(), version: 2, value: b"k1v2".to_vec() });

Uh oh!

Conversation

G8XSU commented Apr 27, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tnull commented May 4, 2023

Uh oh!

tnull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

G8XSUAug 8, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tnull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

G8XSU commented Apr 27, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tnull commented May 4, 2023

Uh oh!

tnull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

G8XSUAug 8, 2023•
edited
Loading

G8XSUAug 8, 2023•
edited
Loading