Add rust Dockerfile by frnandu · Pull Request #80 · lightningdevkit/vss-server

frnandu · 2025-12-29T09:56:04Z

fixes#74

ldk-reviews-bot · 2025-12-29T09:56:07Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-01-01T08:22:52Z

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-03T08:23:44Z

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-05T08:24:34Z

🔔 3rd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tankyleo

Thanks ! can you make this one commit / remove the merge commit in the current PR ?

tankyleo

As mentioned above, let's bring back ca-certificates for HTTPS requests.

Also squash all the commits into a single one.

frnandu · 2026-01-24T15:36:37Z

Also squash all the commits into a single one.

Isn't that possible to do when merging by squash and merge ?

tankyleo · 2026-01-27T22:53:25Z

Isn't that possible to do when merging by squash and merge ?

I need to ACK the exact commit that will get merged, should be quite doable on your side no ?

tankyleo · 2026-01-27T22:53:49Z

@frnandu making sure you see this message above thanks for squashing if you can

frnandu · 2026-02-01T23:07:18Z

Squashed, thanks!

tankyleo

Thanks tested on my machine looks good.

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

frnandu · 2026-02-06T00:32:55Z

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

done

frnandu · 2026-03-27T09:49:56Z

ping?

tankyleo · 2026-06-02T01:37:49Z

@frnandu I cleaned up the branch, used fmar <fmar@fmar.dev> for the author field on the dockerfile commit.

tnull thanks for taking a look I can't merge since I'm the last pusher.

tnull · 2026-06-02T07:50:42Z

+# Copy default configuration file
+COPY server/vss-server-config.toml /app/vss-server-config.toml
+
+EXPOSE 8080


It seems by default this will only bind to localhost. Do we need to set VSS_BIND_ADDRESS to make this work outside of docker/reachable by other docker containers?
[P2] Use container-reachable network defaults — /home/tnull/workspace/vss-server/rust/Dockerfile:40-40
When the image is run with its default CMD, e.g. docker run -p 8080:8080 ..., /app/vss-server-config.toml still binds VSS to 127.0.0.1 and points PostgreSQL at 127.0.0.1. Inside Docker those are container-loopback addresses, so the published port cannot reach the server and Postgres on
another container/host is unreachable unless users override both env vars. Consider shipping a Docker-specific config or setting Docker defaults such as VSS_BIND_ADDRESS=0.0.0.0:8080 and a network-reachable Postgres address.

Thanks made a couple more passes with codex, see below

Co-authored-by: Leo Nash <hello@leonash.net>

frnandu · 2025-12-29T09:56:04Z

fixes#74

ldk-reviews-bot · 2025-12-29T09:56:07Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-01-01T08:22:52Z

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-03T08:23:44Z

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-05T08:24:34Z

🔔 3rd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tankyleo

Thanks ! can you make this one commit / remove the merge commit in the current PR ?

tankyleo

As mentioned above, let's bring back ca-certificates for HTTPS requests.

Also squash all the commits into a single one.

frnandu · 2026-01-24T15:36:37Z

Also squash all the commits into a single one.

Isn't that possible to do when merging by squash and merge ?

tankyleo · 2026-01-27T22:53:25Z

Isn't that possible to do when merging by squash and merge ?

I need to ACK the exact commit that will get merged, should be quite doable on your side no ?

tankyleo · 2026-01-27T22:53:49Z

@frnandu making sure you see this message above thanks for squashing if you can

frnandu · 2026-02-01T23:07:18Z

Squashed, thanks!

tankyleo

Thanks tested on my machine looks good.

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

frnandu · 2026-02-06T00:32:55Z

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

done

frnandu · 2026-03-27T09:49:56Z

ping?

tankyleo · 2026-06-02T01:37:49Z

@frnandu I cleaned up the branch, used fmar <fmar@fmar.dev> for the author field on the dockerfile commit.

tnull thanks for taking a look I can't merge since I'm the last pusher.

tnull · 2026-06-02T07:50:42Z

+# Copy default configuration file
+COPY server/vss-server-config.toml /app/vss-server-config.toml
+
+EXPOSE 8080


It seems by default this will only bind to localhost. Do we need to set VSS_BIND_ADDRESS to make this work outside of docker/reachable by other docker containers?
[P2] Use container-reachable network defaults — /home/tnull/workspace/vss-server/rust/Dockerfile:40-40
When the image is run with its default CMD, e.g. docker run -p 8080:8080 ..., /app/vss-server-config.toml still binds VSS to 127.0.0.1 and points PostgreSQL at 127.0.0.1. Inside Docker those are container-loopback addresses, so the published port cannot reach the server and Postgres on
another container/host is unreachable unless users override both env vars. Consider shipping a Docker-specific config or setting Docker defaults such as VSS_BIND_ADDRESS=0.0.0.0:8080 and a network-reachable Postgres address.

Thanks made a couple more passes with codex, see below

Co-authored-by: Leo Nash <hello@leonash.net>

frnandu · 2025-12-29T09:56:04Z

fixes#74

ldk-reviews-bot · 2025-12-29T09:56:07Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-01-01T08:22:52Z

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-03T08:23:44Z

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-05T08:24:34Z

🔔 3rd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tankyleo

Thanks ! can you make this one commit / remove the merge commit in the current PR ?

tankyleo

As mentioned above, let's bring back ca-certificates for HTTPS requests.

Also squash all the commits into a single one.

frnandu · 2026-01-24T15:36:37Z

Also squash all the commits into a single one.

Isn't that possible to do when merging by squash and merge ?

tankyleo · 2026-01-27T22:53:25Z

Isn't that possible to do when merging by squash and merge ?

I need to ACK the exact commit that will get merged, should be quite doable on your side no ?

tankyleo · 2026-01-27T22:53:49Z

@frnandu making sure you see this message above thanks for squashing if you can

frnandu · 2026-02-01T23:07:18Z

Squashed, thanks!

tankyleo

Thanks tested on my machine looks good.

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

frnandu · 2026-02-06T00:32:55Z

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

done

frnandu · 2026-03-27T09:49:56Z

ping?

tankyleo · 2026-06-02T01:37:49Z

@frnandu I cleaned up the branch, used fmar <fmar@fmar.dev> for the author field on the dockerfile commit.

tnull thanks for taking a look I can't merge since I'm the last pusher.

tnull · 2026-06-02T07:50:42Z

+# Copy default configuration file
+COPY server/vss-server-config.toml /app/vss-server-config.toml
+
+EXPOSE 8080


It seems by default this will only bind to localhost. Do we need to set VSS_BIND_ADDRESS to make this work outside of docker/reachable by other docker containers?
[P2] Use container-reachable network defaults — /home/tnull/workspace/vss-server/rust/Dockerfile:40-40
When the image is run with its default CMD, e.g. docker run -p 8080:8080 ..., /app/vss-server-config.toml still binds VSS to 127.0.0.1 and points PostgreSQL at 127.0.0.1. Inside Docker those are container-loopback addresses, so the published port cannot reach the server and Postgres on
another container/host is unreachable unless users override both env vars. Consider shipping a Docker-specific config or setting Docker defaults such as VSS_BIND_ADDRESS=0.0.0.0:8080 and a network-reachable Postgres address.

Thanks made a couple more passes with codex, see below

Co-authored-by: Leo Nash <hello@leonash.net>

frnandu · 2025-12-29T09:56:04Z

fixes#74

ldk-reviews-bot · 2025-12-29T09:56:07Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-01-01T08:22:52Z

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-03T08:23:44Z

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-05T08:24:34Z

🔔 3rd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tankyleo

Thanks ! can you make this one commit / remove the merge commit in the current PR ?

tankyleo

As mentioned above, let's bring back ca-certificates for HTTPS requests.

Also squash all the commits into a single one.

frnandu · 2026-01-24T15:36:37Z

Also squash all the commits into a single one.

Isn't that possible to do when merging by squash and merge ?

tankyleo · 2026-01-27T22:53:25Z

Isn't that possible to do when merging by squash and merge ?

I need to ACK the exact commit that will get merged, should be quite doable on your side no ?

tankyleo · 2026-01-27T22:53:49Z

@frnandu making sure you see this message above thanks for squashing if you can

frnandu · 2026-02-01T23:07:18Z

Squashed, thanks!

tankyleo

Thanks tested on my machine looks good.

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

frnandu · 2026-02-06T00:32:55Z

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

done

frnandu · 2026-03-27T09:49:56Z

ping?

tankyleo · 2026-06-02T01:37:49Z

@frnandu I cleaned up the branch, used fmar <fmar@fmar.dev> for the author field on the dockerfile commit.

tnull thanks for taking a look I can't merge since I'm the last pusher.

tnull · 2026-06-02T07:50:42Z

+# Copy default configuration file
+COPY server/vss-server-config.toml /app/vss-server-config.toml
+
+EXPOSE 8080


It seems by default this will only bind to localhost. Do we need to set VSS_BIND_ADDRESS to make this work outside of docker/reachable by other docker containers?
[P2] Use container-reachable network defaults — /home/tnull/workspace/vss-server/rust/Dockerfile:40-40
When the image is run with its default CMD, e.g. docker run -p 8080:8080 ..., /app/vss-server-config.toml still binds VSS to 127.0.0.1 and points PostgreSQL at 127.0.0.1. Inside Docker those are container-loopback addresses, so the published port cannot reach the server and Postgres on
another container/host is unreachable unless users override both env vars. Consider shipping a Docker-specific config or setting Docker defaults such as VSS_BIND_ADDRESS=0.0.0.0:8080 and a network-reachable Postgres address.

Thanks made a couple more passes with codex, see below

Co-authored-by: Leo Nash <hello@leonash.net>

frnandu · 2025-12-29T09:56:04Z

fixes#74

ldk-reviews-bot · 2025-12-29T09:56:07Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-01-01T08:22:52Z

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-03T08:23:44Z

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-05T08:24:34Z

🔔 3rd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tankyleo

Thanks ! can you make this one commit / remove the merge commit in the current PR ?

tankyleo

As mentioned above, let's bring back ca-certificates for HTTPS requests.

Also squash all the commits into a single one.

frnandu · 2026-01-24T15:36:37Z

Also squash all the commits into a single one.

Isn't that possible to do when merging by squash and merge ?

tankyleo · 2026-01-27T22:53:25Z

Isn't that possible to do when merging by squash and merge ?

I need to ACK the exact commit that will get merged, should be quite doable on your side no ?

tankyleo · 2026-01-27T22:53:49Z

@frnandu making sure you see this message above thanks for squashing if you can

frnandu · 2026-02-01T23:07:18Z

Squashed, thanks!

tankyleo

Thanks tested on my machine looks good.

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

frnandu · 2026-02-06T00:32:55Z

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

done

frnandu · 2026-03-27T09:49:56Z

ping?

tankyleo · 2026-06-02T01:37:49Z

@frnandu I cleaned up the branch, used fmar <fmar@fmar.dev> for the author field on the dockerfile commit.

tnull thanks for taking a look I can't merge since I'm the last pusher.

tnull · 2026-06-02T07:50:42Z

+# Copy default configuration file
+COPY server/vss-server-config.toml /app/vss-server-config.toml
+
+EXPOSE 8080


It seems by default this will only bind to localhost. Do we need to set VSS_BIND_ADDRESS to make this work outside of docker/reachable by other docker containers?
[P2] Use container-reachable network defaults — /home/tnull/workspace/vss-server/rust/Dockerfile:40-40
When the image is run with its default CMD, e.g. docker run -p 8080:8080 ..., /app/vss-server-config.toml still binds VSS to 127.0.0.1 and points PostgreSQL at 127.0.0.1. Inside Docker those are container-loopback addresses, so the published port cannot reach the server and Postgres on
another container/host is unreachable unless users override both env vars. Consider shipping a Docker-specific config or setting Docker defaults such as VSS_BIND_ADDRESS=0.0.0.0:8080 and a network-reachable Postgres address.

Thanks made a couple more passes with codex, see below

Co-authored-by: Leo Nash <hello@leonash.net>

frnandu · 2025-12-29T09:56:04Z

fixes#74

ldk-reviews-bot · 2025-12-29T09:56:07Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-01-01T08:22:52Z

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-03T08:23:44Z

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-05T08:24:34Z

🔔 3rd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tankyleo

Thanks ! can you make this one commit / remove the merge commit in the current PR ?

tankyleo

As mentioned above, let's bring back ca-certificates for HTTPS requests.

Also squash all the commits into a single one.

frnandu · 2026-01-24T15:36:37Z

Also squash all the commits into a single one.

Isn't that possible to do when merging by squash and merge ?

tankyleo · 2026-01-27T22:53:25Z

Isn't that possible to do when merging by squash and merge ?

I need to ACK the exact commit that will get merged, should be quite doable on your side no ?

tankyleo · 2026-01-27T22:53:49Z

@frnandu making sure you see this message above thanks for squashing if you can

frnandu · 2026-02-01T23:07:18Z

Squashed, thanks!

tankyleo

Thanks tested on my machine looks good.

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

frnandu · 2026-02-06T00:32:55Z

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

done

frnandu · 2026-03-27T09:49:56Z

ping?

tankyleo · 2026-06-02T01:37:49Z

@frnandu I cleaned up the branch, used fmar <fmar@fmar.dev> for the author field on the dockerfile commit.

tnull thanks for taking a look I can't merge since I'm the last pusher.

tnull · 2026-06-02T07:50:42Z

+# Copy default configuration file
+COPY server/vss-server-config.toml /app/vss-server-config.toml
+
+EXPOSE 8080


It seems by default this will only bind to localhost. Do we need to set VSS_BIND_ADDRESS to make this work outside of docker/reachable by other docker containers?
[P2] Use container-reachable network defaults — /home/tnull/workspace/vss-server/rust/Dockerfile:40-40
When the image is run with its default CMD, e.g. docker run -p 8080:8080 ..., /app/vss-server-config.toml still binds VSS to 127.0.0.1 and points PostgreSQL at 127.0.0.1. Inside Docker those are container-loopback addresses, so the published port cannot reach the server and Postgres on
another container/host is unreachable unless users override both env vars. Consider shipping a Docker-specific config or setting Docker defaults such as VSS_BIND_ADDRESS=0.0.0.0:8080 and a network-reachable Postgres address.

Thanks made a couple more passes with codex, see below

Co-authored-by: Leo Nash <hello@leonash.net>

frnandu · 2025-12-29T09:56:04Z

fixes#74

ldk-reviews-bot · 2025-12-29T09:56:07Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-01-01T08:22:52Z

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-03T08:23:44Z

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-05T08:24:34Z

🔔 3rd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tankyleo

Thanks ! can you make this one commit / remove the merge commit in the current PR ?

tankyleo

As mentioned above, let's bring back ca-certificates for HTTPS requests.

Also squash all the commits into a single one.

frnandu · 2026-01-24T15:36:37Z

Also squash all the commits into a single one.

Isn't that possible to do when merging by squash and merge ?

tankyleo · 2026-01-27T22:53:25Z

Isn't that possible to do when merging by squash and merge ?

I need to ACK the exact commit that will get merged, should be quite doable on your side no ?

tankyleo · 2026-01-27T22:53:49Z

@frnandu making sure you see this message above thanks for squashing if you can

frnandu · 2026-02-01T23:07:18Z

Squashed, thanks!

tankyleo

Thanks tested on my machine looks good.

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

frnandu · 2026-02-06T00:32:55Z

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

done

frnandu · 2026-03-27T09:49:56Z

ping?

tankyleo · 2026-06-02T01:37:49Z

@frnandu I cleaned up the branch, used fmar <fmar@fmar.dev> for the author field on the dockerfile commit.

tnull thanks for taking a look I can't merge since I'm the last pusher.

tnull · 2026-06-02T07:50:42Z

+# Copy default configuration file
+COPY server/vss-server-config.toml /app/vss-server-config.toml
+
+EXPOSE 8080


It seems by default this will only bind to localhost. Do we need to set VSS_BIND_ADDRESS to make this work outside of docker/reachable by other docker containers?
[P2] Use container-reachable network defaults — /home/tnull/workspace/vss-server/rust/Dockerfile:40-40
When the image is run with its default CMD, e.g. docker run -p 8080:8080 ..., /app/vss-server-config.toml still binds VSS to 127.0.0.1 and points PostgreSQL at 127.0.0.1. Inside Docker those are container-loopback addresses, so the published port cannot reach the server and Postgres on
another container/host is unreachable unless users override both env vars. Consider shipping a Docker-specific config or setting Docker defaults such as VSS_BIND_ADDRESS=0.0.0.0:8080 and a network-reachable Postgres address.

Thanks made a couple more passes with codex, see below

Co-authored-by: Leo Nash <hello@leonash.net>

frnandu · 2025-12-29T09:56:04Z

fixes#74

ldk-reviews-bot · 2025-12-29T09:56:07Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot · 2026-01-01T08:22:52Z

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-03T08:23:44Z

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-05T08:24:34Z

🔔 3rd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tankyleo

Thanks ! can you make this one commit / remove the merge commit in the current PR ?

tankyleo

As mentioned above, let's bring back ca-certificates for HTTPS requests.

Also squash all the commits into a single one.

frnandu · 2026-01-24T15:36:37Z

Also squash all the commits into a single one.

Isn't that possible to do when merging by squash and merge ?

tankyleo · 2026-01-27T22:53:25Z

Isn't that possible to do when merging by squash and merge ?

I need to ACK the exact commit that will get merged, should be quite doable on your side no ?

tankyleo · 2026-01-27T22:53:49Z

@frnandu making sure you see this message above thanks for squashing if you can

frnandu · 2026-02-01T23:07:18Z

Squashed, thanks!

tankyleo

Thanks tested on my machine looks good.

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

frnandu · 2026-02-06T00:32:55Z

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

done

frnandu · 2026-03-27T09:49:56Z

ping?

tankyleo · 2026-06-02T01:37:49Z

@frnandu I cleaned up the branch, used fmar <fmar@fmar.dev> for the author field on the dockerfile commit.

tnull thanks for taking a look I can't merge since I'm the last pusher.

tnull · 2026-06-02T07:50:42Z

+# Copy default configuration file
+COPY server/vss-server-config.toml /app/vss-server-config.toml
+
+EXPOSE 8080


It seems by default this will only bind to localhost. Do we need to set VSS_BIND_ADDRESS to make this work outside of docker/reachable by other docker containers?
[P2] Use container-reachable network defaults — /home/tnull/workspace/vss-server/rust/Dockerfile:40-40
When the image is run with its default CMD, e.g. docker run -p 8080:8080 ..., /app/vss-server-config.toml still binds VSS to 127.0.0.1 and points PostgreSQL at 127.0.0.1. Inside Docker those are container-loopback addresses, so the published port cannot reach the server and Postgres on
another container/host is unreachable unless users override both env vars. Consider shipping a Docker-specific config or setting Docker defaults such as VSS_BIND_ADDRESS=0.0.0.0:8080 and a network-reachable Postgres address.

Thanks made a couple more passes with codex, see below

Co-authored-by: Leo Nash <hello@leonash.net>

ldk-reviews-bot requested a review from jkczyz December 29, 2025 10:06

tnull requested review from tankyleo and removed request for jkczyz December 30, 2025 08:22

tankyleo reviewed Jan 7, 2026
View reviewed changes

Comment threadrust/Dockerfile
Comment threadrust/Dockerfile
Comment threadrust/Dockerfile Outdated
Comment threadrust/Dockerfile Outdated

frnandu changed the title ~~Chore/rust dockerfile~~chore: rust dockerfileJan 15, 2026

tankyleo reviewed Jan 17, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch 3 times, most recently from fcec5ff to 2336a2dCompare January 24, 2026 15:35

frnandu force-pushed the chore/rust-dockerfile branch from 2336a2d to 7f34829Compare February 1, 2026 23:06

tankyleo reviewed Feb 2, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch from 7f34829 to 2bbc54cCompare February 6, 2026 00:32

frnandu changed the title ~~chore: rust dockerfile~~Add rust DockerfileApr 24, 2026

Upgrade bitcoin_hashes to 1.0
c4c26ba

tankyleo force-pushed the chore/rust-dockerfile branch from 2bbc54c to 834b6b9Compare June 2, 2026 01:29

tankyleo previously approved these changes Jun 2, 2026
View reviewed changes

tankyleo requested a review from tnull June 2, 2026 01:37

tnull reviewed Jun 2, 2026
View reviewed changes

Add Dockerfile
71506ab
Co-authored-by: Leo Nash <hello@leonash.net>

Add vss-server to docker-compose.yml
e9df9b6

tankyleo dismissed their stale review via e9df9b6June 2, 2026 15:14

tankyleo force-pushed the chore/rust-dockerfile branch from 834b6b9 to e9df9b6Compare June 2, 2026 15:14

tankyleo requested a review from tnull June 2, 2026 15:27

tnull approved these changes Jun 2, 2026
View reviewed changes

tnull merged commit 5dca68b into lightningdevkit:mainJun 2, 2026
8 checks passed

tnull mentioned this pull request Jun 2, 2026
Delete the java implementation of vss-server #101
Merged

ldk-reviews-bot requested a review from jkczyz December 29, 2025 10:06

tnull requested review from tankyleo and removed request for jkczyz December 30, 2025 08:22

tankyleo reviewed Jan 7, 2026
View reviewed changes

Comment threadrust/Dockerfile
Comment threadrust/Dockerfile
Comment threadrust/Dockerfile Outdated
Comment threadrust/Dockerfile Outdated

frnandu changed the title ~~Chore/rust dockerfile~~chore: rust dockerfileJan 15, 2026

tankyleo reviewed Jan 17, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch 3 times, most recently from fcec5ff to 2336a2dCompare January 24, 2026 15:35

frnandu force-pushed the chore/rust-dockerfile branch from 2336a2d to 7f34829Compare February 1, 2026 23:06

tankyleo reviewed Feb 2, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch from 7f34829 to 2bbc54cCompare February 6, 2026 00:32

frnandu changed the title ~~chore: rust dockerfile~~Add rust DockerfileApr 24, 2026

Upgrade bitcoin_hashes to 1.0
c4c26ba

tankyleo force-pushed the chore/rust-dockerfile branch from 2bbc54c to 834b6b9Compare June 2, 2026 01:29

tankyleo previously approved these changes Jun 2, 2026
View reviewed changes

tankyleo requested a review from tnull June 2, 2026 01:37

tnull reviewed Jun 2, 2026
View reviewed changes

Add Dockerfile
71506ab
Co-authored-by: Leo Nash <hello@leonash.net>

Add vss-server to docker-compose.yml
e9df9b6

tankyleo dismissed their stale review via e9df9b6June 2, 2026 15:14

tankyleo force-pushed the chore/rust-dockerfile branch from 834b6b9 to e9df9b6Compare June 2, 2026 15:14

tankyleo requested a review from tnull June 2, 2026 15:27

tnull approved these changes Jun 2, 2026
View reviewed changes

tnull merged commit 5dca68b into lightningdevkit:mainJun 2, 2026
8 checks passed

tnull mentioned this pull request Jun 2, 2026
Delete the java implementation of vss-server #101
Merged

ldk-reviews-bot requested a review from jkczyz December 29, 2025 10:06

tnull requested review from tankyleo and removed request for jkczyz December 30, 2025 08:22

tankyleo reviewed Jan 7, 2026
View reviewed changes

Comment threadrust/Dockerfile
Comment threadrust/Dockerfile
Comment threadrust/Dockerfile Outdated
Comment threadrust/Dockerfile Outdated

frnandu changed the title ~~Chore/rust dockerfile~~chore: rust dockerfileJan 15, 2026

tankyleo reviewed Jan 17, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch 3 times, most recently from fcec5ff to 2336a2dCompare January 24, 2026 15:35

frnandu force-pushed the chore/rust-dockerfile branch from 2336a2d to 7f34829Compare February 1, 2026 23:06

tankyleo reviewed Feb 2, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch from 7f34829 to 2bbc54cCompare February 6, 2026 00:32

frnandu changed the title ~~chore: rust dockerfile~~Add rust DockerfileApr 24, 2026

Upgrade bitcoin_hashes to 1.0
c4c26ba

tankyleo force-pushed the chore/rust-dockerfile branch from 2bbc54c to 834b6b9Compare June 2, 2026 01:29

tankyleo previously approved these changes Jun 2, 2026
View reviewed changes

tankyleo requested a review from tnull June 2, 2026 01:37

tnull reviewed Jun 2, 2026
View reviewed changes

Add Dockerfile
71506ab
Co-authored-by: Leo Nash <hello@leonash.net>

Add vss-server to docker-compose.yml
e9df9b6

tankyleo dismissed their stale review via e9df9b6June 2, 2026 15:14

tankyleo force-pushed the chore/rust-dockerfile branch from 834b6b9 to e9df9b6Compare June 2, 2026 15:14

tankyleo requested a review from tnull June 2, 2026 15:27

tnull approved these changes Jun 2, 2026
View reviewed changes

tnull merged commit 5dca68b into lightningdevkit:mainJun 2, 2026
8 checks passed

tnull mentioned this pull request Jun 2, 2026
Delete the java implementation of vss-server #101
Merged

ldk-reviews-bot requested a review from jkczyz December 29, 2025 10:06

tnull requested review from tankyleo and removed request for jkczyz December 30, 2025 08:22

tankyleo reviewed Jan 7, 2026
View reviewed changes

Comment threadrust/Dockerfile
Comment threadrust/Dockerfile
Comment threadrust/Dockerfile Outdated
Comment threadrust/Dockerfile Outdated

frnandu changed the title ~~Chore/rust dockerfile~~chore: rust dockerfileJan 15, 2026

tankyleo reviewed Jan 17, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch 3 times, most recently from fcec5ff to 2336a2dCompare January 24, 2026 15:35

frnandu force-pushed the chore/rust-dockerfile branch from 2336a2d to 7f34829Compare February 1, 2026 23:06

tankyleo reviewed Feb 2, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch from 7f34829 to 2bbc54cCompare February 6, 2026 00:32

frnandu changed the title ~~chore: rust dockerfile~~Add rust DockerfileApr 24, 2026

Upgrade bitcoin_hashes to 1.0
c4c26ba

tankyleo force-pushed the chore/rust-dockerfile branch from 2bbc54c to 834b6b9Compare June 2, 2026 01:29

tankyleo previously approved these changes Jun 2, 2026
View reviewed changes

tankyleo requested a review from tnull June 2, 2026 01:37

tnull reviewed Jun 2, 2026
View reviewed changes

Add Dockerfile
71506ab
Co-authored-by: Leo Nash <hello@leonash.net>

Add vss-server to docker-compose.yml
e9df9b6

tankyleo dismissed their stale review via e9df9b6June 2, 2026 15:14

tankyleo force-pushed the chore/rust-dockerfile branch from 834b6b9 to e9df9b6Compare June 2, 2026 15:14

tankyleo requested a review from tnull June 2, 2026 15:27

tnull approved these changes Jun 2, 2026
View reviewed changes

tnull merged commit 5dca68b into lightningdevkit:mainJun 2, 2026
8 checks passed

tnull mentioned this pull request Jun 2, 2026
Delete the java implementation of vss-server #101
Merged

ldk-reviews-bot requested a review from jkczyz December 29, 2025 10:06

tnull requested review from tankyleo and removed request for jkczyz December 30, 2025 08:22

tankyleo reviewed Jan 7, 2026
View reviewed changes

Comment threadrust/Dockerfile
Comment threadrust/Dockerfile
Comment threadrust/Dockerfile Outdated
Comment threadrust/Dockerfile Outdated

frnandu changed the title ~~Chore/rust dockerfile~~chore: rust dockerfileJan 15, 2026

tankyleo reviewed Jan 17, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch 3 times, most recently from fcec5ff to 2336a2dCompare January 24, 2026 15:35

frnandu force-pushed the chore/rust-dockerfile branch from 2336a2d to 7f34829Compare February 1, 2026 23:06

tankyleo reviewed Feb 2, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch from 7f34829 to 2bbc54cCompare February 6, 2026 00:32

frnandu changed the title ~~chore: rust dockerfile~~Add rust DockerfileApr 24, 2026

Upgrade bitcoin_hashes to 1.0
c4c26ba

tankyleo force-pushed the chore/rust-dockerfile branch from 2bbc54c to 834b6b9Compare June 2, 2026 01:29

tankyleo previously approved these changes Jun 2, 2026
View reviewed changes

tankyleo requested a review from tnull June 2, 2026 01:37

tnull reviewed Jun 2, 2026
View reviewed changes

Add Dockerfile
71506ab
Co-authored-by: Leo Nash <hello@leonash.net>

Add vss-server to docker-compose.yml
e9df9b6

tankyleo dismissed their stale review via e9df9b6June 2, 2026 15:14

tankyleo force-pushed the chore/rust-dockerfile branch from 834b6b9 to e9df9b6Compare June 2, 2026 15:14

tankyleo requested a review from tnull June 2, 2026 15:27

tnull approved these changes Jun 2, 2026
View reviewed changes

tnull merged commit 5dca68b into lightningdevkit:mainJun 2, 2026
8 checks passed

tnull mentioned this pull request Jun 2, 2026
Delete the java implementation of vss-server #101
Merged

ldk-reviews-bot requested a review from jkczyz December 29, 2025 10:06

tnull requested review from tankyleo and removed request for jkczyz December 30, 2025 08:22

tankyleo reviewed Jan 7, 2026
View reviewed changes

Comment threadrust/Dockerfile
Comment threadrust/Dockerfile
Comment threadrust/Dockerfile Outdated
Comment threadrust/Dockerfile Outdated

frnandu changed the title ~~Chore/rust dockerfile~~chore: rust dockerfileJan 15, 2026

tankyleo reviewed Jan 17, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch 3 times, most recently from fcec5ff to 2336a2dCompare January 24, 2026 15:35

frnandu force-pushed the chore/rust-dockerfile branch from 2336a2d to 7f34829Compare February 1, 2026 23:06

tankyleo reviewed Feb 2, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch from 7f34829 to 2bbc54cCompare February 6, 2026 00:32

frnandu changed the title ~~chore: rust dockerfile~~Add rust DockerfileApr 24, 2026

Upgrade bitcoin_hashes to 1.0
c4c26ba

tankyleo force-pushed the chore/rust-dockerfile branch from 2bbc54c to 834b6b9Compare June 2, 2026 01:29

tankyleo previously approved these changes Jun 2, 2026
View reviewed changes

tankyleo requested a review from tnull June 2, 2026 01:37

tnull reviewed Jun 2, 2026
View reviewed changes

Add Dockerfile
71506ab
Co-authored-by: Leo Nash <hello@leonash.net>

Add vss-server to docker-compose.yml
e9df9b6

tankyleo dismissed their stale review via e9df9b6June 2, 2026 15:14

tankyleo force-pushed the chore/rust-dockerfile branch from 834b6b9 to e9df9b6Compare June 2, 2026 15:14

tankyleo requested a review from tnull June 2, 2026 15:27

tnull approved these changes Jun 2, 2026
View reviewed changes

tnull merged commit 5dca68b into lightningdevkit:mainJun 2, 2026
8 checks passed

tnull mentioned this pull request Jun 2, 2026
Delete the java implementation of vss-server #101
Merged

ldk-reviews-bot requested a review from jkczyz December 29, 2025 10:06

tnull requested review from tankyleo and removed request for jkczyz December 30, 2025 08:22

tankyleo reviewed Jan 7, 2026
View reviewed changes

Comment threadrust/Dockerfile
Comment threadrust/Dockerfile
Comment threadrust/Dockerfile Outdated
Comment threadrust/Dockerfile Outdated

frnandu changed the title ~~Chore/rust dockerfile~~chore: rust dockerfileJan 15, 2026

tankyleo reviewed Jan 17, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch 3 times, most recently from fcec5ff to 2336a2dCompare January 24, 2026 15:35

frnandu force-pushed the chore/rust-dockerfile branch from 2336a2d to 7f34829Compare February 1, 2026 23:06

tankyleo reviewed Feb 2, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch from 7f34829 to 2bbc54cCompare February 6, 2026 00:32

frnandu changed the title ~~chore: rust dockerfile~~Add rust DockerfileApr 24, 2026

Upgrade bitcoin_hashes to 1.0
c4c26ba

tankyleo force-pushed the chore/rust-dockerfile branch from 2bbc54c to 834b6b9Compare June 2, 2026 01:29

tankyleo previously approved these changes Jun 2, 2026
View reviewed changes

tankyleo requested a review from tnull June 2, 2026 01:37

tnull reviewed Jun 2, 2026
View reviewed changes

Add Dockerfile
71506ab
Co-authored-by: Leo Nash <hello@leonash.net>

Add vss-server to docker-compose.yml
e9df9b6

tankyleo dismissed their stale review via e9df9b6June 2, 2026 15:14

tankyleo force-pushed the chore/rust-dockerfile branch from 834b6b9 to e9df9b6Compare June 2, 2026 15:14

tankyleo requested a review from tnull June 2, 2026 15:27

tnull approved these changes Jun 2, 2026
View reviewed changes

tnull merged commit 5dca68b into lightningdevkit:mainJun 2, 2026
8 checks passed

tnull mentioned this pull request Jun 2, 2026
Delete the java implementation of vss-server #101
Merged

ldk-reviews-bot requested a review from jkczyz December 29, 2025 10:06

tnull requested review from tankyleo and removed request for jkczyz December 30, 2025 08:22

tankyleo reviewed Jan 7, 2026
View reviewed changes

Comment threadrust/Dockerfile
Comment threadrust/Dockerfile
Comment threadrust/Dockerfile Outdated
Comment threadrust/Dockerfile Outdated

frnandu changed the title ~~Chore/rust dockerfile~~chore: rust dockerfileJan 15, 2026

tankyleo reviewed Jan 17, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch 3 times, most recently from fcec5ff to 2336a2dCompare January 24, 2026 15:35

frnandu force-pushed the chore/rust-dockerfile branch from 2336a2d to 7f34829Compare February 1, 2026 23:06

tankyleo reviewed Feb 2, 2026
View reviewed changes

frnandu force-pushed the chore/rust-dockerfile branch from 7f34829 to 2bbc54cCompare February 6, 2026 00:32

frnandu changed the title ~~chore: rust dockerfile~~Add rust DockerfileApr 24, 2026

Upgrade bitcoin_hashes to 1.0
c4c26ba

tankyleo force-pushed the chore/rust-dockerfile branch from 2bbc54c to 834b6b9Compare June 2, 2026 01:29

tankyleo previously approved these changes Jun 2, 2026
View reviewed changes

tankyleo requested a review from tnull June 2, 2026 01:37

tnull reviewed Jun 2, 2026
View reviewed changes

Add Dockerfile
71506ab
Co-authored-by: Leo Nash <hello@leonash.net>

Add vss-server to docker-compose.yml
e9df9b6

tankyleo dismissed their stale review via e9df9b6June 2, 2026 15:14

tankyleo force-pushed the chore/rust-dockerfile branch from 834b6b9 to e9df9b6Compare June 2, 2026 15:14

tankyleo requested a review from tnull June 2, 2026 15:27

tnull approved these changes Jun 2, 2026
View reviewed changes

tnull merged commit 5dca68b into lightningdevkit:mainJun 2, 2026
8 checks passed

tnull mentioned this pull request Jun 2, 2026
Delete the java implementation of vss-server #101
Merged

Uh oh!

Conversation

frnandu commented Dec 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Dec 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Jan 1, 2026

Uh oh!

ldk-reviews-bot commented Jan 3, 2026

Uh oh!

ldk-reviews-bot commented Jan 5, 2026

Uh oh!

tankyleo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tankyleo left a comment

Choose a reason for hiding this comment

Uh oh!

frnandu commented Jan 24, 2026

Uh oh!

tankyleo commented Jan 27, 2026

Uh oh!

tankyleo commented Jan 27, 2026

Uh oh!

frnandu commented Feb 1, 2026

Uh oh!

tankyleo left a comment

Choose a reason for hiding this comment

Uh oh!

frnandu commented Feb 6, 2026

Uh oh!

frnandu commented Mar 27, 2026

Uh oh!

tankyleo commented Jun 2, 2026

Uh oh!

tnullJun 2, 2026

Choose a reason for hiding this comment

Uh oh!

tankyleoJun 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

frnandu commented Dec 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Dec 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Jan 1, 2026

Uh oh!

ldk-reviews-bot commented Jan 3, 2026

Uh oh!

ldk-reviews-bot commented Jan 5, 2026

Uh oh!

tankyleo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tankyleo left a comment

Choose a reason for hiding this comment

Uh oh!

frnandu commented Dec 29, 2025•
edited
Loading

ldk-reviews-bot commented Dec 29, 2025•
edited
Loading

frnandu commented Dec 29, 2025•
edited
Loading

ldk-reviews-bot commented Dec 29, 2025•
edited
Loading

frnandu commented Dec 29, 2025•
edited
Loading

ldk-reviews-bot commented Dec 29, 2025•
edited
Loading