Skip to content

config: create all directories - #4622

Merged
cfromknecht merged 1 commit into
lightningnetwork:masterfrom
guggero:config-mkdir
Sep 18, 2020
Merged

cfromknecht merged 1 commit into
lightningnetwork:masterfrom
guggero:config-mkdir

Conversation

@guggero

@guggero guggero commented Sep 16, 2020

Copy link
Copy Markdown
Collaborator

Fixes #4572.

With this PR we make sure that all directories where lnd could
potentially want to write files to are created on startup. This fixes
the case where the lnddir isn't set but all other paths point to
explicit locations with non-existend parent directories.

We don't create the log dir as that's done by the log rotator already.

@guggero
guggero requested review from Crypt-iQ and halseth September 16, 2020 13:12
@guggero guggero added bug fix config Parameters/arguments/config file related issues/PRs v0.12 labels Sep 16, 2020
@guggero guggero added this to the 0.12.0 milestone Sep 16, 2020

@cfromknecht cfromknecht left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix!

Comment thread config.go Outdated
Comment thread config.go Outdated

@halseth halseth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

With this commit we make sure that all directories where lnd could
potentially want to write files to are created on startup. This fixes
the case where the lnddir isn't set but all other paths point to
explicit locations with non-existend parent directories.

We don't create the log dir as that's done by the log rotator already.

@cfromknecht cfromknecht left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@cfromknecht
cfromknecht merged commit 98da919 into lightningnetwork:master Sep 18, 2020
@guggero
guggero deleted the config-mkdir branch September 19, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix config Parameters/arguments/config file related issues/PRs v0.12

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LND will not create path specified by --tlscertpath

3 participants