fix/UI state persistence across tab switches - #180
Merged
lightningpixel merged 4 commits intoAug 18, 2026
Conversation
iammojogo-sudo
marked this pull request as draft
June 23, 2026 16:50
iammojogo-sudoforce-pushed
the
ui-communication-fixes
branch
from
June 23, 2026 17:00
4b97015 to
a402f0eCompareiammojogo-sudo
marked this pull request as ready for review
June 23, 2026 17:01
iammojogo-sudoforce-pushed
the
ui-communication-fixes
branch
from
June 24, 2026 18:17
a402f0e to
1358ca7Compare…xel#180 The new sync effects referenced identifiers that do not exist, so both editors crashed as soon as an external save bumped updatedAt: - WorkflowPanel: setEdges was never destructured from useEdgesState - WorkflowsPage: setName has no counterpart in WorkflowCanvasInner (renaming is handled at page level via renameTarget/handleRename) Also: - WorkflowsPage kept the debounce cleanup despite the comment claiming otherwise, so switching tabs within 500 ms dropped the edit. The pending save is now flushed on unmount instead of cancelled. - The saved-at claim is rolled back when the write fails, so a failed save no longer replaces the canvas with the last persisted version. - handleGenerate / handleRun now claim their own save and drop the pending debounce, instead of triggering a resync + redundant write that could clobber input typed during the IPC round-trip. - Restore the monotonic progress guard in generation.py: the loading phase walks the bar to 7 on a background thread and extensions then report their own 0-100 scale, so an unguarded assignment yanked the bar backwards. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Keeps the raw line as emitted by the extension, as before lightningpixel#180. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
lightningpixel
approved these changes
Aug 18, 2026
iammojogo-sudo
commented
Aug 19, 2026
ContributorAuthor
Cheers my friend! I hope that update is helpful for others :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes UI state being lost when switching between tabs.
navigating away and back, instead of disappearing mid-install.
Workspace and Generate views, and aren't dropped when switching
tabs before the autosave completes.
Four files changed: api/routers/generation.py, ModelsPage.tsx, WorkflowsPage.tsx, WorkflowPanel.tsx.
No changes to node input handling or anything extension-facing.