Uh oh!
There was an error while loading. Please reload this page.
chore: Sync account schemas - #334
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-openapistudio · code · diff
✅ grid-kotlinstudio · code · diff
|
Greptile SummaryThis PR adds Confidence Score: 5/5This PR is safe to merge — changes are clean, consistent, and the build artifacts are correctly regenerated. All schema changes are uniform and correctly structured. Generated bundles match the source. No broken examples, no missing constraints, no logic issues. All remaining observations are P2 or lower. No files require special attention.
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/BdtAccountInfo.yaml | Adds bankName as a required field with proper string constraints (minLength 1, maxLength 255); correctly positioned in required list and properties. |
| openapi/components/schemas/common/CopAccountInfo.yaml | Adds bankName as a required field with consistent placement and constraints, matching the pattern used across other currency schemas in this PR. |
| openapi/components/schemas/common/EgpAccountInfo.yaml | Adds bankName as a required field; consistent with the rest of the PR changes. |
| openapi/components/schemas/common/GhsAccountInfo.yaml | Adds bankName as a required field; consistent with the rest of the PR changes. |
| openapi/components/schemas/common/GtqAccountInfo.yaml | Adds bankName as a required field; consistent with the rest of the PR changes. |
| openapi/components/schemas/common/JmdAccountInfo.yaml | Adds bankName as a required field; consistent with the rest of the PR changes. |
| openapi/components/schemas/common/PkrAccountInfo.yaml | Adds bankName as a required field; consistent with the rest of the PR changes. |
| openapi/components/schemas/common/UsdAccountInfo.yaml | Adds bankName as a required field appended at the end of both required list and properties; minor ordering difference vs. other schemas but functionally correct, and existing USD examples in path files already include bankName. |
| openapi.yaml | Correctly regenerated bundle reflecting all bankName additions across all affected currency schemas. |
| mintlify/openapi.yaml | Correctly regenerated Mintlify copy of the bundle; consistent with openapi.yaml. |
Entity Relationship Diagram
%%{init: {'theme': 'neutral'}}%%
erDiagram
BdtAccountInfo {
string accountType
array paymentRails
string bankName "NEW - required"
string accountNumber
string branchCode
string phoneNumber
string swiftCode
}
CopAccountInfo {
string accountType
array paymentRails
string bankName "NEW - required"
string accountNumber
string bankAccountType
string phoneNumber
}
EgpAccountInfo {
string accountType
array paymentRails
string bankName "NEW - required"
string accountNumber
}
GhsAccountInfo {
string accountType
array paymentRails
string bankName "NEW - required"
string accountNumber
string phoneNumber
}
GtqAccountInfo {
string accountType
array paymentRails
string bankName "NEW - required"
string accountNumber
string phoneNumber
}
JmdAccountInfo {
string accountType
array paymentRails
string bankName "NEW - required"
string accountNumber
string branchCode
string bankAccountType
}
PkrAccountInfo {
string accountType
array paymentRails
string bankName "NEW - required"
string accountNumber
string phoneNumber
}
UsdAccountInfo {
string accountType
array paymentRails
string accountNumber
string routingNumber
string bankName "NEW - required"
}
Reviews (1): Last reviewed commit: "chore: Sync account schemas" | Re-trigger Greptile
Superseded by #346 |
Auto-synced account schemas.
These schemas are generated from VASP adapter field definitions in sparkcore.
Synced schemas:
common/— per-currency account info, beneficiary, and payment account schemascommon/PaymentInstructions.yaml— payment instructions oneOf (new currencies added)external_accounts/— per-currency external account schemas (reference common/)Please review the changes before merging.