chore: Sync account schemas#384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lightspark-copybara wants to merge 1 commit into from
Closed

chore: Sync account schemas #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,814 changes: 1,272 additions & 542 deletions mintlify/openapi.yaml
View file
Open in desktop

Large diffs are not rendered by default.

1,814 changes: 1,272 additions & 542 deletions openapi.yaml
View file
Open in desktop

Large diffs are not rendered by default.

42 changes: 30 additions & 12 deletions openapi/components/schemas/common/AedAccountInfo.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,30 @@
allOf:
- $ref: ./AedAccountInfoBase.yaml
- type: object
required:
- paymentRails
properties:
paymentRails:
type: array
items:
type: string
enum:
- BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- iban
properties:
accountType:
type: string
enum:
- AED_ACCOUNT
paymentRails:
type: array
items:
type: string
enum:
- BANK_TRANSFER
iban:
type: string
description: UAE IBAN (23 characters, starting with AE)
example: AE070331234567890123456
minLength: 23
maxLength: 23
pattern: ^AE[0-9]{21}$
swiftCode:
type: string
description: The SWIFT/BIC code of the bank
example: EBILAEAD
minLength: 8
maxLength: 11
pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
63 changes: 50 additions & 13 deletions openapi/components/schemas/common/BdtAccountInfo.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,50 @@
allOf:
- $ref: ./BdtAccountInfoBase.yaml
- type: object
required:
- paymentRails
properties:
paymentRails:
type: array
items:
type: string
enum:
- BANK_TRANSFER
- MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- branchCode
- phoneNumber
properties:
accountType:
type: string
enum:
- BDT_ACCOUNT
paymentRails:
type: array
items:
type: string
enum:
- BANK_TRANSFER
- MOBILE_MONEY
bankName:
type: string
description: The name of the bank
minLength: 1
maxLength: 255
accountNumber:
type: string
description: The account number of the bank
minLength: 1
maxLength: 34
branchCode:
type: string
description: The branch code
minLength: 5
maxLength: 5
pattern: ^[0-9]{5}$
swiftCode:
type: string
description: The SWIFT/BIC code of the bank
example: DEUTDEFF
minLength: 8
maxLength: 11
pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
phoneNumber:
type: string
description: The phone number in international format
example: '+1234567890'
minLength: 7
maxLength: 15
pattern: ^\+[0-9]{6,14}$
50 changes: 38 additions & 12 deletions openapi/components/schemas/common/BrlAccountInfo.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,38 @@
allOf:
- $ref: ./BrlAccountInfoBase.yaml
- type: object
required:
- paymentRails
properties:
paymentRails:
type: array
items:
type: string
enum:
- PIX
type: object
required:
- accountType
- paymentRails
- pixKey
- pixKeyType
- taxId
properties:
accountType:
type: string
enum:
- BRL_ACCOUNT
paymentRails:
type: array
items:
type: string
enum:
- PIX
pixKey:
type: string
description: The PIX key (email, phone, CPF, CNPJ, or random)
minLength: 1
maxLength: 77
pixKeyType:
type: string
description: The type of PIX key
enum:
- CPF
- CNPJ
- EMAIL
- PHONE
- RANDOM
taxId:
type: string
description: The tax ID (CPF or CNPJ)
minLength: 11
maxLength: 14
pattern: ^[0-9]{11,14}$
41 changes: 29 additions & 12 deletions openapi/components/schemas/common/BwpAccountInfo.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,29 @@
allOf:
- $ref: ./BwpAccountInfoBase.yaml
- type: object
required:
- paymentRails
properties:
paymentRails:
type: array
items:
type: string
enum:
- MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- phoneNumber
- provider
properties:
accountType:
type: string
enum:
- BWP_ACCOUNT
paymentRails:
type: array
items:
type: string
enum:
- MOBILE_MONEY
phoneNumber:
type: string
description: The phone number in international format
example: '+1234567890'
minLength: 7
maxLength: 15
pattern: ^\+[0-9]{6,14}$
provider:
type: string
description: The mobile money provider name
minLength: 1
maxLength: 255
47 changes: 34 additions & 13 deletions openapi/components/schemas/common/CopAccountInfo.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,34 @@
allOf:
- $ref: ./CopAccountInfoBase.yaml
- type: object
required:
- paymentRails
properties:
paymentRails:
type: array
items:
type: string
enum:
- BANK_TRANSFER
- MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- bankAccountType
properties:
accountType:
type: string
enum:
- COP_ACCOUNT
paymentRails:
type: array
items:
type: string
enum:
- BANK_TRANSFER
Comment on lines +15 to +18

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1MOBILE_MONEY removed from COP and GTQ payment rails

Both CopAccountInfo and GtqAccountInfo previously allowed MOBILE_MONEY alongside BANK_TRANSFER; the new schemas only list BANK_TRANSFER. Clients that currently submit COP or GTQ payments via MOBILE_MONEY will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.

Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopAccountInfo.yaml
Line: 15-18
Comment:
**`MOBILE_MONEY` removed from COP and GTQ payment rails**
Both `CopAccountInfo` and `GtqAccountInfo` previously allowed `MOBILE_MONEY` alongside `BANK_TRANSFER`; the new schemas only list `BANK_TRANSFER`. Clients that currently submit COP or GTQ payments via `MOBILE_MONEY` will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

bankName:
type: string
description: The name of the bank
minLength: 1
maxLength: 255
accountNumber:
type: string
description: The account number of the bank
minLength: 1
maxLength: 34
bankAccountType:
type: string
description: The bank account type
enum:
- CHECKING
- SAVINGS
7 changes: 4 additions & 3 deletions openapi/components/schemas/common/CopBeneficiary.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,8 @@ title: Individual Beneficiary
type: object
required:
- beneficiaryType
- countryOfResidence
- documentNumber
- documentType
- fullName
Comment on lines 3 to 7

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Breaking required-field change in CopBeneficiary

countryOfResidence is dropped from required and documentNumber + documentType are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, GtqBeneficiary gains phoneNumber as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.

Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopBeneficiary.yaml
Line: 3-7
Comment:
**Breaking required-field change in `CopBeneficiary`**`countryOfResidence` is dropped from `required` and `documentNumber` + `documentType` are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, `GtqBeneficiary` gains `phoneNumber` as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

properties:
beneficiaryType:
Expand All@@ -27,11 +28,11 @@ properties:
countryOfResidence:
type: string
description: The country of residence of the beneficiary
address:
$ref: ./Address.yaml
documentType:
type: string
description: The type of identity document (e.g., national ID, passport)
documentNumber:
type: string
description: The identity document number
address:
$ref: ./Address.yaml
44 changes: 31 additions & 13 deletions openapi/components/schemas/common/DkkAccountInfo.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,31 @@
allOf:
- $ref: ./DkkAccountInfoBase.yaml
- type: object
required:
- paymentRails
properties:
paymentRails:
type: array
items:
type: string
enum:
- SEPA
- SEPA_INSTANT
type: object
required:
- accountType
- paymentRails
- iban
properties:
accountType:
type: string
enum:
- DKK_ACCOUNT
paymentRails:
type: array
items:
type: string
enum:
- SEPA
- SEPA_INSTANT
iban:
type: string
description: The IBAN of the bank account
example: DE89370400440532013000
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
swiftCode:
type: string
description: The SWIFT/BIC code of the bank
example: DEUTDEFF
minLength: 8
maxLength: 11
pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
53 changes: 41 additions & 12 deletions openapi/components/schemas/common/EgpAccountInfo.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,41 @@
allOf:
- $ref: ./EgpAccountInfoBase.yaml
- type: object
required:
- paymentRails
properties:
paymentRails:
type: array
items:
type: string
enum:
- BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
properties:
accountType:
type: string
enum:
- EGP_ACCOUNT
paymentRails:
type: array
items:
type: string
enum:
- BANK_TRANSFER
bankName:
type: string
description: The name of the bank
minLength: 1
maxLength: 255
accountNumber:
type: string
description: The account number of the bank
minLength: 1
maxLength: 34
iban:
type: string
description: The IBAN of the bank account
example: DE89370400440532013000
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
swiftCode:
Comment on lines +28 to +35

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2Incorrect IBAN example for EGP

The iban field shows DE89370400440532013000, which is a German IBAN. Egyptian IBANs follow the format EG + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in DkkAccountInfo.yaml (DKK IBANs start with DK). Using country-appropriate examples improves clarity for integrators.

Suggested change
iban:
type: string
description: The IBAN of the bank account
example: DE89370400440532013000
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
swiftCode:
iban:
type: string
description: The IBAN of the bank account
example: EG800002000156789012345180002
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/EgpAccountInfo.yaml
Line: 28-35
Comment:
**Incorrect IBAN example for EGP**
The `iban` field shows `DE89370400440532013000`, which is a German IBAN. Egyptian IBANs follow the format `EG` + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in `DkkAccountInfo.yaml` (DKK IBANs start with `DK`). Using country-appropriate examples improves clarity for integrators.
```suggestion iban: type: string description: The IBAN of the bank account example: EG800002000156789012345180002 minLength: 15 maxLength: 34 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$```
How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

type: string
description: The SWIFT/BIC code of the bank
example: DEUTDEFF
minLength: 8
maxLength: 11
pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore: Sync account schemas#384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

lightspark-copybara
wants to merge
1
commit into

from

 Closed


chore: Sync account schemas
#384
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1,814 changes: 1,272 additions & 542 deletions
mintlify/openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


1,814 changes: 1,272 additions & 542 deletions
openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


42 changes: 30 additions & 12 deletions
openapi/components/schemas/common/AedAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,30 @@
allOf:
- $ref: ./AedAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - AED_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 iban:
 type: string
 description: UAE IBAN (23 characters, starting with AE)
 example: AE070331234567890123456
 minLength: 23
 maxLength: 23
 pattern: ^AE[0-9]{21}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: EBILAEAD
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

63 changes: 50 additions & 13 deletions
openapi/components/schemas/common/BdtAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,50 @@
allOf:
- $ref: ./BdtAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- branchCode
- phoneNumber
properties:
 accountType:
 type: string
 enum:
 - BDT_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 branchCode:
 type: string
 description: The branch code
 minLength: 5
 maxLength: 5
 pattern: ^[0-9]{5}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$

50 changes: 38 additions & 12 deletions
openapi/components/schemas/common/BrlAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,38 @@
allOf:
- $ref: ./BrlAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
type: object
required:
- accountType
- paymentRails
- pixKey
- pixKeyType
- taxId
properties:
 accountType:
 type: string
 enum:
 - BRL_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
 pixKey:
 type: string
 description: The PIX key (email, phone, CPF, CNPJ, or random)
 minLength: 1
 maxLength: 77
 pixKeyType:
 type: string
 description: The type of PIX key
 enum:
 - CPF
 - CNPJ
 - EMAIL
 - PHONE
 - RANDOM
 taxId:
 type: string
 description: The tax ID (CPF or CNPJ)
 minLength: 11
 maxLength: 14
 pattern: ^[0-9]{11,14}$

41 changes: 29 additions & 12 deletions
openapi/components/schemas/common/BwpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,29 @@
allOf:
- $ref: ./BwpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- phoneNumber
- provider
properties:
 accountType:
 type: string
 enum:
 - BWP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$
 provider:
 type: string
 description: The mobile money provider name
 minLength: 1
 maxLength: 255

47 changes: 34 additions & 13 deletions
openapi/components/schemas/common/CopAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,34 @@
allOf:
- $ref: ./CopAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- bankAccountType
properties:
 accountType:
 type: string
 enum:
 - COP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER

Comment on lines

+15
 to 
+18

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1MOBILE_MONEY removed from COP and GTQ payment rails
Both CopAccountInfo and GtqAccountInfo previously allowed MOBILE_MONEY alongside BANK_TRANSFER; the new schemas only list BANK_TRANSFER. Clients that currently submit COP or GTQ payments via MOBILE_MONEY will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopAccountInfo.yaml
Line: 15-18
Comment:
**`MOBILE_MONEY` removed from COP and GTQ payment rails**
Both `CopAccountInfo` and `GtqAccountInfo` previously allowed `MOBILE_MONEY` alongside `BANK_TRANSFER`; the new schemas only list `BANK_TRANSFER`. Clients that currently submit COP or GTQ payments via `MOBILE_MONEY` will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 bankAccountType:
 type: string
 description: The bank account type
 enum:
 - CHECKING
 - SAVINGS

7 changes: 4 additions & 3 deletions
openapi/components/schemas/common/CopBeneficiary.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,8 @@ title: Individual Beneficiary
type: object
required:
- beneficiaryType
- countryOfResidence
- documentNumber
- documentType
- fullName

Comment on lines

3
 to 
7

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Breaking required-field change in CopBeneficiary
countryOfResidence is dropped from required and documentNumber + documentType are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, GtqBeneficiary gains phoneNumber as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopBeneficiary.yaml
Line: 3-7
Comment:
**Breaking required-field change in `CopBeneficiary`**`countryOfResidence` is dropped from `required` and `documentNumber` + `documentType` are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, `GtqBeneficiary` gains `phoneNumber` as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
properties:
 beneficiaryType:
Expand All@@ -27,11 +28,11 @@ properties:
 countryOfResidence:
 type: string
 description: The country of residence of the beneficiary
 address:
 $ref: ./Address.yaml
 documentType:
 type: string
 description: The type of identity document (e.g., national ID, passport)
 documentNumber:
 type: string
 description: The identity document number
 address:
 $ref: ./Address.yaml

44 changes: 31 additions & 13 deletions
openapi/components/schemas/common/DkkAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,31 @@
allOf:
- $ref: ./DkkAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - DKK_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

53 changes: 41 additions & 12 deletions
openapi/components/schemas/common/EgpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,41 @@
allOf:
- $ref: ./EgpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
properties:
 accountType:
 type: string
 enum:
 - EGP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:

Comment on lines

+28
 to 
+35

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2Incorrect IBAN example for EGP
The iban field shows DE89370400440532013000, which is a German IBAN. Egyptian IBANs follow the format EG + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in DkkAccountInfo.yaml (DKK IBANs start with DK). Using country-appropriate examples improves clarity for integrators.

Suggested change

iban:
type: string
description: The IBAN of the bank account
example: DE89370400440532013000
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
swiftCode:
iban:
type: string
description: The IBAN of the bank account
example: EG800002000156789012345180002
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/EgpAccountInfo.yaml
Line: 28-35
Comment:
**Incorrect IBAN example for EGP**
The `iban` field shows `DE89370400440532013000`, which is a German IBAN. Egyptian IBANs follow the format `EG` + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in `DkkAccountInfo.yaml` (DKK IBANs start with `DK`). Using country-appropriate examples improves clarity for integrators.
```suggestion iban: type: string description: The IBAN of the bank account example: EG800002000156789012345180002 minLength: 15 maxLength: 34 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$```
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: Sync account schemas#384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

lightspark-copybara
wants to merge
1
commit into

from

 Closed


chore: Sync account schemas
#384
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1,814 changes: 1,272 additions & 542 deletions
mintlify/openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


1,814 changes: 1,272 additions & 542 deletions
openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


42 changes: 30 additions & 12 deletions
openapi/components/schemas/common/AedAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,30 @@
allOf:
- $ref: ./AedAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - AED_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 iban:
 type: string
 description: UAE IBAN (23 characters, starting with AE)
 example: AE070331234567890123456
 minLength: 23
 maxLength: 23
 pattern: ^AE[0-9]{21}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: EBILAEAD
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

63 changes: 50 additions & 13 deletions
openapi/components/schemas/common/BdtAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,50 @@
allOf:
- $ref: ./BdtAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- branchCode
- phoneNumber
properties:
 accountType:
 type: string
 enum:
 - BDT_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 branchCode:
 type: string
 description: The branch code
 minLength: 5
 maxLength: 5
 pattern: ^[0-9]{5}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$

50 changes: 38 additions & 12 deletions
openapi/components/schemas/common/BrlAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,38 @@
allOf:
- $ref: ./BrlAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
type: object
required:
- accountType
- paymentRails
- pixKey
- pixKeyType
- taxId
properties:
 accountType:
 type: string
 enum:
 - BRL_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
 pixKey:
 type: string
 description: The PIX key (email, phone, CPF, CNPJ, or random)
 minLength: 1
 maxLength: 77
 pixKeyType:
 type: string
 description: The type of PIX key
 enum:
 - CPF
 - CNPJ
 - EMAIL
 - PHONE
 - RANDOM
 taxId:
 type: string
 description: The tax ID (CPF or CNPJ)
 minLength: 11
 maxLength: 14
 pattern: ^[0-9]{11,14}$

41 changes: 29 additions & 12 deletions
openapi/components/schemas/common/BwpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,29 @@
allOf:
- $ref: ./BwpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- phoneNumber
- provider
properties:
 accountType:
 type: string
 enum:
 - BWP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$
 provider:
 type: string
 description: The mobile money provider name
 minLength: 1
 maxLength: 255

47 changes: 34 additions & 13 deletions
openapi/components/schemas/common/CopAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,34 @@
allOf:
- $ref: ./CopAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- bankAccountType
properties:
 accountType:
 type: string
 enum:
 - COP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER

Comment on lines

+15
 to 
+18

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1MOBILE_MONEY removed from COP and GTQ payment rails
Both CopAccountInfo and GtqAccountInfo previously allowed MOBILE_MONEY alongside BANK_TRANSFER; the new schemas only list BANK_TRANSFER. Clients that currently submit COP or GTQ payments via MOBILE_MONEY will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopAccountInfo.yaml
Line: 15-18
Comment:
**`MOBILE_MONEY` removed from COP and GTQ payment rails**
Both `CopAccountInfo` and `GtqAccountInfo` previously allowed `MOBILE_MONEY` alongside `BANK_TRANSFER`; the new schemas only list `BANK_TRANSFER`. Clients that currently submit COP or GTQ payments via `MOBILE_MONEY` will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 bankAccountType:
 type: string
 description: The bank account type
 enum:
 - CHECKING
 - SAVINGS

7 changes: 4 additions & 3 deletions
openapi/components/schemas/common/CopBeneficiary.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,8 @@ title: Individual Beneficiary
type: object
required:
- beneficiaryType
- countryOfResidence
- documentNumber
- documentType
- fullName

Comment on lines

3
 to 
7

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Breaking required-field change in CopBeneficiary
countryOfResidence is dropped from required and documentNumber + documentType are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, GtqBeneficiary gains phoneNumber as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopBeneficiary.yaml
Line: 3-7
Comment:
**Breaking required-field change in `CopBeneficiary`**`countryOfResidence` is dropped from `required` and `documentNumber` + `documentType` are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, `GtqBeneficiary` gains `phoneNumber` as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
properties:
 beneficiaryType:
Expand All@@ -27,11 +28,11 @@ properties:
 countryOfResidence:
 type: string
 description: The country of residence of the beneficiary
 address:
 $ref: ./Address.yaml
 documentType:
 type: string
 description: The type of identity document (e.g., national ID, passport)
 documentNumber:
 type: string
 description: The identity document number
 address:
 $ref: ./Address.yaml

44 changes: 31 additions & 13 deletions
openapi/components/schemas/common/DkkAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,31 @@
allOf:
- $ref: ./DkkAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - DKK_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

53 changes: 41 additions & 12 deletions
openapi/components/schemas/common/EgpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,41 @@
allOf:
- $ref: ./EgpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
properties:
 accountType:
 type: string
 enum:
 - EGP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:

Comment on lines

+28
 to 
+35

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2Incorrect IBAN example for EGP
The iban field shows DE89370400440532013000, which is a German IBAN. Egyptian IBANs follow the format EG + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in DkkAccountInfo.yaml (DKK IBANs start with DK). Using country-appropriate examples improves clarity for integrators.

Suggested change

iban:
type: string
description: The IBAN of the bank account
example: DE89370400440532013000
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
swiftCode:
iban:
type: string
description: The IBAN of the bank account
example: EG800002000156789012345180002
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/EgpAccountInfo.yaml
Line: 28-35
Comment:
**Incorrect IBAN example for EGP**
The `iban` field shows `DE89370400440532013000`, which is a German IBAN. Egyptian IBANs follow the format `EG` + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in `DkkAccountInfo.yaml` (DKK IBANs start with `DK`). Using country-appropriate examples improves clarity for integrators.
```suggestion iban: type: string description: The IBAN of the bank account example: EG800002000156789012345180002 minLength: 15 maxLength: 34 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$```
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: Sync account schemas#384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

lightspark-copybara
wants to merge
1
commit into

from

 Closed


chore: Sync account schemas
#384
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1,814 changes: 1,272 additions & 542 deletions
mintlify/openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


1,814 changes: 1,272 additions & 542 deletions
openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


42 changes: 30 additions & 12 deletions
openapi/components/schemas/common/AedAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,30 @@
allOf:
- $ref: ./AedAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - AED_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 iban:
 type: string
 description: UAE IBAN (23 characters, starting with AE)
 example: AE070331234567890123456
 minLength: 23
 maxLength: 23
 pattern: ^AE[0-9]{21}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: EBILAEAD
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

63 changes: 50 additions & 13 deletions
openapi/components/schemas/common/BdtAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,50 @@
allOf:
- $ref: ./BdtAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- branchCode
- phoneNumber
properties:
 accountType:
 type: string
 enum:
 - BDT_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 branchCode:
 type: string
 description: The branch code
 minLength: 5
 maxLength: 5
 pattern: ^[0-9]{5}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$

50 changes: 38 additions & 12 deletions
openapi/components/schemas/common/BrlAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,38 @@
allOf:
- $ref: ./BrlAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
type: object
required:
- accountType
- paymentRails
- pixKey
- pixKeyType
- taxId
properties:
 accountType:
 type: string
 enum:
 - BRL_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
 pixKey:
 type: string
 description: The PIX key (email, phone, CPF, CNPJ, or random)
 minLength: 1
 maxLength: 77
 pixKeyType:
 type: string
 description: The type of PIX key
 enum:
 - CPF
 - CNPJ
 - EMAIL
 - PHONE
 - RANDOM
 taxId:
 type: string
 description: The tax ID (CPF or CNPJ)
 minLength: 11
 maxLength: 14
 pattern: ^[0-9]{11,14}$

41 changes: 29 additions & 12 deletions
openapi/components/schemas/common/BwpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,29 @@
allOf:
- $ref: ./BwpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- phoneNumber
- provider
properties:
 accountType:
 type: string
 enum:
 - BWP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$
 provider:
 type: string
 description: The mobile money provider name
 minLength: 1
 maxLength: 255

47 changes: 34 additions & 13 deletions
openapi/components/schemas/common/CopAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,34 @@
allOf:
- $ref: ./CopAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- bankAccountType
properties:
 accountType:
 type: string
 enum:
 - COP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER

Comment on lines

+15
 to 
+18

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1MOBILE_MONEY removed from COP and GTQ payment rails
Both CopAccountInfo and GtqAccountInfo previously allowed MOBILE_MONEY alongside BANK_TRANSFER; the new schemas only list BANK_TRANSFER. Clients that currently submit COP or GTQ payments via MOBILE_MONEY will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopAccountInfo.yaml
Line: 15-18
Comment:
**`MOBILE_MONEY` removed from COP and GTQ payment rails**
Both `CopAccountInfo` and `GtqAccountInfo` previously allowed `MOBILE_MONEY` alongside `BANK_TRANSFER`; the new schemas only list `BANK_TRANSFER`. Clients that currently submit COP or GTQ payments via `MOBILE_MONEY` will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 bankAccountType:
 type: string
 description: The bank account type
 enum:
 - CHECKING
 - SAVINGS

7 changes: 4 additions & 3 deletions
openapi/components/schemas/common/CopBeneficiary.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,8 @@ title: Individual Beneficiary
type: object
required:
- beneficiaryType
- countryOfResidence
- documentNumber
- documentType
- fullName

Comment on lines

3
 to 
7

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Breaking required-field change in CopBeneficiary
countryOfResidence is dropped from required and documentNumber + documentType are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, GtqBeneficiary gains phoneNumber as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopBeneficiary.yaml
Line: 3-7
Comment:
**Breaking required-field change in `CopBeneficiary`**`countryOfResidence` is dropped from `required` and `documentNumber` + `documentType` are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, `GtqBeneficiary` gains `phoneNumber` as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
properties:
 beneficiaryType:
Expand All@@ -27,11 +28,11 @@ properties:
 countryOfResidence:
 type: string
 description: The country of residence of the beneficiary
 address:
 $ref: ./Address.yaml
 documentType:
 type: string
 description: The type of identity document (e.g., national ID, passport)
 documentNumber:
 type: string
 description: The identity document number
 address:
 $ref: ./Address.yaml

44 changes: 31 additions & 13 deletions
openapi/components/schemas/common/DkkAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,31 @@
allOf:
- $ref: ./DkkAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - DKK_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

53 changes: 41 additions & 12 deletions
openapi/components/schemas/common/EgpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,41 @@
allOf:
- $ref: ./EgpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
properties:
 accountType:
 type: string
 enum:
 - EGP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:

Comment on lines

+28
 to 
+35

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2Incorrect IBAN example for EGP
The iban field shows DE89370400440532013000, which is a German IBAN. Egyptian IBANs follow the format EG + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in DkkAccountInfo.yaml (DKK IBANs start with DK). Using country-appropriate examples improves clarity for integrators.

Suggested change

iban:
type: string
description: The IBAN of the bank account
example: DE89370400440532013000
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
swiftCode:
iban:
type: string
description: The IBAN of the bank account
example: EG800002000156789012345180002
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/EgpAccountInfo.yaml
Line: 28-35
Comment:
**Incorrect IBAN example for EGP**
The `iban` field shows `DE89370400440532013000`, which is a German IBAN. Egyptian IBANs follow the format `EG` + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in `DkkAccountInfo.yaml` (DKK IBANs start with `DK`). Using country-appropriate examples improves clarity for integrators.
```suggestion iban: type: string description: The IBAN of the bank account example: EG800002000156789012345180002 minLength: 15 maxLength: 34 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$```
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore: Sync account schemas#384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

lightspark-copybara
wants to merge
1
commit into

from

 Closed


chore: Sync account schemas
#384
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1,814 changes: 1,272 additions & 542 deletions
mintlify/openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


1,814 changes: 1,272 additions & 542 deletions
openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


42 changes: 30 additions & 12 deletions
openapi/components/schemas/common/AedAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,30 @@
allOf:
- $ref: ./AedAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - AED_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 iban:
 type: string
 description: UAE IBAN (23 characters, starting with AE)
 example: AE070331234567890123456
 minLength: 23
 maxLength: 23
 pattern: ^AE[0-9]{21}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: EBILAEAD
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

63 changes: 50 additions & 13 deletions
openapi/components/schemas/common/BdtAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,50 @@
allOf:
- $ref: ./BdtAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- branchCode
- phoneNumber
properties:
 accountType:
 type: string
 enum:
 - BDT_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 branchCode:
 type: string
 description: The branch code
 minLength: 5
 maxLength: 5
 pattern: ^[0-9]{5}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$

50 changes: 38 additions & 12 deletions
openapi/components/schemas/common/BrlAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,38 @@
allOf:
- $ref: ./BrlAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
type: object
required:
- accountType
- paymentRails
- pixKey
- pixKeyType
- taxId
properties:
 accountType:
 type: string
 enum:
 - BRL_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
 pixKey:
 type: string
 description: The PIX key (email, phone, CPF, CNPJ, or random)
 minLength: 1
 maxLength: 77
 pixKeyType:
 type: string
 description: The type of PIX key
 enum:
 - CPF
 - CNPJ
 - EMAIL
 - PHONE
 - RANDOM
 taxId:
 type: string
 description: The tax ID (CPF or CNPJ)
 minLength: 11
 maxLength: 14
 pattern: ^[0-9]{11,14}$

41 changes: 29 additions & 12 deletions
openapi/components/schemas/common/BwpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,29 @@
allOf:
- $ref: ./BwpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- phoneNumber
- provider
properties:
 accountType:
 type: string
 enum:
 - BWP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$
 provider:
 type: string
 description: The mobile money provider name
 minLength: 1
 maxLength: 255

47 changes: 34 additions & 13 deletions
openapi/components/schemas/common/CopAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,34 @@
allOf:
- $ref: ./CopAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- bankAccountType
properties:
 accountType:
 type: string
 enum:
 - COP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER

Comment on lines

+15
 to 
+18

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1MOBILE_MONEY removed from COP and GTQ payment rails
Both CopAccountInfo and GtqAccountInfo previously allowed MOBILE_MONEY alongside BANK_TRANSFER; the new schemas only list BANK_TRANSFER. Clients that currently submit COP or GTQ payments via MOBILE_MONEY will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopAccountInfo.yaml
Line: 15-18
Comment:
**`MOBILE_MONEY` removed from COP and GTQ payment rails**
Both `CopAccountInfo` and `GtqAccountInfo` previously allowed `MOBILE_MONEY` alongside `BANK_TRANSFER`; the new schemas only list `BANK_TRANSFER`. Clients that currently submit COP or GTQ payments via `MOBILE_MONEY` will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 bankAccountType:
 type: string
 description: The bank account type
 enum:
 - CHECKING
 - SAVINGS

7 changes: 4 additions & 3 deletions
openapi/components/schemas/common/CopBeneficiary.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,8 @@ title: Individual Beneficiary
type: object
required:
- beneficiaryType
- countryOfResidence
- documentNumber
- documentType
- fullName

Comment on lines

3
 to 
7

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Breaking required-field change in CopBeneficiary
countryOfResidence is dropped from required and documentNumber + documentType are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, GtqBeneficiary gains phoneNumber as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopBeneficiary.yaml
Line: 3-7
Comment:
**Breaking required-field change in `CopBeneficiary`**`countryOfResidence` is dropped from `required` and `documentNumber` + `documentType` are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, `GtqBeneficiary` gains `phoneNumber` as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
properties:
 beneficiaryType:
Expand All@@ -27,11 +28,11 @@ properties:
 countryOfResidence:
 type: string
 description: The country of residence of the beneficiary
 address:
 $ref: ./Address.yaml
 documentType:
 type: string
 description: The type of identity document (e.g., national ID, passport)
 documentNumber:
 type: string
 description: The identity document number
 address:
 $ref: ./Address.yaml

44 changes: 31 additions & 13 deletions
openapi/components/schemas/common/DkkAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,31 @@
allOf:
- $ref: ./DkkAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - DKK_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

53 changes: 41 additions & 12 deletions
openapi/components/schemas/common/EgpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,41 @@
allOf:
- $ref: ./EgpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
properties:
 accountType:
 type: string
 enum:
 - EGP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:

Comment on lines

+28
 to 
+35

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2Incorrect IBAN example for EGP
The iban field shows DE89370400440532013000, which is a German IBAN. Egyptian IBANs follow the format EG + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in DkkAccountInfo.yaml (DKK IBANs start with DK). Using country-appropriate examples improves clarity for integrators.

Suggested change

iban:
type: string
description: The IBAN of the bank account
example: DE89370400440532013000
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
swiftCode:
iban:
type: string
description: The IBAN of the bank account
example: EG800002000156789012345180002
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/EgpAccountInfo.yaml
Line: 28-35
Comment:
**Incorrect IBAN example for EGP**
The `iban` field shows `DE89370400440532013000`, which is a German IBAN. Egyptian IBANs follow the format `EG` + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in `DkkAccountInfo.yaml` (DKK IBANs start with `DK`). Using country-appropriate examples improves clarity for integrators.
```suggestion iban: type: string description: The IBAN of the bank account example: EG800002000156789012345180002 minLength: 15 maxLength: 34 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$```
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: Sync account schemas#384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

lightspark-copybara
wants to merge
1
commit into

from

 Closed


chore: Sync account schemas
#384
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1,814 changes: 1,272 additions & 542 deletions
mintlify/openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


1,814 changes: 1,272 additions & 542 deletions
openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


42 changes: 30 additions & 12 deletions
openapi/components/schemas/common/AedAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,30 @@
allOf:
- $ref: ./AedAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - AED_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 iban:
 type: string
 description: UAE IBAN (23 characters, starting with AE)
 example: AE070331234567890123456
 minLength: 23
 maxLength: 23
 pattern: ^AE[0-9]{21}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: EBILAEAD
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

63 changes: 50 additions & 13 deletions
openapi/components/schemas/common/BdtAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,50 @@
allOf:
- $ref: ./BdtAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- branchCode
- phoneNumber
properties:
 accountType:
 type: string
 enum:
 - BDT_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 branchCode:
 type: string
 description: The branch code
 minLength: 5
 maxLength: 5
 pattern: ^[0-9]{5}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$

50 changes: 38 additions & 12 deletions
openapi/components/schemas/common/BrlAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,38 @@
allOf:
- $ref: ./BrlAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
type: object
required:
- accountType
- paymentRails
- pixKey
- pixKeyType
- taxId
properties:
 accountType:
 type: string
 enum:
 - BRL_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
 pixKey:
 type: string
 description: The PIX key (email, phone, CPF, CNPJ, or random)
 minLength: 1
 maxLength: 77
 pixKeyType:
 type: string
 description: The type of PIX key
 enum:
 - CPF
 - CNPJ
 - EMAIL
 - PHONE
 - RANDOM
 taxId:
 type: string
 description: The tax ID (CPF or CNPJ)
 minLength: 11
 maxLength: 14
 pattern: ^[0-9]{11,14}$

41 changes: 29 additions & 12 deletions
openapi/components/schemas/common/BwpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,29 @@
allOf:
- $ref: ./BwpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- phoneNumber
- provider
properties:
 accountType:
 type: string
 enum:
 - BWP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$
 provider:
 type: string
 description: The mobile money provider name
 minLength: 1
 maxLength: 255

47 changes: 34 additions & 13 deletions
openapi/components/schemas/common/CopAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,34 @@
allOf:
- $ref: ./CopAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- bankAccountType
properties:
 accountType:
 type: string
 enum:
 - COP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER

Comment on lines

+15
 to 
+18

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1MOBILE_MONEY removed from COP and GTQ payment rails
Both CopAccountInfo and GtqAccountInfo previously allowed MOBILE_MONEY alongside BANK_TRANSFER; the new schemas only list BANK_TRANSFER. Clients that currently submit COP or GTQ payments via MOBILE_MONEY will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopAccountInfo.yaml
Line: 15-18
Comment:
**`MOBILE_MONEY` removed from COP and GTQ payment rails**
Both `CopAccountInfo` and `GtqAccountInfo` previously allowed `MOBILE_MONEY` alongside `BANK_TRANSFER`; the new schemas only list `BANK_TRANSFER`. Clients that currently submit COP or GTQ payments via `MOBILE_MONEY` will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 bankAccountType:
 type: string
 description: The bank account type
 enum:
 - CHECKING
 - SAVINGS

7 changes: 4 additions & 3 deletions
openapi/components/schemas/common/CopBeneficiary.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,8 @@ title: Individual Beneficiary
type: object
required:
- beneficiaryType
- countryOfResidence
- documentNumber
- documentType
- fullName

Comment on lines

3
 to 
7

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Breaking required-field change in CopBeneficiary
countryOfResidence is dropped from required and documentNumber + documentType are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, GtqBeneficiary gains phoneNumber as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopBeneficiary.yaml
Line: 3-7
Comment:
**Breaking required-field change in `CopBeneficiary`**`countryOfResidence` is dropped from `required` and `documentNumber` + `documentType` are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, `GtqBeneficiary` gains `phoneNumber` as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
properties:
 beneficiaryType:
Expand All@@ -27,11 +28,11 @@ properties:
 countryOfResidence:
 type: string
 description: The country of residence of the beneficiary
 address:
 $ref: ./Address.yaml
 documentType:
 type: string
 description: The type of identity document (e.g., national ID, passport)
 documentNumber:
 type: string
 description: The identity document number
 address:
 $ref: ./Address.yaml

44 changes: 31 additions & 13 deletions
openapi/components/schemas/common/DkkAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,31 @@
allOf:
- $ref: ./DkkAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - DKK_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

53 changes: 41 additions & 12 deletions
openapi/components/schemas/common/EgpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,41 @@
allOf:
- $ref: ./EgpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
properties:
 accountType:
 type: string
 enum:
 - EGP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:

Comment on lines

+28
 to 
+35

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2Incorrect IBAN example for EGP
The iban field shows DE89370400440532013000, which is a German IBAN. Egyptian IBANs follow the format EG + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in DkkAccountInfo.yaml (DKK IBANs start with DK). Using country-appropriate examples improves clarity for integrators.

Suggested change

iban:
type: string
description: The IBAN of the bank account
example: DE89370400440532013000
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
swiftCode:
iban:
type: string
description: The IBAN of the bank account
example: EG800002000156789012345180002
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/EgpAccountInfo.yaml
Line: 28-35
Comment:
**Incorrect IBAN example for EGP**
The `iban` field shows `DE89370400440532013000`, which is a German IBAN. Egyptian IBANs follow the format `EG` + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in `DkkAccountInfo.yaml` (DKK IBANs start with `DK`). Using country-appropriate examples improves clarity for integrators.
```suggestion iban: type: string description: The IBAN of the bank account example: EG800002000156789012345180002 minLength: 15 maxLength: 34 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$```
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: Sync account schemas#384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

lightspark-copybara
wants to merge
1
commit into

from

 Closed


chore: Sync account schemas
#384
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1,814 changes: 1,272 additions & 542 deletions
mintlify/openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


1,814 changes: 1,272 additions & 542 deletions
openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


42 changes: 30 additions & 12 deletions
openapi/components/schemas/common/AedAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,30 @@
allOf:
- $ref: ./AedAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - AED_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 iban:
 type: string
 description: UAE IBAN (23 characters, starting with AE)
 example: AE070331234567890123456
 minLength: 23
 maxLength: 23
 pattern: ^AE[0-9]{21}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: EBILAEAD
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

63 changes: 50 additions & 13 deletions
openapi/components/schemas/common/BdtAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,50 @@
allOf:
- $ref: ./BdtAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- branchCode
- phoneNumber
properties:
 accountType:
 type: string
 enum:
 - BDT_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 branchCode:
 type: string
 description: The branch code
 minLength: 5
 maxLength: 5
 pattern: ^[0-9]{5}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$

50 changes: 38 additions & 12 deletions
openapi/components/schemas/common/BrlAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,38 @@
allOf:
- $ref: ./BrlAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
type: object
required:
- accountType
- paymentRails
- pixKey
- pixKeyType
- taxId
properties:
 accountType:
 type: string
 enum:
 - BRL_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
 pixKey:
 type: string
 description: The PIX key (email, phone, CPF, CNPJ, or random)
 minLength: 1
 maxLength: 77
 pixKeyType:
 type: string
 description: The type of PIX key
 enum:
 - CPF
 - CNPJ
 - EMAIL
 - PHONE
 - RANDOM
 taxId:
 type: string
 description: The tax ID (CPF or CNPJ)
 minLength: 11
 maxLength: 14
 pattern: ^[0-9]{11,14}$

41 changes: 29 additions & 12 deletions
openapi/components/schemas/common/BwpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,29 @@
allOf:
- $ref: ./BwpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- phoneNumber
- provider
properties:
 accountType:
 type: string
 enum:
 - BWP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$
 provider:
 type: string
 description: The mobile money provider name
 minLength: 1
 maxLength: 255

47 changes: 34 additions & 13 deletions
openapi/components/schemas/common/CopAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,34 @@
allOf:
- $ref: ./CopAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- bankAccountType
properties:
 accountType:
 type: string
 enum:
 - COP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER

Comment on lines

+15
 to 
+18

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1MOBILE_MONEY removed from COP and GTQ payment rails
Both CopAccountInfo and GtqAccountInfo previously allowed MOBILE_MONEY alongside BANK_TRANSFER; the new schemas only list BANK_TRANSFER. Clients that currently submit COP or GTQ payments via MOBILE_MONEY will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopAccountInfo.yaml
Line: 15-18
Comment:
**`MOBILE_MONEY` removed from COP and GTQ payment rails**
Both `CopAccountInfo` and `GtqAccountInfo` previously allowed `MOBILE_MONEY` alongside `BANK_TRANSFER`; the new schemas only list `BANK_TRANSFER`. Clients that currently submit COP or GTQ payments via `MOBILE_MONEY` will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 bankAccountType:
 type: string
 description: The bank account type
 enum:
 - CHECKING
 - SAVINGS

7 changes: 4 additions & 3 deletions
openapi/components/schemas/common/CopBeneficiary.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,8 @@ title: Individual Beneficiary
type: object
required:
- beneficiaryType
- countryOfResidence
- documentNumber
- documentType
- fullName

Comment on lines

3
 to 
7

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Breaking required-field change in CopBeneficiary
countryOfResidence is dropped from required and documentNumber + documentType are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, GtqBeneficiary gains phoneNumber as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopBeneficiary.yaml
Line: 3-7
Comment:
**Breaking required-field change in `CopBeneficiary`**`countryOfResidence` is dropped from `required` and `documentNumber` + `documentType` are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, `GtqBeneficiary` gains `phoneNumber` as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
properties:
 beneficiaryType:
Expand All@@ -27,11 +28,11 @@ properties:
 countryOfResidence:
 type: string
 description: The country of residence of the beneficiary
 address:
 $ref: ./Address.yaml
 documentType:
 type: string
 description: The type of identity document (e.g., national ID, passport)
 documentNumber:
 type: string
 description: The identity document number
 address:
 $ref: ./Address.yaml

44 changes: 31 additions & 13 deletions
openapi/components/schemas/common/DkkAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,31 @@
allOf:
- $ref: ./DkkAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - DKK_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

53 changes: 41 additions & 12 deletions
openapi/components/schemas/common/EgpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,41 @@
allOf:
- $ref: ./EgpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
properties:
 accountType:
 type: string
 enum:
 - EGP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:

Comment on lines

+28
 to 
+35

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2Incorrect IBAN example for EGP
The iban field shows DE89370400440532013000, which is a German IBAN. Egyptian IBANs follow the format EG + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in DkkAccountInfo.yaml (DKK IBANs start with DK). Using country-appropriate examples improves clarity for integrators.

Suggested change

iban:
type: string
description: The IBAN of the bank account
example: DE89370400440532013000
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
swiftCode:
iban:
type: string
description: The IBAN of the bank account
example: EG800002000156789012345180002
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/EgpAccountInfo.yaml
Line: 28-35
Comment:
**Incorrect IBAN example for EGP**
The `iban` field shows `DE89370400440532013000`, which is a German IBAN. Egyptian IBANs follow the format `EG` + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in `DkkAccountInfo.yaml` (DKK IBANs start with `DK`). Using country-appropriate examples improves clarity for integrators.
```suggestion iban: type: string description: The IBAN of the bank account example: EG800002000156789012345180002 minLength: 15 maxLength: 34 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$```
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore: Sync account schemas#384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

lightspark-copybara
wants to merge
1
commit into

from

 Closed


chore: Sync account schemas
#384
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1,814 changes: 1,272 additions & 542 deletions
mintlify/openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


1,814 changes: 1,272 additions & 542 deletions
openapi.yaml

View file


Open in desktop


Large diffs are not rendered by default.


42 changes: 30 additions & 12 deletions
openapi/components/schemas/common/AedAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,30 @@
allOf:
- $ref: ./AedAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - AED_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 iban:
 type: string
 description: UAE IBAN (23 characters, starting with AE)
 example: AE070331234567890123456
 minLength: 23
 maxLength: 23
 pattern: ^AE[0-9]{21}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: EBILAEAD
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

63 changes: 50 additions & 13 deletions
openapi/components/schemas/common/BdtAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,50 @@
allOf:
- $ref: ./BdtAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- branchCode
- phoneNumber
properties:
 accountType:
 type: string
 enum:
 - BDT_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 branchCode:
 type: string
 description: The branch code
 minLength: 5
 maxLength: 5
 pattern: ^[0-9]{5}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$

50 changes: 38 additions & 12 deletions
openapi/components/schemas/common/BrlAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,38 @@
allOf:
- $ref: ./BrlAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
type: object
required:
- accountType
- paymentRails
- pixKey
- pixKeyType
- taxId
properties:
 accountType:
 type: string
 enum:
 - BRL_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - PIX
 pixKey:
 type: string
 description: The PIX key (email, phone, CPF, CNPJ, or random)
 minLength: 1
 maxLength: 77
 pixKeyType:
 type: string
 description: The type of PIX key
 enum:
 - CPF
 - CNPJ
 - EMAIL
 - PHONE
 - RANDOM
 taxId:
 type: string
 description: The tax ID (CPF or CNPJ)
 minLength: 11
 maxLength: 14
 pattern: ^[0-9]{11,14}$

41 changes: 29 additions & 12 deletions
openapi/components/schemas/common/BwpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,29 @@
allOf:
- $ref: ./BwpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- phoneNumber
- provider
properties:
 accountType:
 type: string
 enum:
 - BWP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - MOBILE_MONEY
 phoneNumber:
 type: string
 description: The phone number in international format
 example: '+1234567890'
 minLength: 7
 maxLength: 15
 pattern: ^\+[0-9]{6,14}$
 provider:
 type: string
 description: The mobile money provider name
 minLength: 1
 maxLength: 255

47 changes: 34 additions & 13 deletions
openapi/components/schemas/common/CopAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,34 @@
allOf:
- $ref: ./CopAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 - MOBILE_MONEY
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
- bankAccountType
properties:
 accountType:
 type: string
 enum:
 - COP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER

Comment on lines

+15
 to 
+18

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1MOBILE_MONEY removed from COP and GTQ payment rails
Both CopAccountInfo and GtqAccountInfo previously allowed MOBILE_MONEY alongside BANK_TRANSFER; the new schemas only list BANK_TRANSFER. Clients that currently submit COP or GTQ payments via MOBILE_MONEY will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopAccountInfo.yaml
Line: 15-18
Comment:
**`MOBILE_MONEY` removed from COP and GTQ payment rails**
Both `CopAccountInfo` and `GtqAccountInfo` previously allowed `MOBILE_MONEY` alongside `BANK_TRANSFER`; the new schemas only list `BANK_TRANSFER`. Clients that currently submit COP or GTQ payments via `MOBILE_MONEY` will fail schema validation after this change. Please confirm whether the corresponding sparkcore adapters have intentionally dropped this rail.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 bankAccountType:
 type: string
 description: The bank account type
 enum:
 - CHECKING
 - SAVINGS

7 changes: 4 additions & 3 deletions
openapi/components/schemas/common/CopBeneficiary.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,8 @@ title: Individual Beneficiary
type: object
required:
- beneficiaryType
- countryOfResidence
- documentNumber
- documentType
- fullName

Comment on lines

3
 to 
7

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Breaking required-field change in CopBeneficiary
countryOfResidence is dropped from required and documentNumber + documentType are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, GtqBeneficiary gains phoneNumber as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/CopBeneficiary.yaml
Line: 3-7
Comment:
**Breaking required-field change in `CopBeneficiary`**`countryOfResidence` is dropped from `required` and `documentNumber` + `documentType` are added as required. Any existing client that creates a COP beneficiary without providing a document number/type will now receive a validation error. Similarly, `GtqBeneficiary` gains `phoneNumber` as a new required field. If existing integrations are in production, this is a breaking API change that warrants a version bump or a migration window.
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
properties:
 beneficiaryType:
Expand All@@ -27,11 +28,11 @@ properties:
 countryOfResidence:
 type: string
 description: The country of residence of the beneficiary
 address:
 $ref: ./Address.yaml
 documentType:
 type: string
 description: The type of identity document (e.g., national ID, passport)
 documentNumber:
 type: string
 description: The identity document number
 address:
 $ref: ./Address.yaml

44 changes: 31 additions & 13 deletions
openapi/components/schemas/common/DkkAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,31 @@
allOf:
- $ref: ./DkkAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
type: object
required:
- accountType
- paymentRails
- iban
properties:
 accountType:
 type: string
 enum:
 - DKK_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - SEPA
 - SEPA_INSTANT
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$

53 changes: 41 additions & 12 deletions
openapi/components/schemas/common/EgpAccountInfo.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,41 @@
allOf:
- $ref: ./EgpAccountInfoBase.yaml
- type: object
 required:
 - paymentRails
 properties:
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
type: object
required:
- accountType
- paymentRails
- bankName
- accountNumber
properties:
 accountType:
 type: string
 enum:
 - EGP_ACCOUNT
 paymentRails:
 type: array
 items:
 type: string
 enum:
 - BANK_TRANSFER
 bankName:
 type: string
 description: The name of the bank
 minLength: 1
 maxLength: 255
 accountNumber:
 type: string
 description: The account number of the bank
 minLength: 1
 maxLength: 34
 iban:
 type: string
 description: The IBAN of the bank account
 example: DE89370400440532013000
 minLength: 15
 maxLength: 34
 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
 swiftCode:

Comment on lines

+28
 to 
+35

@greptile-appsgreptile-appsBotApr 23, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2Incorrect IBAN example for EGP
The iban field shows DE89370400440532013000, which is a German IBAN. Egyptian IBANs follow the format EG + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in DkkAccountInfo.yaml (DKK IBANs start with DK). Using country-appropriate examples improves clarity for integrators.

Suggested change

iban:
type: string
description: The IBAN of the bank account
example: DE89370400440532013000
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
swiftCode:
iban:
type: string
description: The IBAN of the bank account
example: EG800002000156789012345180002
minLength: 15
maxLength: 34
pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/EgpAccountInfo.yaml
Line: 28-35
Comment:
**Incorrect IBAN example for EGP**
The `iban` field shows `DE89370400440532013000`, which is a German IBAN. Egyptian IBANs follow the format `EG` + 2 check digits + 25 alphanumeric characters (29 chars total). The same German placeholder also appears in `DkkAccountInfo.yaml` (DKK IBANs start with `DK`). Using country-appropriate examples improves clarity for integrators.
```suggestion iban: type: string description: The IBAN of the bank account example: EG800002000156789012345180002 minLength: 15 maxLength: 34 pattern: ^[A-Z]{2}[0-9]{2}[A-Za-z0-9]{11,30}$```
How can I resolve this? If you propose a fix, please make it concise.
Fix in Claude Code
 type: string
 description: The SWIFT/BIC code of the bank
 example: DEUTDEFF
 minLength: 8
 maxLength: 11
 pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$
Loading
Loading