Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/grid-visualizer/src/data/account-types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,11 @@ export const accountTypeSpecs: Record<string, AccountTypeSpec> = {
INR_ACCOUNT: {
accountType: 'INR_ACCOUNT',
fields: [
{ name: 'vpa', example: 'customer@okbank' },
{ name: 'vpa', example: 'customer@okbank', description: 'For UPI' },
{ name: 'accountNumber', example: '000111222333', description: 'For NEFT/RTGS (9-18 digits)' },
{ name: 'ifsc', example: 'HDFC0001234', description: 'For NEFT/RTGS (11-character branch code)' },
{ name: 'rail', example: 'NEFT', description: 'NEFT or RTGS' },
{ name: 'bankName', example: 'HDFC Bank', description: 'Optional' },
],
beneficiaryRequired: true,
},
Comment on lines 54 to 64

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Missing required paymentRails field for INR_ACCOUNT

code-generator.ts's buildAccountInfoBody populates the request body exclusively by iterating over spec.fields (line 47–49). The OpenAPI schema (InrAccountInfo) marks paymentRails as a required field, but there is no paymentRails entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A { name: 'paymentRails', example: '["NEFT"]' } entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.

Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/account-types.ts
Line: 54-64
Comment:
**Missing required `paymentRails` field for INR_ACCOUNT**`code-generator.ts`'s `buildAccountInfoBody` populates the request body exclusively by iterating over `spec.fields` (line 47–49). The OpenAPI schema (`InrAccountInfo`) marks `paymentRails` as a **required** field, but there is no `paymentRails` entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A `{ name: 'paymentRails', example: '["NEFT"]' }` entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.
How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant anymore - paymentRails is only on the response

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right — the PR description spells this out clearly: paymentRails belongs to InrAccountInfo (the response wrapper), not InrAccountInfoBase or InrExternalAccountCreateInfo which make up the request. My comment was wrong to treat it as a required request field.

Shall I remember this as a rule: "Do not flag paymentRails as missing from INR account request bodies — it is a response-only field on InrAccountInfo and is not part of the create request schema"?

Expand Down
4 changes: 2 additions & 2 deletions components/grid-visualizer/src/data/currencies.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,9 +103,9 @@ export const currencies: FiatCurrency[] = [
name: 'Indian Rupee',
countryCode: 'in',
accountType: 'INR_ACCOUNT',
accountLabel: 'UPI',
accountLabel: 'UPI / Bank Account',
instantRails: ['UPI'],
allRails: ['UPI'],
allRails: ['UPI', 'NEFT', 'RTGS'],
examplePerson: { fullName: 'Priya Sharma', nationality: 'IN' },
},
{
Expand Down
2 changes: 1 addition & 1 deletion mintlify/snippets/country-support.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ import { FeatureCard, FeatureCardGrid, FeatureCardList, FeatureCardContainer } f
| 🇭🇹 Haiti | HT | `Bank Transfer` |
| 🇭🇺 Hungary | HU | `SEPA` `SEPA Instant` |
| 🇮🇸 Iceland | IS | `SEPA` `SEPA Instant` |
| 🇮🇳 India | IN | `UPI` |
| 🇮🇳 India | IN | `UPI` `NEFT` `RTGS` |
| 🇮🇩 Indonesia | ID | `Bank Transfer` |
| 🇮🇪 Ireland | IE | `SEPA` `SEPA Instant` |
| 🇮🇹 Italy | IT | `SEPA` `SEPA Instant` |
Expand Down
45 changes: 43 additions & 2 deletions mintlify/snippets/external-accounts.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,11 +407,15 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
</Tab>

<Tab title="India">
**UPI**
**UPI, NEFT, or RTGS**

India supports three payment rails: UPI (instant), NEFT (near-real-time), and RTGS (real-time, for large transfers).

**UPI:**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-H 'Authorization: Basic $GRID_CLIENT_ID:$GRID_CLIENT_SECRET' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
Expand All@@ -436,6 +440,43 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
}'
```

**NEFT / RTGS (bank transfer):**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
"platformAccountId": "in_neft_001",
"accountInfo": {
"accountType": "INR_ACCOUNT",
"accountNumber": "000111222333",
"ifsc": "HDFC0001234",
"rail": "NEFT",
"bankName": "HDFC Bank",
"beneficiary": {
"beneficiaryType": "INDIVIDUAL",
"fullName": "Priya Sharma",
"birthDate": "1991-05-14",
"nationality": "IN",
"address": {
"line1": "123 MG Road",
"city": "Mumbai",
"state": "Maharashtra",
"postalCode": "400001",
"country": "IN"
}
}
}
}'
```

<Note>
UPI requires `vpa`. NEFT and RTGS require `accountNumber` (9-18 digits), `ifsc`
(11-character branch code), and `rail` (`NEFT` or `RTGS`). `bankName` is optional
on both. Do not send `paymentRails` — Grid returns it on the created account.
</Note>
</Tab>

<Tab title="Nigeria">
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -115,10 +115,19 @@ private fun buildAccountInfo(accountType: String, accountInfo: JsonNode): Extern
ExternalAccountCreate.AccountInfo.ofUsdAccount(info)
}
"INR_ACCOUNT" -> {
// Which fields apply depends on the rail: UPI uses vpa, NEFT/RTGS use
// accountNumber + ifsc + rail. All are optional on the builder so one
// branch can serve both.
val info = InrExternalAccountCreateInfo.builder()
.accountType(InrExternalAccountCreateInfo.AccountType.INR_ACCOUNT)
.vpa(accountInfo.requireText("vpa"))
.beneficiary(buildInrBeneficiary(beneficiaryNode))
.apply {
accountInfo.optText("vpa")?.let { vpa(it) }
accountInfo.optText("accountNumber")?.let { accountNumber(it) }
accountInfo.optText("ifsc")?.let { ifsc(it) }
accountInfo.optText("rail")?.let { rail(it) }
accountInfo.optText("bankName")?.let { bankName(it) }
}
.build()
ExternalAccountCreate.AccountInfo.ofInrAccount(info)
}
Comment on lines 117 to 133

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1paymentRails never forwarded to the INR account builder

The OpenAPI schema (InrAccountInfo) requires paymentRails (an array like ["NEFT"] or ["UPI"]). The apply block maps all five INR account-info fields, but never reads or sets paymentRails. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include "paymentRails", so the Kotlin path should read it from the incoming request body (e.g., accountInfo.optList("paymentRails")) and call the corresponding builder method.

Prompt To Fix With AI
This is a comment left during a code review.
Path: samples/kotlin/src/main/kotlin/com/grid/sample/routes/ExternalAccounts.kt
Line: 116-129
Comment:
**`paymentRails` never forwarded to the INR account builder**
The OpenAPI schema (`InrAccountInfo`) requires `paymentRails` (an array like `["NEFT"]` or `["UPI"]`). The `apply` block maps all five INR account-info fields, but never reads or sets `paymentRails`. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include `"paymentRails"`, so the Kotlin path should read it from the incoming request body (e.g., `accountInfo.optList("paymentRails")`) and call the corresponding builder method.
How can I resolve this? If you propose a fix, please make it concise.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/grid-visualizer/src/data/account-types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,11 @@ export const accountTypeSpecs: Record<string, AccountTypeSpec> = {
INR_ACCOUNT: {
accountType: 'INR_ACCOUNT',
fields: [
{ name: 'vpa', example: 'customer@okbank' },
{ name: 'vpa', example: 'customer@okbank', description: 'For UPI' },
{ name: 'accountNumber', example: '000111222333', description: 'For NEFT/RTGS (9-18 digits)' },
{ name: 'ifsc', example: 'HDFC0001234', description: 'For NEFT/RTGS (11-character branch code)' },
{ name: 'rail', example: 'NEFT', description: 'NEFT or RTGS' },
{ name: 'bankName', example: 'HDFC Bank', description: 'Optional' },
],
beneficiaryRequired: true,
},
Comment on lines 54 to 64

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Missing required paymentRails field for INR_ACCOUNT

code-generator.ts's buildAccountInfoBody populates the request body exclusively by iterating over spec.fields (line 47–49). The OpenAPI schema (InrAccountInfo) marks paymentRails as a required field, but there is no paymentRails entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A { name: 'paymentRails', example: '["NEFT"]' } entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.

Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/account-types.ts
Line: 54-64
Comment:
**Missing required `paymentRails` field for INR_ACCOUNT**`code-generator.ts`'s `buildAccountInfoBody` populates the request body exclusively by iterating over `spec.fields` (line 47–49). The OpenAPI schema (`InrAccountInfo`) marks `paymentRails` as a **required** field, but there is no `paymentRails` entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A `{ name: 'paymentRails', example: '["NEFT"]' }` entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.
How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant anymore - paymentRails is only on the response

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right — the PR description spells this out clearly: paymentRails belongs to InrAccountInfo (the response wrapper), not InrAccountInfoBase or InrExternalAccountCreateInfo which make up the request. My comment was wrong to treat it as a required request field.

Shall I remember this as a rule: "Do not flag paymentRails as missing from INR account request bodies — it is a response-only field on InrAccountInfo and is not part of the create request schema"?

Expand Down
4 changes: 2 additions & 2 deletions components/grid-visualizer/src/data/currencies.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,9 +103,9 @@ export const currencies: FiatCurrency[] = [
name: 'Indian Rupee',
countryCode: 'in',
accountType: 'INR_ACCOUNT',
accountLabel: 'UPI',
accountLabel: 'UPI / Bank Account',
instantRails: ['UPI'],
allRails: ['UPI'],
allRails: ['UPI', 'NEFT', 'RTGS'],
examplePerson: { fullName: 'Priya Sharma', nationality: 'IN' },
},
{
Expand Down
2 changes: 1 addition & 1 deletion mintlify/snippets/country-support.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ import { FeatureCard, FeatureCardGrid, FeatureCardList, FeatureCardContainer } f
| 🇭🇹 Haiti | HT | `Bank Transfer` |
| 🇭🇺 Hungary | HU | `SEPA` `SEPA Instant` |
| 🇮🇸 Iceland | IS | `SEPA` `SEPA Instant` |
| 🇮🇳 India | IN | `UPI` |
| 🇮🇳 India | IN | `UPI` `NEFT` `RTGS` |
| 🇮🇩 Indonesia | ID | `Bank Transfer` |
| 🇮🇪 Ireland | IE | `SEPA` `SEPA Instant` |
| 🇮🇹 Italy | IT | `SEPA` `SEPA Instant` |
Expand Down
45 changes: 43 additions & 2 deletions mintlify/snippets/external-accounts.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,11 +407,15 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
</Tab>

<Tab title="India">
**UPI**
**UPI, NEFT, or RTGS**

India supports three payment rails: UPI (instant), NEFT (near-real-time), and RTGS (real-time, for large transfers).

**UPI:**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-H 'Authorization: Basic $GRID_CLIENT_ID:$GRID_CLIENT_SECRET' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
Expand All@@ -436,6 +440,43 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
}'
```

**NEFT / RTGS (bank transfer):**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
"platformAccountId": "in_neft_001",
"accountInfo": {
"accountType": "INR_ACCOUNT",
"accountNumber": "000111222333",
"ifsc": "HDFC0001234",
"rail": "NEFT",
"bankName": "HDFC Bank",
"beneficiary": {
"beneficiaryType": "INDIVIDUAL",
"fullName": "Priya Sharma",
"birthDate": "1991-05-14",
"nationality": "IN",
"address": {
"line1": "123 MG Road",
"city": "Mumbai",
"state": "Maharashtra",
"postalCode": "400001",
"country": "IN"
}
}
}
}'
```

<Note>
UPI requires `vpa`. NEFT and RTGS require `accountNumber` (9-18 digits), `ifsc`
(11-character branch code), and `rail` (`NEFT` or `RTGS`). `bankName` is optional
on both. Do not send `paymentRails` — Grid returns it on the created account.
</Note>
</Tab>

<Tab title="Nigeria">
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -115,10 +115,19 @@ private fun buildAccountInfo(accountType: String, accountInfo: JsonNode): Extern
ExternalAccountCreate.AccountInfo.ofUsdAccount(info)
}
"INR_ACCOUNT" -> {
// Which fields apply depends on the rail: UPI uses vpa, NEFT/RTGS use
// accountNumber + ifsc + rail. All are optional on the builder so one
// branch can serve both.
val info = InrExternalAccountCreateInfo.builder()
.accountType(InrExternalAccountCreateInfo.AccountType.INR_ACCOUNT)
.vpa(accountInfo.requireText("vpa"))
.beneficiary(buildInrBeneficiary(beneficiaryNode))
.apply {
accountInfo.optText("vpa")?.let { vpa(it) }
accountInfo.optText("accountNumber")?.let { accountNumber(it) }
accountInfo.optText("ifsc")?.let { ifsc(it) }
accountInfo.optText("rail")?.let { rail(it) }
accountInfo.optText("bankName")?.let { bankName(it) }
}
.build()
ExternalAccountCreate.AccountInfo.ofInrAccount(info)
}
Comment on lines 117 to 133

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1paymentRails never forwarded to the INR account builder

The OpenAPI schema (InrAccountInfo) requires paymentRails (an array like ["NEFT"] or ["UPI"]). The apply block maps all five INR account-info fields, but never reads or sets paymentRails. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include "paymentRails", so the Kotlin path should read it from the incoming request body (e.g., accountInfo.optList("paymentRails")) and call the corresponding builder method.

Prompt To Fix With AI
This is a comment left during a code review.
Path: samples/kotlin/src/main/kotlin/com/grid/sample/routes/ExternalAccounts.kt
Line: 116-129
Comment:
**`paymentRails` never forwarded to the INR account builder**
The OpenAPI schema (`InrAccountInfo`) requires `paymentRails` (an array like `["NEFT"]` or `["UPI"]`). The `apply` block maps all five INR account-info fields, but never reads or sets `paymentRails`. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include `"paymentRails"`, so the Kotlin path should read it from the incoming request body (e.g., `accountInfo.optList("paymentRails")`) and call the corresponding builder method.
How can I resolve this? If you propose a fix, please make it concise.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/grid-visualizer/src/data/account-types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,11 @@ export const accountTypeSpecs: Record<string, AccountTypeSpec> = {
INR_ACCOUNT: {
accountType: 'INR_ACCOUNT',
fields: [
{ name: 'vpa', example: 'customer@okbank' },
{ name: 'vpa', example: 'customer@okbank', description: 'For UPI' },
{ name: 'accountNumber', example: '000111222333', description: 'For NEFT/RTGS (9-18 digits)' },
{ name: 'ifsc', example: 'HDFC0001234', description: 'For NEFT/RTGS (11-character branch code)' },
{ name: 'rail', example: 'NEFT', description: 'NEFT or RTGS' },
{ name: 'bankName', example: 'HDFC Bank', description: 'Optional' },
],
beneficiaryRequired: true,
},
Comment on lines 54 to 64

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Missing required paymentRails field for INR_ACCOUNT

code-generator.ts's buildAccountInfoBody populates the request body exclusively by iterating over spec.fields (line 47–49). The OpenAPI schema (InrAccountInfo) marks paymentRails as a required field, but there is no paymentRails entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A { name: 'paymentRails', example: '["NEFT"]' } entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.

Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/account-types.ts
Line: 54-64
Comment:
**Missing required `paymentRails` field for INR_ACCOUNT**`code-generator.ts`'s `buildAccountInfoBody` populates the request body exclusively by iterating over `spec.fields` (line 47–49). The OpenAPI schema (`InrAccountInfo`) marks `paymentRails` as a **required** field, but there is no `paymentRails` entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A `{ name: 'paymentRails', example: '["NEFT"]' }` entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.
How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant anymore - paymentRails is only on the response

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right — the PR description spells this out clearly: paymentRails belongs to InrAccountInfo (the response wrapper), not InrAccountInfoBase or InrExternalAccountCreateInfo which make up the request. My comment was wrong to treat it as a required request field.

Shall I remember this as a rule: "Do not flag paymentRails as missing from INR account request bodies — it is a response-only field on InrAccountInfo and is not part of the create request schema"?

Expand Down
4 changes: 2 additions & 2 deletions components/grid-visualizer/src/data/currencies.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,9 +103,9 @@ export const currencies: FiatCurrency[] = [
name: 'Indian Rupee',
countryCode: 'in',
accountType: 'INR_ACCOUNT',
accountLabel: 'UPI',
accountLabel: 'UPI / Bank Account',
instantRails: ['UPI'],
allRails: ['UPI'],
allRails: ['UPI', 'NEFT', 'RTGS'],
examplePerson: { fullName: 'Priya Sharma', nationality: 'IN' },
},
{
Expand Down
2 changes: 1 addition & 1 deletion mintlify/snippets/country-support.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ import { FeatureCard, FeatureCardGrid, FeatureCardList, FeatureCardContainer } f
| 🇭🇹 Haiti | HT | `Bank Transfer` |
| 🇭🇺 Hungary | HU | `SEPA` `SEPA Instant` |
| 🇮🇸 Iceland | IS | `SEPA` `SEPA Instant` |
| 🇮🇳 India | IN | `UPI` |
| 🇮🇳 India | IN | `UPI` `NEFT` `RTGS` |
| 🇮🇩 Indonesia | ID | `Bank Transfer` |
| 🇮🇪 Ireland | IE | `SEPA` `SEPA Instant` |
| 🇮🇹 Italy | IT | `SEPA` `SEPA Instant` |
Expand Down
45 changes: 43 additions & 2 deletions mintlify/snippets/external-accounts.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,11 +407,15 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
</Tab>

<Tab title="India">
**UPI**
**UPI, NEFT, or RTGS**

India supports three payment rails: UPI (instant), NEFT (near-real-time), and RTGS (real-time, for large transfers).

**UPI:**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-H 'Authorization: Basic $GRID_CLIENT_ID:$GRID_CLIENT_SECRET' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
Expand All@@ -436,6 +440,43 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
}'
```

**NEFT / RTGS (bank transfer):**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
"platformAccountId": "in_neft_001",
"accountInfo": {
"accountType": "INR_ACCOUNT",
"accountNumber": "000111222333",
"ifsc": "HDFC0001234",
"rail": "NEFT",
"bankName": "HDFC Bank",
"beneficiary": {
"beneficiaryType": "INDIVIDUAL",
"fullName": "Priya Sharma",
"birthDate": "1991-05-14",
"nationality": "IN",
"address": {
"line1": "123 MG Road",
"city": "Mumbai",
"state": "Maharashtra",
"postalCode": "400001",
"country": "IN"
}
}
}
}'
```

<Note>
UPI requires `vpa`. NEFT and RTGS require `accountNumber` (9-18 digits), `ifsc`
(11-character branch code), and `rail` (`NEFT` or `RTGS`). `bankName` is optional
on both. Do not send `paymentRails` — Grid returns it on the created account.
</Note>
</Tab>

<Tab title="Nigeria">
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -115,10 +115,19 @@ private fun buildAccountInfo(accountType: String, accountInfo: JsonNode): Extern
ExternalAccountCreate.AccountInfo.ofUsdAccount(info)
}
"INR_ACCOUNT" -> {
// Which fields apply depends on the rail: UPI uses vpa, NEFT/RTGS use
// accountNumber + ifsc + rail. All are optional on the builder so one
// branch can serve both.
val info = InrExternalAccountCreateInfo.builder()
.accountType(InrExternalAccountCreateInfo.AccountType.INR_ACCOUNT)
.vpa(accountInfo.requireText("vpa"))
.beneficiary(buildInrBeneficiary(beneficiaryNode))
.apply {
accountInfo.optText("vpa")?.let { vpa(it) }
accountInfo.optText("accountNumber")?.let { accountNumber(it) }
accountInfo.optText("ifsc")?.let { ifsc(it) }
accountInfo.optText("rail")?.let { rail(it) }
accountInfo.optText("bankName")?.let { bankName(it) }
}
.build()
ExternalAccountCreate.AccountInfo.ofInrAccount(info)
}
Comment on lines 117 to 133

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1paymentRails never forwarded to the INR account builder

The OpenAPI schema (InrAccountInfo) requires paymentRails (an array like ["NEFT"] or ["UPI"]). The apply block maps all five INR account-info fields, but never reads or sets paymentRails. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include "paymentRails", so the Kotlin path should read it from the incoming request body (e.g., accountInfo.optList("paymentRails")) and call the corresponding builder method.

Prompt To Fix With AI
This is a comment left during a code review.
Path: samples/kotlin/src/main/kotlin/com/grid/sample/routes/ExternalAccounts.kt
Line: 116-129
Comment:
**`paymentRails` never forwarded to the INR account builder**
The OpenAPI schema (`InrAccountInfo`) requires `paymentRails` (an array like `["NEFT"]` or `["UPI"]`). The `apply` block maps all five INR account-info fields, but never reads or sets `paymentRails`. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include `"paymentRails"`, so the Kotlin path should read it from the incoming request body (e.g., `accountInfo.optList("paymentRails")`) and call the corresponding builder method.
How can I resolve this? If you propose a fix, please make it concise.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/grid-visualizer/src/data/account-types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,11 @@ export const accountTypeSpecs: Record<string, AccountTypeSpec> = {
INR_ACCOUNT: {
accountType: 'INR_ACCOUNT',
fields: [
{ name: 'vpa', example: 'customer@okbank' },
{ name: 'vpa', example: 'customer@okbank', description: 'For UPI' },
{ name: 'accountNumber', example: '000111222333', description: 'For NEFT/RTGS (9-18 digits)' },
{ name: 'ifsc', example: 'HDFC0001234', description: 'For NEFT/RTGS (11-character branch code)' },
{ name: 'rail', example: 'NEFT', description: 'NEFT or RTGS' },
{ name: 'bankName', example: 'HDFC Bank', description: 'Optional' },
],
beneficiaryRequired: true,
},
Comment on lines 54 to 64

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Missing required paymentRails field for INR_ACCOUNT

code-generator.ts's buildAccountInfoBody populates the request body exclusively by iterating over spec.fields (line 47–49). The OpenAPI schema (InrAccountInfo) marks paymentRails as a required field, but there is no paymentRails entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A { name: 'paymentRails', example: '["NEFT"]' } entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.

Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/account-types.ts
Line: 54-64
Comment:
**Missing required `paymentRails` field for INR_ACCOUNT**`code-generator.ts`'s `buildAccountInfoBody` populates the request body exclusively by iterating over `spec.fields` (line 47–49). The OpenAPI schema (`InrAccountInfo`) marks `paymentRails` as a **required** field, but there is no `paymentRails` entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A `{ name: 'paymentRails', example: '["NEFT"]' }` entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.
How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant anymore - paymentRails is only on the response

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right — the PR description spells this out clearly: paymentRails belongs to InrAccountInfo (the response wrapper), not InrAccountInfoBase or InrExternalAccountCreateInfo which make up the request. My comment was wrong to treat it as a required request field.

Shall I remember this as a rule: "Do not flag paymentRails as missing from INR account request bodies — it is a response-only field on InrAccountInfo and is not part of the create request schema"?

Expand Down
4 changes: 2 additions & 2 deletions components/grid-visualizer/src/data/currencies.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,9 +103,9 @@ export const currencies: FiatCurrency[] = [
name: 'Indian Rupee',
countryCode: 'in',
accountType: 'INR_ACCOUNT',
accountLabel: 'UPI',
accountLabel: 'UPI / Bank Account',
instantRails: ['UPI'],
allRails: ['UPI'],
allRails: ['UPI', 'NEFT', 'RTGS'],
examplePerson: { fullName: 'Priya Sharma', nationality: 'IN' },
},
{
Expand Down
2 changes: 1 addition & 1 deletion mintlify/snippets/country-support.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ import { FeatureCard, FeatureCardGrid, FeatureCardList, FeatureCardContainer } f
| 🇭🇹 Haiti | HT | `Bank Transfer` |
| 🇭🇺 Hungary | HU | `SEPA` `SEPA Instant` |
| 🇮🇸 Iceland | IS | `SEPA` `SEPA Instant` |
| 🇮🇳 India | IN | `UPI` |
| 🇮🇳 India | IN | `UPI` `NEFT` `RTGS` |
| 🇮🇩 Indonesia | ID | `Bank Transfer` |
| 🇮🇪 Ireland | IE | `SEPA` `SEPA Instant` |
| 🇮🇹 Italy | IT | `SEPA` `SEPA Instant` |
Expand Down
45 changes: 43 additions & 2 deletions mintlify/snippets/external-accounts.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,11 +407,15 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
</Tab>

<Tab title="India">
**UPI**
**UPI, NEFT, or RTGS**

India supports three payment rails: UPI (instant), NEFT (near-real-time), and RTGS (real-time, for large transfers).

**UPI:**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-H 'Authorization: Basic $GRID_CLIENT_ID:$GRID_CLIENT_SECRET' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
Expand All@@ -436,6 +440,43 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
}'
```

**NEFT / RTGS (bank transfer):**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
"platformAccountId": "in_neft_001",
"accountInfo": {
"accountType": "INR_ACCOUNT",
"accountNumber": "000111222333",
"ifsc": "HDFC0001234",
"rail": "NEFT",
"bankName": "HDFC Bank",
"beneficiary": {
"beneficiaryType": "INDIVIDUAL",
"fullName": "Priya Sharma",
"birthDate": "1991-05-14",
"nationality": "IN",
"address": {
"line1": "123 MG Road",
"city": "Mumbai",
"state": "Maharashtra",
"postalCode": "400001",
"country": "IN"
}
}
}
}'
```

<Note>
UPI requires `vpa`. NEFT and RTGS require `accountNumber` (9-18 digits), `ifsc`
(11-character branch code), and `rail` (`NEFT` or `RTGS`). `bankName` is optional
on both. Do not send `paymentRails` — Grid returns it on the created account.
</Note>
</Tab>

<Tab title="Nigeria">
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -115,10 +115,19 @@ private fun buildAccountInfo(accountType: String, accountInfo: JsonNode): Extern
ExternalAccountCreate.AccountInfo.ofUsdAccount(info)
}
"INR_ACCOUNT" -> {
// Which fields apply depends on the rail: UPI uses vpa, NEFT/RTGS use
// accountNumber + ifsc + rail. All are optional on the builder so one
// branch can serve both.
val info = InrExternalAccountCreateInfo.builder()
.accountType(InrExternalAccountCreateInfo.AccountType.INR_ACCOUNT)
.vpa(accountInfo.requireText("vpa"))
.beneficiary(buildInrBeneficiary(beneficiaryNode))
.apply {
accountInfo.optText("vpa")?.let { vpa(it) }
accountInfo.optText("accountNumber")?.let { accountNumber(it) }
accountInfo.optText("ifsc")?.let { ifsc(it) }
accountInfo.optText("rail")?.let { rail(it) }
accountInfo.optText("bankName")?.let { bankName(it) }
}
.build()
ExternalAccountCreate.AccountInfo.ofInrAccount(info)
}
Comment on lines 117 to 133

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1paymentRails never forwarded to the INR account builder

The OpenAPI schema (InrAccountInfo) requires paymentRails (an array like ["NEFT"] or ["UPI"]). The apply block maps all five INR account-info fields, but never reads or sets paymentRails. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include "paymentRails", so the Kotlin path should read it from the incoming request body (e.g., accountInfo.optList("paymentRails")) and call the corresponding builder method.

Prompt To Fix With AI
This is a comment left during a code review.
Path: samples/kotlin/src/main/kotlin/com/grid/sample/routes/ExternalAccounts.kt
Line: 116-129
Comment:
**`paymentRails` never forwarded to the INR account builder**
The OpenAPI schema (`InrAccountInfo`) requires `paymentRails` (an array like `["NEFT"]` or `["UPI"]`). The `apply` block maps all five INR account-info fields, but never reads or sets `paymentRails`. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include `"paymentRails"`, so the Kotlin path should read it from the incoming request body (e.g., `accountInfo.optList("paymentRails")`) and call the corresponding builder method.
How can I resolve this? If you propose a fix, please make it concise.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/grid-visualizer/src/data/account-types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,11 @@ export const accountTypeSpecs: Record<string, AccountTypeSpec> = {
INR_ACCOUNT: {
accountType: 'INR_ACCOUNT',
fields: [
{ name: 'vpa', example: 'customer@okbank' },
{ name: 'vpa', example: 'customer@okbank', description: 'For UPI' },
{ name: 'accountNumber', example: '000111222333', description: 'For NEFT/RTGS (9-18 digits)' },
{ name: 'ifsc', example: 'HDFC0001234', description: 'For NEFT/RTGS (11-character branch code)' },
{ name: 'rail', example: 'NEFT', description: 'NEFT or RTGS' },
{ name: 'bankName', example: 'HDFC Bank', description: 'Optional' },
],
beneficiaryRequired: true,
},
Comment on lines 54 to 64

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Missing required paymentRails field for INR_ACCOUNT

code-generator.ts's buildAccountInfoBody populates the request body exclusively by iterating over spec.fields (line 47–49). The OpenAPI schema (InrAccountInfo) marks paymentRails as a required field, but there is no paymentRails entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A { name: 'paymentRails', example: '["NEFT"]' } entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.

Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/account-types.ts
Line: 54-64
Comment:
**Missing required `paymentRails` field for INR_ACCOUNT**`code-generator.ts`'s `buildAccountInfoBody` populates the request body exclusively by iterating over `spec.fields` (line 47–49). The OpenAPI schema (`InrAccountInfo`) marks `paymentRails` as a **required** field, but there is no `paymentRails` entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A `{ name: 'paymentRails', example: '["NEFT"]' }` entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.
How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant anymore - paymentRails is only on the response

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right — the PR description spells this out clearly: paymentRails belongs to InrAccountInfo (the response wrapper), not InrAccountInfoBase or InrExternalAccountCreateInfo which make up the request. My comment was wrong to treat it as a required request field.

Shall I remember this as a rule: "Do not flag paymentRails as missing from INR account request bodies — it is a response-only field on InrAccountInfo and is not part of the create request schema"?

Expand Down
4 changes: 2 additions & 2 deletions components/grid-visualizer/src/data/currencies.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,9 +103,9 @@ export const currencies: FiatCurrency[] = [
name: 'Indian Rupee',
countryCode: 'in',
accountType: 'INR_ACCOUNT',
accountLabel: 'UPI',
accountLabel: 'UPI / Bank Account',
instantRails: ['UPI'],
allRails: ['UPI'],
allRails: ['UPI', 'NEFT', 'RTGS'],
examplePerson: { fullName: 'Priya Sharma', nationality: 'IN' },
},
{
Expand Down
2 changes: 1 addition & 1 deletion mintlify/snippets/country-support.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ import { FeatureCard, FeatureCardGrid, FeatureCardList, FeatureCardContainer } f
| 🇭🇹 Haiti | HT | `Bank Transfer` |
| 🇭🇺 Hungary | HU | `SEPA` `SEPA Instant` |
| 🇮🇸 Iceland | IS | `SEPA` `SEPA Instant` |
| 🇮🇳 India | IN | `UPI` |
| 🇮🇳 India | IN | `UPI` `NEFT` `RTGS` |
| 🇮🇩 Indonesia | ID | `Bank Transfer` |
| 🇮🇪 Ireland | IE | `SEPA` `SEPA Instant` |
| 🇮🇹 Italy | IT | `SEPA` `SEPA Instant` |
Expand Down
45 changes: 43 additions & 2 deletions mintlify/snippets/external-accounts.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,11 +407,15 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
</Tab>

<Tab title="India">
**UPI**
**UPI, NEFT, or RTGS**

India supports three payment rails: UPI (instant), NEFT (near-real-time), and RTGS (real-time, for large transfers).

**UPI:**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-H 'Authorization: Basic $GRID_CLIENT_ID:$GRID_CLIENT_SECRET' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
Expand All@@ -436,6 +440,43 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
}'
```

**NEFT / RTGS (bank transfer):**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
"platformAccountId": "in_neft_001",
"accountInfo": {
"accountType": "INR_ACCOUNT",
"accountNumber": "000111222333",
"ifsc": "HDFC0001234",
"rail": "NEFT",
"bankName": "HDFC Bank",
"beneficiary": {
"beneficiaryType": "INDIVIDUAL",
"fullName": "Priya Sharma",
"birthDate": "1991-05-14",
"nationality": "IN",
"address": {
"line1": "123 MG Road",
"city": "Mumbai",
"state": "Maharashtra",
"postalCode": "400001",
"country": "IN"
}
}
}
}'
```

<Note>
UPI requires `vpa`. NEFT and RTGS require `accountNumber` (9-18 digits), `ifsc`
(11-character branch code), and `rail` (`NEFT` or `RTGS`). `bankName` is optional
on both. Do not send `paymentRails` — Grid returns it on the created account.
</Note>
</Tab>

<Tab title="Nigeria">
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -115,10 +115,19 @@ private fun buildAccountInfo(accountType: String, accountInfo: JsonNode): Extern
ExternalAccountCreate.AccountInfo.ofUsdAccount(info)
}
"INR_ACCOUNT" -> {
// Which fields apply depends on the rail: UPI uses vpa, NEFT/RTGS use
// accountNumber + ifsc + rail. All are optional on the builder so one
// branch can serve both.
val info = InrExternalAccountCreateInfo.builder()
.accountType(InrExternalAccountCreateInfo.AccountType.INR_ACCOUNT)
.vpa(accountInfo.requireText("vpa"))
.beneficiary(buildInrBeneficiary(beneficiaryNode))
.apply {
accountInfo.optText("vpa")?.let { vpa(it) }
accountInfo.optText("accountNumber")?.let { accountNumber(it) }
accountInfo.optText("ifsc")?.let { ifsc(it) }
accountInfo.optText("rail")?.let { rail(it) }
accountInfo.optText("bankName")?.let { bankName(it) }
}
.build()
ExternalAccountCreate.AccountInfo.ofInrAccount(info)
}
Comment on lines 117 to 133

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1paymentRails never forwarded to the INR account builder

The OpenAPI schema (InrAccountInfo) requires paymentRails (an array like ["NEFT"] or ["UPI"]). The apply block maps all five INR account-info fields, but never reads or sets paymentRails. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include "paymentRails", so the Kotlin path should read it from the incoming request body (e.g., accountInfo.optList("paymentRails")) and call the corresponding builder method.

Prompt To Fix With AI
This is a comment left during a code review.
Path: samples/kotlin/src/main/kotlin/com/grid/sample/routes/ExternalAccounts.kt
Line: 116-129
Comment:
**`paymentRails` never forwarded to the INR account builder**
The OpenAPI schema (`InrAccountInfo`) requires `paymentRails` (an array like `["NEFT"]` or `["UPI"]`). The `apply` block maps all five INR account-info fields, but never reads or sets `paymentRails`. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include `"paymentRails"`, so the Kotlin path should read it from the incoming request body (e.g., `accountInfo.optList("paymentRails")`) and call the corresponding builder method.
How can I resolve this? If you propose a fix, please make it concise.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/grid-visualizer/src/data/account-types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,11 @@ export const accountTypeSpecs: Record<string, AccountTypeSpec> = {
INR_ACCOUNT: {
accountType: 'INR_ACCOUNT',
fields: [
{ name: 'vpa', example: 'customer@okbank' },
{ name: 'vpa', example: 'customer@okbank', description: 'For UPI' },
{ name: 'accountNumber', example: '000111222333', description: 'For NEFT/RTGS (9-18 digits)' },
{ name: 'ifsc', example: 'HDFC0001234', description: 'For NEFT/RTGS (11-character branch code)' },
{ name: 'rail', example: 'NEFT', description: 'NEFT or RTGS' },
{ name: 'bankName', example: 'HDFC Bank', description: 'Optional' },
],
beneficiaryRequired: true,
},
Comment on lines 54 to 64

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Missing required paymentRails field for INR_ACCOUNT

code-generator.ts's buildAccountInfoBody populates the request body exclusively by iterating over spec.fields (line 47–49). The OpenAPI schema (InrAccountInfo) marks paymentRails as a required field, but there is no paymentRails entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A { name: 'paymentRails', example: '["NEFT"]' } entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.

Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/account-types.ts
Line: 54-64
Comment:
**Missing required `paymentRails` field for INR_ACCOUNT**`code-generator.ts`'s `buildAccountInfoBody` populates the request body exclusively by iterating over `spec.fields` (line 47–49). The OpenAPI schema (`InrAccountInfo`) marks `paymentRails` as a **required** field, but there is no `paymentRails` entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A `{ name: 'paymentRails', example: '["NEFT"]' }` entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.
How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant anymore - paymentRails is only on the response

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right — the PR description spells this out clearly: paymentRails belongs to InrAccountInfo (the response wrapper), not InrAccountInfoBase or InrExternalAccountCreateInfo which make up the request. My comment was wrong to treat it as a required request field.

Shall I remember this as a rule: "Do not flag paymentRails as missing from INR account request bodies — it is a response-only field on InrAccountInfo and is not part of the create request schema"?

Expand Down
4 changes: 2 additions & 2 deletions components/grid-visualizer/src/data/currencies.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,9 +103,9 @@ export const currencies: FiatCurrency[] = [
name: 'Indian Rupee',
countryCode: 'in',
accountType: 'INR_ACCOUNT',
accountLabel: 'UPI',
accountLabel: 'UPI / Bank Account',
instantRails: ['UPI'],
allRails: ['UPI'],
allRails: ['UPI', 'NEFT', 'RTGS'],
examplePerson: { fullName: 'Priya Sharma', nationality: 'IN' },
},
{
Expand Down
2 changes: 1 addition & 1 deletion mintlify/snippets/country-support.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ import { FeatureCard, FeatureCardGrid, FeatureCardList, FeatureCardContainer } f
| 🇭🇹 Haiti | HT | `Bank Transfer` |
| 🇭🇺 Hungary | HU | `SEPA` `SEPA Instant` |
| 🇮🇸 Iceland | IS | `SEPA` `SEPA Instant` |
| 🇮🇳 India | IN | `UPI` |
| 🇮🇳 India | IN | `UPI` `NEFT` `RTGS` |
| 🇮🇩 Indonesia | ID | `Bank Transfer` |
| 🇮🇪 Ireland | IE | `SEPA` `SEPA Instant` |
| 🇮🇹 Italy | IT | `SEPA` `SEPA Instant` |
Expand Down
45 changes: 43 additions & 2 deletions mintlify/snippets/external-accounts.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,11 +407,15 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
</Tab>

<Tab title="India">
**UPI**
**UPI, NEFT, or RTGS**

India supports three payment rails: UPI (instant), NEFT (near-real-time), and RTGS (real-time, for large transfers).

**UPI:**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-H 'Authorization: Basic $GRID_CLIENT_ID:$GRID_CLIENT_SECRET' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
Expand All@@ -436,6 +440,43 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
}'
```

**NEFT / RTGS (bank transfer):**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
"platformAccountId": "in_neft_001",
"accountInfo": {
"accountType": "INR_ACCOUNT",
"accountNumber": "000111222333",
"ifsc": "HDFC0001234",
"rail": "NEFT",
"bankName": "HDFC Bank",
"beneficiary": {
"beneficiaryType": "INDIVIDUAL",
"fullName": "Priya Sharma",
"birthDate": "1991-05-14",
"nationality": "IN",
"address": {
"line1": "123 MG Road",
"city": "Mumbai",
"state": "Maharashtra",
"postalCode": "400001",
"country": "IN"
}
}
}
}'
```

<Note>
UPI requires `vpa`. NEFT and RTGS require `accountNumber` (9-18 digits), `ifsc`
(11-character branch code), and `rail` (`NEFT` or `RTGS`). `bankName` is optional
on both. Do not send `paymentRails` — Grid returns it on the created account.
</Note>
</Tab>

<Tab title="Nigeria">
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -115,10 +115,19 @@ private fun buildAccountInfo(accountType: String, accountInfo: JsonNode): Extern
ExternalAccountCreate.AccountInfo.ofUsdAccount(info)
}
"INR_ACCOUNT" -> {
// Which fields apply depends on the rail: UPI uses vpa, NEFT/RTGS use
// accountNumber + ifsc + rail. All are optional on the builder so one
// branch can serve both.
val info = InrExternalAccountCreateInfo.builder()
.accountType(InrExternalAccountCreateInfo.AccountType.INR_ACCOUNT)
.vpa(accountInfo.requireText("vpa"))
.beneficiary(buildInrBeneficiary(beneficiaryNode))
.apply {
accountInfo.optText("vpa")?.let { vpa(it) }
accountInfo.optText("accountNumber")?.let { accountNumber(it) }
accountInfo.optText("ifsc")?.let { ifsc(it) }
accountInfo.optText("rail")?.let { rail(it) }
accountInfo.optText("bankName")?.let { bankName(it) }
}
.build()
ExternalAccountCreate.AccountInfo.ofInrAccount(info)
}
Comment on lines 117 to 133

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1paymentRails never forwarded to the INR account builder

The OpenAPI schema (InrAccountInfo) requires paymentRails (an array like ["NEFT"] or ["UPI"]). The apply block maps all five INR account-info fields, but never reads or sets paymentRails. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include "paymentRails", so the Kotlin path should read it from the incoming request body (e.g., accountInfo.optList("paymentRails")) and call the corresponding builder method.

Prompt To Fix With AI
This is a comment left during a code review.
Path: samples/kotlin/src/main/kotlin/com/grid/sample/routes/ExternalAccounts.kt
Line: 116-129
Comment:
**`paymentRails` never forwarded to the INR account builder**
The OpenAPI schema (`InrAccountInfo`) requires `paymentRails` (an array like `["NEFT"]` or `["UPI"]`). The `apply` block maps all five INR account-info fields, but never reads or sets `paymentRails`. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include `"paymentRails"`, so the Kotlin path should read it from the incoming request body (e.g., `accountInfo.optList("paymentRails")`) and call the corresponding builder method.
How can I resolve this? If you propose a fix, please make it concise.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/grid-visualizer/src/data/account-types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,11 @@ export const accountTypeSpecs: Record<string, AccountTypeSpec> = {
INR_ACCOUNT: {
accountType: 'INR_ACCOUNT',
fields: [
{ name: 'vpa', example: 'customer@okbank' },
{ name: 'vpa', example: 'customer@okbank', description: 'For UPI' },
{ name: 'accountNumber', example: '000111222333', description: 'For NEFT/RTGS (9-18 digits)' },
{ name: 'ifsc', example: 'HDFC0001234', description: 'For NEFT/RTGS (11-character branch code)' },
{ name: 'rail', example: 'NEFT', description: 'NEFT or RTGS' },
{ name: 'bankName', example: 'HDFC Bank', description: 'Optional' },
],
beneficiaryRequired: true,
},
Comment on lines 54 to 64

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Missing required paymentRails field for INR_ACCOUNT

code-generator.ts's buildAccountInfoBody populates the request body exclusively by iterating over spec.fields (line 47–49). The OpenAPI schema (InrAccountInfo) marks paymentRails as a required field, but there is no paymentRails entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A { name: 'paymentRails', example: '["NEFT"]' } entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.

Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/account-types.ts
Line: 54-64
Comment:
**Missing required `paymentRails` field for INR_ACCOUNT**`code-generator.ts`'s `buildAccountInfoBody` populates the request body exclusively by iterating over `spec.fields` (line 47–49). The OpenAPI schema (`InrAccountInfo`) marks `paymentRails` as a **required** field, but there is no `paymentRails` entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A `{ name: 'paymentRails', example: '["NEFT"]' }` entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.
How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant anymore - paymentRails is only on the response

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right — the PR description spells this out clearly: paymentRails belongs to InrAccountInfo (the response wrapper), not InrAccountInfoBase or InrExternalAccountCreateInfo which make up the request. My comment was wrong to treat it as a required request field.

Shall I remember this as a rule: "Do not flag paymentRails as missing from INR account request bodies — it is a response-only field on InrAccountInfo and is not part of the create request schema"?

Expand Down
4 changes: 2 additions & 2 deletions components/grid-visualizer/src/data/currencies.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,9 +103,9 @@ export const currencies: FiatCurrency[] = [
name: 'Indian Rupee',
countryCode: 'in',
accountType: 'INR_ACCOUNT',
accountLabel: 'UPI',
accountLabel: 'UPI / Bank Account',
instantRails: ['UPI'],
allRails: ['UPI'],
allRails: ['UPI', 'NEFT', 'RTGS'],
examplePerson: { fullName: 'Priya Sharma', nationality: 'IN' },
},
{
Expand Down
2 changes: 1 addition & 1 deletion mintlify/snippets/country-support.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ import { FeatureCard, FeatureCardGrid, FeatureCardList, FeatureCardContainer } f
| 🇭🇹 Haiti | HT | `Bank Transfer` |
| 🇭🇺 Hungary | HU | `SEPA` `SEPA Instant` |
| 🇮🇸 Iceland | IS | `SEPA` `SEPA Instant` |
| 🇮🇳 India | IN | `UPI` |
| 🇮🇳 India | IN | `UPI` `NEFT` `RTGS` |
| 🇮🇩 Indonesia | ID | `Bank Transfer` |
| 🇮🇪 Ireland | IE | `SEPA` `SEPA Instant` |
| 🇮🇹 Italy | IT | `SEPA` `SEPA Instant` |
Expand Down
45 changes: 43 additions & 2 deletions mintlify/snippets/external-accounts.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,11 +407,15 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
</Tab>

<Tab title="India">
**UPI**
**UPI, NEFT, or RTGS**

India supports three payment rails: UPI (instant), NEFT (near-real-time), and RTGS (real-time, for large transfers).

**UPI:**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-H 'Authorization: Basic $GRID_CLIENT_ID:$GRID_CLIENT_SECRET' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
Expand All@@ -436,6 +440,43 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
}'
```

**NEFT / RTGS (bank transfer):**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
"platformAccountId": "in_neft_001",
"accountInfo": {
"accountType": "INR_ACCOUNT",
"accountNumber": "000111222333",
"ifsc": "HDFC0001234",
"rail": "NEFT",
"bankName": "HDFC Bank",
"beneficiary": {
"beneficiaryType": "INDIVIDUAL",
"fullName": "Priya Sharma",
"birthDate": "1991-05-14",
"nationality": "IN",
"address": {
"line1": "123 MG Road",
"city": "Mumbai",
"state": "Maharashtra",
"postalCode": "400001",
"country": "IN"
}
}
}
}'
```

<Note>
UPI requires `vpa`. NEFT and RTGS require `accountNumber` (9-18 digits), `ifsc`
(11-character branch code), and `rail` (`NEFT` or `RTGS`). `bankName` is optional
on both. Do not send `paymentRails` — Grid returns it on the created account.
</Note>
</Tab>

<Tab title="Nigeria">
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -115,10 +115,19 @@ private fun buildAccountInfo(accountType: String, accountInfo: JsonNode): Extern
ExternalAccountCreate.AccountInfo.ofUsdAccount(info)
}
"INR_ACCOUNT" -> {
// Which fields apply depends on the rail: UPI uses vpa, NEFT/RTGS use
// accountNumber + ifsc + rail. All are optional on the builder so one
// branch can serve both.
val info = InrExternalAccountCreateInfo.builder()
.accountType(InrExternalAccountCreateInfo.AccountType.INR_ACCOUNT)
.vpa(accountInfo.requireText("vpa"))
.beneficiary(buildInrBeneficiary(beneficiaryNode))
.apply {
accountInfo.optText("vpa")?.let { vpa(it) }
accountInfo.optText("accountNumber")?.let { accountNumber(it) }
accountInfo.optText("ifsc")?.let { ifsc(it) }
accountInfo.optText("rail")?.let { rail(it) }
accountInfo.optText("bankName")?.let { bankName(it) }
}
.build()
ExternalAccountCreate.AccountInfo.ofInrAccount(info)
}
Comment on lines 117 to 133

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1paymentRails never forwarded to the INR account builder

The OpenAPI schema (InrAccountInfo) requires paymentRails (an array like ["NEFT"] or ["UPI"]). The apply block maps all five INR account-info fields, but never reads or sets paymentRails. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include "paymentRails", so the Kotlin path should read it from the incoming request body (e.g., accountInfo.optList("paymentRails")) and call the corresponding builder method.

Prompt To Fix With AI
This is a comment left during a code review.
Path: samples/kotlin/src/main/kotlin/com/grid/sample/routes/ExternalAccounts.kt
Line: 116-129
Comment:
**`paymentRails` never forwarded to the INR account builder**
The OpenAPI schema (`InrAccountInfo`) requires `paymentRails` (an array like `["NEFT"]` or `["UPI"]`). The `apply` block maps all five INR account-info fields, but never reads or sets `paymentRails`. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include `"paymentRails"`, so the Kotlin path should read it from the incoming request body (e.g., `accountInfo.optList("paymentRails")`) and call the corresponding builder method.
How can I resolve this? If you propose a fix, please make it concise.

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/grid-visualizer/src/data/account-types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,11 @@ export const accountTypeSpecs: Record<string, AccountTypeSpec> = {
INR_ACCOUNT: {
accountType: 'INR_ACCOUNT',
fields: [
{ name: 'vpa', example: 'customer@okbank' },
{ name: 'vpa', example: 'customer@okbank', description: 'For UPI' },
{ name: 'accountNumber', example: '000111222333', description: 'For NEFT/RTGS (9-18 digits)' },
{ name: 'ifsc', example: 'HDFC0001234', description: 'For NEFT/RTGS (11-character branch code)' },
{ name: 'rail', example: 'NEFT', description: 'NEFT or RTGS' },
{ name: 'bankName', example: 'HDFC Bank', description: 'Optional' },
],
beneficiaryRequired: true,
},
Comment on lines 54 to 64

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Missing required paymentRails field for INR_ACCOUNT

code-generator.ts's buildAccountInfoBody populates the request body exclusively by iterating over spec.fields (line 47–49). The OpenAPI schema (InrAccountInfo) marks paymentRails as a required field, but there is no paymentRails entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A { name: 'paymentRails', example: '["NEFT"]' } entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.

Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/account-types.ts
Line: 54-64
Comment:
**Missing required `paymentRails` field for INR_ACCOUNT**`code-generator.ts`'s `buildAccountInfoBody` populates the request body exclusively by iterating over `spec.fields` (line 47–49). The OpenAPI schema (`InrAccountInfo`) marks `paymentRails` as a **required** field, but there is no `paymentRails` entry in the fields array here. Every INR account creation call emitted by the Grid Visualizer will therefore be missing that field and fail API validation. A `{ name: 'paymentRails', example: '["NEFT"]' }` entry (or equivalent special-casing in the code generator) is needed to produce a valid request body.
How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant anymore - paymentRails is only on the response

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right — the PR description spells this out clearly: paymentRails belongs to InrAccountInfo (the response wrapper), not InrAccountInfoBase or InrExternalAccountCreateInfo which make up the request. My comment was wrong to treat it as a required request field.

Shall I remember this as a rule: "Do not flag paymentRails as missing from INR account request bodies — it is a response-only field on InrAccountInfo and is not part of the create request schema"?

Expand Down
4 changes: 2 additions & 2 deletions components/grid-visualizer/src/data/currencies.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,9 +103,9 @@ export const currencies: FiatCurrency[] = [
name: 'Indian Rupee',
countryCode: 'in',
accountType: 'INR_ACCOUNT',
accountLabel: 'UPI',
accountLabel: 'UPI / Bank Account',
instantRails: ['UPI'],
allRails: ['UPI'],
allRails: ['UPI', 'NEFT', 'RTGS'],
examplePerson: { fullName: 'Priya Sharma', nationality: 'IN' },
},
{
Expand Down
2 changes: 1 addition & 1 deletion mintlify/snippets/country-support.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,7 +40,7 @@ import { FeatureCard, FeatureCardGrid, FeatureCardList, FeatureCardContainer } f
| 🇭🇹 Haiti | HT | `Bank Transfer` |
| 🇭🇺 Hungary | HU | `SEPA` `SEPA Instant` |
| 🇮🇸 Iceland | IS | `SEPA` `SEPA Instant` |
| 🇮🇳 India | IN | `UPI` |
| 🇮🇳 India | IN | `UPI` `NEFT` `RTGS` |
| 🇮🇩 Indonesia | ID | `Bank Transfer` |
| 🇮🇪 Ireland | IE | `SEPA` `SEPA Instant` |
| 🇮🇹 Italy | IT | `SEPA` `SEPA Instant` |
Expand Down
45 changes: 43 additions & 2 deletions mintlify/snippets/external-accounts.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -407,11 +407,15 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
</Tab>

<Tab title="India">
**UPI**
**UPI, NEFT, or RTGS**

India supports three payment rails: UPI (instant), NEFT (near-real-time), and RTGS (real-time, for large transfers).

**UPI:**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-H 'Authorization: Basic $GRID_CLIENT_ID:$GRID_CLIENT_SECRET' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
Expand All@@ -436,6 +440,43 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-acco
}'
```

**NEFT / RTGS (bank transfer):**

```bash cURL
curl -X POST 'https://api.lightspark.com/grid/2025-10-13/customers/external-accounts' \
-u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
-H 'Content-Type: application/json' \
-d '{
"currency": "INR",
"platformAccountId": "in_neft_001",
"accountInfo": {
"accountType": "INR_ACCOUNT",
"accountNumber": "000111222333",
"ifsc": "HDFC0001234",
"rail": "NEFT",
"bankName": "HDFC Bank",
"beneficiary": {
"beneficiaryType": "INDIVIDUAL",
"fullName": "Priya Sharma",
"birthDate": "1991-05-14",
"nationality": "IN",
"address": {
"line1": "123 MG Road",
"city": "Mumbai",
"state": "Maharashtra",
"postalCode": "400001",
"country": "IN"
}
}
}
}'
```

<Note>
UPI requires `vpa`. NEFT and RTGS require `accountNumber` (9-18 digits), `ifsc`
(11-character branch code), and `rail` (`NEFT` or `RTGS`). `bankName` is optional
on both. Do not send `paymentRails` — Grid returns it on the created account.
</Note>
</Tab>

<Tab title="Nigeria">
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -115,10 +115,19 @@ private fun buildAccountInfo(accountType: String, accountInfo: JsonNode): Extern
ExternalAccountCreate.AccountInfo.ofUsdAccount(info)
}
"INR_ACCOUNT" -> {
// Which fields apply depends on the rail: UPI uses vpa, NEFT/RTGS use
// accountNumber + ifsc + rail. All are optional on the builder so one
// branch can serve both.
val info = InrExternalAccountCreateInfo.builder()
.accountType(InrExternalAccountCreateInfo.AccountType.INR_ACCOUNT)
.vpa(accountInfo.requireText("vpa"))
.beneficiary(buildInrBeneficiary(beneficiaryNode))
.apply {
accountInfo.optText("vpa")?.let { vpa(it) }
accountInfo.optText("accountNumber")?.let { accountNumber(it) }
accountInfo.optText("ifsc")?.let { ifsc(it) }
accountInfo.optText("rail")?.let { rail(it) }
accountInfo.optText("bankName")?.let { bankName(it) }
}
.build()
ExternalAccountCreate.AccountInfo.ofInrAccount(info)
}
Comment on lines 117 to 133

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1paymentRails never forwarded to the INR account builder

The OpenAPI schema (InrAccountInfo) requires paymentRails (an array like ["NEFT"] or ["UPI"]). The apply block maps all five INR account-info fields, but never reads or sets paymentRails. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include "paymentRails", so the Kotlin path should read it from the incoming request body (e.g., accountInfo.optList("paymentRails")) and call the corresponding builder method.

Prompt To Fix With AI
This is a comment left during a code review.
Path: samples/kotlin/src/main/kotlin/com/grid/sample/routes/ExternalAccounts.kt
Line: 116-129
Comment:
**`paymentRails` never forwarded to the INR account builder**
The OpenAPI schema (`InrAccountInfo`) requires `paymentRails` (an array like `["NEFT"]` or `["UPI"]`). The `apply` block maps all five INR account-info fields, but never reads or sets `paymentRails`. Any INR account creation request routed through this sample will omit the required field and receive a validation error from the API. Both the UPI and NEFT/RTGS documentation examples explicitly include `"paymentRails"`, so the Kotlin path should read it from the incoming request body (e.g., `accountInfo.optList("paymentRails")`) and call the corresponding builder method.
How can I resolve this? If you propose a fix, please make it concise.

Expand Down
Loading