Skip to content

chore: Sync account schemas#692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lightspark-copybara wants to merge 1 commit into from
Closed

chore: Sync account schemas #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion mintlify/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion openapi/components/schemas/common/GtqAccountInfoBase.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ properties:
- SAVINGS
bankName:
type: string
description: The name of the beneficiary's bank
description: The name of the bank
minLength: 1
maxLength: 255
example:
Expand Down
8 changes: 8 additions & 0 deletions openapi/components/schemas/common/PhpAccountInfoBase.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,15 @@ properties:
maxLength: 16
example: '001234567890'
pattern: ^[0-9]{8,16}$
rail:
type: string
description: The payment rail to route the payout over, for currencies that support
more than one (e.g. NEFT or RTGS for INR).
example: NEFT
minLength: 1
maxLength: 32
example:
accountType: PHP_ACCOUNT
bankName: BDO Unibank
accountNumber: '001234567890'
rail: NEFT
Comment on lines +24 to +35

@greptile-appsgreptile-appsBotJul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 The rail field description and example are copied verbatim from InrAccountInfoBase.yaml and reference Indian payment rails (NEFT, RTGS) rather than Philippine ones. A developer integrating PHP payouts will see "e.g. NEFT or RTGS for INR" and the example value NEFT, both of which are specific to India's NEFT/RTGS interbank clearing systems. The description and example should reflect the actual Philippine payment rails (e.g., PESONet or InstaPay).

Suggested change
rail:
type: string
description: The payment rail to route the payout over, for currencies that support
more than one (e.g. NEFT or RTGS for INR).
example: NEFT
minLength: 1
maxLength: 32
example:
accountType: PHP_ACCOUNT
bankName: BDO Unibank
accountNumber: '001234567890'
rail: NEFT
rail:
type: string
description: The payment rail to route the payout over, for currencies that support
more than one (e.g. PESONet or InstaPay for PHP).
example: PESONet
minLength: 1
maxLength: 32
example:
accountType: PHP_ACCOUNT
bankName: BDO Unibank
accountNumber: '001234567890'
rail: PESONet
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/PhpAccountInfoBase.yaml
Line: 24-35
Comment:
The `rail` field description and example are copied verbatim from `InrAccountInfoBase.yaml` and reference Indian payment rails (NEFT, RTGS) rather than Philippine ones. A developer integrating PHP payouts will see "e.g. NEFT or RTGS for INR" and the example value `NEFT`, both of which are specific to India's NEFT/RTGS interbank clearing systems. The description and example should reflect the actual Philippine payment rails (e.g., PESONet or InstaPay).
```suggestion rail: type: string description: The payment rail to route the payout over, for currencies that support more than one (e.g. PESONet or InstaPay for PHP). example: PESONet minLength: 1 maxLength: 32example: accountType: PHP_ACCOUNT bankName: BDO Unibank accountNumber: '001234567890' rail: PESONet```
How can I resolve this? If you propose a fix, please make it concise.

Loading