Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .claude/skills/grid-api/SKILL.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -220,7 +220,6 @@ curl -s -u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
"currency": "MXN",
"accountInfo": {
"accountType": "MXN_ACCOUNT",
"paymentRails": ["SPEI"],
"clabeNumber": "<18-digit-number>",
"beneficiary": {
"beneficiaryType": "INDIVIDUAL",
Expand DownExpand Up@@ -578,7 +577,7 @@ Use this flow when the user asks for a "realtime quote" or "just in time" funded
7. **Destination currency is only for UMA**: Specify `currency` in the destination object ONLY for `UMA_ADDRESS` destinations. For `ACCOUNT` destinations the currency is intrinsic to the account and must be omitted — the only optional field there is `paymentRail`
8. **Individual beneficiary requires fullName**: For `beneficiaryType: "INDIVIDUAL"`, `fullName` is required. `birthDate` (YYYY-MM-DD) and `nationality` (2-letter code) are optional but recommended
9. **Use correct Nigerian field names**: Use `bankName` (NOT `bankCode`) and include `purposeOfPayment`
10. **Don't forget country-specific required fields**: Brazil (BRL_ACCOUNT) requires `pixKey`, `pixKeyType`, and `taxId`; Europe (EUR_ACCOUNT) requires `iban`; all fiat accounts require `paymentRails`
10. **Don't forget country-specific required fields**: Brazil (BRL_ACCOUNT) requires `pixKey`, `pixKeyType`, and `taxId`; Europe (EUR_ACCOUNT) requires `iban`; all fiat accounts require a `beneficiary`. Do not send `paymentRails` — Grid selects the rail and returns it on the created account.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Create schemas still require paymentRails

When users follow the MXN or USD external-account creation guidance, the changed examples omit paymentRails and the new text explicitly says not to send it, even though both OpenAPI create schemas mark it as required, causing copied requests to fail schema or API validation.

Context Used: CLAUDE.md (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: .claude/skills/grid-api/SKILL.md
Line: 580
Comment:
**Create schemas still require paymentRails**
When users follow the MXN or USD external-account creation guidance, the changed examples omit `paymentRails` and the new text explicitly says not to send it, even though both OpenAPI create schemas mark it as required, causing copied requests to fail schema or API validation.
**Context Used:** CLAUDE.md ([source](https://github.com/lightsparkdev/grid-api/blob/main/CLAUDE.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.


## Error Handling

Expand Down
2 changes: 0 additions & 2 deletions .claude/skills/grid-api/references/workflows.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -165,7 +165,6 @@ curl -s -u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
"currency": "MXN",
"accountInfo": {
"accountType": "MXN_ACCOUNT",
"paymentRails": ["SPEI"],
"clabeNumber": "012345678901234567",
"beneficiary": {
"beneficiaryType": "INDIVIDUAL",
Expand DownExpand Up@@ -296,7 +295,6 @@ curl -s -u "$GRID_CLIENT_ID:$GRID_CLIENT_SECRET" \
"currency": "USD",
"accountInfo": {
"accountType": "USD_ACCOUNT",
"paymentRails": ["ACH"],
"routingNumber": "123456789",
"accountNumber": "12345678901",
"beneficiary": {
Expand Down
Loading