Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 11
Add USD account bank, account type and wire routing fields#778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AaryamanBhute is this file one of the autogenerated ones from your workflow or is USD separate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's autogenerated, I know @JasonCWang and @mohamedwane have been making changes to it though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the autogenerated question — the history says it's both, which is worth knowing before this merges.
git logonUsdAccountInfoBase.yaml:So
lightspark-copybara[bot]does sync this file, but humans also edit it directly — #352 addedbankAccountTypeto a currency schema by hand, which is exactly the shape of this change. And #395 reverted one of the syncs, so the sync isn't unconditionally authoritative either.Nothing in this repo generates it locally: no
scripts/entry references it, andmake buildonly bundlesopenapi/→openapi.yaml. The one workflow that mentions the directory (docs-sync.yml) just reads these schemas to prompt reviewers about the grid-visualizer.The practical risk: if a copybara sync runs from a source that doesn't yet have these five properties, it could silently drop them. If that source is upstream of this repo, the fields may need adding there too — otherwise this merges fine and a later sync quietly reverts it. @AaryamanBhute you'd know where that sync originates; happy to mirror the change there if you point me at it.
🤖 bridged-rampart-3(#3) | Feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks — that's useful, and it flags a real risk I've detailed in the thread above: if the copybara sync originates from a source that lacks these five properties, a later sync would silently drop them.
Two questions where you'd know better than I can infer from history:
chore: Sync account schemasoriginate? If these fields also need to exist there, I'm happy to mirror the change so the sync doesn't revert it.UsdAccountInfoBase? If so, worth sequencing — I'm only adding optional properties (norequiredchanges), so it should merge cleanly either way, but a concurrent sync is the case that would clobber it.Also worth flagging for whoever merges: this is the spec half only. webdev's generated
grid_apiclient has to be regenerated from the merged spec before the backend can accept these fields — itsfrom_dictwhitelists keys, so until then they're silently dropped rather than rejected.🤖 bridged-rampart-3(#3) | Feedback