feat(spec): remove the VASP directory endpoint by shreyav · Pull Request #875 · lightsparkdev/grid-api

shreyav · 2026-08-28T16:47:42Z

Removes GET /vasps — the directory of Virtual Asset Service Providers — from the Grid API spec.

Changes

openapi/paths/vasps/vasps.yaml — deleted (the listVasps operation); directory removed
openapi/components/schemas/vasps/ — deleted Vasp.yaml and VaspListResponse.yaml; directory removed
openapi/openapi.yaml — dropped the VASPs tag and the /vasps path $ref
.stainless/stainless.yml — dropped the vasps resource, so generated SDKs no longer expose vasps.list
openapi/components/schemas/external_accounts/WalletCustodyFields.yaml — removed the "from the VASP directory (GET /vasps)" clause from the vaspName description
openapi.yaml / mintlify/openapi.yaml — rebundled via make build

The vaspName field on wallet external accounts is not removed — it is an input on external account creation, independent of the directory that previously enumerated valid values.

Validation

make build — rebundled cleanly; the bundled diff contains only the removal, no incidental reformatting
make lint — exits 0 (666 problems, 0 errors); all warnings/infos are pre-existing and none are VASP-related
No Mintlify navigation change needed: the API reference is generated from the Stainless-hosted spec. Remaining VASP mentions in the docs are unrelated prose (inter-VASP settlement legs, counterparty VASP in UMA flows).

Open question

CLAUDE.md says to bump info.version only when a breaking change ships, matching a new servers.url path. Removing a published endpoint is breaking, but choosing the new version date and deciding whether this rides a version cut is a release call — so info.version is left at 2025-10-13. Please advise if it should move as part of this change.

Downstream

lightsparkdev/webdev vendors this spec and its generated Python client under grid-api/, refreshed by ./update_schema.sh. Once this merges, that client should be regenerated so VASPsApi, Vasp, and VaspListResponse drop out. Nothing in webdev called those symbols, so there are no call sites to migrate.

Generated by Claude Code

Drops `GET /vasps` (`listVasps`), the `VASPs` tag, and the `Vasp` / `VaspListResponse` schemas from the spec, along with the `vasps` resource in the Stainless SDK config. Rebundled openapi.yaml and mintlify/openapi.yaml. The `vaspName` field on wallet external accounts stays; its description no longer points at the removed directory endpoint. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126o5tx3Hg4ceTFdvpyAwYW

mintlify · 2026-08-28T16:47:46Z

Preview deployment for your docs. Learn more about Mintlify Previews.

Project	Status	Preview	Updated (UTC)
Grid	🟢 Ready	View Preview	Aug 28, 2026, 4:49 PM

vercel · 2026-08-28T16:47:49Z

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
grid-flow-builder	Ignored		Aug 28, 2026 4:47pm
grid-wallet-demo	Ignored		Aug 28, 2026 4:47pm

github-actions · 2026-08-28T16:48:02Z

⚠️ Breaking OpenAPI changes detected

oasdiff reports 1 error / 0 warning changes to openapi.yaml.
This PR will need approval from an API reviewer before merge.

Errors (1)

GET /vasps — api path removed without deprecation [api-path-removed-without-deprecation].

Detected by oasdiff. Full report: job summary or the oasdiff-report artifact.

github-actions · 2026-08-28T16:48:40Z

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

feat(spec): remove the VASP directory endpoint

go

feat(api): remove vasps resource

kotlin

feat(api): remove vasps endpoints

openapi

feat(api): remove vasps list endpoint and associated models

php

feat(spec): remove the VASP directory endpoint

python

feat(spec): remove the VASP directory endpoint

ruby

feat(api): remove vasps resource

typescript

feat(spec): remove the VASP directory endpoint

⚠️

grid-openapistudio · code

Your SDK build had at least one "warning" diagnostic.
generate ⚠️

✅ grid-rubystudio · code

Your SDK build had at least one "note" diagnostic.
generate ✅ → build ✅ → lint ✅ → test ✅

⚠️

grid-gostudio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ✅ → build ✅ → lint ❗ → test ❗
go get github.com/stainless-sdks/grid-go@96c2d79e22f0a7f1f8c498fe2ed5b6f618cf64c0

⚠️

grid-kotlinstudio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ⚠️ → build ✅ → lint ✅ → test ❗

✅ grid-typescriptstudio · conflict

Your SDK build had at least one note diagnostic.

⚠️

grid-pythonstudio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ✅ → build ✅ → lint ❗ → test ❗
pip install https://pkg.stainless.com/s/grid-python/ff21d0583603a9c4782c10357793c4677dc347f2/grid-0.0.1-py3-none-any.whl

✅ grid-phpstudio · code

Your SDK build had at least one "note" diagnostic.
generate ✅ → lint ✅ → test ✅

⚠️

grid-clistudio · code

Your SDK build had a failure in the build CI job, which is a regression from the base state.
generate ⚠️ → build ❗ → lint ❗ → test ❗

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-08-28 16:55:45 UTC

greptile-apps · 2026-08-28T16:50:12Z

Greptile Summary

Removes the VASP directory endpoint, its response schemas, and the corresponding Stainless SDK resource while retaining the wallet vaspName input. The removal is consistently propagated across the modular and bundled specifications, but it leaves a breaking contract change under the existing API version.

Removes GET /vasps, the VASPs tag, and the Vasp response models.
Removes Stainless generation of vasps.list.
Updates wallet custody documentation and rebundles the public specifications.

Confidence Score: 4/5

The breaking endpoint removal should not merge until it is paired with a new API version and matching server path, or explicitly deferred to a version-cut change.

Removing /vasps and its generated SDK resource while continuing to advertise the 2025-10-13 contract gives that version incompatible before-and-after client surfaces.

Files Needing Attention: openapi/openapi.yaml, openapi.yaml, mintlify/openapi.yaml

Important Files Changed

Filename	Overview
openapi/openapi.yaml	Removes the authoritative VASP path and tag but does not advance the versioned API boundary required for this breaking change.
.stainless/stainless.yml	Removes the VASP SDK resource consistently with the specification, causing regenerated clients under the unchanged version to lose `vasps.list`.
openapi/components/schemas/external_accounts/WalletCustodyFields.yaml	Correctly retains `vaspName` while removing only the obsolete directory reference from its description.
openapi.yaml	Bundled specification consistently reflects the endpoint and schema removal, including the unchanged API version.
mintlify/openapi.yaml	Mintlify’s bundled specification remains synchronized with the primary bundled contract.

Prompt To Fix All With AI

### Issue 1
openapi/openapi.yaml:273-275
**API version boundary is broken**
Existing consumers of the advertised `2025-10-13` contract lose `GET /vasps` and the generated `vasps.list` method while the version and matching server URL remain unchanged, causing the same API version to expose incompatible client contracts. Ship this removal with a new `info.version` and corresponding `servers.url`, as required for breaking changes.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

_{Reviews (1): Last reviewed commit: "feat(spec): remove the VASP directory en..." | Re-trigger Greptile}

greptile-apps · 2026-08-28T16:50:16Z

 $ref: paths/sandbox/sandbox_internal_accounts_{accountId}_fund.yaml
 /uma-providers:
 $ref: paths/uma_providers/uma_providers.yaml


API version boundary is broken
Existing consumers of the advertised 2025-10-13 contract lose GET /vasps and the generated vasps.list method while the version and matching server URL remain unchanged, causing the same API version to expose incompatible client contracts. Ship this removal with a new info.version and corresponding servers.url, as required for breaking changes.
Context Used: CLAUDE.md (source)
Knowledge Base Used:Contract validation workflows
Prompt To Fix With AI
This is a comment left during a code review. Path: openapi/openapi.yaml Line: 273-275 Comment: **API version boundary is broken** Existing consumers of the advertised `2025-10-13` contract lose `GET /vasps` and the generated `vasps.list` method while the version and matching server URL remain unchanged, causing the same API version to expose incompatible client contracts. Ship this removal with a new `info.version` and corresponding `servers.url`, as required for breaking changes. **Context Used:** CLAUDE.md ([source](https://github.com/lightsparkdev/grid-api/blob/main/CLAUDE.md)) **Knowledge Base Used:**[Contract validation workflows](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/contract-validation-workflows.md)--- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

no one is using it

Understood. If no consumers are using it, the practical migration risk is low, but removing a published endpoint is still technically a breaking contract change. I’d still bump info.version and the matching servers.url unless the release owner confirms that 2025-10-13 is pre-release or not externally consumed; usage telemetry alone does not guarantee that existing generated clients or integrations do not depend on it.

github-actionsBot added the breaking-change Introduces a breaking change to the OpenAPI spec label Aug 28, 2026

shreyav marked this pull request as ready for review August 28, 2026 16:48

mintlifyBotdeployed to staging - mintlify August 28, 2026 16:49 View deployment

greptile-appsBot reviewed Aug 28, 2026
View reviewed changes

jklein24 approved these changes Aug 28, 2026
View reviewed changes

shreyav merged commit 2c24eaf into mainAug 28, 2026
11 of 12 checks passed

shreyav deleted the claude/remove-vasp-directory-endpoint-kr5xv8 branch August 28, 2026 16:52

Navigation Menu

Uh oh!

feat(spec): remove the VASP directory endpoint - #875

feat(spec): remove the VASP directory endpoint#875
shreyav merged 1 commit into
mainfrom
claude/remove-vasp-directory-endpoint-kr5xv8

shreyav commented Aug 28, 2026

Uh oh!

mintlifyBot commented Aug 28, 2026•
edited
Loading

Uh oh!

vercelBot commented Aug 28, 2026

Uh oh!

github-actionsBot commented Aug 28, 2026

Uh oh!

github-actionsBot commented Aug 28, 2026•
edited
Loading

Uh oh!

greptile-appsBot commented Aug 28, 2026

Important Files Changed

Uh oh!

greptile-appsBotAug 28, 2026

Uh oh!

shreyavAug 28, 2026

Uh oh!

greptile-appsBotAug 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

shreyav commented Aug 28, 2026

Changes

Validation

Open question

Downstream

Uh oh!

mintlifyBot commented Aug 28, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercelBot commented Aug 28, 2026

Uh oh!

github-actionsBot commented Aug 28, 2026

⚠️ Breaking OpenAPI changes detected

Errors (1)

Uh oh!

github-actionsBot commented Aug 28, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✱ Stainless preview builds for grid

Uh oh!

greptile-appsBot commented Aug 28, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

greptile-appsBotAug 28, 2026

Choose a reason for hiding this comment

Uh oh!

shreyavAug 28, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-appsBotAug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mintlifyBot commented Aug 28, 2026•
edited
Loading

github-actionsBot commented Aug 28, 2026•
edited
Loading