Uh oh!
There was an error while loading. Please reload this page.
chore: Sync account schemas - #876
Open
lightspark-copybara[bot] wants to merge 1 commit into
Open
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
|
Contributor
✱ Stainless preview builds for gridThis PR will update the cli go kotlin openapi php python ruby typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-typescriptstudio · code · diff
✅ grid-openapistudio · code · diff
✅ grid-rubystudio · code · diff
✅ grid-kotlinstudio · code · diff
✅ grid-gostudio · code · diff
✅ grid-pythonstudio · code · diff
✅ grid-phpstudio · code · diff
✅ grid-clistudio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Contributor
Greptile SummaryThe PR synchronizes currency-specific account, beneficiary, payment-instruction, and external-account schemas from the adapter definitions.
Confidence Score: 4/5The PR should not merge until the business-beneficiary create and response schemas agree for the eight affected currencies. Public create endpoints still document Files Needing Attention: openapi/components/schemas/external_accounts/BdtExternalAccountInfo.yaml and the equivalent COP, EGP, GHS, GTQ, HTG, JMD, and PKR response schemas
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/external_accounts/BdtExternalAccountInfo.yaml | Narrows the response beneficiary to an individual while the corresponding public create schema still accepts businesses. |
| openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml | Adds the ILS external-account variant consistently to the response union and discriminator. |
| openapi/components/schemas/common/PaymentInstructions.yaml | Adds the ILS payment account consistently to the payment-instruction union and mapping. |
| openapi/components/schemas/common/IlsAccountInfoBase.yaml | Introduces the ILS account contract with a constrained Israeli IBAN and required bank name. |
| openapi.yaml | Synchronizes the bundled contract, including the same create/response beneficiary asymmetry present in the modular schemas. |
| mintlify/openapi.yaml | Synchronizes the documentation bundle and reproduces the modular contract changes. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Client[API client] --> Create[External-account create request]
Create --> CreateUnion[Currency CreateInfo union]
CreateUnion -->|BUSINESS accepted| Service[Grid API]
Service --> Response[ExternalAccount response]
Response --> InfoUnion[Currency Info union]
InfoUnion -->|BUSINESS removed for 8 currencies| Validation[Generated-client or validator failure]
Prompt To Fix All With AI
### Issue 1
openapi/components/schemas/external_accounts/BdtExternalAccountInfo.yaml:9
**Business responses become invalid**
When a client creates a BDT, COP, EGP, GHS, GTQ, HTG, JMD, or PKR external account with the `BUSINESS` beneficiary still accepted by its create schema, the changed response schema permits only an individual beneficiary, causing generated response models and OpenAPI validators to reject the returned business beneficiary or drop its business-only fields.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "chore: Sync account schemas" | Re-trigger Greptile
| @@ -7,13 +7,4 @@ allOf: | |||
| - beneficiary | |||
| properties: | |||
| beneficiary: | |||
Contributor
There was a problem hiding this comment.
When a client creates a BDT, COP, EGP, GHS, GTQ, HTG, JMD, or PKR external account with the BUSINESS beneficiary still accepted by its create schema, the changed response schema permits only an individual beneficiary, causing generated response models and OpenAPI validators to reject the returned business beneficiary or drop its business-only fields.
Knowledge Base Used:Grid API contract
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/BdtExternalAccountInfo.yaml
Line: 9
Comment:
**Business responses become invalid**
When a client creates a BDT, COP, EGP, GHS, GTQ, HTG, JMD, or PKR external account with the `BUSINESS` beneficiary still accepted by its create schema, the changed response schema permits only an individual beneficiary, causing generated response models and OpenAPI validators to reject the returned business beneficiary or drop its business-only fields.
**Knowledge Base Used:**[Grid API contract](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/api-contract.md)---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.JasonCWang
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-synced account schemas.
These schemas are generated from VASP adapter field definitions in sparkcore.
Synced schemas:
common/— per-currency account info, beneficiary, and payment account schemascommon/PaymentInstructions.yaml— payment instructions oneOf (new currencies added)external_accounts/— per-currency external account schemas (reference common/)Please review the changes before merging.