Uh oh!
There was an error while loading. Please reload this page.
ci(gitleaks): authenticate the updater with the App client id - #1456
Conversation
✅ Template check passed after update. Thanks for fixing the PR description. |
⏱️ Aging and SLA annotation
Maintained by project-meta-sync workflow. |
🚫 This PR description is missing required template content. Missing required section(s): Linked issues, Changelog, Global DoD checklist Please update the PR body using one of the repository PR templates:
Empty placeholders, unchecked checklist boxes, and stub issue references do not count. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Around line 96-97: Add the required pull request and related issue links to
the new [Unreleased] changelog entry for “Gitleaks updater App authentication,”
following the existing link format used by neighboring entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: d46b396f-9824-4721-a54f-58d596c6ea6c
📒 Files selected for processing (2)
.github/workflows/gitleaks-update.ymlCHANGELOG.md
📜 Review details
⏰ Context from checks skipped due to timeout. (13)
- GitHub Check: scan / Scan for secrets
- GitHub Check: front-matter-validate
- GitHub Check: coderabbit-gate
- GitHub Check: lint-and-links
- GitHub Check: Validate changelog on PR
- GitHub Check: validate-pr-template
- GitHub Check: Validation
- GitHub Check: Testing
- GitHub Check: Mergify Merge Protections
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (python)
- GitHub Check: Summary
- GitHub Check: Validate Mermaid Diagrams
🧰 Additional context used
📓 Path-based instructions (5)
**/.github/workflows/*.yml
⚙️ CodeRabbit configuration file
**/.github/workflows/*.yml: Review GitHub Actions workflows for this governance repo:
- Security: check for least-privilege permissions (use
permissions:at job level, default to read-only).- Secret handling: ensure secrets are passed via env vars, not interpolated directly into run: steps to prevent injection.
- Action pinning: prefer SHA-pinned actions over mutable tags (e.g.
actions/checkout@v4is acceptable; SHA pins are better).- No
pull_request_targetwith untrusted code execution unless explicitly justified.- Avoid storing sensitive outputs as unmasked step outputs.
- Check for reusable workflow patterns and matrix strategies where appropriate.
- Validate
on:triggers: ensure branch/path filters are present to avoid unnecessary runs.- Confirm workflows are documented, DRY, and maintainable.
- Ensure agent-triggered workflows use
workflow_dispatchwith defined inputs.
Files:
.github/workflows/gitleaks-update.yml
**/*
📄 CodeRabbit inference engine (CLAUDE.md)
**/*: Do not place reusable AI assets under.github/; store them in the appropriate top-level portable asset folder.
Portable JSON schemas belong in the root.schemas/directory; portable agents belong inagents/; permanent human documentation belongs indocs/; temporary scratch files belong in.github/tmp/and must be cleaned up.
Do not commitnode_modules/,build/, or other generated artefacts.
**/*: Use UK English and optimise solutions for clarity, scalability, maintainability, and profitable outcomes.
Prefer minimal, modular solutions; justify heavier tools based on return on investment and maintenance cost.
Files:
CHANGELOG.md
**/*.md
📄 CodeRabbit inference engine (CLAUDE.md)
Use UK English throughout documentation and Markdown content, including spellings such as
optimise,organisation,colour, andbehaviour.
**/*.md: Documentation and AI infrastructure files must follow their applicable documented standards, including required structure, frontmatter, quality gates, and validation.
Run Markdown linting withnpm run lint:mdand validate frontmatter withnpm run validate:frontmatterwhere applicable.
Files:
CHANGELOG.md
**/*.{md,yml,yaml,json}
📄 CodeRabbit inference engine (CLAUDE.md)
Do not use a
referencesfrontmatter field; use inline links or footer sections instead.
Files:
CHANGELOG.md
CHANGELOG.md
⚙️ CodeRabbit configuration file
CHANGELOG.md: Review CHANGELOG.md:
- Confirm entries follow Keep a Changelog 1.1.0 format.
- Each entry under [Unreleased] must include a PR link and issue link.
- Verify entries use the correct section headings (Added, Changed, Fixed, Deprecated, Removed, Security, Documentation, Performance).
- Check UK English spelling throughout.
Files:
CHANGELOG.md
🔇 Additional comments (1)
.github/workflows/gitleaks-update.yml (1)
30-30: LGTM!
Uh oh!
There was an error while loading. Please reload this page.
🔍 Reviewer Summary for PR #1456CI Status: ❌ Recommendations
|
Replace the deprecated app-id input on create-github-app-token with client-id, reading vars.DEP_MERGE_APP_CLIENT_ID. Matches the convention used by the dependency-merge controller. Least-privilege permissions are unchanged.
18c50b9 to
fe3f452Compare🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
Summary
Authenticates the gitleaks version updater with the
client-idinput onactions/create-github-app-token, reading the newDEP_MERGE_APP_CLIENT_IDrepository variable, instead of the deprecatedapp-id.docs/CHECKPOINT.mdindependency-merge-controllerrecords the intended convention for thelightspeed-dependency-mergeApp asvars.DEP_MERGE_APP_CLIENT_ID+secrets.DEP_MERGE_APP_PRIVATE_KEY, with noDEP_MERGE_APP_ID. The earlier repair usedapp-id, which worked but diverged. This realigns them and clears the deprecation warning as a side effect. The deprecation was never the cause of the original failure.Least-privilege permissions are untouched:
contents: writeto push thedeps/gitleaks-*branch,pull-requests: writeto open the update PR, andworkflows: writebecause the diff editsgitleaks-reusable.yml.DEP_MERGE_APP_CLIENT_IDis already set on this repository, so the token step resolves on merge. Theapp-idform is verified working in run 30790979429 (Already on 8.30.1); this PR swaps the input only.DEP_MERGE_APP_IDis deleted only after the client-id workflow is live.Linked issues
issue-remediation-bulk.yml, merged first so workflow parsing is clean.Changelog
gitleaks-update.ymlto theclient-idinput onactions/create-github-app-token, reading the newDEP_MERGE_APP_CLIENT_IDvariable, replacing the deprecatedapp-idform. Aligns with thelightspeed-dependency-mergeconvention used by the dependency auto-merge controller. The App's least-privilege permission set (contents, pull-requests, workflows) is unchanged.Checklist (Global DoD / PR)
app-idstays functional until the variable is deleted