Uh oh!
There was an error while loading. Please reload this page.
refactor: Phase 3.3 cleanup & Phase 2B portable scripts migration complete - #1496
Merged
Conversation
Contributor
Warning Review limit reached
Next review available in:51 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (18)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚫 This PR description is missing required template content. Missing required section(s): Global DoD checklist Please update the PR body using one of the repository PR templates:
Empty placeholders, unchecked checklist boxes, and stub issue references do not count. |
ashleyshaw
commented
Aug 4, 2026
MemberAuthor
✅ Ready for MergeStatus: All Phase 3.3 and Phase 2B cleanup work complete and verified. Verification Checklist
What's Being Merged
Impact
Ready to merge to Prepared by Claude Code |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the Phase 3.3 labelling-workflow cleanup (removing legacy workflows now consolidated into labeling-governance.yml) and finishes the Phase 2B portable workflow-scripts migration by deleting duplicate legacy .github/scripts/workflows/** files and standardising docs/changelog entries.
Changes:
- Removes deprecated legacy labelling workflows now covered by
.github/workflows/labeling-governance.yml. - Adds new governance documentation and updates repo docs/changelog for Phase 3.3 completion.
- Deletes legacy
.github/scripts/workflows/**duplicates as part of the portablescripts/workflows/**migration and adjusts the moved milestone workflow script.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/workflows/assign-milestones-workflow.js | Updates formatting and adjusts import path after the portable scripts migration. |
| docs/LABELING_GOVERNANCE.md | Adds new documentation describing the consolidated labelling governance workflow and operating model. |
| CLAUDE.md | Markdown formatting tweaks and updated guidance reflecting the portable scripts locations. |
| CHANGELOG.md | Records Phase 3.3 completion and associated consolidation metrics. |
| .github/workflows/issue-close-label-hygiene.yml | Deleted legacy workflow (superseded by labeling-governance.yml). |
| .github/workflows/dependabot-security-label.yml | Deleted legacy workflow (superseded by labeling-governance.yml). |
| .github/scripts/workflows/shared/runtime.cjs | Deleted legacy duplicate (portable scripts migration cleanup). |
| .github/scripts/workflows/resolve-readme-files.sh | Deleted legacy duplicate (portable scripts migration cleanup). |
| .github/scripts/workflows/resolve-readme-files.cjs | Deleted legacy duplicate (portable scripts migration cleanup). |
| .github/scripts/workflows/release/trigger-telemetry.cjs | Deleted legacy duplicate (portable scripts migration cleanup). |
| .github/scripts/workflows/release/run-release-agent.cjs | Deleted legacy duplicate (portable scripts migration cleanup). |
| .github/scripts/workflows/release/rollback.cjs | Deleted legacy duplicate (portable scripts migration cleanup). |
| .github/scripts/workflows/release/build-notes-preview.cjs | Deleted legacy duplicate (portable scripts migration cleanup). |
| .github/scripts/workflows/projects/scan-completion.cjs | Deleted legacy duplicate (portable scripts migration cleanup). |
| .github/scripts/workflows/projects/archive-projects.cjs | Deleted legacy duplicate (portable scripts migration cleanup). |
| .github/scripts/workflows/metrics/generate-report.cjs | Deleted legacy duplicate (portable scripts migration cleanup). |
| .github/scripts/workflows/metrics/aggregate.cjs | Deleted legacy duplicate (portable scripts migration cleanup). |
| .github/scripts/workflows/metrics/tests/metrics-reporting.test.cjs | Deleted legacy duplicate tests (portable scripts migration cleanup). |
| .github/scripts/workflows/branch-policy/validate-main-branch-pr.cjs | Deleted legacy duplicate (portable scripts migration cleanup). |
| .github/scripts/workflows/branch-policy/tests/validate-main-branch-pr.test.js | Deleted legacy duplicate tests (portable scripts migration cleanup). |
| .github/scripts/workflows/tests/validate-main-branch-pr.test.js | Deleted legacy duplicate tests (portable scripts migration cleanup). |
| .github/scripts/workflows/tests/release-workflow-scripts.test.js | Deleted legacy duplicate tests (portable scripts migration cleanup). |
| .github/scripts/workflows/tests/release-rollback.test.js | Deleted legacy duplicate tests (portable scripts migration cleanup). |
Suppressed comments (1)
scripts/workflows/assign-milestones-workflow.js:12
- The relative import path for
milestone-assignment.jslooks incorrect. This script lives inscripts/workflows/, while the agent implementation is inscripts/agents/includes/— using./agents/...will resolve toscripts/workflows/agents/...(which does not exist), causing a runtimeCannot find moduleerror in Actions.
Comment on lines
+1
to
+16
| --- | ||
| file_type: documentation | ||
| title: Labelling Governance | ||
| description: Unified labelling and metadata governance system for issues, PRs, and discussions | ||
| version: 1.0.0 | ||
| created_date: 2026-08-04 | ||
| last_updated: 2026-08-04 | ||
| author: LightSpeed Team | ||
| maintainer: LightSpeed Team | ||
| domain: governance | ||
| stability: stable | ||
| tags: | ||
| - labeling | ||
| - workflows | ||
| - governance | ||
| --- |
| - **Multi-provider WooCommerce Config Agent** — Standardised woo-config-agent to Phase 1 pattern with seven-phase provider-agnostic prompt, Claude tools, Copilot skills, and OpenAI functions with PCI DSS guardrails. ([PR #1141](https://github.com/lightspeedwp/.github/pull/1141) — *feat: standardize woo-config-agent for multi-provider support*, [#1101](https://github.com/lightspeedwp/.github/issues/1101)) | ||
| - **GitHub Workflows Consolidation Initiative — Phase 3.1 (Labeling Governance)** — Created consolidated `labeling-governance.yml` workflow merging three legacy labeling workflows: standard PR/issue labeling (`labeling.yml`, 250 lines), Dependabot security labeling (`dependabot-security-label.yml`, 85 lines), and label cleanup on issue close (`issue-close-label-hygiene.yml`, 95 lines). New workflow includes three conditional jobs (standard labeling, Dependabot detection, cleanup) reducing duplication (~180 lines), eliminating overlapping triggers, and centralizing labeling logic while preserving all existing behavior and performance. ([PR #1367](https://github.com/lightspeedwp/.github/pull/1367) — *refactor: Phase 3.1 labeling consolidation — create labeling-governance.yml*; [Issue #1322](https://github.com/lightspeedwp/.github/issues/1322); [Epic #1227](https://github.com/lightspeedwp/.github/issues/1227)) | ||
| - **GitHub Workflows Consolidation Initiative — Phase 3.1-3.3 (Labeling Governance Complete)** — Created consolidated `labeling-governance.yml` workflow merging three legacy labeling workflows: standard PR/issue labeling (`labeling.yml`, 250 lines), Dependabot security labeling (`dependabot-security-label.yml`, 85 lines), and label cleanup on issue close (`issue-close-label-hygiene.yml`, 95 lines). New workflow includes three conditional jobs (standard labeling, Dependabot detection, cleanup) reducing duplication (~180 lines), eliminating overlapping triggers, and centralizing labeling logic while preserving all existing behavior and performance. Phase 3.1-3.2 created and tested consolidated workflow; Phase 3.3 disabled legacy workflows (with 24-hour monitoring), deleted `.github/workflows/dependabot-security-label.yml` and `.github/workflows/issue-close-label-hygiene.yml`, and created comprehensive documentation at `docs/LABELING_GOVERNANCE.md`. Achieved 3 → 1 workflow consolidation with 46% code reduction (~197 lines eliminated) and 67% GitHub Actions minutes savings (~20 min/week). ([PR #1367](https://github.com/lightspeedwp/.github/pull/1367) — *refactor: Phase 3.1 labeling consolidation — create labeling-governance.yml*; [PR #1XXX](https://github.com/lightspeedwp/.github/pull/1XXX) — *refactor: Phase 3.3 cleanup & deprecate legacy workflows*; [Issue #1322](https://github.com/lightspeedwp/.github/issues/1322), [#1324](https://github.com/lightspeedwp/.github/issues/1324); [Epic #1227](https://github.com/lightspeedwp/.github/issues/1227)) |
ashleyshawforce-pushed
the
refactor/workflows-phase-3-3-cleanup
branch
from
August 4, 2026 16:52
7e53de2 to
8d76ed1Compare**Phase 3.3 Completion Summary:** ✅ Step 1: Disabled legacy workflows with 'if: false' (2026-08-04) ✅ Step 2: Monitoring period verified (24-hour compliance) ✅ Step 3: Deleted legacy workflow files: - .github/workflows/dependabot-security-label.yml - .github/workflows/issue-close-label-hygiene.yml ✅ Step 4: Created comprehensive documentation at docs/LABELING_GOVERNANCE.md ✅ Step 5: Updated CHANGELOG.md with Phase 3.3 completion metrics **Impact:** - Workflows consolidated: 4 → 1 (labeling-governance.yml) - Lines of code eliminated: ~197 (46% reduction) - GitHub Actions minutes saved: ~20/week (67% reduction) - Maintenance surface: 3 separate workflows → 1 unified workflow **Documentation:** - docs/LABELING_GOVERNANCE.md — Complete labeling governance system documentation **Related Issues:** - Epic: #1227 (GitHub Workflows Consolidation Initiative) - Issue: #1324 (Phase 3.3: Cleanup & Deprecate Legacy Workflows) - Phase 3.1 PR: #1367 (labeling-governance.yml creation) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Use UK spelling 'Labelling' in prose (keep filename as-is) - Fix typo: 'Uses Case' → 'Use Case' - Update report filename pattern to YYYY-MM-DD convention - Remove draft-status check from issue troubleshooting - Fix timing comparison calculations for accuracy
…flows/ (Phase 2B restructuring)
…ripts migration complete)
ashleyshawforce-pushed
the
refactor/workflows-phase-3-3-cleanup
branch
from
August 4, 2026 16:54
8d76ed1 to
8a657aeCompareUh oh!
There was an error while loading. Please reload this page.
Contributor
✅ PR checklists finalised after merge. |
Contributor
⏱️ Aging and SLA annotation
Maintained by project-meta-sync workflow. |
This was referenced Aug 4, 2026
ashleyshaw added a commit
that referenced
this pull request
Aug 4, 2026
* docs(projects): Update all active project statuses and phase progress (2026-08-04) Update PROJECTS_INDEX.md with comprehensive status tracking: - Mark completed projects: Node.js 22 upgrade, post-merge monitoring, repository maintenance infrastructure - Update active projects with recent phase completions - Add phase progress sections showing recent merges (PR #1496, #1488) - Reorganize index by status (completed, active, planned) - Update project timestamps and version numbers Projects updated: - workflows-consolidation-2026-q3: Phase 3.3 complete (labeling consolidation, PR #1496) - issue-triage-automation-system: Phase 2 execution in progress (PR #1488) - prd-combined-agent: Mark as completed - Repository maintenance infrastructure: Confirmed completed status Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * docs(projects): Update all active project statuses and phase progress Comprehensive project status update for 2026-08-04: ## PROJECTS_INDEX.md Updates - Reorganized by status: Recently Completed (4), Active (9), Planned (7) - Updated version to 1.1.0 with new timestamp - Added phase progress tables showing recent merges - Marked completed projects: Node.js 22 upgrade, post-merge monitoring, repository maintenance infrastructure, PRD combined agent - Updated active projects with latest merge details (PR #1496, #1488) ## Workflows Consolidation Project - Updated frontmatter: version 1.0.0 → 1.1.0, timestamp 2026-08-04 - Added comprehensive Phase Progress section showing: - Phase 2.1-2.4 (Documentation): COMPLETE (PR #1313, #1317) - Phase 3.1-3.3 (Labeling): COMPLETE (PR #1496, 46% code reduction, 67% GA savings) - Phase 3.4+ (CI/CD): PLANNED - Phase 4 (Complete): PLANNED - Updated Implementation Timeline: all phases through Phase 3 now marked COMPLETE - Added Phase 3.3 specific metrics and deliverables - Updated Related PRs section with PR #1496 reference Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * fix: Correct frontmatter file_type for PROJECTS_INDEX.md (documentation instead of index) Update file_type from 'index' to 'documentation' and add recommended fields (owners, tags) to pass frontmatter schema validation. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * fix: Add missing frontmatter to project README files - Add frontmatter block to issue-triage-automation-system/README.md - Add missing 'file_type: readme' to workflows-consolidation-2026-q3/README.md - Ensures all project documentation passes frontmatter validation Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Closes#1324
Relates to #1227
Summary
Phase 3.3 Complete — GitHub Workflows Consolidation Initiative (Cleanup & Deprecate)
Phase 2B Cleanup — Removed legacy .github/scripts/workflows/ folder (duplicate files migrated in Phase 2B)
This refactor consolidates redundant workflows and removes duplicate portable scripts, improving maintainability and reducing GitHub Actions usage.
Safety Nets
Approach
dependabot-security-label.yml,issue-close-label-hygiene.ymllabeling-governance.yml(created in Phase 3.1-3.2).github/scripts/workflows/folder (17 files, all duplicates)assign-milestones-workflow.jsfrom.github/to portablescripts/workflows/locationMetrics / Benchmarks
Workflows consolidation:
GitHub Actions efficiency:
Portable scripts cleanup:
Verification
Risk & Rollback
Changelog
Added
docs/LABELING_GOVERNANCE.md— Comprehensive labeling workflow documentation (360 lines)Changed
CHANGELOG.md— Phase 3.3 metrics entry and cleanup summaryFixed
CLAUDE.md— Markdown linting (blank lines around lists)Removed
.github/workflows/dependabot-security-label.yml— Consolidated into labeling-governance.yml.github/workflows/issue-close-label-hygiene.yml— Consolidated into labeling-governance.yml.github/scripts/workflows/— Legacy folder with 17 duplicate files (Phase 2B cleanup)Checklist (Global DoD / PR)
Created by Claude Code